3 Commits (1645db3cee1fa7c782209f1c470cc529a5475bdb)

Author	SHA1	Message	Date
Adam Miller	bc7ff83cd9	parted module not idempotent for esp flag and name (#40547) ... * parted module not idempotent for esp flag and name Fixes #40452 Currently the parted module doesn't take into account names with spaces in them which leads to non-idempotent transactions on the state of the system because the name comparison will never succeed. Also, when the esp flag is set, parted infers the boot flag and the parted module did not previously account for this. This lead to non-idempotent transactions as well. Signed-off-by: Adam Miller <admiller@redhat.com> * fix unit tests, expected command changed in the patch Signed-off-by: Adam Miller <admiller@redhat.com>	7 years ago
Pilou	a5c9726502	Unit tests: share common code (#31456) ... * move set_module_args to units.modules.utils * unit tests: reuse set_module_args * unit tests: mock exit/fail_json in module.utils.ModuleTestCase * unit tests: use module.utils.ModuleTestCase * unit tests: fix 'import shadowed by loop variable'	7 years ago
Guillaume Coré	42ca1ef040	Add unit tests for parted module (#24164) ... * Add unit tests for parted module Test the current expected behavior of the module: - mock parted() and get_device_info() - Use some of the examples and test the 'script' passed to parted. - mock check_parted_label() to return false, as if parted version is > 3.1 - assert get_device_info output is correct Current implementation of the module runs parted several time while going through all parameters (flags, name, ...). Between calls it uses get_device_info to update the dictionary. Use check_mode for some of the tests to force module to go through all the parameters even is dictionary is not updated. * test_parted.py: add "name" param into expected results since 78fff751ab, parse_partition_info fetch the partition name. This commit adds 'name' key and value into the expected results.	7 years ago