Commit Graph

45141 Commits (1637aeea297f54b60c418e910d69a59c19ae4297)
 

Author SHA1 Message Date
Will Thames ac1895453f Add test case for k8s cascading deletes (#55987)
* Add test case for non-cascading deletes

Deleting a DaemonSet does not delete associated pods,
even though it should

* Add coverage module when using pip

Otherwise tests seemingly fail
6 years ago
Kevin Breit 5008e1d479 meraki_config_template - Enable check mode (#54502)
* Add support for check mode

* Check mode returns proper changed status
- Added is_template_valid()
- Restructured check_mode so it will always return data
- Check mode should show proper changed status
- Code is untested and integration tests need to be expanded

* Fix deleting networks
- Add integration tests for deleting networks
- Refine tests based on changed/unchanged

* Remove one task from integration test
6 years ago
Kevin Breit 4df53f869e meraki_network - Add support for disableRemoteStatusPage (#48971)
* Add support for disableRemoteStatusPage
- New feature in the Meraki API
- Yes, it's a double negative, I may fix at some point

* Remove double negative
- All disables became enable and logic is reversed
- This isn't yet tested

* Switching computers!!!

* Apply changes to make the logic work, even reversed

* Attempt to fix some formatting errors

* Add documentation fragment

* Fix whitespace

* Add disable_my_meraki back, with deprecation notice

* Edit changelog notice

* Update deprecation version

* Update example to be a block and change deprecation message.

* Remove duplicate delegate_to

* Change deprecation notice.
6 years ago
Kevin Backhouse 79bb7bde5f apt_repository: Fix crash caused by cache.update() raising an IOError on timeout. (#51996)
* Fix crash caused by cache.update() raising an IOError on timeout.

* Add changelog fragment.
6 years ago
Felix Fontein c47e9d22b4
Rename one_image_facts -> one_image_info (#57035)
* Rename one_image_facts -> one_image_info.

* Add changelog.

* Forgot symlink.
6 years ago
Fred-sun ba18dd713a Update document related with azure_rm_keyvault module (#57110) 6 years ago
Fred-sun 163d3efbf8 Update azure_rm_image relate document (#57043) 6 years ago
szymon3 00067c8d54 Update rabbitmq_queue.py (#56912)
change description for when `state=absent`
6 years ago
Dag Wieers e381135ace Update BOTMETA with latest community changes (#57064)
This is the requested change from #56816 for 'dch'
6 years ago
Sviatoslav Sydorenko 5183f84016 📝 Mention the minumum cherry-picker version in doc (#57139) 6 years ago
Remon van de Kamp dea9644d21 Use correct variable for run_once regardless of batch example (#57077)
Changes example to `when: inventory_hostname == ansible_play_hosts_all[0]` to really run run_once regardless of serial.
6 years ago
Ian Wienand 39945b8570 Make query with errors='ignore' return a blank list (#57038)
The jinja2 query() function (or lookup with wantslist=True, which is
the same thing) should always return a list.

However, if you combine a query with errors='ignore' and take the
error path, the current code returns a None value.  This is important
in a case such as

 - name: Conditional include file
   import_tasks: '{{ item }}'
   vars:
     params:
       files:
         - path/file1.yaml
         - path/file2.yaml
   loop: "{{ q('first_found', params, errors='ignore') }}"

If neither file1.yaml or file2.yaml exist, this should do nothing by
returning an empty list to the loop.  Currently if you run the above
task you'll get a rather unhelpful:

 Invalid data passed to 'loop', it requires a list, got this instead: .

This change ensures that when a query ignores an error, it returns a
empty list.  The errors='ignore' case is tested in several variants
with first_found.  The extant (but deprecated) "skip: True" for
first_found doesn't seem to be explicitly tested; a test is added here
to avoid regressions before removal in 2.12.

This fixes a regression you'll hit if you follow the suggestion in the
deprecation message included with
e17a2b502d to use errors=ignore over
"skip: True" for first_found.  This change adds an example that points
out the query/lookup difference and also fixes the error message to
not mention the now deprecated "skip: True".

Closes #56775
6 years ago
xuxiaowei0512 b7f4e2a190 update ospf modules to fix bugs as software version changes (#56974) 6 years ago
xuxiaowei0512 0137c4343b update ce_ntp.py and remove the root tag name to find all nodes (#56976)
* add a maintainer

* update ce_ntp.py and remove the root tag name to find all node

* update ce_ntp.py and remove the root tag name to find all node
6 years ago
xuxiaowei0512 9e1f184b2d add terminal initial prompt for initial connection (#57057) 6 years ago
Dag Wieers fe1f1c4541 Update BOTMETA with latest community changes (#57063)
This is the requested change for 'koladiya'
6 years ago
Pilou e5b2e4c1ac tower_credential: ssh_key_data isn't a path anymore (#57113) 6 years ago
Fred-sun 8043940c93 Update azure_rm_devtestlabvirtualmachine relate document (#56828)
* Update azure_rm_devtestlabvirtualmachine documentation
6 years ago
Kevin Breit 7864df8cb9 meraki - Rewrite update requirement check (#48394)
* Rewrite idempotency check
- Check now operates recursively and works on multiple types
- Order of lists matter

* Remove blank line for lint

* Fixed idempotency checks in meraki_ssid
- New sanitize() method for finding keys unique in compared dicts
- Fixed bug in meraki_ssid where SSID specified by number breaks
  - This will require a backport
- Converted ignored_keys from tuple to list

* Made changes required for idempotency

* Add changelog fragment

* Add unidirectional option for testing

* Disable option 1 check

* General fixes for is_update_required testing
- Added commented out debug statements in method
- Fixed ignored_keys modifications

* Remove old commented algorithm
6 years ago
Kevin Breit 57e1063fc7 meraki_config_template - Remove mandatory network lookup (#56525)
* Module only makes network lookups when needed instead of every execution

* Formatting fixes
6 years ago
Rohit b143918f30
text format fan info mismatch and module info check (#57009)
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
6 years ago
MyronFanQiu a56a9e1eeb switch the deletion order (#57102) 6 years ago
Abhijeet Kasurde b1a92a37b4
VMware: Add pgbidkar in team_vmware (#56993)
Add Pavan Bidkar from VMware India in team_vmware as per request.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
6 years ago
Jim Ladd c36bdee416 Remove wwitzel3 from BOTMETA (#57091) 6 years ago
Abhijeet Kasurde 2cf1dfc415 Fixed misc typos (#57103)
* Changed immuteable to immutable
* Changed conig to config

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
6 years ago
Daniel Mellado Area 0ada6b8d8d Fix junos_facts test (#57065)
This commit fixes a non-passing junos_facts integration test, as it was
using a non-ordered frozenset to assert its result.
6 years ago
ShachafGoldstein 486370a744 Fix win_iis_virtualdirectory to remove a virtual directory that contains children (#56569)
* FIX #49755

* Added changelog fragment

* Changes according to review

* Fixed changelog
6 years ago
xuxiaowei0512 1544924550 add a maintainer (#56858) 6 years ago
ShachafGoldstein 4490c0ba51 correct behaviour of win_iis when using site_id if site not found (#56567)
* Fixed #47057

* Fix trailing whitespace

* Change for review
6 years ago
ShachafGoldstein 94566ed79c Win_hostname module: Change name check to WMI (#56420)
* Change name check to WMI

* Changelog fragment

* Fixed per review
6 years ago
Ilya Zonov 35c8739c2a Add full change check for rabbitmq policy (#19073)
Add check for all policy fields (name, apply_to, pattern, tags,
priority) to have correct changed state. Previosly changed state was
based on policy name only.

* Add support for rabbitmq 3.7
* Fix exec args for rabbitmqctl status
* Add changelog and fix description for Ansible 2.9
6 years ago
Tyler Hartley 1d22909f7c Make second group match of ufw status output optional (#56678)
* Make second group match of ufw status output optional

Fixes #56674

* Fix comparison logic.

* Add changelog fragment
6 years ago
Felix Fontein 86928a5f74
docker_image: fix module failing when build option is used without specifying path (#56940)
* Fix module failing when build option is used without specifying path.

* Add changelog.
6 years ago
Felix Fontein 56e2d48612
docker_image: fix default handling of old docker-build options nocache and rm (#56610)
* Fix usage of nocache parameter.

* Fix defaults.

* Add changelog.
6 years ago
Nathaniel Case 1b66a13186
Fix flow in eos_l2_interface (#57059)
* Also fix test debug labels
6 years ago
Matt Williams cf00883c9d Return results even when the cache is disabled (#55505)
* Return results even when the cache is disabled

By default the cache is disabled and so the results of the API call
are not placed in there for the return statement to fetch.

* Always update self._cache to return
6 years ago
The Magician a837cc5694 Bug fixes for GCP modules (#55976) 6 years ago
The Magician 713ac29054 Bug fixes for GCP modules (#56689) 6 years ago
The Magician 0ff62fd5c4 Bug fixes for GCP modules (#56764) 6 years ago
The Magician 70ac35da3e Bug fixes for GCP modules (#56765) 6 years ago
The Magician 2220b9c851 Bug fixes for GCP modules (#56766) 6 years ago
Paul Belanger 532de89b44
Fix exception with load_provider function (#56959)
It is possible for provider.authorize to exist, but set to None. Rather
then loading this value blindly, assume the default is False.

   File "/home/zuul/src/github.com/ansible/ansible/lib/ansible/executor/task_executor.py", line 145, in run
     res = self._execute()
   File "/home/zuul/src/github.com/ansible/ansible/lib/ansible/executor/task_executor.py", line 635, in _execute
     result = self._handler.run(task_vars=variables)
   File "/home/zuul/src/github.com/ansible/ansible/lib/ansible/plugins/action/ios.py", line 50, in run
     provider = load_provider(ios_provider_spec, self._task.args)
   File "/home/zuul/src/github.com/ansible/ansible/lib/ansible/module_utils/network/common/utils.py", line 424, in load_provider
     provider['authorize'] = boolean(provider['authorize'])
   File "/home/zuul/src/github.com/ansible/ansible/lib/ansible/module_utils/parsing/convert_bool.py", line 26, in boolean
     raise TypeError("The value '%s' is not a valid boolean.  Valid booleans include: %s" % (to_text(value), ', '.join(repr(i) for i in BOOLEANS)))

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
6 years ago
Brian Coca 1a893a48a3
Allow finer grained control for dupe YAML keys (#56933)
* Allow finer grained control for dupe YAML keys

  fixes #16903

* expand option to handle errors

* remove clog for previous version of toggle

* added missing parens

* fix typoe
6 years ago
Joshua Kluball c97d8ce25b Update intro_installation.rst (#57027)
Updated RHEL 8 Repository Name
6 years ago
Takashi Sugimura e17434c19f Correct repository name to install (#56991) 6 years ago
Dag Wieers a3b13bcf0d Update BOTMETA with latest community changes (#57053)
These have all confirmed in #56816
6 years ago
Brian Coca 615db8e6f4
clarify package facts errors and warnings (#56060)
* clarify package facts errors and warnings

  fixes #56056
6 years ago
Paul Belanger 6f1ff8eb8e Add missing scp dependency for ios_file tests (#56956)
This was required to be installed by a human, out side of our testing.
Add it so ansible-test can now manage.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
6 years ago
Paul Belanger 94e007ed77 ansible-test: use become for connection=local on ios_user (#56960)
ios_user requires escalated privledges, rather then doing this in the
inventory, we can just add it into the playbook tasks.

Also add missing provider settings for authorize.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
6 years ago
Ankur Gupta a40dc1174e Add support to start a vm and put it on hold in one_vm (#56841)
* Add support to start a vm and put it on hold in one_vm

* Add version_added to vm_start_on_hold option for one_vm

* Add version_added to vm_start_on_hold option for one_vm#2

* Add version_added to vm_start_on_hold option for one_vm#3

* Fix indentation for one_vm
6 years ago