Commit Graph

127 Commits (14cf3c4d2a2444a24c3329e6ed3c280e8e8ab904)

Author SHA1 Message Date
James Cammarata 5ad7dcf4f0 Merge pull request #6766 from Jmainguy/mysql_db_bug
mysql_db module now correctly fails on import if bz2 or gz fails.
11 years ago
Scott Brown 28c9104ed5 BUGFIX 1178: Adding better existence check in one place. db_import now fails fast if target does not exist b/c no point going further without the target. 11 years ago
Scott Brown b09a144724 BUGFIX 7811: Adding file existence check when performing mysql import on a .gz or .bz2 file, otherwise Ansible will not notice that the underlying *nix command silently died. 11 years ago
James Cammarata 4c30b3d68a Fixing mysql master replication boolean
Fixes #7528
11 years ago
Josef Špak 2d402ab5ca Fix typo in CHANGE MASTER TO syntax 11 years ago
Mathieu Martin a8969b5d3c Add example 'Specify grants composed of more than one word' to the mysql_user module. 11 years ago
Scott Sturdivant 726dc1d2e8 Clarify that the encrypted param must also be set.
While the encrypted parameter's documentation clearly states that it needs to
be set, if you are focused on the password parameter's documentation, there's
nothing to draw your attention to the fact that encrypted may also need to be
set.
11 years ago
Adam Chainz 967de3cdf9 Fix sync_binlog name in mysql_variables example
The previous sync_binary_log is not a real MySQL variable.
11 years ago
Cove Schneider 6a321fe346 re-add idempotency check 11 years ago
Cove Schneider 6e81f41cd4 add replicaset support to mongodb_user module 11 years ago
Michael DeHaan 0125f36c49 Merge pull request #6796 from mistaka0s/mysqldump_fix
Remove extra quote from the mysqldump password argument
11 years ago
Matt Martz b4de76373a Use /usr/bin/python instead of /usr/bin/env python 11 years ago
Chao Luan 134c449cf6 Remove extra quote from the mysqldump password argument
The mysqldb Ansible module will fail if the state specified is import or dump with a '1045: Access Denied' mysql error for complex passwords.

This is caused by the extra quote around the '--password' argument to mysqldump, as pipes.quotes already quotes the password string.

>>> "--password='%s'" % pipes.quote('simple')
"--password='simple'"

>>> "--password='%s'" % pipes.quote('c0mplexp@ssword!')
"--password=''c0mplexp@ssword!''"

>>> "--password='%s'" % pipes.quote('password with space')
"--password=''password with space''"
11 years ago
Jonathan Mainguy 8928a5ede1 Added mpdehaan suggestion to use os.path.splitext. Wise suggestion, does look clearner 11 years ago
Jonathan Mainguy bb73819c43 mysql_db module now correctly fails on import if bz2 or gz fails. 11 years ago
Michael DeHaan 991399edf0 Update comments about redis config. 11 years ago
Michael DeHaan b0639b16cf Merge branch 'devel' of git://github.com/mleventi/ansible into devel 11 years ago
Michael DeHaan aaaf9dbc43 Merge pull request #5597 from laggyluke/mongodb_user_idempotence
Fix idempotence in mongodb_user module
11 years ago
Cristian Ciupitu 0749112286 Micro-optimization: replace s.find(x)!=-1 with x in s
timeit shows a speedup of ~3x on Python 2.7.5 x86_64.
It also makes the code a bit shorter.
11 years ago
Richard Isaacson e6f6a73328 Merge pull request #6461 from risaacson/modules_make_run_command_safer
Modules make run command safer
11 years ago
Richard C Isaacson 2b53ece3ab mysql_db module: typo fix
Tests clean.
11 years ago
Richard C Isaacson 427221786c Shell updates. 11 years ago
James Martin 3d032b9db9 Fixes various typos introduced in a9017af2bb.
Fixes odd encoding problem with wait_for_service.
11 years ago
Michael DeHaan dac90278db More shell fixes 11 years ago
James Cammarata a9017af2bb Adding validate_certs to all modules that use fetch_url 11 years ago
Richard C Isaacson c2bf201bce Bulk update of choices=BOOLEANS to type='bool' 11 years ago
James Cammarata 11f500fa2f Merge pull request #4630 from mmoya/mysql_variables-fix2
Add support for string values
11 years ago
James Cammarata 9730157525 Validate SSL certs accessed through urllib*
* Adds another module utility file which generalizes the
  access of urls via the urllib* libraries.
* Adds a new spec generator for common arguments.
* Makes the user-agent string configurable.

Fixes #6211
11 years ago
Michael DeHaan 616d7e53b1 Merge pull request #6305 from amree/fix-mysql-replication-port
Fixed SQL syntax error when running mysql_replication module
11 years ago
Jimena Cabrera-Notari cc6e1ec261 Don't use keyword `error` in encode
This is not supported in Python 2.6. Just use positional arguments.
11 years ago
amree 1d731e5c30 MASTER_PORT variable for CHANGE MASTER TO command can only accept integer value 11 years ago
Guido Kollerie a000f37132 Emphasize target is on remote host. List supported file types.
From the documentation it is not immediately clear that the 'target'
option refers to a location on the remote host. This change emphasizes that.
In addition to .sql files, .bz2 and .gz files are supported for dumps and
restores. This is now documented.
11 years ago
Kyle Kelley b5eb4d2a71 Fix expires 11 years ago
James Martin 0e3356c40e Properly fetching the riak version, and properly setting the python interpreter. 11 years ago
James Cammarata 1544c93bf2 Merge branch 'fix-postgres_user_to_understand_pg_namespaces' of https://github.com/alanfairless/ansible into alanfairless-fix-postgres_user_to_understand_pg_namespaces 11 years ago
James Cammarata 87bf16930e Merge branch 'postgres_alter_role' of https://github.com/jinnko/ansible into jinnko-postgres_alter_role
Conflicts:
	library/database/postgresql_user
11 years ago
Maykel Moya 811aa2611e Add support for string values
The SET GLOBAL statement requires properly quoting of values. For example, the
following correct queries will fail if quotes are toggled:

mysql> SET GLOBAL innodb_lru_scan_depth = 2000;
mysql> SET GLOBAL master_info_repository = "TABLE";

`mysql_variable` module doesn't quote the value argument, therefore
string values will fail.

  # this task will pass, 2000 is passed without quotes
  - name: set a numeric value
    mysql_variable: variable=innodb_lru_scan_depth value=2000

  # this task will fail, TABLE is passed without quotes
  - name: set a string value
    mysql_variable: variable=master_info_repository value=TABLE

With this patch prepared statements are used. Proper quoting will be
done automatically based on the type of the variables thus an attempt
to convert to int, then to float is done in first place.

Booleans values, ie: ON, OFF, are not specially handled because they
can be quoted. For example, the following queries are correct and
equivalent, they all set _innodb_file_per_table_ to logical _True_:

mysql> SET GLOBAL innodb_file_per_table = "ON";
mysql> SET GLOBAL innodb_file_per_table = ON;
mysql> SET GLOBAL innodb_file_per_table = 1;

Tested in mysql 5.5 and 5.6.
11 years ago
Arturs Vonda 6d85082586 Added port documentation to postgresql_db and postgresql_user 11 years ago
George Miroshnykov 66b2d55a18 Add idempotency to mongodb_user module 11 years ago
Matthew Jones 31ac3e71df Allow strings containing single and double quotes to be used as passwords for postgres_user 11 years ago
Timur Batyrshin 658c15930e reword "except Error as e:" into "except Error, e:" to be compatible with Python 2.5 (#5852) 11 years ago
Matthew Leventi 07a388e567 adding the ability to change redis configuration 11 years ago
jctanner 09f7b11d1d Merge pull request #5435 from jkleckner/fix-mysql-dump-import
mysql_db module: make dump and import to use port argument
11 years ago
David Busby b4f86abafd Documentation update to yield example of "WITH GRANT OPTION" which is undocumented previous 11 years ago
Alan Fairless 7a86083850 Fix postgresql_user to understand PG namespaces
Previously postgresql_user quoted user supplied identifers to create
grant statements that look like this:

    GRANT SELECT on "tablename" to "user";

Which only works if the tablename is not in a namespace.  If you supply
a namespaced tabelname like "report.revenue" then it creates this
incorrect statement:

    GRANT SELECT on "report.revenue" to "user";

Which will not find the "revenue" table in the "report" namespace, but
will rather look for a table named "report.revenue" in the current
(default public) namespace.  The correct form is:

    GRANT SELECT on "report"."revenue" to "user";

This approach could have the unfortunate effect that code that
previously relied on the other behavior to grant privileges on tables
with periods in their names may now break.  PostgreSQL users
typically shouldn't name tables as such, and users can still access the
old behavior and use tablenames with periods in the if they must by
supplying their own quoting.
11 years ago
Jim Kleckner dacef1915a Add quotes to password argument for dump/import
The password is passed on a command line for dump and import and needs
quoting.

Ideally, this would not be passed on a command line at all - any ideas?
Or at least have a stronger form of quoting so that embedded single
quotes will be escaped.
11 years ago
Jinn Koriech aebae13c9b postgresql_user module: Gracefully handle ALTER ROLE on read-only postgres servers. 11 years ago
Jim Kleckner f532b449d7 Fix mysql_db dump and import to use port argument
The code for mysql_db did not pass the port argument when state=dump or
state=import.
11 years ago
jctanner 7182486fd2 Merge pull request #5099 from tartansandal/postgresql_db_check_mode
postgres_db CHECKMODE changed status
11 years ago
Jinn Koriech 6f2843724d Fix postgresql_user documentation render 11 years ago