Commit Graph

24 Commits (0e0f87be126afb2724961658000dba8949f56805)

Author SHA1 Message Date
Toshio Kuratomi 0de2627efc Make cache_parameter_group the name of this new param to match with similar params (leave old name as an alias) 9 years ago
Toshio Kuratomi e16c5c54fd Revert "Expose cache_parameter_group_name in elasticache module"
This PR #1950 implements duplicate functionality to #1353
This reverts commit b04efa22c4.

Conflicts:
	cloud/amazon/elasticache.py
9 years ago
Brian Coca a38e0095f9 added missing version added 9 years ago
Brian Coca 6e905f0586 Merge pull request #1950 from frenchfrywpepper/cache_parameter_group_name
Expose cache_parameter_group_name in elasticache module
9 years ago
Brian Coca c4f64d822c changed modules to use common ec2 docs for region 9 years ago
Brian Coca da220e0bb0 added version_added 9 years ago
Alex Kessinger 4308ae25c4 Fix a argument mismatch in elasticache
I think in this commit 720aeffca2

There was bug introduced where the ElastiCacheManager init method has
a number of positional arguments like so.

```py
    def __init__(self, module, name, engine, cache_engine_version, node_type,
                 num_nodes, cache_port, parameter_group, cache_subnet_group,
                 cache_security_groups, security_group_ids, zone, wait,
                 hard_modify, region, **aws_connect_kwargs):
```

But then later in the code the positional arguments are passed in
like this.

```py
    elasticache_manager = ElastiCacheManager(module, name, engine,
                                             cache_engine_version, node_type,
                                             num_nodes, cache_port,
                                             cache_subnet_group,
                                             cache_security_groups,
                                             security_group_ids, parameter_group, zone, wait,
                                             hard_modify, region, **aws_connect_kwargs)
```

If you count, you can see that cache_subnet_group, is being passed in
where the manager expects to see parameter_group.
9 years ago
Sarah Haskins b04efa22c4 Expose cache_parameter_group_name in elasticache module
The cache_parameter_group_name was not previously exposed in
elasticachy.py, I have exposed it, as optional.
9 years ago
Scot Spinner abf2083671 one thing missed 9 years ago
Scot Spinner b47bbfad1b merging with ansible devel 9 years ago
Frank van Tol 300656ca07 Remove default port value, it does not work in _requires_destroy_and_create logic
When creating a Redis cluster, every run it gets destroyed and recreated because the port number of memcached is used as the default.
9 years ago
Frank van Tol a85640c368 Update elasticache.py 9 years ago
Frank van Tol a7f33ee533 Remove default for engine_version
Redis and memcached have different engine version numbering, there can not be a shared default value.
9 years ago
Greg DeKoenigsberg 28a869a030 Updating cloud modules with proper github author information 10 years ago
Scot Spinner 720aeffca2 adding parameter group option 10 years ago
Brian Coca 74351490f7 doc fix 10 years ago
steenzout d960dc1584 issue #994: use HAS_BOTO to determine if import was successful:
- removed import of sys module.
- HAS_BOTO constant to check if import was successful.
- trigger a failure when import fails.
- removed unnecessary imports.
10 years ago
Brian Coca 8c80900fef removed requirements/boto as it broke documentation as it is duplicated in shared aws fragements 10 years ago
Mick Bass 64a2077787 Add support for AWS Security Token Service (temporary credentials) to all AWS cloud modules. 10 years ago
Brandon W Maister efa4d04284 Make cache_subnet_group default to empty security groups
Since they can't be specified together, it seems like setting the
default to no security groups is the right option.
10 years ago
Brandon W Maister 3cb2346312 Add `cache_subnet_group` to elasticache module
According to the [docs] cache subnet groups are required inside a VPC.

[docs]: http://docs.aws.amazon.com/AmazonElastiCache/latest/UserGuide/CacheSubnetGroups.html
10 years ago
Toshio Kuratomi 6cbce4d911 Potential fix for 640 10 years ago
Michael DeHaan e7c92a6bc6 More EC2 doc tweaks 10 years ago
Brian Coca 0c4adcb2c6 made subcategories for cloud modules for better organization 10 years ago