Commit Graph

342 Commits (0dcf27964c2b532594a52a08b2e6d5465bf99f15)

Author SHA1 Message Date
Brian Geihsler c6a934d57b Fix #1107: Prepend registry type on key path 9 years ago
Brian Geihsler d0e3a315ac Fix #1107: Use Get-Attr in win_regedit 9 years ago
Brian Geihsler 1e37276c97 Fix #1101: win_webpicmd strict mode fixes 9 years ago
Brian Geihsler 0e64863429 Fix #1099: Only populate site result when it is there 9 years ago
Corwin Brown c35c37258f Adding win_uri module 9 years ago
Brian Coca 561d768f44 Merge pull request #1076 from trondhindenes/win_package_bugfix
turned off strict msi code checking
9 years ago
Brian Coca a155f7ee34 Merge pull request #1071 from nlandais/devel
Adding fix to get around bug found with the New-Website command when…
9 years ago
Brian Coca cc69ac1513 Merge pull request #1064 from dreamcat4/feature/win_fw-hotfixes
hotfixes: module windows/win_firewall_rules
9 years ago
Corwin Brown f8e1600444 Made Powershell Strict Complient 9 years ago
Trond Hindenes b9d842ecd6 turned out strict msi code checking 9 years ago
Nicolas Landais d1dcf8e06b Adding fix to get around bug found with the New-Webstire command when running playbook on a vanilla machine. 9 years ago
= 576b5e2fc3 Document module limitations to resolve https://github.com/ansible/ansible-modules-extras/issues/908 9 years ago
Dreamcat4 ece9c2b43a fix: Add 'enable:' flag for enabling existing rules which are disabled by default.
This is a very much needed flag. To turn on/off existing firewall rules. And like the recent fix of the 'Profile' key, the netsh cmd prints 'Enabled' in the textual output. (at least on win10 it does). So again a similar small code added for the necessary exception handling when the difference check happens.

Please merge / push upstream like the other fixes. Many thanks. This is the last fix I have put together for this patch set. So I will raise my PR now.

But if you want to fix more bugs, it seems there may be others. In terms of the control code. Sometimes it will delete a rule under 'force' condition (when found difference) - but instead it is supposed to just modify the existing rule. Some weird behaviour regarding that. The other problem is that ansible does not return the error text printed by 'netsh' cmd verbatim... but it should as that makes debugging these errors a *lot* easier.
9 years ago
Dreamcat4 dcaa794949 fix: update documentation with new module name "win_firewall_rule" 9 years ago
Dreamcat4 469d22df97 fix: The names of firewall profiles are different on win10 & win2008r2
Hi again. This commit removes a small portion of your script's own internal error checking. In specific: for the value of the profile: key. This is essential to avoid errors on other verisons of the windows operating system which are not win2008r2 (your version).

For example: on win10 (and most likely win8x too), the names of the profiles don't include the values 'current' and 'all'. But instead the values are 'Public' 'Private' 'Domain' and 'Any. But in addition, there are also certain combinatorial values, such as profile=Public,Private etc. Which is too many to error check yourself.

Yet removing the error checking here should not cause any ill effects however: since the netsh advfirewall ... cmds themselves to add / remove / modify actually to their own error checking of the profile=value. So when the cmd is run, it will error out itself with an appropriate / informative error msg. No harm done.

Therefore please remove the highlighed portions from your own script. It is essential for interoperability with win10 and win8x. Many thanks.
9 years ago
Dreamcat4 6c5a4a14ef fix: win10 - Add exception handling for 'Profiles:' textual output key name mismatch.
In win10 (and pribably win8x also):

The output of 'show rule' key includes the line "Profiles:<TAB>Public,Private".
Yet your script expects the key name printed out to be "Profile:<TAB>value".

This commit added the necessary exception handling to avoid flagging 'different=true' under the false circumstance. The key name to SET a firewall rule is still "profile=" and not "profiles=".

There is coming up another commit to fix the value handling for win10/win8. Which is another (different) error with the profile: key.
9 years ago
Dreamcat4 2654789af7 fix: fw rule names must always be quoted, to permit spaces ' ' and brackets '()'
Without this fix, the 'netsh' command gets name=Firewall Rule Name instead of name="Firewall Rule Name". Thus causing all sorts of havoc. Basic shell quoting rules seems to apply to Windows Powershell too. This is very much needed as many of windows 10's default firewall rules contain spaces and brackets () characters.
9 years ago
Brian Coca ebbd7748b1 doc formatting fixes 9 years ago
Brian Coca 02b68be09d Merge pull request #854 from nitzmahone/win_updates_rewrite
win_updates rewrite for 2.0
9 years ago
Trond Hindenes 7c48fe617d added module author 9 years ago
Trond Hindenes 161b3cf1e1 fixes #984 9 years ago
Toshio Kuratomi 255666a09d Fix doc build 9 years ago
Greg DeKoenigsberg 22a3ec05e4 Merge pull request #1022 from trondhindenes/trondhindenes_win_chocolatey_improvements
win_chocolatey bugfixes
9 years ago
Greg DeKoenigsberg 5931e60d99 Merge pull request #695 from georgefrank/win_nssm
Adding win_nssm module
9 years ago
Greg DeKoenigsberg ff0a38ea65 Merge pull request #665 from perzizzle/scheduledTask
Ability to add/remove scheduled task
9 years ago
Phil 228abcd396 fixes examples in docs to use updated param name 9 years ago
Trond Hindenes d7cc0f60c9 win_chocolatey bugfixes 9 years ago
Brian Coca 7f245e8c73 Merge pull request #318 from TimothyVandenbrande/win_fw
windows firewall control
9 years ago
TimothyVandenbrande 2d6303b368 upon request, added the license 9 years ago
Michael Perzel 123a2b25ed Remove duplicate action declaration. 9 years ago
Michael Perzel a7675e6621 Note parameters that are not idempotent 9 years ago
Michael Perzel 685c935a37 Documentation updates 9 years ago
Michael Perzel 64416ff094 Fix logging of error message 9 years ago
Michael Perzel de1696cb74 Add support for specifying user for scheduled task to run as 9 years ago
Michael Perzel 027dff6d3d Add support for command arguments 9 years ago
Michael Perzel d0b4bc0dda Show order of operations with parenthesis 9 years ago
Michael Perzel a9eb69b0fa Use helper methods to validate vars. Cleanup logic. 9 years ago
Toshio Kuratomi 6a3cf63351 correct documentation formatting 9 years ago
Brian Coca b0b0ac1a58 Merge pull request #713 from trondhindenes/win_package
Added module win_package (was #618)
9 years ago
nitzmahone 29a80d3555 win_updates rewrite for 2.0
uses scheduled job to run under a local token (required for WU client)
supports check mode
no external PS module deps
9 years ago
gfrank b75f7cc22b Move comments to the documentation 9 years ago
gfrank 9d68a1746f Remove unnecessary aliases arrays 9 years ago
gfrank ee395ced4d Clean up unneeded comment and comma 9 years ago
Chris Church 6a7b2f5869 Workaround for bug in PowerShell Get-Website cmdlet. 9 years ago
Brian Coca e30d8b84fe more doc fixes 9 years ago
Greg DeKoenigsberg e1b15e6930 Merge pull request #438 from petemounce/win_webpicmd
win_webpicmd module for IIS module installation
10 years ago
Greg DeKoenigsberg 34bd09aae1 Merge pull request #440 from petemounce/win_dotnet_ngen
Create win_dotnet_ngen module
10 years ago
Peter Mounce 8128d42dcd re-submit @adematte's PR #278 against HEAD 10 years ago
Michael Perzel 681cdd1c12 Remove accidental newlines 10 years ago
Michael Perzel cdb36ea0fc Cleanup enable/disable logic 10 years ago
Phil b598161f46 minor doc fixes that had lingering description of deprecated functions 10 years ago
Brian Coca cc305adfb6 minor doc fixes 10 years ago
Brian Coca 2754157d87 minor doc fixes 10 years ago
Phil 26bdf16e69 changes param src to path, and updates docs accordingly 10 years ago
Phil 05e01bd3b5 updates user search verification for local/domain
- Thanks to @trondhindenes for implementing this strategy
- also updated documentation
10 years ago
Trond Hindenes a2166b60cb Added module win_package 10 years ago
Greg DeKoenigsberg c6e069dead Merge pull request #174 from schwartzmx/module/win_unzip
win_unzip Module
10 years ago
gfrank 05d5d939e7 Adding nssm requirement note 10 years ago
gfrank 8a72cf6a1c Adding win_nssm module 10 years ago
Michael Perzel 3542e7d42d Update method to determine if task exists, add days of week parameter to weekly triggers 10 years ago
Adam Keech 389e59b970 Adding functionality to not only edit Values, but also Keys. 10 years ago
Adam Keech e84666fd74 Renaming variables in win_regedit module to make more sense with actions that are happening. 10 years ago
Adam Keech 5a2a22bf68 Adding win_regedit module 10 years ago
Phil dc84f05fed changes check for src 10 years ago
Phil 311d73620b use convertto-bool for rm and recurse params 10 years ago
Timothy Vandenbrande b0a637086f add version_added: "2.0" 10 years ago
Timothy Vandenbrande d87da2ba2d renamed profile var 10 years ago
Michael Perzel 00d3a62907 Documentation updates 10 years ago
Michael Perzel d6339c47e4 Ability to add/remove scheduled task 10 years ago
Timothy Vandenbrande 97d8273558 windows default to current instead of all 10 years ago
Timothy Vandenbrande 2a0df8ec04 renamed the module 10 years ago
Timothy Vandenbrande ada6d0a18c added the profile option + updated the docs for it 10 years ago
Timothy Vandenbrande 828482643a Merge remote-tracking branch 'upstream/devel' into win_fw 10 years ago
Brian Coca 552c4ef53a Merge pull request #441 from petemounce/win_scheduled_task
win_scheduled_task module for windows
10 years ago
Phil b5d724c2fb removed hardcoded paths, check for .exe error exit code, use get-attr for required param check. 10 years ago
Toshio Kuratomi dec7d95d51 Fix up docs 10 years ago
Toshio Kuratomi 9183170a4a These modules were added to version 2.0, not 1.9 10 years ago
Greg DeKoenigsberg 526e2d30ea Merge pull request #419 from whenrik/devel
Adds Modules to manage IIS
10 years ago
Phil 6b41b80b09 init commit win_timezone 10 years ago
Phil 03ce40a62e removes restart functionality, and added creates param for idempotency 10 years ago
Phil 92744ef558 fixes typo 10 years ago
Phil d72bb17de1 check if the rule exists or not before allow/deny rules are added/removed, and fixes where result changed would be true on all executions. 10 years ago
Phil 623a29cc0e update to not auto-install PSCX
- will use built-in powershell method instead for .zip files
- added example for installing pscx as a pretask
10 years ago
Greg DeKoenigsberg 004dedba8a Changes to author formatting, remove emails 10 years ago
Greg DeKoenigsberg dc519fb848 Add author data 10 years ago
Pepe Barbe b5d22eb1ec Refactor win_chocolatey module
* Refactor code to be more robust. Run main logic inside a try {} catch {}
  block. If there is any error, bail out and log all the command output
  automatically.
* Rely on error code generated by chocolatey instead of scraping text
  output to determine success/failure.
* Add support for unattended installs: (`-y` flag is a requirement by
  chocolatey)
* Before (un)installing, check existence of files.
* Use functions to abstract logic
* The great rewrite of 0.9.9, the `choco` interface has changed, check
  if chocolatey is installed and an older version. If so upgrade to
  latest.
* Allow upgrading packages that are already installed
* Use verbose logging for chocolate actions
* Adding functionality to specify a source for a chocolatey repository.
  (@smadam813)
* Removing pre-determined sources and adding specified source url in
  it's place. (@smadam813)

Contains contributions from:
*  Adam Keech  <akeech@chathamfinancial.com> (@smadam813)
10 years ago
Ernst Kuschke 3761052597 Allow any custom chocolatey source
This is to allow for a local source (for instance in the form of artifactory)
10 years ago
Brian Coca e5d59d2014 Merge pull request #494 from jhawkesworth/set_windows_environment_variables
Set windows environment variables
10 years ago
Peter Mounce 8454997cd9 version -> 2, remove unnecessary doc attributes 10 years ago
Peter Mounce dc347b0683 fix license boilerplate 10 years ago
Peter Mounce ec172be310 win_webpicmd module for IIS module installation
Chocolatey 0.9.9+ deprecated support for the `webpi` custom source, so I needed to write this.

[Windows Web Platform Installer](http://www.microsoft.com/web/downloads/platform.aspx) is a way of installing products and applications for Microsoft IIS on Windows. It has a [command line](http://www.iis.net/learn/install/web-platform-installer/web-platform-installer-v4-command-line-webpicmdexe-rtw-release); this ansible module allows IIS modules to be installed via this means.

To find out names of modules, use `webpicmd /list /listoption:available`.

Notes:
* `webpicmd` must be installed and on `PATH` first (see `win_chocolatey` module; package is `webpicmd`)
* `webpicmd` does not allow modules to be uninstalled
* IIS must be installed first (see `win_feature` module; package is `Web-Server`)
* Installations will
  * accept EULA (which otherwise requires user input)
  * suppress reboots (so you have to manage those; see `win_reboot` module)
10 years ago
Peter Mounce c322627320 use the notes property 10 years ago
Peter Mounce 52a87e1637 version -> 2, quote doc strings with colons 10 years ago
Peter Mounce ddb85479cd Add documentation note 10 years ago
Peter Mounce 0b0416aca1 Create win_dotnet_ngen module
When .NET is installed or updated, ngen is triggered to optimise the installation. This triggers high CPU while it's happening, and usually happens at an inconvenient time.

This allows you to trigger it when you like. Full details and background in doc.

I don't know a way to figure out whether this is required without actually running it.
10 years ago
Peter Mounce a4a3a13439 Code-review
Swap state enabled/disabled -> enabled yes/no
10 years ago
Peter Mounce d9211b709b no default, remove it 10 years ago
Peter Mounce ede4820562 version_added -> 2, remove empty aliases 10 years ago
Peter Mounce 4fef779f09 caught out by syntax 10 years ago
Peter Mounce 6f1d9fbbcc correct variable name 10 years ago
Peter Mounce d1c896d31e win_scheduled_task module for windows
Fledgling module to allow scheduled tasks to be managed.
At present, I only need enabled/disabled support. There's lots of scope for more features.
10 years ago
Toshio Kuratomi 88eff11c04 Many more doc fixes 10 years ago
Jon Hawkesworth ccd9a4eb6a Update attribution 10 years ago
Jon Hawkesworth 44fa32f2dc Add win_environment module 10 years ago
Greg DeKoenigsberg efd307903c Adding author's github id 10 years ago
Greg DeKoenigsberg 8ec8cd182a Adding author's github id 10 years ago
Greg DeKoenigsberg 9a1e35e1db Adding author's github id 10 years ago
Henrik Wallström 91483bdd6b Modules to manage IIS
Wraps the Web Server Administration module for PowerShell into Ansible modules.
10 years ago
schwartzmx c6d5680967 fixes unzip bug for zip files, thanks to @ryanwalls
- also fixes possible import errors, and switches to use Start-Process on install to correctly wait
10 years ago
Timothy Vandenbrande 6b43dd630c windows firewall control 10 years ago
schwartzmx 4ece7362fb inital commit win_acl 10 years ago
schwartzmx 99927a5c54 updates docs, adds unzip func for bz2 gz tar msu¬
- Added functionality for unzipping/decompressing bzip gzip tar exe (self extracting) and msu (ms update) files to coincide with added functionality to win_zip¬
  - Added functionality requires PSCX (it will be installed if it can't be imported)¬¬
    - First try with chocolatey, if fail, direct install from msi
- Added recurse param to recursively unzip files from a compressed folder¬
  - useful for example: unzipping a Log.zip file that contains a load of .gz files¬
    - setting rm param to true will remove all compressed files after decompressing¬
10 years ago
Phil Schwartz a95fabeeb2 fixes rm & restart param checks 10 years ago
Phil Schwartz 61d3f23c03 edit check for extension to use library func 10 years ago
Phil Schwartz fd12a5cc84 specifies creation of directory if !exists
- added try catch for creation of directory, in case of an invalid path specified
- added specification to documentation
10 years ago
Phil Schwartz a21e23846d init commit 10 years ago
Brian Coca 24734db807 corrected version added 10 years ago
net 33585d14a3 package file 10 years ago
Brian Coca b5a0d10925 changed to use ansible standard 'name' instead of 'package' 10 years ago
Toshio Kuratomi 19e688b017 Fixes to documentation 10 years ago
Brian Coca 12e419bb4b Merge pull request #37 from petemounce/chocolatey
win_chocolatey: Windows package management with Chocolatey
10 years ago
Peter Mounce 9fb500480b Windows package management with Chocolatey 10 years ago
Peter Mounce 7f2732782d Add module to install windows updates
Supports specifying which category to install all updates from.
NEEDS: `choco install PSWindowsUpdate` beforehand - does not attempt to install it (or detect it's missing, yet)
PSWindowsUpdate: http://gallery.technet.microsoft.com/scriptcenter/2d191bcd-3308-4edd-9de2-88dff796b0bc#content
10 years ago
Michael DeHaan 73123b69fa Move modules into subdirectory. 10 years ago
Jon Hawkesworth f8a5ddb9fd This change selects the certificate from the winrm configuration and attempts to find the expiry date from that.
Trond Hindenes pointed out that simply picking the first certificate from local computer certs is not guaranteed to select the correct certificate.
10 years ago
Jon Hawkesworth a098882fb9 Added null check in case http connection used and no cert found. 10 years ago
Trond Hindenes 9aa6c44473 All changes referenced in PRs #8767 , #8768 , #8769 :
This changes the get-attr function slightly, and lets the module specify whether a param is needed and auto-fails if it is not present. A module can now verify params like so::
 $params = Parse-Args $args;
 $result = New-Object psobject;
 Set-Attr $result "changed" $false;
 $path = Get-Attr -obj $params -name path -failifempty $true -resultobj $result

or

$params = Parse-Args $args;
 $result = New-Object psobject;
 Set-Attr $result "changed" $false;
 $path = Get-Attr -obj $params -name path -failifempty $true -emptyattributefailmessage "Oh man. You forgot the main part!" -resultobj $result

slight tweak in how the powershell module converts to json in order to support nested objects (allows for more complex facts, among others)

This script gathers some extended facts on windows hosts in a json array attribute called "ansible_interfaces". This info is needed for some network-related modules I'm working on. Required the update to powershell.ps1 to return deeply nested json objects.
10 years ago
Chris Church 1b6ef9aa2e Replace Get-FileHash with MD5 code that works on PowerShell 3. 10 years ago
Michael DeHaan 71786bbdc8 Merge pull request #8227 from trondhindenes/win_setup_improvements
win_setup improvements: Correcly outputs ansible_totalmem
10 years ago
Trond Hindenes fc26601981 win_setup improvements: Correcly outputs ansible_totalmem on computers with multiple ram chips 11 years ago
Trond Hindenes ba507553b0 Better result handling 11 years ago
Trond Hindenes 8e16962596 improvements to win_feature 11 years ago
Chris Church 042d5b761d Return service name, display name, start mode and state from win_service module. 11 years ago
Michael DeHaan f777471337 Merge pull request #7889 from chrishoffman/win_group
Adding win_group module
11 years ago
Chris Hoffman da7c617ad3 Adding win_group module 11 years ago
Chris Hoffman 3a3a285d96 Fixing bug with stopped state 11 years ago
Chris Hoffman 24ad45c8e6 Better propagation of cmdlet errors 11 years ago
Chris Hoffman 0f2c5a3472 Using generic windows service for example 11 years ago
Michael DeHaan 4e153c7584 Merge pull request #7881 from cchurch/devel
Fix typo in powershell setup module.
11 years ago
Chris Hoffman 3000614930 Adding win_service module 11 years ago
Chris Church 1780cd6fda Fix typo in powershell setup module. 11 years ago
Simon Olofsson 73c4cb4c07 win_feature: Fix Description. 11 years ago
Paul Durivage eba5e34641 Check .GetType rather than object directly 11 years ago
Paul Durivage 1fee46270c Move check down for access to 11 years ago
Paul Durivage 44fcebc5aa Rename variable 11 years ago
Paul Durivage 42834963cc Update documentation 11 years ago
Paul Durivage ce0909035b Fix so it only deletes users that exist 11 years ago
Paul Durivage 6f87380248 Remove commented out lines 11 years ago
Paul Durivage ac1d1b509b Fix incorrect name 11 years ago
Paul Durivage 5636f2b033 Move functions to top for correct scope 11 years ago
Paul Durivage f8f1b7e922 Refactor of win_user module 11 years ago
Matt Martz 0ac996fbaa Add documentation for win_user module 11 years ago
Matt Martz 53497d90da Make sure the doc stubs for windows modules have proper license headers 11 years ago
Matt Martz 1f9121911c Make sure the module name is specified correctly in the win_feature docs 11 years ago
Paul Durivage 52ffcfb1ea Add documentation for win_feature module 11 years ago
Paul Durivage 8b0cc1a87b Add comments 11 years ago
Paul Durivage ebbf356b30 Add restart functionality 11 years ago
Paul Durivage a8dff668dd Renaming and refactoring of names, variables 11 years ago
Chris Church d1423254d0 Update slurp/win_ping/win_stat to use Get-Attr. 11 years ago
Paul Durivage e0f618b27a Remove unnecessary obj 11 years ago
Chris Church 2a20dfe963 Add data option to docs for win_ping. 11 years ago
Chris Church a13b2dd3b3 Add tests for win_stat module. 11 years ago
Paul Durivage c218a125bb Fix variable reference 11 years ago
Paul Durivage c83e5d0890 Ensure state is present if no value provided 11 years ago
Paul Durivage 03526456fa Fix logic to ensure state is either present or absent 11 years ago
Paul Durivage 376d1cc0a4 Add prelim version of win_feature module (for installing packages, roles, features, etc) 11 years ago
Michael DeHaan 2944962915 Add explanation of windows upgrade details. 11 years ago
Don Schenck 755da95e15 Added logging to UpgradeToPS3.ps1
UpgradeToPS3.ps1 failed when tested with Ansible. Added logging output
to file C:\powershell\install.log.
11 years ago
Chris Church e9c9cab3c8 Add integration tests for fetch/slurp, make powershell fetch/slurp work as close as possible to existing fetch/slurp modules. 11 years ago
Paul Durivage 9a52ee4753 Make non-executable 11 years ago
Paul Durivage ec6a386967 Add win_get_url module documentation 11 years ago
Paul Durivage 9eeb4c39f7 Add win_get_url module 11 years ago
Matt Martz 3238268ea3 Remove unneeded code, document creates param and ensure creates only affects state=present 11 years ago
Matt Martz fed9e9087e At state for win_msi and add documentation 11 years ago
Matt Martz 499031ef47 First pass at win_msi.ps1 msi installer module 11 years ago
Paul Durivage cb129b444a Add memory and IP information to setup 11 years ago
Matt Martz b0ef377a09 Add Exit-Json and Fail-Json powershell helper functions 11 years ago
Matt Martz 57f43ae518 Clean up how we initialize the result psobject 11 years ago
Matt Martz 70936bbf8b A couple of DOCUMENTATION fixes for win_ping and win_stat 11 years ago
Michael DeHaan 289b77d6da Update windows docs in progress. 11 years ago
Michael DeHaan b9f8aac85e Add doc stubs 11 years ago
Michael DeHaan 10706180a7 Add a docs stub for the module. 11 years ago
Matt Martz d30f0e384a setup.ps1 willnot support fact_path and filter to start 11 years ago
Michael DeHaan 3bba3be68b Remove stubs. 11 years ago
Matt Martz 2e3a44d835 Need to call ToString Platform to get the string 11 years ago
Michael DeHaan bbd8228d21 Rename some modules so they can have seperate doc stubs. 11 years ago
Matt Martz ddb7e6669e Add start for powershell setup module 11 years ago
Matt Martz b3b52800f3 Add license header to powersell modules 11 years ago
Matt Martz 4268cb6a2d Add shared functions to module_utils/powershell.ps1 and refactor powershell modules to utilize the common powershell code 11 years ago
Matt Martz 3b5c568b10 Use more simple check for existence of member 11 years ago
Matt Martz fb43772429 Instantiate psobject directly 11 years ago
Chris Church 54e5289f79 Add shell_plugins to abstract shell-specific functions out of runner, add winrm connection plugin, add initial Windows modules. 11 years ago