Commit Graph

1741 Commits (0b6570eef8e3a0f83b59bef8c33e40ea956e71a7)

Author SHA1 Message Date
trbs b537aff586 Fix for #3062 additional groups should only be added once.
Also consolidated duplicate groups code into one get_groups_set() method.
Removed unused call to user_group_membership.
Removed sorting operations on set functions cause sets are inherently unordered.
Minor style improvements to match the rest of the code.

The new function will make the order of group names passed to the system command less determistic.
Which was already the case for modify_user_usermod() but not for other methods.
It will also strip out duplicate group names automatically which was not always the case previously.
12 years ago
Lorin Hochstein 8c9cceacbf authorized_key: Set manage_dir default value
This commit fixes a bug where the authorized_key module causes
the ~user/.ssh directory to be owned by root instead of the user,
when the manage_dir argument is not specified.

If the manage_dir argument was not specified, the module behaved as if
manage_dir was set to false, even though it's supposed to default to
true.

This module assumed that an optional argument, with no default
specified, will not be present in the module.params dictionary.

What actually seems to happen is that the argument does appear in
the module.params dictionary with a value of None.

The upside is that this line was evaluating to None instead of
true:

    manage_dir = params.get("manage_dir", True)

I fixed the problem in this particular module by explicitly specifying
the default value for the manage_dir arugment. But if this bug
occurred because of a change in behavior in AnsibleModule, then other
modules may be broken as well.
12 years ago
Michael DeHaan ad1a02aa55 Merge pull request #3064 from sfromm/issue2990
Verify /proc/modules is readable (issue #2990)
12 years ago
Stephen Fromm 00b3a450c7 Verify /proc/modules is readable (issue #2990) 12 years ago
Stephen Fromm 3127bab6d6 Use get_bin_path to find mkfs command (issue #2983) 12 years ago
Michael DeHaan 0c03a5cfc2 Merge pull request #3049 from stoned/cmd-expanduser-once
No need to expanduser() command's chdir argument twice
12 years ago
Chris Gardner 2b71ab6765 Fix typo. Solaris 9 should now correctly ignore 'brand' and use 'implementation'. 12 years ago
Chris Gardner 88115f4ab2 TODO: Separate IPv4 and IPv6 12 years ago
Jiří Kubíček 5cb0525430 Add some FreeBSD facts
added:
 * ansible_distribution
 * ansible_distribution_release 
 * ansible_distribution_version
 * ansible_os_family
 * ansible_pkg_mgr
 * ansible_ssh_host_key_ecdsa_public

Also adds ECDSA public key for all plaforms.
12 years ago
Chris Gardner 6809b56233 Add Solaris network facts. IPv6 details overwrite IPv4 per interface, needs further work. 12 years ago
Michael DeHaan 07361375b5 Fix version added field in modules. 12 years ago
Michael DeHaan 44e32cc45e Some formatting fixes so docs will build, etc. 12 years ago
Michael DeHaan 250bcaff03 Fix docs build causing parse error message. 12 years ago
Michael DeHaan 5e8923c04f use EXAMPLES vs examples (easier to format) 12 years ago
Michael DeHaan f7cabfe64e use EXAMPLES vs inline examples (easier to format) 12 years ago
Michael DeHaan b7485ea4d6 Merge pull request #3046 from dstoflet/devel
Adding monit module to start/stop/monitor/unmonitor process via monit
12 years ago
Michael DeHaan 02e772bb29 Merge pull request #3032 from thaumos/devel
Pagerduty and Pingdom modules for core
12 years ago
Michael DeHaan a9fcea5893 Merge branch 'escape' of git://github.com/ngrilly/ansible into repr 12 years ago
Chris Gardner f482649cbb Add clock speed to processor description for SPARC CPU. 12 years ago
Chris Gardner 68959e7f92 Use 'implementation' if 'brand' not available (Solaris 9). Add CPU socket/core counting. 12 years ago
Stoned Elipot f9cff3c444 No need to expanduser() command's chdir argument twice 12 years ago
Michael DeHaan f9a14f0d70 Fixup fetch doc formatting. 12 years ago
Michael DeHaan 01a2384cdd Minor style tweak. 12 years ago
Timothy Appnel 3e774fedea Modified assemble module so the dest file is streamed together rather than built-in memory before writing. 12 years ago
Michael DeHaan a581077b4d Merge branch 'facter-fix' of git://github.com/flyapen/ansible into devel 12 years ago
Michael DeHaan 575967cee4 Merge pull request #3038 from jsmartin/riak_bugfixes
Riak bugfixes
12 years ago
Guillaume Lasmayous 1c0e01a72b Implement NetBSD-specific subclass of Hardware in the setup module.
Defines memory and CPU facts:
- memfree_mb
- memtotal_mb
- swapfree_mb
- swaptotal_mb
- processor (a list)
- processor_cores
- processor_count
- devices

As a matter of fact, on NetBSD, it is possible to get memory, swap and
processor facts exactly as on Linux. Tested on NetBSD-5, NetBSD-6 and
NetBSD-6.1 (without Linux emulation).
12 years ago
Michael DeHaan ebf28ff856 Merge pull request #2867 from cstorey/rabbitmq_user-node-parameter
Allow specification of erlang node name for rabbitmq_user/vhost/parameter actions.
12 years ago
Darryl Stoflet 0b53c711a6 Adding monit modules to start/stop/monitor/unmonitor process via monit 12 years ago
Chris Gardner 9ca7165f88 Use kstat for Solaris CPU info 12 years ago
Chris Gardner 66c10410ec Use kstat for Solaris CPU info 12 years ago
James Martin 1aec4c0e74 Now can specify amount of time to wait_for_handoffs or ring ready instead of booleans. 12 years ago
James Martin 633724dc8c Timeouts implemented for riak stats operation. Removed failback mode
for fetching riak stats.
12 years ago
Dylan Silva da5be56b33 Pagerduty and Pingdom modules for core 12 years ago
Lorin Hochstein b432ae5a74 Documentation for keystone_user
Updated the module with proper documentation.
12 years ago
Kristof Keppens c5b40ca2ff change fix to lookup path with get_bin_path 12 years ago
Rik Theys e97f789913 Fix tabs 12 years ago
Ceri Storey c01992b564 Update rabbitmq_user/vhost/parameter to pass the node to rabbitmqctl using -n flag to rabbitmqctl rather than setting the environment variable. 12 years ago
Rik Theys a61978aed9 Support state parameter in list_vms command
Support the state parameter in the list_vms command to filter the
VM's to list based on their state.
12 years ago
Michael DeHaan 3a635d2d26 Lots of formatting fixes 12 years ago
Michael DeHaan 9c5d6f11f0 Fix tabs and spaces in OpenStack modules. 12 years ago
Michael DeHaan b499f0754e Merge pull request #2986 from wbowling/devel
Fixes apt_repository always reporting file uri repos as changed
12 years ago
Michael DeHaan 82909179a0 Merge pull request #2976 from stoned/pip-virtualenv_command-pathname
Allow virtualenv_command argument of the pip module to be a pathname
12 years ago
Michael DeHaan 698b2fe9c5 Merge pull request #2992 from SirScott/service_pattern
Fixes #2991: Service module pattern argument ignored.
12 years ago
Michael DeHaan 84623441e1 Merge pull request #2945 from jsmartin/new_fetch
Fetch destination path can now be overriden.
12 years ago
Michael DeHaan e68894ea45 Merge pull request #2975 from stoned/doc-pip-fix
Fix pip module documentation (YAML quoting)
12 years ago
Michael DeHaan e3af9258ae Merge pull request #2995 from SirScott/pip-sudo-user
pip module -- sudo_user permission problem fix
12 years ago
Michael DeHaan c397969ca3 Merge pull request #3001 from SirScott/user-always-changing
Fixes #2924: User creation always reports 'changed'
12 years ago
Michael DeHaan 9d92125a93 Merge pull request #2989 from lorin/keystone_user
OpenStack Identity (keystone) user module
12 years ago
Michael DeHaan 6ed01d2d9c Merge pull request #2985 from bennojoy/devel
OpenStack Modules
12 years ago
Michael DeHaan 2459255739 Merge pull request #3016 from bpennypacker/airbrake_deployment
new airbrake_deployment module
12 years ago
Bruce Pennypacker fceaca4a53 new airbrake_deployment module 12 years ago
Michael DeHaan 1d3782cfc7 Merge pull request #3006 from stoned/doc-fix-npm
Fix typo in npm module documentation preventing it to be processed by an...
12 years ago
Stoned Elipot c9f268ac48 Fix typo in git module documentation preventing it to be processed by ansible-doc 12 years ago
Stoned Elipot 81e0a7adcc Fix typo in npm module documentation preventing it to be processed by ansible-doc 12 years ago
Nicolas Grilly 75ceb80572 Escape args injected in new style modules 12 years ago
Scott Sturdivant 922a1efbc0 Fixes #2924: User creation always reports 'changed' 12 years ago
James Martin 3c131dbd2b Initial Commit. 12 years ago
Scott Sturdivant b2542bff72 Chdir to tempdir to prevent permissions problems. 12 years ago
Scott Sturdivant b274fb9774 Fixes #2991: Service module pattern argument ignored. 12 years ago
Lorin Hochstein dbd9d92861 OpenStack Identity (keystone) user module
Module for managing users, tenants, and roles within OpenStack.
12 years ago
Kristof Keppens e2e10c1977 fix for facter being installed in a different location 12 years ago
William Bowling 222f004bfa Fixes apt_repository always reporting file uri repos as changed 12 years ago
bennojoy b16e2a1d48 OpenStack Modules 12 years ago
Stoned Elipot d4d0753e03 Allow virtualenv_command argument of the pip module to be a pathname 12 years ago
Stoned Elipot 83cce7d2e0 Fix pip module documentation (YAML quoting) 12 years ago
Bruce Pennypacker d4429fcb91 Fixed handling of urlopen result to work properly under both python 2.4 and python 2.6 12 years ago
John Jarvis daf4c358f7 fixes case where name is omitted from pip arg list
This code:
```
    if name.endswith('.tar.gz') or name.endswith('.tar.bz2') or
name.endswith('.zip'):
        is_tar = True
```
was not checking whether name is defined since it is an
optional param.
12 years ago
John Jarvis 423fe82d94 fixing syntax error 12 years ago
Elan Ruusamäe d3a2b1dbbb no need to init None to None 12 years ago
Michael DeHaan 5f98c6c246 Merge pull request #2948 from jcbagneris/devel
Fixes in apt module doc: typos, examples
12 years ago
Michael DeHaan 206b34783f Merge pull request #2942 from stoned/doc-requirements
Fix empty requirements specifications in modules documentation
12 years ago
Michael DeHaan 328065506e Merge pull request #2941 from bcoca/setup_bin
no uses get_bin_path for 2nd use of ip tool
12 years ago
Michael DeHaan 39673fe8c0 Merge pull request #2940 from madema/patch-3
-o and -r option don't exist on AIX
12 years ago
Michael DeHaan fee3d9004f Merge pull request #2934 from j2sol/git-update
Add an update option to the git module
12 years ago
Michael DeHaan 223e4e2349 Merge pull request #2932 from bcoca/apt_getbins
apt now uses module function to find bin paths
12 years ago
Michael DeHaan 3ecae5f21a Merge pull request #2931 from caredotcom/flowdock_nochange
flowdock module returns changed=false on succes
12 years ago
Michael DeHaan 439c2ef684 Merge pull request #2921 from lwade/ec2_fact_doc
Added a helpful example to the ec2_facts doc.
12 years ago
Michael DeHaan d6048425e3 Merge pull request #2919 from fabulops/campfire_notification_fixes
Campfire Notification Module: Typo fixes, tighter error handling, corrected check mode support
12 years ago
Ton Kersten 8926684942 Fix issue 2906 12 years ago
Michael DeHaan 56e3cef60c Merge pull request #2918 from bcoca/jabber_notchanged
jabber module returns changed=false on success
12 years ago
Michael DeHaan f8a99335dd Merge pull request #2914 from jpmens/notif_unchanged
notification modules irc, mqtt now exit with changed=False
12 years ago
Michael DeHaan e389b00050 Merge pull request #2905 from kjkuan/bugfix-apt-version-comparison
Make package version comparison use globbing.
12 years ago
Michael DeHaan 9a19e8a8ae Merge pull request #2875 from yeukhon/devel
Pip's name key can now accept remote package address.
12 years ago
Yeukhon Wong 08a486fe31 Pip can now accept vcs or tarball as name. Prevented adding mirrors when name is vcs.
**Summary**:

There was a bug in the previous commit; pip module would add --use-mirrors options to a source package when state is absent. The bug is resolved in this commit by checking ``not is_package`` in the if branch.

Furthermore, in order to support non-vcs source name like tarballs, we must not add -e option to the arg list. Given this circumstance, this commit have is_tar and is_vcs and the latter is checked to add -e option. Since mirrors do not make sense with vcs or tarball source, this commit will not add --use-mirrors (default to True) as always.
12 years ago
JcB 33ba919e5f Fixes in apt module doc: typos, examples 12 years ago
Stoned Elipot d25888f410 Fix empty requirements specifications in modules documentation
And also be liberal in what ansible-doc accepts as an empty
requirements specification.

While here fix a typo in template module documentation
wrt jinja2 overrides example.
12 years ago
Brian Coca 8d6e18fc90 no uses get_bin_path for 2nd use of ip tool (fixes reported issue with openwrt)
module needs this added to many tool invokations, but his is a start
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
madema 58d59c180d -o and -r option don't exist on AIX 12 years ago
Jesse Keating f645d27f5e Add an update option to the git module
This will allow just making sure the repo exists w/out actually making
any chnages to it. Useful if you're going to run a play repeatedly
against a host that might have active development going on in the
repository (think initial bootstrap of a developers system, and
continued playbook runs to work on other projects).
12 years ago
Brian Coca a8ca48888f apt now uses module function to find bin paths
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Matt Coddington ccd2bafd37 notification modules should set chnged to False 12 years ago
lwade 8b62f25c5c Added a helpful example to the ec2_facts doc. 12 years ago
Adam Garside 628254a8ed Typo fixes, tighter error handling, corrected check mode support 12 years ago
Brian Coca b71a09d6ab module returns changed=false on success
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Jan-Piet Mens 79cff7c076 notification modules irc, mqtt now exit with changed=False
(as per discussion on ML)
12 years ago
Michael DeHaan d29d142a2d Merge pull request #2911 from sergevanginderachter/apt-repo-ppa-bug
fix an idempotence bug in apt-repository where 'ppa' is used in a plain http://ppa. ....
12 years ago
Jack Kuan c7ebe44780 Make package version comparison use globbing.
I have something like:

  apt: pkg={{ item }} state=present
  with_items:
    - python-pysqlite2=2.6.3-*
    - python-paramiko=1.7.7.1-*

But due to the use of *'s in the version specifications, the apt ansible
module always reports changed: true. This patch fixes that.
12 years ago
Jan-Piet Mens 98ddb1ca6b notification/mqtt: ensure network communication and check error 12 years ago
Michael DeHaan 3d3a050648 Style fix. 12 years ago