Brian Coca
e5f297697a
ifconfig changed on FreeBSD, tested this on 8,9 and 10 latest stable
...
versions and it now works
11 years ago
Brian Coca
bc23926f42
fixed ETIME issue on FreeBSD 8 through 10, which broke all fact
...
gathering
11 years ago
Michael Scherer
c87afc1109
Clean a bit more the ssh_args configuration
...
If someone add ssh_args = " " to his .ansible.cfg, it will result into
strange failure later :
<server.example.org> ESTABLISH CONNECTION FOR USER: misc
<server.example.org> REMOTE_MODULE ping
<server.example.org> EXEC ['ssh', '-C', '-tt', '-q', ' ', '-o', 'KbdInteractiveAuthentication=no',
'-o', 'PreferredAuthentications=gssapi-with-mic,gssapi-keyex,hostbased,publickey', '-o', 'PasswordAuthentication=no',
'-o', 'ConnectTimeout=10', 'server.example.org', "/bin/sh -c 'mkdir -p /tmp/ansible-tmp-1397947711.21-5932460998838
&& chmod a+rx /tmp/ansible-tmp-1397947711.21-5932460998838 && echo /tmp/ansible-tmp-1397947711.21-5932460998838'"]
server.example.org | FAILED => SSH encountered an unknown error during the connection. We recommend you re-run the
command using -vvvv, which will enable SSH debugging output to help diagnose the issue
The root cause is the empty string between -q and -o, who kinda break mkdir.
11 years ago
Michael Scherer
3a09c99811
Enhance error message about missing ControlPersist
...
ansible_ssh_args is good for playbook, but in the ~/.ansible.cfg
file, it should be ssh_args in a specific section.
11 years ago
James Cammarata
ae29e43f93
Merge branch 'issue_7009_nfs_selinux' into devel
11 years ago
James Cammarata
a32dd34359
Make sure HostVars object is instantiated before assigning it
...
Fixes #7006
11 years ago
Jim Kleckner
46ec238613
Fix #7057 missing False default for vars_prompt
...
The test for default should be "is not None" since a boolean value of
False is a valid value.
See discussion at:
https://groups.google.com/forum/#!topic/ansible-project/oc1_zE-FnyI
11 years ago
James Cammarata
75e0b7a5cf
Make sure umask is set restrictively before creating any vault files
11 years ago
James Cammarata
3715482d7c
Determine selinux context for NFS mount points correctly
...
Fixes #7009
11 years ago
Sébastien Gross
22d6572270
Honor ansible_private_key_file for delegated hosts
...
If a delegated host is not found in the inventory specified
private_key_file for primary host was not used.
This allows running playbooks without having to define any inventory at
all and to use the same ssh private key for both primary host and
delegated one.
11 years ago
Wim
6ed4ca97a8
hint to install python-ssl on redhat systems
11 years ago
smoothify
48bf7a000d
Try to pass in item to on_skippped callback.
11 years ago
James Cammarata
d240d073eb
Changing SSL cert detection method to allow for auto-negotiation of SSL protocols
...
Fixes #6904
11 years ago
James Cammarata
23c5f4524d
Make sure args in run_command are encoded for shlex.split calls on py2.6
11 years ago
James Cammarata
d494a163f9
Merge pull request #6900 from jimi-c/issue_6891_cifs_mount_hang
...
Add a timeout decorator for timing out functions that may hang
11 years ago
James Cammarata
ba1a6c2e11
Removing .orig file merged in accidentally
11 years ago
James Tanner
aad128bac7
Use combined cache for templating module vars
...
Fixes #6901
11 years ago
James Cammarata
40b958e348
Don't turn complex args back into a k=v string for the synchronize module
...
Fixes #6951
11 years ago
James Cammarata
2cc4ac2e75
Catch traceback caused by permissions errors during a local md5 sum
...
Fixes #6948
11 years ago
Aaron Iles
a5507275cb
Fix localhost tasks with complex executables
...
Enable the use of executable commands that use command line options with
the localhost command runner. These commands require parsing out the
base executable from the command string to pass to subprocess.
11 years ago
jctanner
bfb25f4f89
Merge pull request #6917 from bcoca/random_filter_clean
...
simple random filter
11 years ago
jctanner
af99abc81c
Merge pull request #6913 from willthames/aws_module_doc_fragments
...
Use common module document fragments for AWS modules
11 years ago
James Tanner
4eb626825b
Refactor play._update_vars_files_for_host to make common functions and easier debugging
...
Fixes #4883
11 years ago
Brian Coca
80cd217eb7
simple random filter
11 years ago
willthames
509561f658
Moved AWS modules over to common module fragments
...
Created common module doc fragment, and applied to all
modules that use ec2_connect or connect_to_aws as
they definitely share the common doc fragments
11 years ago
James Cammarata
5ce6c86595
Merge branch 'sudo_pass_typo' of https://github.com/tyll/ansible into tyll-sudo_pass_typo
11 years ago
James Cammarata
eebc72ab9b
Add a timeout decorator for timing out functions that may hang
...
Fixes #6891
11 years ago
James Tanner
2d33cd1b5d
Fixes #6894 add missing file and remove debug line
11 years ago
James Tanner
68cd7258b6
Fixes #6894 create docs fragment for files
11 years ago
James Cammarata
9ca8c3262c
Switch module safe_eval to ast.literal_eval
11 years ago
James Tanner
318e752b6f
Fixes #6845 evaluate changed_when only if task is not skipped
11 years ago
Michael DeHaan
ccdd91f9c2
Merge pull request #6861 from ericlake/devel
...
add distribution_major_version to fact gathering
11 years ago
James Tanner
5a65dc3b6a
Fixes #6820 fix erroneous missing vault password error when using the template module
11 years ago
Eric Lake
7f9736198a
add distribution_major_version to fact gathering
11 years ago
Serge van Ginderachter
e36e2d38fe
InventoryDir: another fix for the host.groups list
...
In some cases, where a host is mentioned in multiple groups, and those
groups are referenced in multiple ini files, a group could still contain
multiple instances of a group in its host,groups list, where only one of them
is the right group, that exists in the inventory.
11 years ago
James Cammarata
82b24c162e
Adding delimiter fixes to action_plugin + fixing local assembling with a delimiter
...
Also added a new integration test for assemble using local assembly
with a delimiter.
11 years ago
Michael DeHaan
2c7275e8a9
Merge pull request #6835 from sivel/version-compare-filter
...
Add version_compare filter
11 years ago
Michael DeHaan
0a574af270
Merge pull request #5555 from sivel/expose-playbook-to-callback
...
Expose the playbook to callback plugins
11 years ago
Michael DeHaan
1fa19e29e8
Use common file argument system previously implemented by @sivel for rax modules on the file modules as well (copy/file/template).
...
Application to other cloud providers would make very good sense.
11 years ago
Matt Martz
7b5f89ec7c
Use PluginLoader for module docs fragments
11 years ago
Matt Martz
bb6f7a267a
Add support for shared module documentation fragments
11 years ago
James Cammarata
ee0a0b492b
Allow isprintable() util function to work with unicode
...
Fixes #6842
11 years ago
James Tanner
cdc0819939
Fixes #6088 turn off sudo and su if the connection is local the sudo user matches the current user
11 years ago
jctanner
2a9fcdd87c
Merge pull request #6711 from j2sol/raw-unreachable
...
Treat 255 errors from raw as dark host
11 years ago
jctanner
f6db60cbce
Merge pull request #6787 from tyll/pull_ssh_prompt
...
ssh: propagate prompt to _communicate()
11 years ago
Matt Martz
5770428e91
Add version_compare filter
11 years ago
James Cammarata
317c2f4bc0
Fixes to variable issues introduced by recent changes
...
Fixes #6801
Fixes #6832
11 years ago
Harlan Lieberman-Berg
876b8085aa
Add directory_mode to common file parameters to prevent errors.
11 years ago
Michael DeHaan
904f331210
Merge pull request #6788 from tyll/pull_ssh_verbose_comments
...
ssh connection plugin: Make comments more verbose
11 years ago
James Cammarata
a6a4680e5c
Fix variable naming issue in _load_tasks()
...
Fixes #6800
11 years ago
James Cammarata
6f34a6336f
Differentiate decryption failures from empty data files in ansible-vault
...
Fixes #6822
11 years ago
BoscoMW
39fcbd1f10
Update ssh.py
11 years ago
BoscoMW
165406cf35
Catch permissions errors related to opening a known_hosts file
...
Catch permissions errors related to opening a known_hosts file
11 years ago
James Cammarata
e2d86e4f43
Splitting SETUP_CACHE into two caches, one for host vars and one for setup facts
11 years ago
James Cammarata
a4df906fc9
Fixes to safe_eval
11 years ago
Tim G
c307a73e28
Check for errors from adb, may not work on all systems.
11 years ago
Tim G
285d4f3fa6
If memory not available in syslog.log, catch error, attempt to find it with adb
11 years ago
Till Maas
e6cb32f284
ssh connection plugin: Make comments more verbose
...
Explain _communicate() more.
11 years ago
Till Maas
1da69309e5
ssh connection plugin: Report missing sudo password
...
If no password is provided, sudo hangs at the prompt. Identify this and
report that the password is missing as an error.
11 years ago
Till Maas
2cae7472ad
ssh: propagate prompt to _communicate()
...
_communicate() uses the prompt variable to detect wrong passwords early,
therefore it needs to be passed to it from exec_command().
11 years ago
James Cammarata
612a1a64f0
Apply extra vars after all other vars have been merged in a play
...
Fixes #6677
11 years ago
James Cammarata
b9c044b8c9
Making the exception caught during os.dup of stdin explicit
...
Related to f23bb34
11 years ago
James Cammarata
f23bb344aa
Catch errors when duping stdin
...
Fixes #6657
11 years ago
James Cammarata
4f140be711
Merge branch 'devel' of https://github.com/Synforge/ansible into Synforge-devel
11 years ago
James Tanner
efba8b4771
Merge branch 'regexreplace' of git://github.com/jacobweber/ansible into jacobweber-regexreplace
11 years ago
James Tanner
2492c2714a
Fixes #5307 set relative paths to the files dir for roles and the inventory dir for non-role tasks
11 years ago
Till Maas
b07113f358
ssh: Properly check for wrong su password
11 years ago
James Cammarata
b698f7a44b
Add option to create host_key directory if it doesn't exist
...
Fixes #6731
11 years ago
Matt Martz
7e3dd1066c
Allow raw and script to support su
11 years ago
Michael DeHaan
a6b25e8657
Allow type=list module arguments to accept integers and floats.
11 years ago
Michael DeHaan
9921f804f9
Merge pull request #6643 from herbygillot/fact-full-hostname
...
Add a fact providing the full hostname, without the domain portion
11 years ago
Cristian Ciupitu
96ff1444f0
Micro-optimization: replace s.find(x)==0 with s.startswith(x)
...
timeit shows a speedup of ~1.4x on Python 2.7.5 x86_64.
It also makes the code a bit shorter.
11 years ago
Cristian Ciupitu
1eaf85b89f
Micro-optimization: replace s.find(x)!=-1 with x in s
...
timeit shows a speedup of ~3x on Python 2.7.5 x86_64.
It also makes the code a bit shorter.
11 years ago
Paul Oyston
1942a69ed2
Added template call to _executor_internal to allow the passing of arbitrary data to modules.
11 years ago
Jesse Keating
3315ba0b99
Treat 255 errors from raw as dark host
...
Any other module is able to detect a dark host, but raw was treating 255
as a return code from the module execution, rather from the connection
attempt. This change allows 255 to be treated as a connection failure
when using the raw module.
11 years ago
James Cammarata
78bdb078fe
Fix for bug related to async jid polling change plus a new test
11 years ago
James Tanner
88462729aa
Addresses #6708 fill in missing keywords for ssh.py _communicate
11 years ago
jctanner
7dc3dc5279
Merge pull request #6708 from sivel/put-file-control-master
...
Share p.communicate alternative logic between exec_command and put_file
11 years ago
James Cammarata
e09313120c
Make async jid's unique per host
...
The jid will now also contain the PID of the async_wrapper process,
and can each unique jid from each host is tracked rather than just
relying on one global jid per task.
Fixes #5582
11 years ago
James Tanner
38de8cc87e
Addresses #6705 Only set the role_uuid inside the role vars
11 years ago
Matt Martz
b8cb23d309
Share p.communicate alternative logic between exec_command and put_file
11 years ago
James Tanner
8991e403e8
Fixes #6705 Give each role a unique uuid and apply tags only to tasks matching the uuid
11 years ago
James Cammarata
9ede6f7f49
Convert gather_facts to a boolean value if it is not None
...
Fixes #5618
11 years ago
James Tanner
2a976ac313
Fixes #5059 Ignore lookup failures when templating a task name
11 years ago
Serge van Ginderachter
b0ff1ea425
performance optimisation in hash merge logic
...
rewrite deepcopy in util.merge_hash and just iterate
on an inventory with 500 groups and 800 hosts this brings back the
inventory initialisation from 13s to 3s (with hash_behaviour=merge)
11 years ago
Serge van Ginderachter
d4634983f0
Move group/host_vars parsing into core inventory
...
modified: lib/ansible/inventory/__init__.py
deleted: lib/ansible/inventory/vars_plugins/group_vars.py
modified: lib/ansible/utils/__init__.py
11 years ago
James Cammarata
7a3fa63db5
Fix for unicode environment variable handling
...
Fixes #5395
11 years ago
Serge van Ginderachter
f8ea93c732
Move inventory.set_playbook_basedir from ansible-playbook to playbook constructor
11 years ago
Serge van Ginderachter
cc28fd891b
Introduce noop vars plugin.
...
In preparation to move the group_vars plugin code into core.
new file: lib/ansible/inventory/vars_plugins/noop.py
11 years ago
Serge van Ginderachter
f6a55a3552
Refactor vars_plugins (host/group_vars)
...
Split out parsing of vars files to per host and per group
parsing, instead of reparsing all groups for each host. This enhances
performance.
Extend vars_plugins' API with two new methods:
* get host variables: only parses host_vars
* get group variables: only parses group_vars for specific group
The initial run method is still used for backward compatibility.
Parse all vars_plugins at inventory initialisation, instead of
per host when touched first by runner. Here we can also loop through
all groups once easily, then parse them.
This also centralizes all parsing in the inventory constructor.
modified: bin/ansible
modified: bin/ansible-playbook
modified: lib/ansible/inventory/__init__.py
modified: lib/ansible/inventory/vars_plugins/group_vars.py
11 years ago
James Tanner
3194fbd365
Fixes #6655 catch unicode encoding errors before sending to syslog
11 years ago
jctanner
7b8d1c0ffd
Merge pull request #6580 from ramondelafuente/fix-vault-editor-call
...
Changed call to EDITOR to allow for parameters
11 years ago
Ramon de la Fuente
c79c001bfb
Changed call to EDITOR to allow for parameters
...
The EDITOR environment variable is used to create and edit files in the vault.
But if the EDITOR variable contains parameters, subprocess.call() breaks.
This fixes the EDITOR environment variable to be safely split into a list.
It adds a dependency on shlex.
11 years ago
James Cammarata
c9bf7eb9bb
Don't run {failed|changed}_when checks until async_status is done
...
Fixes #5117
11 years ago
James Cammarata
4ea12c1b86
Make sure stat of dest is available in atomic_move
...
Fixes #6682
11 years ago
James Tanner
f9018a6f1d
Ensure handlers run when meta tasks are defined and add handler integration tests
...
Fixes #6678
Fixes #6670
11 years ago
Michael DeHaan
3eecc039b9
Merge pull request #6656 from Jmainguy/setup
...
Added ansible_date_time.weekday as a fact. This returns Monday,Tuesday,W...
11 years ago
James Cammarata
8c7828d469
Tweaking error message resulting from undefined template variables
...
Fixes #5114
11 years ago
James Cammarata
846933dd53
Make inventory parsing error detection smarter
...
If something is executable but doesn't look like it should be, or if
something is NOT executable and DOES looks like it should, show a
more apropos error with a hint on correcting the problem
Fixes #5113
11 years ago
Michael DeHaan
a062912a1f
Merge pull request #6658 from pilou-/fix_fix
...
'changed' key is not defined when task fails
11 years ago
Michael DeHaan
9be732d8f2
Merge pull request #6679 from renard/fix-simplejson-module
...
Fix TypeError when using old simplejson lib.
11 years ago
Herby Gillot
94297950a0
Name platform.node() fact as "nodename"
11 years ago
James Tanner
ebd1f70c5d
Typo in setting task_errors variable
11 years ago
Sébastien Gross
ef6b437d0d
Fix TypeError when using old simplejson lib.
...
On some very old simplejson does not support the 'encoding' and give
following exception:
TypeError: __init__() got an unexpected keyword argument 'encoding'
This fix runs json.dump with no encoding key (such as before #a023cb) on
TypeError exception only.
11 years ago
Serge van Ginderachter
d3eaa1b79e
InventoryDir: refactor logic
...
Make sure all hosts and groups are unique objects
and that those are referenced uniquely everywhere.
Also fixes test_dir_inventory unit tests which were broken after previous
patches.
modified: lib/ansible/inventory/dir.py
11 years ago
Serge van Ginderachter
188375171e
Inventory: raise error when adding a group that already exists.
...
The parsers check if a group already exists.
11 years ago
Serge van Ginderachter
be58808fe4
inventory script parser: do not add all the groups to *all* group
11 years ago
Serge van Ginderachter
0ceefbbf29
inventory ini parser: do not add all the groups to *all* group
...
but only those with lowest depth, so we keep a proper tree structure
11 years ago
Serge van Ginderachter
cc8efb4aab
inventory groups: make sure group.depth is updated on all grandchildren
11 years ago
Serge van Ginderachter
1c86909875
inventory group: add groups to parent_groups only once
11 years ago
Serge van Ginderachter
36f55d3549
inventory directory parser: add host to group only once
11 years ago
Serge van Ginderachter
8b215149d4
inventory directory parser: add groups to parent_groups non-recursively
11 years ago
Serge van Ginderachter
262ba0460a
inventory directory parser: add hosts to group non-recursively
11 years ago
James Tanner
605156c904
Fixes premature handler execution after adding force-handlers
11 years ago
James Cammarata
bc93732b1d
Catch permissions errors related to opening a known_hosts file in modules
...
Fixes #6644
11 years ago
James Cammarata
dc658eaa1c
Check to make sure the host is in the inventory vars cache before clearing it
...
Fixes #6660
11 years ago
James Cammarata
db345391e3
Fixing ownership when atomic_move is creating a file while sudo'ing
...
Fixes #6647
11 years ago
Pierre-Louis Bonicoli
c76501b8a3
'changed' key is not defined when task fails
...
fix KeyError introduced by fix of #6591 .
11 years ago
Jonathan Mainguy
b17b5ad85b
Added ansible_date_time.weekday as a fact. This returns Monday,Tuesday,Wednesday,Thursday,Friday,Saturday, or Sunday depending on the remote servers time. Useful for backups the way I use it
11 years ago
James Cammarata
bb723bedee
Merge branch 'atomic_move_restore_owner_group_rebase' of https://github.com/tyll/ansible into tyll-atomic_move_restore_owner_group_rebase
11 years ago
James Tanner
9169a11088
Fixes #4777 add --force-handlers option to run handlers even if tasks fail
11 years ago
Herby Gillot
c0886a5f3a
Add a fact providing the full hostname, without the domain portion
...
truncated.
11 years ago
Michael DeHaan
fba2f1f9a9
Merge pull request #6639 from fvieira/devel
...
Add missing sha1 import on known_hosts.py
11 years ago
Michael DeHaan
a24d3f78d9
Merge pull request #6634 from pilou-/fix
...
Remove print statements
11 years ago
James Cammarata
31628d86a1
Adding in a configurable option for the accelerate daemon timeout
...
This was apparently an oversite, as it has never been configurable
despite having a module parameter for the timeout.
11 years ago
James Cammarata
3ea5d573aa
Acclerate improvements
...
* Added capability to support multiple keys, so clients from different
machines can connect to a single daemon instance
* Any activity on the daemon will cause the timeout to extend, so that the
daemon must be idle for the full number of minutes before it will auto-
shutdown
* Various other small fixes to remove some redundancy
Fixes #5171
11 years ago
Francisco José Marques Vieira
e9d7476c28
Add missing sha1 import on known_hosts.py
11 years ago
Pierre-Louis Bonicoli
d3a470db0c
Remove print statements
...
"print item" raises an exception when type of item is
jinja2.runtime.StrictUndefined
11 years ago
James Tanner
5b3b9ba267
Addresses #4407 Caculate failed percentage based on serial and number of hosts in play
11 years ago
Michael DeHaan
d0cbb51170
Merge pull request #6615 from 8191/devel
...
Addresses #6591 Hide diff for lineinfile if file did not change.
11 years ago
Manuel Faux
b8158f5f6a
Addresses #6591 Hide diff for lineinfile if file did not change.
11 years ago
Joshua Conner
1c504eff68
etcd lookup: use $ANSIBLE_ETCD_URL if it exists in the env
11 years ago
James Tanner
14499e8bf3
Fixes #4325 allow async and poll parameters to be templated vars
11 years ago
James Tanner
ea5186ca63
Fixes #6590 add set_remote_user parameter to synchronize
...
This allows usage of custom ssh configs for remote hosts where
the inventory user does not match the configured user.
11 years ago
James Tanner
95c79ad483
Fixes #4239 merge injects with new vars loaded from files
11 years ago
James Tanner
d327e3d11a
Fixes #5622 included tasks in roles now inherit tags from the role
11 years ago
Till Maas
898a38b074
module_utils/atomic_move(): Use tempfile module
...
Fix a potential race condition by using the tempfile module.
11 years ago
Till Maas
8f778a83df
module_utils/atomic_move(): Restore owner/group
...
Manually restore owner and group if both src and dest are on a separate
file system.
11 years ago
Michael DeHaan
e639b5382b
Change default gathering policy, add to docs.
11 years ago
Brian Coca
18adf07fc6
changed setting values and updated docs
11 years ago
Brian Coca
4dfa40f18e
added gathering control to ansible, defaults to 'smart'
11 years ago
Michael DeHaan
c42dbf80a2
Merge pull request #6586 from sivel/probline-logic-fix
...
Fix logic in process_common_errors for unbalanced quotes
11 years ago
James Tanner
b8f627d1d5
Prevent rewriting the encrypted file if decryption fails
11 years ago
James Tanner
e71857fbdf
Addresses #6579 Only strip vault passwords if given
11 years ago
James Tanner
8c2e1e2baa
Addresses #6579 Disallow vault passwords with newline characters by stripping them in utils
11 years ago
James Cammarata
a9000e7f3a
Making the error messages for bad key/dir permissions more understandable
...
Fixes #6254
11 years ago
Matt Martz
2aaecc5afa
Fix logic in process_common_errors for unbalanced quotes
11 years ago
James Cammarata
4880cfb5ea
Merge pull request #6568 from sivel/ssl-cert-validation-osx
...
Make SSL verification on Mac OS X work out of the box
11 years ago
James Tanner
67517e96d3
Fixes #6567 put the git wrapper script in the module temp dir
11 years ago
Matt Martz
1d3d73a0b6
Only write the DUMMY_CA_CERT on OS X
11 years ago
Matt Martz
3b5aa8bd30
Provide a dummy ca to allow OS X to do it's OpenSSL keychain magic
11 years ago
James Cammarata
eb7717aa02
Make sure all tags are in a list before merging for role deps
...
Fixes #6557
11 years ago
James Cammarata
c9fcbf7bdd
Change print message to vvv for missing known hosts in ssh.py
11 years ago
James Tanner
49807877fa
Fixes #6550 Use shell for pipe lookup subprocess.popen calls
11 years ago
James Cammarata
3f5440f7df
Make modules set a valid working directory
...
Fixes #6546
11 years ago
James Cammarata
84908a57fc
Don't filter role deps on tags
...
Also, fixed a bug where the tags were being merged into the wrong
data structure (passed_vars) in _build_role_dependencies()
Fixes #6439
Fixes #5709
11 years ago
Michael DeHaan
9da26da335
Merge branch 'ini_vars' of git://github.com/dmage/ansible into devel
11 years ago
Michael DeHaan
13f69dad05
Merge pull request #6527 from patrickheeney/hosts-bug
...
Fix for hostkey directory
11 years ago
Michael DeHaan
94e3350b38
Catch a unquoted line error. Fixes #6532
11 years ago
jctanner
b8d5ba42f5
Merge pull request #6523 from sergevanginderachter/vault-in-subdirs
...
Pass through vault_password when parsing host/group vars as directories.
11 years ago
James Cammarata
c4f1c3c6b0
Merge branch 'bcoca-file_fixes_clean' into devel
11 years ago
James Tanner
ad70e9bcd6
Fixes #6227 skip non-unicode strings and catch decode errors silently in template_from_string
11 years ago
James Tanner
20262b6c15
Remove unused variable in _executor_internal
11 years ago
James Cammarata
5d8c9d3f0f
Merge branch 'file_fixes_clean' of https://github.com/bcoca/ansible into bcoca-file_fixes_clean
11 years ago
James Cammarata
7edee91aba
Fixing a bug in role tag handling where only the first tag was used
...
Fixes #6517
11 years ago
James Tanner
ebb6b8442b
Catch unicode unescape failures in copy action plugin
11 years ago
patrickheeney
a9aab23f11
Fix for hostkey directory
11 years ago
James Tanner
b14c658532
Fix concatenation for with_file
11 years ago
Serge van Ginderachter
280498a7e5
Pass through vault_password when parsing host/group vars as directories.
...
Fixes a bug where vault_password parameter was not passed through in
_load_vars_from_folder()
modified: lib/ansible/inventory/vars_plugins/group_vars.py
11 years ago
Greg Dallavalle
77229553a3
fetch_url: Avoid credential stripping for FTP-scheme URLs
11 years ago
Michael DeHaan
fe696e4720
Merge commit.
11 years ago
Michael DeHaan
b41541c62a
Merge conflict.
11 years ago
Michael DeHaan
fd0ff6f174
Merge pull request #5711 from sivel/plugin-realpath
...
Use realpath for plugin directories instead of abspath
11 years ago
Michael DeHaan
6144c5e1e2
Merge pull request #5714 from eggsby/patch-2
...
Allow templates in ansible_sudo_pass inventory var
11 years ago
Michael DeHaan
b0dbc61d63
Move facts to 'module_utils' so they can be referenced by other modules. Note unlike other module_utils/ dirs this keeps the original
...
license -- so usage of facts code in modules will be limited to GPLv3 modules.
11 years ago
Michael DeHaan
b8f1e4f765
Merge pull request #6134 from veeti/include_with_items_path
...
Show the offending file name with the include + with_items error
11 years ago
Michael DeHaan
4a06954a13
Merge pull request #6390 from sergevanginderachter/group-varsdirs-svn
...
group_vars plugin: do not parse hidden files in subfolders
11 years ago
Michael DeHaan
9cdbc53741
Merge pull request #6420 from bcoca/role_names
...
added new role_names variable that exposes current roles list
11 years ago
Michael DeHaan
26efc7ace8
Revert "Populate module_setup from the setup module rather than special code elsewhere"
...
This reverts commit 58eec2e4c2
.
11 years ago
Oleg Bulatov
f6a4c20cc0
Make parsing variables for hosts and groups more consistent
...
This commit allows to specify arrays in [group:vars] block.
Signed-off-by: Oleg Bulatov <oleg@bulatov.me>
11 years ago
Michael DeHaan
a9896afc66
Merge pull request #6418 from bcoca/template_itnore_errors
...
templates ignore_errors
11 years ago
Michael DeHaan
d5856bd475
Merge pull request #6391 from sergevanginderachter/hashmerge_inventoryscripts
...
Allow hash_behaviour=merge to be respected in core inventory
11 years ago
Dag Wieers
58eec2e4c2
Populate module_setup from the setup module rather than special code elsewhere
...
This small change allows for individual setup actions to populate the SETUP_CACHE and not cause a subsequent facts-gathering when not needed. This follows the standard of other facts modules as laid out in #1206 and implemented in fedfd18774
. It allows to test of the setup module has already been run even when gather_facts was explicitely disabled.
11 years ago
Michael DeHaan
3d44f7cd51
Merge pull request #6217 from ashokrajar/patch-1
...
pause plugin doesn't flush raw_input prompt
11 years ago
Cristian Ciupitu
0749112286
Micro-optimization: replace s.find(x)!=-1 with x in s
...
timeit shows a speedup of ~3x on Python 2.7.5 x86_64.
It also makes the code a bit shorter.
11 years ago
Cristian Ciupitu
a7da5d8702
Micro-optimization of inventory.expand_hosts.detect_range
11 years ago
brdo
3963a64a4f
Set keepalive to 5 seconds in paramiko_ssh.py
...
This update resolves https://github.com/ansible/ansible/issues/6476 .
11 years ago
Brian Coca
2d25577e11
Fixes and cleanup to file functions and module
...
- unified set attribute functions ... not sure why 2 identical functions
exist with diff names, now there are 3 while i repoint all modules to 1
- fixed issue with symlinks being created w/o existing src when force=no
- refactored conditionals, simplified where possible
- added tests for symlink to nonexistant source, with both force options
- made symlink on existing attomic (force)
11 years ago
James Cammarata
a0cb974575
Be sure to return to the old directory if cwd is set in run_command
11 years ago
James Tanner
a348f67238
Reset the current directory after running subprocess.Popen
11 years ago
James Cammarata
677008bef7
Rejoin args list into a string for run_command when using an unsafe shell
...
This allows the use of an args list with leading environment variables,
which otherwise would fail due to the way Popen works.
11 years ago
James Cammarata
5233d4bc31
Fix typo in run_command when sending data that is not binary
11 years ago
James Cammarata
b1a37dcc08
Revert "Rejoin args list into a string for run_command when using an unsafe shell"
...
This reverts commit 4273cb2d8e
.
11 years ago
James Cammarata
4273cb2d8e
Rejoin args list into a string for run_command when using an unsafe shell
...
This allows the use of an args list with leading environment variables,
which otherwise would fail due to the way Popen works.
11 years ago
Michael DeHaan
d1753046e0
Revert "Correctly catch template errors without returning invalid data"
...
This reverts commit 3cd7d47b7e
.
11 years ago
James Cammarata
303e085f8b
Only use cwd in run_command kwargs if the directory exists
11 years ago
James Cammarata
60a7f57300
Make sure the cwd exists in run_command before trying to use it
11 years ago
Dan Koch
bbf320fd22
Work around for cwd stat problems with run_command and sudo
...
This fixes issue #6443
11 years ago
James Cammarata
2c7d58abe0
Compile ca certs into a temp file to reduce number of attempts
...
For those who may have a large number of certs found, this can reduce
the number of ssl connections attempted.
11 years ago
Michael DeHaan
d37f0c6d12
Use same implementation as ssh.py for "is in host file" checks in module code, prevents git module from adding keys more than once.
11 years ago
Michael DeHaan
6d841d120e
Don't process shell commands as arrays.
11 years ago
James Cammarata
86d2ee4b97
Don't append tags from roles to the plays tags list
...
Fixes #6393
11 years ago
James Cammarata
a9017af2bb
Adding validate_certs to all modules that use fetch_url
11 years ago
Michael DeHaan
cfabc2e28a
module.run_command is intended to bypass the shell here, so can't do ">>"
11 years ago
James Cammarata
7f38cff989
Remove unused code from get_ca_certs() function
11 years ago
James Cammarata
804e4166c8
Rewriting ssl validation to try multiple certs found in paths
...
Previously, the function checked only for a single CA root cert, however
some distributions may have multiple certs in a directory. This will now
try any .crt or .pem file contained within several common paths for
each platform.
Fixes #6412
11 years ago
Michael DeHaan
0b0ca95731
Expand environment variables and tildes passed to commands generically across the board.
11 years ago
James Tanner
0e38f5dfdc
Check for hash availability during vault operations
11 years ago
Brian Coca
906e59d8a8
added new role_names variable that exposes current roles list
11 years ago
Brian Coca
7778aca966
templates ignore_errors
11 years ago
James Cammarata
6c25e78299
Merge branch 'devel' of https://github.com/dparalen/ansible into dparalen-devel
11 years ago
James Tanner
e4e64a9699
Rename lxc to libvirt_lxc
11 years ago
James Cammarata
bca6adc812
Merge pull request #4064 from mscherer/lxc
...
Add a plugin that permit to use ansible for lxc system, using libvirt
11 years ago
James Cammarata
430cce9df3
Merge branch 'ec2_security_token' of https://github.com/willthames/ansible into willthames-ec2_security_token
11 years ago
Serge van Ginderachter
6b1cb22fc3
Allow hash_behaviour=merge to be respected in core inventory
...
(For now, this means, enable it also for inventory scripts)
11 years ago
Serge van Ginderachter
29c60bdaff
group_vars plugin: do not parse hidden files in subfolders, e.g. avoid .svn/
11 years ago
James Tanner
6740a1f342
Wrap crypto.hash imports with try/except
11 years ago
Michael DeHaan
411bcb7161
Merge remote branch 'real/devel' into devel
11 years ago
Michael DeHaan
2fa6110961
Update the message about pycrypto to include that python-devel must be installed.
11 years ago
James Tanner
0d6f6ad282
Implement new default cipher class AES256
11 years ago
Michael DeHaan
20f0157152
Merge pull request #6378 from franckcuny/headers-gce-utils
...
Add BSD license to module_utils/gce.py
11 years ago
James Tanner
ba0fec4f42
Force command action to not be executed by the shell unless specifically enabled
11 years ago
James Cammarata
9730157525
Validate SSL certs accessed through urllib*
...
* Adds another module utility file which generalizes the
access of urls via the urllib* libraries.
* Adds a new spec generator for common arguments.
* Makes the user-agent string configurable.
Fixes #6211
11 years ago
James Cammarata
6577ff5f85
Add tags from handlers to tag availability calculation
11 years ago
Richard Isaacson
4993cb57f4
Merge pull request #6283 from magicrobotmonkey/upstream
...
fix missing stdin in _parallel_runner
Tested with GIST https://gist.github.com/risaacson/7290d30a612e0c70ea1b .
Passes "make tests"
Passes non_destructive tests.
11 years ago
Franck Cuny
82f99bfa3d
Add BSD license to module_utils/gce.py
11 years ago
Matt Martz
4b400ca5e9
Only used stripped data for testing if the file is json, but used unstripped when actually parsing. Fixes #6348
11 years ago
Seth Woodworth
1d5db30067
Updates loop warning, removes unnecessary c
11 years ago
James Cammarata
04a6dc6d12
Check for skipped tags in passed role variables before adding to them
...
Fixes #6330
11 years ago
Michael DeHaan
d2cb35f898
Merge pull request #6320 from angstwad/instance-redo
...
Use isinstance() rather than a check using type()
11 years ago
James Cammarata
4753804ab4
Merge pull request #6332 from jimi-c/issue_6329_space_in_var
...
Correctly catch template errors without returning invalid data
11 years ago
James Cammarata
e3b887f770
Fix range issue in inventory and add additional error checking
...
Fixes #6331
11 years ago
James Cammarata
3cd7d47b7e
Correctly catch template errors without returning invalid data
...
Fixes #6329
11 years ago
James Cammarata
f80d02d841
Properly wrap logical elements together for su/sudo detection
11 years ago
James Cammarata
b6056044b7
Partial revert of 73c883c
due to issues with handlers in roles
...
Fixes #6322
11 years ago
Michael DeHaan
e486dbab04
Use the loaded variable since we have it assigned, not just for error detection.
11 years ago
Michael DeHaan
3f07ec3d73
Fixup JSON error reporting in previous commits.
11 years ago
Michael DeHaan
a4d01b0891
Also search .json filenames
11 years ago
Michael DeHaan
79799f6819
Allow any file that can be in YAML to also be in JSON. This is primarily done to support non-visual editors better.
11 years ago
James Cammarata
a0f939581d
Merge branch 'aresch-devel' into devel
11 years ago
Paul Durivage
3cce3650e5
Use isinstance() rather than a check using type()
11 years ago
Richard Isaacson
119434d079
Merge pull request #6319 from risaacson/fix_test_dir_inventory
...
Fix TestInventory Unit Tests
Tested clean.
11 years ago
James Cammarata
9b79591f23
Merge branch 'devel' of https://github.com/aresch/ansible into aresch-devel
11 years ago
James Cammarata
2a0028e687
Sanitize run_command argument output
...
Fixes #6316
11 years ago
Andrew Resch
4d80019ac8
Fix logic checking for both sudo and su, and their respective users
11 years ago
Richard C Isaacson
16fe09eef8
Fixes related to uncommenting test_dir_inventory in TestInventory.
...
0. Uncomment the test.
1. Test fails.
2. Make vars unique per file in test inventory files.
3. Modify token addition to not ast.literal_eval(v) a variable containing a hash.
4. Modify vars to have an escape in test inventory file.
5. Catch exceptions explicitly. Any unknown exceptions should be a bug.
6. Test passes.
11 years ago
James Cammarata
9f2999df79
Un-escape newlines in delimiters for assemble module
11 years ago
Brian Coca
79809b67dc
fixed another line with same issues
...
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
11 years ago
Brian Coca
d3d5680d8f
tags lists are properly uniqued and joined now, also avoids type issues when passed as list/set or strings
...
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
11 years ago
Will Thames
b9a7352e0a
Work to allow security tokens and profiles to work with Ansible
...
Allow security tokens and profiles to be used as arguments
to the 'common' ec2 modules
Mostly refactoring to provide two new methods,
`get_aws_connection_info`, which results in a dict that can be
passed through to the boto `connect_to_region` calls, and
`connect_to_aws` that can pass that dict through to the
`connect_to_region` method of the appropriate module.
Tidied up some variable names
Works around boto/boto#2100
profiles don't work with boto < 2.24, but this detects for that
and fails with an appropriate message. It is designed to work
if profile is not passed but boto < 2.24 is installed.
Modifications to allow empty aws auth variables to be passed
(this is useful if wanting to have the keys as an optional
parameter in ec2 calls - if set, use this value, if not set,
use boto config or env variables)
Reworked validate_certs improvements to work with refactoring
Added documentation for profile and security_token to affected modules
11 years ago
James Cammarata
0e98496e12
Merge pull request #6299 from jimi-c/issue_4656_role_deps_across_plays
...
Keep track of role dependencies across plays
11 years ago
Michael DeHaan
94a7fb60fe
Allow escaped comments in inventory files.
11 years ago
aresch
23a0468a4b
Fix respecting remote_tmp when sudo is used
11 years ago
James Tanner
4e8ed92130
Fixes #6077 decode escaped newline characters in content for the copy module
11 years ago
Richard C Isaacson
b41d8106ff
Revert "Merge pull request #6287 from risaacson/fix_hash_in_var"
...
This reverts commit a808287451
, reversing
changes made to 6129ea7566
.
11 years ago
James Cammarata
73c883c122
Keep track of role dependencies across plays
...
Also fixes a bug in which tags specified on top-level roles were
not being passed down to dependent roles.
Fixes #4656
11 years ago
Richard Isaacson
a808287451
Merge pull request #6287 from risaacson/fix_hash_in_var
...
Fix inventory for test_dir_inventory, merge PRs from GH-5749, cleanup some formatting.
11 years ago
James Tanner
6129ea7566
Fixes #6298 and adds a sudo unit test for synchronize
11 years ago
Richard C Isaacson
38abd5e20e
Break this out into a reusable function and document regex shortcomings.
11 years ago
Luca Berruti
7cf363910a
fixes #6244
11 years ago
jctanner
40ee030790
Merge pull request #6265 from franckcuny/gce-fixes
...
Add credential parameters to the GCE modules.
11 years ago
Franck Cuny
6294264dc4
Add credential parameters to the GCE modules.
...
In order to simplify the workflow with the GCE modules, it's now
possible to add the parameters and project name as arguments to the
various GCE modules.
The inventory plugin also returns the IP of the host in
`ansible_ssh_host` so that you don't have to specify IPs into the
inventory file.
Some update to the documentation are also added.
Closes #5583 .
11 years ago
Richard C Isaacson
49bd8b0b35
Fix inventory for test_dir_inventory
...
It came up that fixing this unit test may relate to another ticket that is open. This work allows us to uncomment this unit test by fixing how we pars variables allowing a quoted variable to contain a '#'.
Work also went into cleaning up some of the test data to clarify what was working.
Lastly work went into cleaning up formatting so that the code is easily read.
11 years ago
Aaron Bassett
5c589af191
fix missing stdin in _parallel_runner
11 years ago
Richard Isaacson
92aacb198c
Merge pull request #6156 from iiordanov/devel
...
Add support for checking host against global known host files.
The effect of this is that before this fix if files are spread across the known_hosts file but not in the ~/known_hosts file the hosts will execute sequentially. This PR augments the functionality so that all of the knowns hosts will execute in parallel.
11 years ago
Richard Isaacson
e79d859dfb
Merge pull request #6213 from sergevanginderachter/fix-delegate-templating
...
Fixes templating of ansible_ssh_host for delegates.
Tested that this works. Confirmed.
11 years ago
Michael DeHaan
435104065e
Merge pull request #6248 from hkariti/fix_list_copy
...
Fix incorrect use of copy() on list, causing a traceback
11 years ago
Jesse Keating
0c2c37a47a
Avoid range selection on empty groups
...
This prevents a traceback when the group is empty.
Fixes #6258
11 years ago
James Tanner
623cd9ac50
Revert "Merge pull request #6250 from dagwieers/gather_facts-once"
...
This reverts commit b769b4181a
, reversing
changes made to 1e01fb856d
.
11 years ago
Dag Wieers
0da06eff5c
Fix regression causing setup to run for every play
...
This patch makes sure setup only runs once, unless it is enforced on a play.
11 years ago
Hagai
0e4b38ed5a
Fix incorrect use of copy on list
11 years ago
Tefnet
c652802d29
missing import in assert module
...
Fixed missing ansible.errors import in assert module
11 years ago
Michael DeHaan
16d3be03af
Remove a few extra legacy variable feature references.
11 years ago
Michael DeHaan
46ec8759d5
Remove the legacy templating code, which was guarded by deprecation warnings in the previous two releases, and undocumented for a long time. use {{ foo }} to access variables instead of ${foo} or $foo.
11 years ago
Michael DeHaan
9d01d88a57
Bump versions on the devel branch (devel branch version is 1.6)
11 years ago
Michael DeHaan
5443ddec75
Trim references to fireball as we want folks using accelerate or pipelining options. Fireball is pretty well deprecated at this point, but will still be part of the release.
11 years ago
James Cammarata
79645535c0
Handle empty results from failed connections in _remote_md5()
...
Fixes #5800
11 years ago
Gilles Cornu
04f6367172
Fully clean 'ssh_old' and 'paramiko_alt' options
...
These transports have been removed in 33857855ad
11 years ago
Ashok Raja R
cb3c6417dd
pause plugin doesn't flush raw_input prompt
...
##### Issue Type:
Bugfix Pull Request
##### Ansible Version:
ansible 1.4.3
##### Environment:
N/A
##### Summary:
We are using a wrapper python script to run ansible-playbook. We use subprocess to execute and print the stdout as and when its written. Problem is when we use pause it doesn't display the prompt string as raw_input does not flush stdout before reading from stdin.
It looks like a dirty fix to add "\n" to the prompt string but i don't see any other way to over come this. If anyone else have a better fix please do propose/suggest.
##### Steps To Reproduce:
```yaml
#File: test_play.yml
- name: Test
hosts: $nodes
gather_facts: false
tasks:
- name: Waiting for User
local_action: pause prompt="Do you want to continue (yes/no)? "
```
```python
#!/usr/bin/env python
#File: test.py
import shlex, subprocess
def run_process(process):
process = process.encode("utf-8")
command = shlex.split(process)
p = subprocess.Popen(command, stdout=subprocess.PIPE, stderr=subprocess.STDOUT)
for line in iter(p.stdout.readline, b''):
print line,
cmd = "/usr/bin/python -u /usr/bin/ansible-playbook -i hosts.txt test_play.yml -e 'nodes=local'"
run_process(cmd)
```
```
shell $ python test.py
```
##### Expected Results:
```
PLAY [Test] *******************************************************************
TASK: [Waiting for User] ******************************************************
[localhost]
Do you want to continue (yes/no)? :
```
##### Actual Results:
```
PLAY [Test] *******************************************************************
TASK: [Waiting for User] ******************************************************
[localhost]
```
11 years ago
James Cammarata
df9de6ea71
Expand the source path in the action plugin when not using a remote source
...
Fixes #6209
11 years ago
Serge van Ginderachter
9833263417
Fixes templating of ansible_ssh_host for delegates
11 years ago
James Cammarata
c11e2100e0
Save the original transport in runner after detecting the smart transport
...
Fixes #6192
11 years ago
Michael DeHaan
cd7d7eb1bc
Merge pull request #6202 from muffl0n/unarchive_destdir
...
unarchive: output dest in error-message
11 years ago
muffl0n
17946b23d5
output dest in error-message
11 years ago
Richard C Isaacson
9c8bbe2904
column must always be less than len(probline)
...
Fixes related to GH-5773.
11 years ago
James Cammarata
14ba10393b
Minor tweak to region config in boto configuration file
11 years ago
James Cammarata
88acb48e61
Merge branch 'ec2_boto_config_region' of https://github.com/willthames/ansible into willthames-ec2_boto_config_region
11 years ago
James Cammarata
2a383786dd
And remove the expanduser calls from the action_plugin
11 years ago
Richard C Isaacson
585766201d
When looking for double colon len(line) is longer then 1.
...
Addresses GH-5116.
It comes up that when parsing json that if you are missing the last double quote on the last variable and the next line is just '}' we will get an out of range error. In this instance we will also then make sure that the line is long enough to have two colons.
11 years ago
James Cammarata
b758ed9417
Merge pull request #6150 from hkariti/fix_join_bug
...
Fix incorrect use of .join on list causing a traceback
11 years ago
James Cammarata
96f1c3ce2e
Move where the expanduser call is made, to avoid issues with None
11 years ago
James Cammarata
e659d55d62
Merge branch 'devel' of https://github.com/muffl0n/ansible into muffl0n-devel
11 years ago
James Cammarata
5ff20c1ae7
Merge branch 'scottanderson42-ec2-params' into devel
11 years ago
James Tanner
baed7a0ed9
Fixes #6187 Add unit tests for VaultLib
11 years ago
Michael DeHaan
33857855ad
removing some unusued files. Paramiko alt was an experiment to attempt pipeline for paramiko, ssh_old is the non-pipelining-supported earlier
...
version of the OpenSSH transport, which is configurable now and unified.
11 years ago
James Tanner
35def422a3
Addresses #6188 Add --vault-password-file to bin/ansible and bin/ansible-playbook
11 years ago
James Cammarata
8a7c68dc18
Merge branch 'ec2-params' of https://github.com/scottanderson42/ansible into scottanderson42-ec2-params
...
Conflicts:
lib/ansible/module_utils/ec2.py
library/cloud/ec2
11 years ago
Richard C Isaacson
af616fe15e
Rename flatten funciton.
...
flatten(x) is used a lot in the various lookup plugins where in each it is slightly different. This is to make this name slightly more unique.
11 years ago
Kent R. Spillner
1fcc9ff666
lookup_plugins: loop over hashes
...
Create a lookup plugin named dict that can be used to loop over hashes.
It converts a dict into a list of key-value pairs, with attributes named
"key" and "value." Also adds a brief explanation and simple example to
the docs.
Signed-off-by: Kent R. Spillner <kspillner@acm.org>
11 years ago
James Tanner
876035c0b1
Fixes #6161 Get the delegate host info properly from the hostvars object
11 years ago