18 Commits (0a60e5e341f9a781c27462e047ebe0f73129f4a1)

Author	SHA1	Message	Date
David Shrewsbury	dd07bdf22d	Fix galaxy role info bug to support multiple roles (#70148) ... * Add changelog fragment * Update changelog	4 years ago
James Cassell	47d14a33bd	config: singular ANSIBLE_COLLECTIONS_PATH (#70007) ... * config: singular ANSIBLE_COLLECTIONS_PATH Every other *_PATH setting in ansible is singular, and the traditional $PATH variable is also singular despite containing a list of directories. Let's be consistent both internally and with POSIX tradition. * update all ANSIBLE_COLLECTIONS_PATHS env references to be singular * deprecate plural ANSIBLE_COLLECTIONS_PATHS setting	4 years ago
Sam Doran	3815ed67d5	ansible-galaxy - Fix role info when role is not installed (#69924) ... * ansible-galaxy - Fix role info when role is not installed Only report the role not found if in offline mode, otherwise query the galaxy API to get role information. Fixes #69867 * Improve error message when role is not found in Ansible Galaxy	4 years ago
Sloane Hertel	55e29a1464	ansible-galaxy - fall back to galaxy.yml when listing collections (#68925) ... Fallback to galaxy.yml for listing collections that don't have a FILES.json or MANIFEST.json Co-authored-by: Sam Doran <sdoran@redhat.com>	5 years ago
Matt Martz	bc41dd4514	Handle non-ascii paths during role installation. Fixes #69133 (#69213)	5 years ago
Alexandre Chouinard	91bb5af688	Update ansible-galaxy to handle role requirements (#68288) ... * Update galaxy role object to handle requirements Co-Authored-By: Sandra McCann <samccann@redhat.com>	5 years ago
Sam Doran	cdb24e0078	ansible-galaxy - fix listing specific role and role description (#67409) ... * ansible-galaxy - fix listing specific role If the role was not in the first search path, it was reported as not found * Properly display role description Default to description to top level description, falling back to the description from within galaxy_info * Display proper message when a role does not exist * Add integration tests * Use context manager * BSD and macOS ruining all the fun	5 years ago
Jordan Borean	26129fcb80	ansible-galaxy - optimise some paths and use fake galaxy int tests (#67685) ... * ansible-galaxy - optimise some paths and use fake galaxy int tests * Added init, built, and publish tests * Test against both mocked Galaxy and AH server * Finish off writing the install tests * Fix up broken tests * Rename test target and add migrated tests * Use cloud provider for Galaxy implementation * Added blank static config * Use correct alias group * Set release version and fix copy typo * Remove reset step as it is no longer needed * Use sane env var names for test container name	5 years ago
Sam Doran	c64202a495	ansible-galaxy - fix role list bug (#67391) ... Properly list roles even when the role name is the same or a substring of the path to the role.	5 years ago
Sam Doran	7ae34cef15	Fix role list regression (#67436) ... Add the roles_path parent to the role_parser object, so paths are passed to the list function Add basic role list tests to prevent future regressions	5 years ago
Sam Doran	f506fd4730	Add ansible-galaxy collection list command (#65022) ... * Start adding ansible-galaxy collection list options * Working list all collections and list a specific collection * Nuke debugging cruft * Use to_text to get a string of the FQCN for sorting * Improve collection output formatting - add header - display collection name and version in separate columns - width of columns is dynamic based on collection name and version length * Make role list output match collection output list - add header - add columns for role name and version - make column width dynamic based on name and version length * remove debug statemnt and extra header * Revert "Make role list output match collection output list" This reverts commit a0b3db47bb3b198aafd34c1f1be5b6561af2f928. * Add validate_collection_path function Utility function for ensuring a collection target ends with 'ansible_collection' * Use validate_collection_path * Do not warn if a specific collection in found in any search path * Fix extraneous warning and remove duplicate code Do not warn when listing a specific collection and it does not exist in other collection paths. Restructure the code that loops through collection paths to remove duplicate conditional code. * Indicate role path was found * Use new function name * WIP Save Point * Use separate functions for role and collection list * Wrap error message There may be a better way to do this besides hard coding a line break, but this does make the message a lot more readable. * Add validate_collection_path function (#66441) * Add validate_collection_path function Utility function for ensuring a collection target ends with 'ansible_collection' * Fix bad syntax * Correct docstring * Bikeshed the names * Properly list a single role * Simplify _display_warnings() Only display warnings. Move exception raise back to each caller. * Move private methods to private functions They don't need self, so it makes sense to have them as functions Get rid of _display_warnings() function since it doesn't do anything worthy of an independent function. * Add integration tests for ansible-galaxy collection list * Fix docs sanity test * Fix bug where ansible_collections dir does not exist The path may exist, but if there is no ansible_collections dir inside that path, an exception was raised in find_existing_collections(). Add integration test for this scenario * Put execute_list() method back * Add some informational messages for debugging * Add unit tests Units tests for the various private methods in support of collection list * Start adding unit tests for test_execute_list * Display collection path when listing specific collection * Add unit tests for listing all collections and specific collection - Create fixture for creating test objects - Add function for controlling os.path.isdir results * Set defaults for minimum collection widths Ensure that collections with small FQCNs display correctly. Add unit tests * Split up unit tests and fix fixtures Add more fixtures for mocking objects during the specific collection tests * Change help message for -p in list subcommand Give accurate description of what it actually does rather than trying to use language shared between sub commands. * Disable colorized output in unit test * Add docs for collection list * Fix integration test on macOS The temp file path is really long on macOS, so the warning message gets wrapped across multiple lines. That make seth grep fail. Switch to matching on a smaller part of the warning. * Recreate common path options for collections Improve help about what the '-p' option does and how it works. * Remove unnecessary elif after continue statements * Account for duplicate paths in collections_searh_paths If someone specifies the same path via '-p' that is the COLLECTIONS_PATHS, do not list the collections twice. * Docs updates	5 years ago
Jordan Borean	aba8f12495	ansible-galaxy ignore empty server_list (#65986) ... * ansible-galaxy ignore empty server_list	5 years ago
Andrea Tartaglia	202ad4f89a	Fixes --version in ansible-galaxy cli	5 years ago
Jordan Borean	ba7097cba3	Collection test (#59488) ... * Add missing __init__.py for collection unit tests * Added more tests for collection install and remove default path	5 years ago
Jordan Borean	b6791e6ae3	ansible-galaxy: add collection sub command (#57106) ... * ansible-galaxy: add collection init sub command * Fix changelog and other sanity issues * Slim down skeleton structure, fix encoding issue on template * Fix doc generation code to include sub commands * Added build step * Tidy up the build action * Fixed up doc changes and slight testing tweaks * Re-organise tests to use pytest * Added publish step and fixed up issues after working with Galaxy * Unit test improvments * Fix unit test on 3.5 * Add remaining build tests * Test fixes, make the integration tests clearer to debug on failures * Removed unicode name tests until I've got further clarification * Added publish unit tests * Change expected length value * Added collection install steps, tests forthcoming * Added unit tests for collection install entrypoint * Added some more tests for collection install * follow proper encoding rules and added more tests * Add remaining tests * tidied up tests and code based on review * exclude pre-release versions from galaxy API	5 years ago
Matt Clay	86268b09a1	Support ansible-galaxy test on FreeBSD Python 3.x.	6 years ago
Matt Clay	e7b793c8c6	Move requirements into tests. (#35885)	7 years ago
Adam Miller	6cc5e4c9df	galaxy remove incorrect check for role path before extraction (#35259) ... * galaxy remove incorrect check for role path before extraction Fixes #35217 Currently lib/ansible/galaxy/role.py checks roles_path and will ignore paths that don't currently exist which it should not because the path will attempt to be created by the role extraction process (which is valid and expected behavior) and if unable to write at the time of role extraction into the role_path, that error will be handled properly at that point in the process. Signed-off-by: Adam Miller <admiller@redhat.com> * add test case for galaxy install with rolefile and rolepath Verify we don't regress GitHub Issue #35217 Signed-off-by: Adam Miller <admiller@redhat.com> * fix the integration test Signed-off-by: Adam Miller <admiller@redhat.com> * double quote for shellcheck glob warning Signed-off-by: Adam Miller <admiller@redhat.com> * fix galaxy install tests to not need remote resources Signed-off-by: Adam Miller <admiller@redhat.com> * make shellcheck sanity tests happy Signed-off-by: Adam Miller <admiller@redhat.com> * prep git global conf for running the galaxy install tests in docker Signed-off-by: Adam Miller <admiller@redhat.com> * move ansible-galaxy tests into their own target, make git conf non-global Signed-off-by: Adam Miller <admiller@redhat.com> * fix up tests based on feedback Signed-off-by: Adam Miller <admiller@redhat.com> * remove extra newline from aliases file Signed-off-by: Adam Miller <admiller@redhat.com>	7 years ago