Marius Gedminas
4ae4331a6b
user: don't generate SSH keys in check mode
...
Fixes https://github.com/ansible/ansible/issues/11768
Test plan:
- (in a Vagrant VM) created a user 'bob' with no ssh key
- ran the following playbook in check mode:
---
- hosts: trusty
tasks:
- user: name=bob state=present generate_ssh_key=yes
- saw that ansible-playbook reported "changes=1"
- saw that /home/bob/.ssh was still absent
- ran the playbook for real
- saw that /home/bob/.ssh was created
- ran the playbook in check mode again
- saw that ansible-playbook reported no changes
- tried a variation with a different username for a user that didn't
exist: ansible-playbook --check worked correctly (no errors, reported
"changed")
9 years ago
Yann Hamon
8f03f1e4e1
Docker module: restarted should update the container when necessary
9 years ago
Marius Gedminas
eb17b6a36c
apt: check for "0 upgraded" to be at the beginning of the line
...
Fixes #1678 .
9 years ago
Brian Coca
116793889f
Merge pull request #1915 from leedm777/patch-1
...
ec2_vol: Added missing "needs 2.0" doc
9 years ago
Toshio Kuratomi
b29276df34
Merge pull request #1204 from detiber/test_rhsm
...
bugfixes for redhat_subscription
9 years ago
Brian Coca
aae5177164
Merge pull request #1966 from tback/devel
...
Delete dead and broken code
9 years ago
Till Backhaus
39e7e05a8d
Delete dead and broken code
9 years ago
Tony Kinsley
bd210e42bc
Adding start and stop actions to os_server_actions
...
Also making the os_server module allow a server in the possible new
states from the os_server_actions changes
9 years ago
Brian Coca
bc6a8761a1
Merge pull request #1958 from omriiluz/Bugfix-for-1957
...
No need for .keys on volumes list
9 years ago
Omri Iluz
daf7a0551b
No need for .keys on volumes list
...
Since c3f92cca21
changed "volumes" to be a list instead of a dictionary, we don't need (and cannot) .keys when appending to set.
Reported as bug #1957
9 years ago
Chris Church
1d074d43aa
* Update core modules to fix strict mode errors.
...
* Also fix creates parameter issue in win_msi as described in https://github.com/ansible/ansible-modules-core/issues/129 , slightly different fix from https://github.com/ansible/ansible-modules-core/pull/1482
* Fix setup.ps1 module issue described in https://github.com/ansible/ansible-modules-core/issues/1927
9 years ago
James Cammarata
85ddb1b902
Fixing region requirement regarding euca clusters
...
Fixes ansible/ansible#11023
9 years ago
Brian Coca
630e8ef9a6
Merge pull request #1954 from nitzmahone/setup_uptime
...
added windows facts ansible_lastboot, ansible_uptime_seconds
9 years ago
nitzmahone
2a5f3754e7
added windows facts ansible_lastboot, ansible_uptime_seconds
...
switched OS object to Get-CimInstance since we need a DateTime object for lastbootuptime
9 years ago
Bruno Galindro da Costa
f7f621839a
Added termination_policies option
9 years ago
Simon Li
428550e179
Don't fail in check_mode if user exists
...
PR #1651 fixed issue #1515 but the requirement for path to be defined is unecessarily strict. If the user has previously been created a path isn't necessary.
9 years ago
Sarah Haskins
b04efa22c4
Expose cache_parameter_group_name in elasticache module
...
The cache_parameter_group_name was not previously exposed in
elasticachy.py, I have exposed it, as optional.
9 years ago
Brian Coca
2af3f34d58
Merge pull request #1926 from cjchang/keystone_user
...
support creating role only
9 years ago
Jérémie Astori
72fb7a0a17
Fix physical walk on acl module for Linux
...
`-h` is for BSD [1] while `-P`/`--physical` is for Linux [2].
This commit fixes that option now that acl module is (temporarily)
only supported for Linux.
I will re-add `-h` when fixing BSD support.
[1]: http://www.freebsd.org/cgi/man.cgi?format=html&query=setfacl(1)
[2]: http://linuxcommand.org/man_pages/setfacl1.html
9 years ago
Jérémie Astori
8eefd44aef
Make sure entry is not sent when acl state=query
9 years ago
Jérémie Astori
0e659ad872
Make sure permission-less entries are accepted when state=absent
...
Also, remove that try condition as, at that stage, no permissions with
other than 2 or 3 fields are sent to the function.
9 years ago
Toshio Kuratomi
4721d6d8b5
Fix for the case where plugins aren't loaded on old RHEL systems
9 years ago
Jérémie Astori
e95bcaeb8a
Remove support for `d[efault]:` in entry permissions
...
It is not documented in [the Ansible doc page][1] nor
[the BSD setfacl man entry][2] (which means it might not be compatible
with BSD) so removing it does not break the API.
On the other hand, it does not conform with POSIX 1003.1e DRAFT
STANDARD 17 according to the [Linux setfacl man entry][3] so safer to
remove.
Finally, the most important reason: in non POSIX 1003.e mode, only ACL
entries without the permissions field are accepted, so having an
optional field here is very much error-prone.
[1]: http://docs.ansible.com/ansible/acl_module.html
[2]: http://www.freebsd.org/cgi/man.cgi?format=html&query=setfacl(1)
[3]: http://linuxcommand.org/man_pages/setfacl1.html
9 years ago
tobbe
8fa1e9515b
Add suport for selinux user when adding a new user on selinux enabled
...
systems
9 years ago
Toshio Kuratomi
c228739f2d
Merge pull request #1946 from ansible/pr/1657
...
Update check-mode results to be a dictionary (finishes pr 1657)
9 years ago
Toshio Kuratomi
9d4694122d
Return change results in a dictionary listing the package names.
...
Fix a parsing problem when package names contain a dot.
9 years ago
Matt Martz
51b800d1df
Merge pull request #1943 from richbria/devel
...
Preventing servers that are deleted and left in the deleted state from being included in the server list
9 years ago
Brian Richards
e4a5f3b409
Preventing servers that are deleted and left in the deleted state from being included in the server list
9 years ago
Toshio Kuratomi
c6d09d8f8d
Merge pull request #1920 from ilya-epifanov/devel
...
fixed memory_limit for docker api version >= 1.19
9 years ago
Nithy Renganathan
4171d167f4
Handle the changed value
9 years ago
Jason Cowley
8215aad3b3
Add support for S3 canned permissions. resolves #1939
9 years ago
Brian Coca
f925f7e01f
Merge pull request #1734 from freym/assemble-file-validation
...
assemble: add file validation support.
9 years ago
Toshio Kuratomi
8841c85505
Merge pull request #1934 from SamYaple/refix_bug_1226
...
Refix bug 1226 after revert
9 years ago
Sam Yaple
54804d25e3
Actually remove the section we are replacing
9 years ago
Sam Yaple
dddb5270c8
Refix bug 1226 after revert
...
This patch properly fixes bug 1226 without introducing a breaking
change to idempotency which was introduced in PR #1358
We can properly assign permissions to databases with a '.' in the name
of the database as well as assign priviliges to all databases as
specified with '*'
9 years ago
Jérémie Astori
3ac990556d
Fix wrong expectation regarding entry format in acl module
9 years ago
Jérémie Astori
421d3f12cf
Fix wrong processing of lines returned by setfacl in test mode
9 years ago
Jérémie Astori
50c6425673
Fix minor whitespace issues
9 years ago
Brian Coca
5913f5e5e1
deal with more failures when apt module fails to instantiate pkg
...
fixes #1499
9 years ago
Brian Coca
65270a172e
Merge pull request #1857 from SamYaple/devel
...
Revert "escapeds changes"
9 years ago
Bill Nottingham
c93456adc3
win_msi: document extra_args
...
The extra_args parameter was not documented. It's needed for installing some MSIs.
9 years ago
HAMSIK Adam
dfac073343
Rebase start/stop instance pull code
9 years ago
Mahesh Sawaiker
f459b3773c
support creating role only
9 years ago
Brian Coca
ff3b88c4d7
Merge pull request #1925 from kostyrevaa/devel
...
Fix documentation of authorized_key.py
9 years ago
Александр Костырев
31ec203583
Fix documentation of authorized_key.py
...
man for sshd http://www.openbsd.org/cgi-bin/man.cgi/OpenBSD-current/man8/sshd.8?query=sshd
says there's no "host" option but "from".
9 years ago
Ilya Epifanov
d951172920
fixed memory_limit for docker api version >= 1.19
9 years ago
Brian Coca
d61fde42ef
updated encoding comment and expanded authors field
9 years ago
Brian Coca
d4a39d23df
Merge pull request #150 from astorije/recursive_acl
...
Add recursive support for ACL module
9 years ago
Jérémie Astori
acfc2166b0
Set version number in recursive option description
9 years ago
Jérémie Astori
f8027a7f0a
Ensure Python 2.4 compatibility and Linux-restricted support
...
- Make build_entry compatible with Python 2.4
- Re-add missing warning/comment that was forgotten while refactoring
- Replace `all()` with a good ol' for-loop Python 2.4 compatibility
- Make a condition check more explicit (when `state` is `query`)
- Make sure this module can only be run with on a Linux distribution
- Add a note about Linux-only support in the documentation
- Set the version in which recursive support was added, 2.0
9 years ago