Commit Graph

150 Commits (08af5f833fb5e84e6e89a849a9d101e7558d1a47)

Author SHA1 Message Date
Ingo Gottwald 08af5f833f Bugfix service module: Only change service state when needed 11 years ago
James Cammarata 3e7511609e Slight refactorization of the sysctl module
* Added in support for freebsd-style sysctl commands
* Replaced some functionality that was provided by module_common
* Simplified some logic in a couple of places (ie, not checking
  a split with len() but instead limiting the split to 1)

Fixes #3380
11 years ago
James Cammarata 8d6e302cf8 Compare exploded values in the sysctl module to avoid whitespace errors
Fixes #3931
11 years ago
James Cammarata 5fe192e5e7 Fixes to the service module for Ubuntu 12.04 (LTS)
Fixes #3615
Fixes #3572
11 years ago
James Cammarata 5e8918cb2c Check for systemd ownership of a service even if an init.d script exists
Also slight modification to the error message in the earlier commit that
modified the update-rc.d detection portion of the code

Fixes #3474
11 years ago
James Cammarata ef02c6107a Minor fix to account for template service names in systemctl 11 years ago
James Cammarata f22ffab259 Fix for update-rc.d based systems that also have systemd installed
By default, the service module had assumed that if the system had the
update-rc.d binary, the service was either managed via upstart or standard
sysV init-style scripts. This patch adds a check for systemctl ahead
of the other methods when update-rc.d is detected, and also simplifies
the logic around the detection of systemctl-managed services
11 years ago
James Laska 5dc830c279 The required package for selinux is libselinux-python 11 years ago
James Cammarata 21ae255fb3 Merge branch 'aix_wpar_facts' of https://github.com/mplonka/ansible into mplonka-aix_wpar_facts 11 years ago
James Cammarata 17f683aad7 Added 'reloaded' state to list of states checked for bounced services
Fixes #3556
11 years ago
Raul Melo b0ffba472f Fix issue 3908. There was some ilegal operations over the sets 11 years ago
James Cammarata b4306920ce Fix for the cron module on FreeBSD
Apparently crontab on freebsd does not like the file path coming before
the "-u username" portion of the command to install the crontab
11 years ago
Marcin Płonka 4a43bb3b00 Skipping facts not available on AIX WPARs 11 years ago
Michael DeHaan 003c86e250 Merge branch 'fix_service_with_initscript' of git://github.com/psvo/ansible into devel 11 years ago
Andy Wilson 85e34cc107 docfix: grammar in docstring for sysctl module 11 years ago
Petr Svoboda 48b064b55b Fix traceback in service module when svc_cmd is None
When service module is used on unsupported Linux system where init
script is used directly, LinuxService.svc_cmd is None so .endswith()
fails.

Fixes issue #3533
11 years ago
Michael Scherer bb9d0a9493 Add urpmi as a package manager for mandriva-based distribution 11 years ago
James Cammarata 494030aa6c Removing skipped=True so the task is just marked as not-changed 11 years ago
James Cammarata f3384374b9 Set result to skipped when vol group is missing and lv state=absent
Fixes issue #3714 - lvol module state=absent fails (with error) if
the volume group doesn't exist
11 years ago
rishid fea38f44ac Verify groups string is not empty before trying add user to groups 11 years ago
Brian Coca e8e8779dfa fixed bug from prev update
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Brian Coca 2c06418f6d whitespace updates on new lines
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Brian Coca fe57037f84 now uses get_bin_path for lvg executables
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Michael DeHaan 5b80299231 Make exceptions handling python 2.4 compatible. 11 years ago
Michael DeHaan ecf074865f Continue on mount errors, don't fail the setup module. 12 years ago
Brian Coca 220fe24d39 use global to fail as its not in self
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Michael DeHaan 3f4c6affa3 Update CHANGELOG 12 years ago
Michael DeHaan 9ebde16e3a Merge branch 'iss_cron' of git://github.com/dirtyharrycallahan/ansible into dh_cron 12 years ago
Michael DeHaan 4281f773bb Merge pull request #3602 from bcoca/fine_tune_stat_exception
narrowed down exception
12 years ago
Michael DeHaan 517c318989 Merge pull request #3470 from langemeijer/devel
Only append non_unique parameter if a uid is provided as well to user module
12 years ago
Brian Coca 7132f7e792 narrowed down exception we ignore and fail if any other unexpected one
crops up.
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Florian Tham 865a663d05 fix fatal error when removing logical volumes 12 years ago
Antti Rasinen f9e9286b2c Make zfs set_property accept values with embedded spaces
Converting the argument list to a string with ' '.join causes
the shell interpreter to misparse spaces in property values.
Since the zfs command does not need shell anywhere, using
a list instead of a string works just as well with run_command. 

Fixes #3545.
12 years ago
Antti Rasinen 8bfe9f6942 Fix zfs property parsing
Current property parser breaks when values contain spaces. Since
zfs get -H returns tab separated lines,  it is better to explicitly
split on tabs than on whitespace.
12 years ago
trbs 98b284159f fix missing json module for issue #3363 print JSON error as string instead 12 years ago
Brian Coca dd1ffce0a0 now won't throw exception if we don't have permission to stat a mtab
entry on linux (weird chromebook issue)
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Michael DeHaan b22428d87e Merge pull request #3426 from trbs/services_sleep_option
sleep option for service module which adds a pauze between stopping and ...
12 years ago
Michael DeHaan 7dfafc6ec4 Merge pull request #3496 from johanwiren/bsd-ipv6-facts
Fix for populating default_ipv6 on BSD systems
12 years ago
Michael DeHaan 38ac6c9abd Merge pull request #3497 from johanwiren/bsd-gateway
Updated setup module to collect gateway fact for BSD systems
12 years ago
Michael DeHaan 03605484f8 Merge pull request #3388 from bcoca/fixed_user_create_doc
updated module docs to reflect 'correct' on_create vs on_creation
12 years ago
Johan Wirén 3e765f7775 Updated GenericBsdIfconfigNetwork to collect gateway 12 years ago
Johan Wirén a03125e0cf Fix for populating default_ipv6 on BSD systems 12 years ago
Joshua Lund d75f73fffe Added a new with_file example to the authorized_key documentation 12 years ago
Patrick Callahan f37becb94a Bug fixes and enhancements.
Bugs:
(1) no longer allow empty jobs
(2) strip the header added by crontab package used in openSuSE and SuSE
(3) try not to leak temp files when things go wrong
(4) issue returning job names under certain conditions

Enhancements:
(1) Allow all special times not just reboot.
(2) Fail earlier by performing more input validation
(3) Add feature to allow removing cron file under /etc/cron.d

ToDo:
(1) Validate times (minute, hour, ...)
(2) Strip white space from fields such as name and job such that name=foo equals name=' foo'.
(3) More testing
12 years ago
Brian Coca e0e50b5936 fixed check mode
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Casper Langemeijer 8727f0ce11 Only append non_unique parameter if a uid is provided as well 12 years ago
Aaron Brady 34617476d0 Make the CPU facts Hyperthreading aware 12 years ago
trbs 0d8da6eeb0 sleep option for service module which adds a pauze between stopping and starting a service using state=restarted. This helps for bad scripts that exist immediatly after signaling a process to stop. 12 years ago
Antti Rasinen c2a4645349 Fix service enable on FreeBSD
Some services have a knob (i.e. rc.conf setting) whose name
differs from that of the script. For example, lockd process
is controlled with a script called lockd, but the rc.conf
value is rpc_lockd_enable.

Fixes issue #3382.
12 years ago
Brian Coca b494d6d2ae updated module docs to reflect 'correct' on_create vs on_creation
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago