Commit Graph

752 Commits (08559670e5f2d8104cc94de3914ec039883766a5)

Author SHA1 Message Date
Brian Coca 83b5220068 clarified ping module purpose 9 years ago
Toshio Kuratomi dc51e1ae41 Mark a few parameters as no_log 9 years ago
Brian Coca ccbcff8c8e better handling of checkmode for solaris
fixes #2296
9 years ago
Brian Coca 0307e3e649 Merge pull request #2209 from gekmihesg/devel
Support sysctl on OpenBSD
9 years ago
Achilleas Pipinellis 1499288c64 Add missing documentation: cron_file requires user to be set 9 years ago
gekmihesg cdf0c8a560 Support sysctl on OpenBSD
Fixes #1233
9 years ago
Simon Li d616fd12da Fix incorrect variable in group.py: user -> group 9 years ago
Brian Coca a15aa09251 removed typo 9 years ago
Brian Coca f6bbd2ac5b removed syslog in favor of common module logging functions 9 years ago
Brian Coca 3e42527fde revert must_exist 9 years ago
Mike Boone 539c996ede Updated link to the FAQ. 9 years ago
Brian Coca 81a7243bbb changed chmod to 2.4 compat 9 years ago
Brian Coca 813053c51c Merge pull request #986 from ssssam/cron-permissions-fix
Fix permissions issue with 'cron' module
9 years ago
Brian Coca e278f285aa partially reverted previous change to deal with systemctl show status not returning errors on missing service
Now it looks for not-found key instead of running status which does return error codes when service is present but in diff states.
fixes #12216
9 years ago
Brian Coca bbcfb1092a check systemctl status before show as show will not return antyhing other than rc=0 even when it fails. 9 years ago
Marius Gedminas 5595a9f81d authorized_key: fix example in documentation
'key=' cannot be pointing to a file name; it needs to be the key itself as a string (or a URL).
9 years ago
Tim Rupp 48f522455d Add hostname support for Kali linux 2.0
This patch allows the hostname module to detect and set the hostname for a
Kali Linux 2.0 installation. Without this patch, the hostname module raises
the following error

   hostname module cannot be used on platform Linux (Kali)

Kali is based off of Debian.
9 years ago
Benno Joy 8bf800d5c5 Merge pull request #1973 from mgedmin/user-no-ssh-keygen-in-check-mode
user: don't generate SSH keys in check mode
9 years ago
Marius Gedminas 4ae4331a6b user: don't generate SSH keys in check mode
Fixes https://github.com/ansible/ansible/issues/11768

Test plan:

- (in a Vagrant VM) created a user 'bob' with no ssh key
- ran the following playbook in check mode:

    ---
    - hosts: trusty
      tasks:
        - user: name=bob state=present generate_ssh_key=yes

- saw that ansible-playbook reported "changes=1"
- saw that /home/bob/.ssh was still absent
- ran the playbook for real
- saw that /home/bob/.ssh was created
- ran the playbook in check mode again
- saw that ansible-playbook reported no changes
- tried a variation with a different username for a user that didn't
  exist: ansible-playbook --check worked correctly (no errors, reported
  "changed")
9 years ago
Simon Li 428550e179 Don't fail in check_mode if user exists
PR #1651 fixed issue #1515 but the requirement for path to be defined is unecessarily strict. If the user has previously been created a path isn't necessary.
9 years ago
Александр Костырев 31ec203583 Fix documentation of authorized_key.py
man for sshd http://www.openbsd.org/cgi-bin/man.cgi/OpenBSD-current/man8/sshd.8?query=sshd
says there's no "host" option but "from".
9 years ago
Brian Coca 5d7cb981d3 made continue into a pass (there was no loop) 9 years ago
Brian Coca 6d7428527d minor doc fixes 9 years ago
Brian Coca 2fd171a5e1 Merge pull request #878 from EvanK/system-cron--disabled
cron module: Add disabled option for commented jobs
9 years ago
Brian Coca cd0a1947c2 Merge pull request #1899 from austinhyde/fix-service-rcconf-newlines
Service module incorrectly handles lines not ending in a newline
9 years ago
Brian Coca 7a2687178e avoid shlex exceptions in rc parsing (happens with multiline entries)
fixes #1898
9 years ago
Brian Coca 0c403781a7 Merge pull request #1905 from evverx/fix-legacy-services-enabled
Fix service.enabled on: Debian 8, Ubuntu 15.04
9 years ago
Evgeny Vereshchagin 55e8863cb4 Fix service.enable on: Debian 8, Ubuntu 15.04
Workaround for https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=751638
See https://github.com/systemd/systemd/issues/937
9 years ago
Brian Coca 072c4f38ea Merge pull request #62 from 0x46616c6b/user-add-skeleton-support
Add support for skeleton directory (useradd -k) in user module
9 years ago
Austin Hyde 5c25057868 Always end rc.conf entries with a new line 9 years ago
Brian Coca 0e9fccd098 changed verbose override variable 9 years ago
James Cammarata bc60c893f5 Prefer non-zero rc's over text analyis in service status checks
Fixes ansible/ansible#10441
9 years ago
saito-hideki e91ad2ab6c Add Solaris support in hostname module
feature_pull_request: #1804
9 years ago
saito-hideki b991a2708b Add Solaris support in hostname module 9 years ago
Brian Coca a2b713edad Merge pull request #1790 from renard/allow-star-password-on-openbsd-2015-07-24
[user] Allow '*' as empty password.
9 years ago
KIKUCHI Koichiro a3b9fb58bf Fix service enabled check failure on FreeBSD 9 years ago
Sébastien Gross 349195e689 [user] Allow '*' as empty password.
If `password` is defined as `*` `useradd` or `usermod` returns an error:

    msg: usermod: Invalid password: `*'

This works very well on Linux host to not define any password for a
user (mainly useful if your setup is only based on SSH keys for
auth). On OpenBSD this does not work, so we have to ignore the encrypted
password parameter if it defined as `*`.
9 years ago
fti7 6a872469fc mount: Support for Check-Mode 9 years ago
Brian Coca 718fd1f891 prevent usless assignment of home 9 years ago
Brian Coca 045b8e8cff Merge pull request #1733 from tersmitten/the-tilde-expansion-doesnt-work-with-userhome
The tilde expansion doesn't work with user.home
9 years ago
bambou e04f75d872 Check if the gid is set 9 years ago
Mischa ter Smitten 0ca732baaf The tilde expansion doesn't work with user.home 9 years ago
Brian Coca 8546744418 Merge pull request #1286 from 0tmc/freebsd_mount_fix
Use of proper fstab file on FreeBSD
9 years ago
Sean Chittenden c57d70ad20 Fix group mod and group add for FreeBSD 9 years ago
Brian Coca 03d4805074 Merge pull request #1279 from no2a/devel
Not use "is" to compare strings
10 years ago
Brian Coca 328b6b5a39 Merge pull request #1454 from grossws/patch-issue-530
Escape spaces, backslashes and ampersands in fstab
10 years ago
Brian Coca 2b209f8065 Merge pull request #1642 from sivel/core-fixups
Core module fix-ups
10 years ago
Toshio Kuratomi 1dc5074602 Merge pull request #1651 from verm666/issue-1515
fix authorized_keys in check_mode
10 years ago
Matt Martz b6b576abf6 Replaced tabbed indentation with spaces for group module 10 years ago
verm666 b00b3f2b3c fix authorized_keys in check_mode
This change is in response to issue #1515.
Original pull request #1580.

The original problem is: in authorized_key module you have no idea about users
which will be created by Ansible at first run. I can propose next two ways to
solve this problem:

  1. Combine modules system/user.py and system/authorized_key.py in one module
     (so you will know everything about users in that module)
  2. Use small workaround: add my commit and always provide 'path' parameter
     for authorized_key module during runs with --check option.
10 years ago