Commit Graph

2127 Commits (081ce0e4e132a855550772379eedd7ae1be5335a)

Author SHA1 Message Date
Abhijeet Kasurde 3fd73750dc [2.9] Docs: point inventory script to respective version
With collections migration, inventory scripts are moved from devel (2.10).
Point docs for inventory script to their respective version.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
5 years ago
Felix Fontein c49f2218de
Mention acme_certificate behavior changes in porting guide caused by a bugfix and previously incorrect examples. (#69167) 5 years ago
Sloane Hertel d41e38435b
[2.9] CVE-2020-1746 - Remove the params module option from ldap_attr and ldap_entry (#68714)
* Remove the params module option from ldap_attr and ldap_entry

Module options that circumvent Ansible's option handling were disallowed
in:
https://meetbot.fedoraproject.org/ansible-meeting/2017-09-28/ansible_dev_meeting.2017-09-28-15.00.log.html

Additionally, this particular usage can be insecure if bind_pw is set
this way as the password could end up in a logfile or displayed on
stdout.

Fixes CVE-2020-1746

(cherry picked from commit 0ff609f1bc)

* Fix formatting for option names

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Fix fail_json

* fix indentation error

Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
5 years ago
Abhijeet Kasurde 64d8947f7f [2.9] docs: Fixed "Edit on GitHub" link for plugin, cli
Fixed sphinx theme to navigate "Edit on Github" link to locate correct
plugin, cli source in GitHub repo.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 2728c2476e)
5 years ago
Jeff Geerling b84e3faa3f
Add Kubernetes Working Group to Communicating guide. (#68501) 5 years ago
kaorihinata 39cfb63be6
Allow no_log=False to silence the no_log warnings for module parameters (#64733) (#67439)
As AnsibleModule._log_invocation is currently implemented, any parameter
with a name that matches PASSWORD_MATCH triggers the no_log warning as a
precaution against parameters that may contain sensitive data, but have not
been marked as sensitive by the module author.

This patch would allow module authors to explicitly mark the aforementioned
parameters as not sensitive thereby bypassing an erroneous warning message,
while still catching parameters which have not been marked at all by the
author.

Adds tests for various no_log states including True, False, and None (as
extracted by AnsibleModule._log_invocation) when applied to an argument with
a name that matches PASSWORD_MATCH.

Fixes: #49465 #64656
(cherry picked from commit 3ca4580cb4)
5 years ago
Andrew Klychkov 1bab4c99f3
Backport of 67645 docs/docsite/rst/: fix typos (#67649) 5 years ago
Andrew Klychkov 4cc4d77c4b
[2.9] Backport /docs/docsite/rst: fix typos (#67650)
* user_guide/intro_adhoc.rst: fix typo (#67644)

(cherry picked from commit 05a3192eb7)

* dev_guide/developing_modules_best_practices.rst: fix typo (#67639)

(cherry picked from commit 244277addd)

* /docs/docsite/rst/dev_guide: fix typos (#67643)

(cherry picked from commit 907c98ebcd)
5 years ago
Sam Doran c6a29ed7d2
[stable-2.9] Update example requirements file docs (#67626) (#67714)
Use "name" when possible rather than "src" to make the examples
of roles and collections in a single requirements files more
coherenant. Fundamentally, roles and collections are completely different.
But we can make the requiremets file easier to read by unifying the
format as much as possible.
(cherry picked from commit 6c70959131)

Co-authored-by: Sam Doran <sdoran@redhat.com>
5 years ago
Sandra McCann 80e5ed0bba
Specify lowercase only for Galaxy namespaces (#67485) (#67503)
* specify lowercase only for galaxy namespaces
* doh... include meta file

(cherry picked from commit a60feeb3c1)
5 years ago
Sandra McCann 79ad190f71
[backport][2.9]Add note that devel branch should not be used in real environments (#… (#67494)
* Add note that devel branch should not be used in real environments (#67483)

(cherry picked from commit 39fef58bea)
5 years ago
Jordan Borean 9895e18e24
Clarify b64encode with Python 2 (#67488) (#67491)
(cherry picked from commit 423a900791)
5 years ago
Felix Fontein aeade1412f
Docs: improve anchors vs. header bar (#67244) (#67317)
(cherry picked from commit fd43619f1a)
5 years ago
Sandra McCann 0ed22d1fbc
add info on creating doc fragments in a collection (#67171) (#67279)
* add info on creating doc fragments in a collection
Co-authored-by: Alicia Cozine <879121+acozine@users.noreply.github.com>

(cherry picked from commit 4dd2513371)
5 years ago
Wojciech Sciesinski b390f808d9
Link the testing documentation to the module documenting page (#67248) (#67288) 5 years ago
Sandra McCann 04d5325c3f
Document network resource modules (#66226) (#67053)
* add network resource module details to docs

(cherry picked from commit 3e35d2d63ce17fb694e645785ad855f01420f7d8)

* network resource module page, with example output

(cherry picked from commit 2ad6055efd)
5 years ago
Felix Fontein 05df06fe4d
Add anchor to each parameter row (#66895) (#67057)
* Add anchor to each paramater row
* Update docs/templates/plugin.rst.j2
* Insert full keys into plugin docs.
* Added visible links.

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 5b93a14a0f)

Co-authored-by: Dick Visser <dick.visser@geant.org>
5 years ago
Sandra McCann c8610efa24
Network prompts (#66584) (#67054)
* add network prompt examples and module examples

* Update docs/docsite/rst/network/user_guide/network_working_with_command_output.rst

Co-Authored-By: Nathaniel Case <this.is@nathanielca.se>
(cherry picked from commit 68ab8c23be)
5 years ago
anshulbehl 1e7434c49d
Adding network plugin changes for netconf and network_cli (#65708) (#67049)
* Adding network plugin changes for netconf and network_cli

(cherry picked from commit b349ec8fcf)
5 years ago
Sandra McCann 26a09160eb Trim down to one Ansible search option (#66284) (#66664)
* move swiftype search to upper left of docsite, fix spacing and length issues for search icon and searchbox

(cherry picked from commit 1a0724fdd4)
5 years ago
Sandra McCann af0a72df30 Add a banner which will display on the testing site. (#64763) (#66666)
* Add a banner which will display when the docs are published to the testing site.
Thanks to shane for the javascript code

Co-authored-by: Sandra McCann <samccann@redhat.com>
(cherry picked from commit 365820f871)

Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
5 years ago
Sandra McCann 85f36a3a42 restructure headings and copy-edit shell completion (#66479) (#66536)
* Docs: restructure headings and fix shell completion on installation guide, apply suggestions from code review

(cherry picked from commit 599cc0bdfa)
5 years ago
Sandra McCann de0936f9c4 add details on network gather facts improvements (#66220)
* add details on network gather facts improvements, implement feedback

(cherry picked from commit 9922014441)
5 years ago
Ganesh Nalawade 2d7819e75d Fix netconf plugin related to collections (#65718)
* Fix netconf plugin related to collections

Fixes #65655 (partly)

*  Make netconf plugins configurable so that the
   information of ncclient device handler
   for give platform resides in the platform
   specific netconf plugin.
*  If the device handler value in ncclient is
   different from the ansible_network_os value
   the right value of `ncclient_device_handler`
   should be set in the plugin documentation.

* Fix review comments

* Fix CI issue

* Fix review comment

(cherry picked from commit 1cfab26fab)
5 years ago
Wojciech Sciesinski df37d93754 Update indentation used in the code examples, unify empty lines (#65874) (#65886) 5 years ago
Mark Chappell 43a9bc96a5 AWS Guidelines: Make 'security_token' optional so that they can be run outside of CI (#66107) (#66136) 5 years ago
Wojciech Sciesinski fc89d45385 Update indentation used in the code examples, unify empty lines (#65346) (#65696) 5 years ago
Sandra McCann 6ba26e7556 Clarify how to install roles and collections from same requirements file (#65707) (#65736)
(cherry picked from commit 5eceebcaf3)
5 years ago
Sandra McCann 58a62da92d update version metadata to get faceted swiftype search running (#65574) (#65579)
* update version metadata to get faceted swiftype search running

(cherry picked from commit 96cbbdd59f)
5 years ago
Alicia Cozine 50c25760a0 Fix ansible-galaxy man page generation (#65478) (#65523)
The Action list was misformatted, leading to an error message in the man
page.

https://bugzilla.redhat.com/show_bug.cgi?id=1717110
(cherry picked from commit 9973121f44)
5 years ago
Sandra McCann 9b27c7b7dc Backport/2.9/brokenlinks (#65016)
* Remove duplicated and broken link to Roles (#64991)

(cherry picked from commit f198036d7f)

* Fix link to Roles (#64992)

(cherry picked from commit 1d0a832692)

* fix collection broken links (#65010)

(cherry picked from commit 2749090bc6)
5 years ago
Alicia Cozine 23de3c1614
update configuring ansible-galaxy client (#64796) (#64904)
* update configuring ansible-galaxy client, deduplicate, clarify tokens, AH procedures, etc.

(cherry picked from commit a01376a493)
5 years ago
Felix Fontein 1f0c518965 Document 'elements' for module option and return value documentation. (#64075)
(cherry picked from commit 0bf9146b29)
5 years ago
Matt Martz 26e8474f6d [stable-2.9] unsafe wrapping should only happen for with_ loops (#64401)
* unsafe wrapping should only happen for with_ lookups. Fixes #64379. Addresses #64169

* edit porting guide entry

* typo in changelog fragment

* typo

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* punctuation

Co-Authored-By: Sandra McCann <samccann@redhat.com>
(cherry picked from commit 254788b)

Co-authored-by: Matt Martz <matt@sivel.net>
5 years ago
Kiyo Nagamine cef3036179 [2.9] Fixed tiny typo in interpreter_discovery.rst
Added missing '/'

(cherry picked from commit 84bffff96a)
5 years ago
Sandra McCann 604e06c482 remove toshio as release manager (boohoo) (#64685) (#64740)
(cherry picked from commit 94e98d5369)
5 years ago
Matt Clay c271fd0df2 [stable-2.9] Fixes for validate-modules import handling. (#63932)
* Fix validate-modules support for collections.

- Relative imports now work correctly.
- The collection loader is now used.
- Modules are invoked as `__main__`.

* Remove obsolete validate-modules code ignores.

* Handle sys.exit in validate-modules.

* Add check for AnsibleModule initialization.

* Remove `missing-module-utils-import` check.

This check does not support relative imports or collections.

Instead of trying to overhaul the test, we can rely on the `ansible-module-not-initialized` test instead.

* Fix badly named error codes with `c#` in the name.

The `#` conflicts with comments in the sanity test ignore files.

* Add changelog entries.
(cherry picked from commit e9f8a34dce)

Co-authored-by: Matt Clay <matt@mystile.com>
5 years ago
Sandra McCann 02cc45a8ae clarify acceptable file types in collection docs (#64618) (#64622)
* clarify acceptable file times in collection docs

* implement feedback

(cherry picked from commit 6a662b0ed0)
5 years ago
Alicia Cozine f561e7d15f
updates RHEL packages to 2.9 (#64532) (#64620)
(cherry picked from commit ac9c75d467)
5 years ago
Christian Adams 6c7fadd861 clarify vault warning and fix typo (#64457)
(cherry picked from commit 59eb966042)
5 years ago
Sandra McCann 6d309f726d Add note about large tarball sizes for collections (#64411) (#64416)
* add note on collection tarball size

(cherry picked from commit 797397558e)
5 years ago
Alicia Cozine c486638e4e
add general facts-to-info paragraph (#64293) (#64297)
(cherry picked from commit 6e07d4c1d9)
5 years ago
Sandra McCann 0c6cb417e5 [Docs-Release-2.9] clean up porting guide links and network text (#64124) (#64290)
* clean up porting guide links and network text
* fix shippable error

(cherry picked from commit 56d5fd34e3)
5 years ago
Felix Fontein 67c02e5dee [2.9] crypto modules: improve return value list documentation (#63409)
* crypto modules: improve return value list documentation (#62929)

* Improve return value documentation by allowing entry for return values.
* Add docs formatting, adjust styling.
* Fix sample return value. (Taken from https://tools.ietf.org/html/rfc7517#appendix-A.1.)
* Work around abuse of .

(cherry picked from commit 054285c34c)

* Add changelog.
5 years ago
Alicia Cozine d55f7a0d26
Backport/2.9/docs release (#64173)
* docs: update to latest 3 versions (#64109)

(cherry picked from commit 409545825f)

* update too old version to 2.4 (#64167)

(cherry picked from commit c63ef6d911)

* update backport instructions to use stable-2.9 (#64168)

(cherry picked from commit f264e9cfca)

* [Doc-Release-2.9] update release and maintenance page for 2.9 (#64166)
* only 2.4 and earlier used the old changelog system

(cherry picked from commit 3f808d9ed6)
5 years ago
Sandra McCann e6751a2d2a change 2.9 to lateset` (#64266) 5 years ago
Alicia Cozine b80ca85a69
Backport/2.9/docs (#64073)
* clarify no subfolders and md only for collections /docs folder (#63808)

(cherry picked from commit 6a2902c8d5)

* Fixed example error in windows_winrm user guide (#63922)
The example code to configure TLS 1.2 Support using Ansible had an indention error. The register variable 'enable_tls12' was not indented. This caused the subsequent task to fail since the variable was not registered. 

(cherry picked from commit c562e17659)

* Fix doc errors in AWS modules (#63851)
* Fix register/debug in aws_batch_compute_environment
* Fix aws_batch_job_queue doc errors
* Fix module naming: `batch_job_queue` > `aws_batch_job_queue`
* Fix missing register
* Update debug task to use modern YAML format
* Fix missing register + debug for lambda_policy
* Fix YAML syntax for elb_application_lb_info module

(cherry picked from commit e4f16368ed)

* Update documentation for package module (#63909)
It is not clear from the documentation that list can be used

(cherry picked from commit 7f2c367d78)

* [ec2_launch_template] Update description of state param (#63147)
Currently, it is not possible to delete specific versions of an ec2 launch template. The module docs incorrectly suggest that there is a `version` param to the module that can be used to do that. This patch aims to correct that error.

(cherry picked from commit 7ea7260753)

* template: Add a space in example block (#63930)

(cherry picked from commit f279715c29)

* revisions to docsite  README (#63957)

(cherry picked from commit 5c962ef859)

* combine galaxy.com install roles details (#63486)

(cherry picked from commit ee8a088205)

* Correct a typo (#64020)

(cherry picked from commit 18f4f0549f)

* Update password.py (#63965)
Update the examples of the password lookup plugin to show how multiple options are joined together.

(cherry picked from commit 92daec5d0b)

* Fix indentation of example (#63789)
Remove no_log since module_defaults aren't displayed like set_fact was

(cherry picked from commit 1e52782d6b)

* add newline to render table correctly (#63769)

(cherry picked from commit 1aee11c860)

* clarified some points on environment keyword usage (#64065)

(cherry picked from commit 885ee62b53)
5 years ago
Alicia Cozine 07fa9b5187
Backport/2.9/docs (#63814)
* Replaced old DSC links that given 404 (#63556)
Replace DSC links that returned "not found" with updated, working links.

(cherry picked from commit f638f29e44)

* Fix example in pip module documentation (#63462)

(cherry picked from commit d8b9f9fb4f)

* Update vmware ansible modules requirements section (#62797)
Update vSphere Automation Python SDK to the requirement section

Signed-off-by: Jobin George <jgeorge@vmware.com>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 8a77f17dea)

* Typo usersername should be username (#63671)

(cherry picked from commit 2ef4ac1404)

* Update description for firstmatch option (#62896)

Fixes issue https://github.com/ansible/ansible/issues/62862. The edit makes the description for the `firstmatch` option clearer. The `firstmatch` option was introduced by PR https://github.com/ansible/ansible/pull/33825

(cherry picked from commit aeb0dde7cc)

* Update win_regmerge.py (#63633)
s/windows/Windows/ in title

(cherry picked from commit 4326165be5)

* Example incorrect: server_url is required argument (#63670)
The example "Delete GitLab Group" does not work - requires server_url parameter. This likely applies to all Examples, so this change proposes at least putting in the required parameter in the examples. In future we can remove the soon-to-be deprecated server_url parameter.

(cherry picked from commit b02467961a)

* doc: win_user: fix typo in the description of the groups modifyer (#63743)

(cherry picked from commit 6046386dba)

* Update AWS dev guide to recommend module_defaults and point to CI policy repo (#63589)

(cherry picked from commit 9cda5819b9)

* Add example for port range to win_firewall_rule_module (#63269)

(cherry picked from commit 2e81b813dd)

* added a link to install instruction of OpenSSH (#63548)

(cherry picked from commit cfe2beae46)
5 years ago
Alicia Cozine b04d328b3a
Backport/2.9/docs2 (#63524)
* Update sros_config.py (#63132)

(cherry picked from commit b3deab4319)

* add note about collection links (#63346)

(cherry picked from commit bdd0fac606)

* Nosh module documentation update (#63303)
* detail the 'status' dictionary
* did not add individual descriptions, see nosh documentation for those
* sample: False not being rendered unless 'False' is quoted

(cherry picked from commit df283788e5)

* Move galaxy appendix info to a new Galaxy section (#63356)
* start galaxy docs restructure
* shared snippets in txt files
* moved all content to galaxy section

(cherry picked from commit ae265bc546)

* Enter should be Italics as it is a menu option (#63441)

(cherry picked from commit 7a8c909876)

* ini_file: remove incorrect documentation (#63394)

(cherry picked from commit ab249a469e)

* Changed with_items to loop in VMware example (#63022)

(cherry picked from commit 876a2d57be)

* ovirt update fetch_nested param doc (#63191)

(cherry picked from commit 0beab6bf69)

* Update 'delete' parameter description in synchronize module (#63450)

Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit da46800f1b)

* Update unarchive.py - Further clarify extra_opts (#58102)
Update the description in the options to help assist with what the module is looking for in the extra_opts.  #31873 alone is not enough since if you are not familiar with the option given in the example it may not be obvious that both elements are part of the same option instead of being two different options.

Co-Authored-By: Alicia Cozine <879121+acozine@users.noreply.github.com>
(cherry picked from commit e967060b9f)

* ovirt_vm add warning about next run configuration (#63458)

(cherry picked from commit 16e49fdd44)

* Fix doc - porting_guide_2.8 value example (#63493)

(cherry picked from commit e0f67b58ce)

* Fix warnings for ufw examples (#63505)

(cherry picked from commit e4eea0510c)
5 years ago
Alicia Cozine db2e1d9227
Backport/2.9/docs (#63521)
* Update stat.py (#63289)
Reword awkward documentation language.

(cherry picked from commit b46299ff86)

* Update win_disk_facts.py example (#63266)
Fix incorrect index for second disk (should be `disks[1]` not `disks[0]`)

(cherry picked from commit ce1c8c24f7)

* Fix broken link (#63185)

(cherry picked from commit 021d095625)

* Typo on line 161 (#63133)
fix module name for azure_rm_manageddisk in one example

(cherry picked from commit 81a614684a)

* docs: add Centos and Ubuntu to examples for playbook conditionals (#63085)

Co-Authored-By: Sandra McCann <samccann@redhat.com>
(cherry picked from commit 19587b35da)

* Spot instance code error (#63246)
Adds 'instance_initiated_shutdown_behavior: terminate' to spot instance example for greater efficiency.

(cherry picked from commit 5ed163ce3f)

* Pass a JSON file to the Lambda's payload (#63261)
* Add an example of passing a JSON file to the Lambda's payload
Events passed to Lambda are commonly in JSON format, the change provides an example of using JSON file as an alternative to the inline YAML payload in the other examples.

(cherry picked from commit 1d5206f53e)

* Update ec2.py (#63260)
Change the explanation of spot_wait_timeout

(cherry picked from commit 719170e5c1)

* fix aruba_config examples (#63136)

(cherry picked from commit 6ff5968781)

* [ec2_launch_template] Update examples (#63152)
- Update tasks names for existing examples
- Add a new example showing how to delete a launch template

(cherry picked from commit 32980f214a)
5 years ago