Commit Graph

23717 Commits (079948eef079da06400753a98382e8c7d84e4b5c)
 

Author SHA1 Message Date
Jeroen Geusebroek 54e62c2022 Allow an empty password when adding a new MySQL user. (#3445) 8 years ago
Kyle Dyroff 58f30646ed Log git error stdout/stderr to fail_json (#3022) 8 years ago
Dag Wieers a26188e55d Making unarchive idempotent (#3307)
* WIP: Making unarchive idempotent

Currently unarchive is not idempotent and has many rough edges and bugs.
The current release is a workable improvement on many fronts:

- zip support is now idempotent (but gtar lacks check-mode)
- New option `exclude` to exclude specific paths/files
- New option `keep_newer` to exclude newer files on target
- New option `extra_opts` to influence unzip/gtar (like synchronize module)

The following items are still ongoing:

- Implement CRC32 support for .zip files
- Re-implement the zip support using native zipfile module
- Re-implement the gtar support using native tarfile/gzip/bz2 modules (lzma external)
- Implement check-mode (works in gzip, but fails using gtar)
- Implement diff-mode (discuss an appropriate output model, like synchronize module)

The re-implementation of unzip/gtar support using native python modules will not only simplify the codebase, additional functionality can be implemented correctly and identically, which is currently not possible. (Other archives could be implemented using native modules equally, incl. options)

* Assorted fixes to zip support (during quality checks)

- Support both rw---- and rwx--- permstr
- Better file type support (more qa needed)
- Symlink support
- Include fix from #3229

* Implement zip diff-mode (itemized change) and avoid changes permissions every time (!)

This commit implements:
- rsync-compatible itemized-change output in diff-mode (using zip)
- no longer changing permissions unconditionally (when idempotent)

* Small fixes to itemized change output

* Fixes to user/group ownership changes

- The implementation of user/group ownership is a bit more complex for idempotency
- We report when a ZIP file incorrectly tags a directory as a file/link
- We only offer diff output when there is a change

* Fix the handling of includes and excludes for unzip

* Remove test output from output (confuses easily)

* Logic and performance improvements to ownership handling, and umask fix

* Handle special files (type '?')

* Make exceptions compatible with python 2.4

* Implement CRC32 support

* Revert some unintended/unknown changes ?

* Taking over maintenance as offered by current maintainer

* Fix support for white-spaces in filenames

* Remove/rename incorrect regex

* Ensure that fat executables end up with execute permission

* Remove check_result from output when unchanged

* When unarchiving as a user, or when owner/group/mode is supplied --diff is insufficient

Only way to be sure is to check request with what is on disk (as we do for zip).
Leave this up to set_fs_attributes_if_different() instead of inducing a (false) change

* By default, don't send confusing check_results in verbose output

This fixes #74.
8 years ago
NielsH 1b94aa2d43 Resolve idempotency issue with virtual apt package (#3449)
Virtual packages were always marked as upgradable which caused the changed-state even though nothing changed.
8 years ago
Tobias Wolf fb5a91d9d1 Add diff to apt.py (#2944)
for install, remove, deb_install, and upgrade.

Since apt has very commonly familiar output, just use the normal output
from apt-get or aptitude -- trimmed to the interesting parts -- to show
to the user if she specified --diff on the CLI.

Uses the recent support for the `diff['prepared]` key.

Fixes ansible/ansible#10239
8 years ago
Oleg Senin 7ceaafbbd2 Correct misspell (#3454) 8 years ago
Kei Nohguchi fc5ade4020 ops_template.py: Taking care of the JSON src variable (#3313)
* ops_template.py: Taking care of the JSON src variable

* ops_template.py: Specify type='str' for src argument to be explicit
8 years ago
Marcin c3ebc84689 rebase for #2477, ready_for_review (#2581) 8 years ago
Michael Fenn add1a342fe Support altering the virtual cdrom when state == reconfigured (#2394)
This allows a user to modify the state of the virtual cdrom in a VM
by using the state == reconfigured action.  This is useful for
provisioning VMs from templates which do not have ISO images connected.
8 years ago
Alexey Wasilyev 4971c7fe82 docker: support polling image by digest (#2932) 8 years ago
Joel Thompson 1db444cdc2 Add exponential backoff retries to ec2_elb_lb (#3379)
ec2_elb_lb doesn't react well to AWS API throttling errors. This
implements an exponential backoff operation around some of the AWS API
calls (with random jitter, in line with AWS recommendations) to make
this more resilient.
8 years ago
Patrick Ogenstad d4d86b4bc6 Fix documentation example, missing ")" 8 years ago
Donovan Jones 8274f55818 Make remote_group handle name and id in cloud/openstack/os_security_group_rule.py
* Make remote_group handle name and id

* fix regression breaking os_security_group_rule with no remote_group
8 years ago
Robin Roth b9e55a0877 make git updates respect depth (#3254)
* make git updates respect depth

until now `fetch` gets all tags and heads at full depth, this change
* uses `depth` argument for `fetch`
* only get the specified `version` in `fetch`

* fixes #14954

* treat combination of refspec and depth correctly

* be more conservative for non-depth fetch
8 years ago
jjshoe d3623c8148 Give encoding examples (#3436) 8 years ago
yarick123 87fe4a2f0c ini_file: added option 'noextraspaces' to turn off inserting extra spaces around '=' symbol
* ini_file: added option 'noextraspaces' to turn off inserting extra spaces around '=' symbol

* ini_file: noextraspaces, python 2.4 compatibility

* ini_file: noextraspaces - yes/no => true/false

* ini_file: noextraspaces - added 'version_added' option

* ini_file: noextraspaces => no_extra_spaces
8 years ago
hyperized 51e2813ae4 Set --quick to True by default and make it selectable (#3418)
As indicated by @jmainguy in eb1cb94380 (commitcomment-17077470), this will allow the user to set the option quick, which is True by default (as it was before).

This is in reference to: https://github.com/ansible/ansible-modules-core/pull/3402
8 years ago
Michael Moussa 0494dced3a Fixes read replica create BC break (#3365) 8 years ago
William Holroyd 42d784c24b Added ap-northeast-2 region (#2849) 8 years ago
Rob 5a48a2e93e Fix to ensure youngest snapshot is retrieved rather than oldest (#3115) 8 years ago
jjshoe 5b8d209b7e Speed up AMI code by not attempting to create the AMI without checkin… (#2551)
* Speed up AMI code by not attempting to create the AMI without checking on the name first. Also simplifies code for reporting errors from AMI creation, greatly.

* remove sys.exit
8 years ago
Joshua Kugler 15ae8c8e0b Fix mount's handling of passno 8 years ago
Petrox c050776f9e Missing documentation fix (#2516)
Extending the documentation to state, that this module does not handle externals well.
8 years ago
Marcin ea57d8b005 Check if identifier is specified for geo,weighted or failover routing. Don't fail if record set already exist. Set choices for failover - capital PRIMARY and SECONDARY. (#2470) 8 years ago
Fabian von Feilitzsch 32c744e82a make binds a list instead of a dict (to prevent overwriting when copying the same file to two places) (#2294) 8 years ago
Mengdi Gao 165f48717a Improve doc accuracy of template module 8 years ago
John Barker d531eb146d Replace BOOLEANS with true/false 8 years ago
John Barker b3bc4bc97f Add copyright notice for James Laska 8 years ago
Ricardo Carrillo Cruz 682d97b765 Create subnet by domain
A cloud/domain admin should be able to create a subnet on any
project it is granted on.
This change adds the 'project' parameter that accepts either
a name (admin-only) or id.
8 years ago
Ricardo Carrillo Cruz eecceaef6e Add project parameter to os_network
A cloud/domain admin should be able to create a network on any project
it is granted to.
This changes adds the possibility to pass either a project ID or
project name.
8 years ago
Adrian Likins 2a7324a385 Update redhat_subscriptions 'server_insecure' docs (#3373)
'server_insecure' maps to the subscription-manager config
(/etc/rhsm/rhsm.conf) value for 'insecure' key in the
'server' stanza. The 'insecure' configures if the https connection
to 'server_hostname' is verified as having been issued by
a CA in 'ca_cert_dir' trust store.

Previous documentation indicating it disables https and
enables http was inaccurate. Connection to server_hostname
always uses https.
8 years ago
Robin Roth ee06cd27b2 use custom ismount function in mount module (#2737)
* based on cpython os.path.ismount
* includes patch from http://bugs.python.org/issue2466
* fixes #2186
* when the upstream bug is fixed this should be removed/rewritten
* use ismount from module_utils
8 years ago
hyperized 075edf7bb2 Add single_transaction and quick options to MySQL DB module (#3402) 8 years ago
Michael Scherer 8b125f8c2c Mark path as type='path', do not leak login_password by error (#3396) 8 years ago
Michael Scherer c0179330c9 Update the type of some arguments in mysql_db module (#3285)
login_password should not be logged, so mark it as 'no_log'
the others arguments are path to file, and so should be type='path',
which permit to remove the line handling '~' and shell variables.
8 years ago
Tom Paine 7422ada2c8 Update mysql_db.py
* Update mysql_db.py

Resubmission of https://github.com/ansible/ansible-modules-core/pull/2961 in single commit.

* Update mysql_db.py
8 years ago
Rene Moser aa32ae65a6 openstack: doc fix, add version_added
see #3388
8 years ago
Matt Martz c26c17aa28 overwrite option was added for 2.1 8 years ago
peter.jang f7fb5e31c2 added rsync protocol support (#1999)
* added rsync protocol support

* correction for example document(add example for push on delegate)

* use startswith method for safety
8 years ago
nitzmahone 64cd7903f2 fix win_user type checking
Fixed type checking to be more idiomatic powershell, also fixes a slew of StrictMode issues and gets error handling back to originally-intended behavior.
8 years ago
Toshio Kuratomi 40948cfcc4 git still needs to have abspath applied to dest 8 years ago
David Shrewsbury dcbbd72cfd Wrap calls to main() with if check
A change was merged to the main Ansible core code that can cause

a potential hang if any libraries are called that use threading.

This change was:

  4b0aa1214c

This affected the os_object module by causing a hang on the shade

create_object() API call (which in turn calls swiftclient which

uses threading). The fix is to make sure all modules have a main()

that is wrapped with an "if __name__ == '__main__'" check.
8 years ago
Peter Sprygada ef8b59f430 handles config replace properly in eos_template
fixes 3366
8 years ago
Michael Scherer 2ae3dbcc6a Set the locales to avoid issue with screenscrapping
See https://github.com/ansible/ansible-modules-core/pull/2462 for

details on why this could happen
8 years ago
Thomas Quinot a5ec00f89f Reset all locale environment variables before running svn commands
We screenscrape the output of svn(1), so better ensure it is using the

C locale.

Fixes #3255
8 years ago
Kalle Lehtonen 02f737cdee Fix and add more error handling for role policies
In case role policy was deleted, we did not handle at all if there

was authorization issue to do the deletion. Also add message when

role is not found and the policy is skipped.
8 years ago
Peter Sprygada 8210ede9b4 refactor iosxr_template module to remove old diff functions
this replaces the old diff functions with the netcfg shared module for
handling configuration diffs between running and candidate
8 years ago
Peter Sprygada bba38d2cf8 refactor iosxr_config module to remove old diff functions
this replaces the old diff functions with the netcfg lib for handling
configuration diffs between running and candidate configurations
8 years ago
Peter Sprygada c2c8d51ba2 cleanup iosxr_command module to be consistent with other network modules
this cleans up some of the function calls and output keys to be consistent
with other command modules
8 years ago
Ricardo Carrillo Cruz 1b5288b703 Only check default_project on resource creation
The default_project is checked at the beginning of the module.
This raises an exception if the project passed does not exist.
This logic only makes sense on resource creation, if a user
puts state=absent the module fails, even though the default
project is not relevant
8 years ago