Commit Graph

215 Commits (0415ac5cc3ef3afac05b0f73f279b64a694b0d96)

Author SHA1 Message Date
daveres 5d1e9c6acb Correct problem with changed:true
I have just changed a small piece of this module to avoid to return always that the task is changed
9 years ago
Brian Coca f2dbaa6b33 Merge pull request #1102 from bgeihsgt/win_webpicmd_fix
Fix #1101: win_webpicmd strict mode fixes
9 years ago
gfrank bc42aea3a3 Replace slashes in the parameter string
Also remove duplicate documentation
9 years ago
Adam Keech 42efef5682 Appending "Registry::" is not needed and no longer works. 9 years ago
Hans-Joachim Kliemeck a59f1f528e fix race condition and missing property 9 years ago
Hans-Joachim Kliemeck 5753a05625 fixxed problem with match @ 9 years ago
Brian Coca e738bf80ac Merge pull request #1123 from foretagsplatsen/documentation_win_iis_virtualdirectory
Adds examples for win_iis_virtualdirectory
9 years ago
Brian Coca 8a9d48a552 Merge pull request #1124 from foretagsplatsen/fix_application_in_win_iis_virtualdirectory
Fix: support for virtual directories in applications
9 years ago
Brian Coca be8aacf899 Merge pull request #1143 from smadam813/devel_win_nssm
win_nssm: strict fix + added dependencies,startmode,user/pw feature
9 years ago
Brian Coca 937b588b3f Merge pull request #1172 from nitzmahone/win_updates_strictmode_fix
Strict-Mode fixes
9 years ago
Brian Coca e5f2158312 Merge pull request #1108 from bgeihsgt/win_regedit_fix
Fix #1107: win_regedit parameter parsing and New-Item prompt error
9 years ago
Brian Coca 6d1dd42935 Merge pull request #1174 from trondhindenes/win_package_guidfix
Various improvements to win_package
9 years ago
Trond Hindenes f6ea32b9ec Various improvements to win_package 9 years ago
nitzmahone 8fa10acddf Strict-Mode fixes
Changes to missing member handling to support running top-level script under Strict-Mode v2 (as Ansible 2.0.0 does now)
9 years ago
James Cammarata 949b124e05 Merge pull request #1114 from blakfeld/fix_win_iis_webapppool
Made win_iis_webapppool Strict Compliant
9 years ago
Adam Keech 56e7d80479 Fixing Some Issues with out Parameters are passed around. Also some refactoring. 9 years ago
Adam Keech 9782f08a7d Merge remote-tracking branch 'h0nlg/devel_win_nssm' into devel_win_nssm 9 years ago
Hans-Joachim Kliemeck adc78eaf87 fixed documentation 9 years ago
Hans-Joachim Kliemeck d3f83ee9a7 added start mode feature 9 years ago
Hans-Joachim Kliemeck e7fd5dcde0 strict variables fix 9 years ago
Hans-Joachim Kliemeck 461a479cbd added dependency and user settings 9 years ago
Brian Coca 679e9fc7b4 Merge pull request #1100 from bgeihsgt/win_iis_absent_fix
Fix #1099: Only populate site result when it is there
9 years ago
Henrik Wallström c893f30b2a Fix: support for virtual directories in applications 9 years ago
Henrik Wallström 918f3fa329 Adds examples for win_iis_virtualdirectory 9 years ago
Toshio Kuratomi 632de528a0 Fix win_acl docs build 9 years ago
Corwin Brown ea430466a8 Made win_iis_webapppool Strict Compliant 9 years ago
Brian Coca 05f53f2b95 Merge pull request #200 from schwartzmx/module/win_acl
win_acl Module

talked to @cchurch, merging this for now, need to open ticket to address the 2008 issue
9 years ago
Brian Geihsler c6a934d57b Fix #1107: Prepend registry type on key path 9 years ago
Brian Geihsler d0e3a315ac Fix #1107: Use Get-Attr in win_regedit 9 years ago
Brian Geihsler 1e37276c97 Fix #1101: win_webpicmd strict mode fixes 9 years ago
Brian Geihsler 0e64863429 Fix #1099: Only populate site result when it is there 9 years ago
Brian Coca 561d768f44 Merge pull request #1076 from trondhindenes/win_package_bugfix
turned off strict msi code checking
9 years ago
Brian Coca a155f7ee34 Merge pull request #1071 from nlandais/devel
Adding fix to get around bug found with the New-Website command when…
9 years ago
Brian Coca cc69ac1513 Merge pull request #1064 from dreamcat4/feature/win_fw-hotfixes
hotfixes: module windows/win_firewall_rules
9 years ago
Trond Hindenes b9d842ecd6 turned out strict msi code checking 9 years ago
Nicolas Landais d1dcf8e06b Adding fix to get around bug found with the New-Webstire command when running playbook on a vanilla machine. 9 years ago
= 576b5e2fc3 Document module limitations to resolve https://github.com/ansible/ansible-modules-extras/issues/908 9 years ago
Dreamcat4 ece9c2b43a fix: Add 'enable:' flag for enabling existing rules which are disabled by default.
This is a very much needed flag. To turn on/off existing firewall rules. And like the recent fix of the 'Profile' key, the netsh cmd prints 'Enabled' in the textual output. (at least on win10 it does). So again a similar small code added for the necessary exception handling when the difference check happens.

Please merge / push upstream like the other fixes. Many thanks. This is the last fix I have put together for this patch set. So I will raise my PR now.

But if you want to fix more bugs, it seems there may be others. In terms of the control code. Sometimes it will delete a rule under 'force' condition (when found difference) - but instead it is supposed to just modify the existing rule. Some weird behaviour regarding that. The other problem is that ansible does not return the error text printed by 'netsh' cmd verbatim... but it should as that makes debugging these errors a *lot* easier.
9 years ago
Dreamcat4 dcaa794949 fix: update documentation with new module name "win_firewall_rule" 9 years ago
Dreamcat4 469d22df97 fix: The names of firewall profiles are different on win10 & win2008r2
Hi again. This commit removes a small portion of your script's own internal error checking. In specific: for the value of the profile: key. This is essential to avoid errors on other verisons of the windows operating system which are not win2008r2 (your version).

For example: on win10 (and most likely win8x too), the names of the profiles don't include the values 'current' and 'all'. But instead the values are 'Public' 'Private' 'Domain' and 'Any. But in addition, there are also certain combinatorial values, such as profile=Public,Private etc. Which is too many to error check yourself.

Yet removing the error checking here should not cause any ill effects however: since the netsh advfirewall ... cmds themselves to add / remove / modify actually to their own error checking of the profile=value. So when the cmd is run, it will error out itself with an appropriate / informative error msg. No harm done.

Therefore please remove the highlighed portions from your own script. It is essential for interoperability with win10 and win8x. Many thanks.
9 years ago
Dreamcat4 6c5a4a14ef fix: win10 - Add exception handling for 'Profiles:' textual output key name mismatch.
In win10 (and pribably win8x also):

The output of 'show rule' key includes the line "Profiles:<TAB>Public,Private".
Yet your script expects the key name printed out to be "Profile:<TAB>value".

This commit added the necessary exception handling to avoid flagging 'different=true' under the false circumstance. The key name to SET a firewall rule is still "profile=" and not "profiles=".

There is coming up another commit to fix the value handling for win10/win8. Which is another (different) error with the profile: key.
9 years ago
Dreamcat4 2654789af7 fix: fw rule names must always be quoted, to permit spaces ' ' and brackets '()'
Without this fix, the 'netsh' command gets name=Firewall Rule Name instead of name="Firewall Rule Name". Thus causing all sorts of havoc. Basic shell quoting rules seems to apply to Windows Powershell too. This is very much needed as many of windows 10's default firewall rules contain spaces and brackets () characters.
9 years ago
Brian Coca ebbd7748b1 doc formatting fixes 9 years ago
Brian Coca 02b68be09d Merge pull request #854 from nitzmahone/win_updates_rewrite
win_updates rewrite for 2.0
9 years ago
Trond Hindenes 7c48fe617d added module author 9 years ago
Trond Hindenes 161b3cf1e1 fixes #984 9 years ago
Toshio Kuratomi 255666a09d Fix doc build 9 years ago
Greg DeKoenigsberg 22a3ec05e4 Merge pull request #1022 from trondhindenes/trondhindenes_win_chocolatey_improvements
win_chocolatey bugfixes
9 years ago
Greg DeKoenigsberg 5931e60d99 Merge pull request #695 from georgefrank/win_nssm
Adding win_nssm module
9 years ago
Greg DeKoenigsberg ff0a38ea65 Merge pull request #665 from perzizzle/scheduledTask
Ability to add/remove scheduled task
9 years ago