Commit Graph

441 Commits (03d4805074cbd645826e427a00f2febe9cf55208)

Author SHA1 Message Date
gimoh d9f8fa56d8 Do not insert extra newline if line already contains it
When using YAML multi-line strings, e.g.:

- lineinfile:
    dest: /tmp/foo
    line: >
      foo
      bar

the line already ends with a newline.  If an extra newline is appended unconditionally it will lead to inserting an extra newline on each run.
10 years ago
blxd 2c520f31b3 Added check mode support to the ini_file module 10 years ago
Brian Coca dbd8ea1e7d fixed typo on isgid 10 years ago
Brian Coca 6e654f2442 fixed issues with stats return docs as per feedback 10 years ago
Brian Coca 13cdadcc4d removed always for success, as data wont show on fail 10 years ago
Brian Coca cbf42c95b2 draft for documenting module returns 10 years ago
mrsheepuk 410862d631 Doc change - make clearer usage for existing remote file
Having read the doc for this module several times and completely missing that it can be used for existing remote archives, I propose this update to the wording to make clear from the top the two ways in which this module can be used.
10 years ago
Gauvain Pocentek 6c1f40fea7 fetch: fix the flat parameter description
ansible-doc expects the value of the description field to be a list,
otherwise the output is not correct. This patch updates the flat
description to be a list.
10 years ago
Toshio Kuratomi 9e0959d600 Fix for recursion traceback in copy with relative paths
This is a further fix for: https://github.com/ansible/ansible/issues/9092

when the relative path contains a subdirectory.  Like:

ansible localhost -m copy -a 'src=/etc/group dest=foo/bar/'
10 years ago
Toshio Kuratomi 32e8595abf Merge pull request #790 from rhlmhrtr/file_documentation
Fixed Documentation issue concerning file mode
10 years ago
Rahul Mehrotra 98f869f345 Fixed Documentation issue concerning file mode when specified using numberical value 10 years ago
Toshio Kuratomi aa6c73f11b When recursing subdirectories, honor the follow parameter for setting file attributes.
One half of the fix for
https://github.com/ansible/ansible-modules-core/issues/778
The other half is in basic.py
10 years ago
Brian Coca f4dbcea30c Merge pull request #295 from techtonik/patch-3
acl: Fix X support in ACL permissions
10 years ago
Toshio Kuratomi 99a8caf409 Prefer gtar to tar
Fixes #702
10 years ago
sysadmin75 80a5500a23 Fix #10059 - replace module does not obey follow=yes 10 years ago
Toshio Kuratomi 9f333afb6a Standardize class names on Archive suffix.
This also removes the collision between the stdlib ZipFile class and the
module's ZipFile class

Fixes #681
10 years ago
Toshio Kuratomi e3759bd0d3 Add detection of uid,gid,mode changes when deciding whether an archive
needs to be unarchived again.
10 years ago
Toshio Kuratomi 6159b5c423 Implement user,group,mode,selinux settings for unarchive.
This is a partial fix for #234.  Still have to figure out how to
make change reporting work as we can no longer rely on tar's --compare
option
10 years ago
Brian Coca 78cacd0c22 fix for allowing permissions on hard links and soft links + follow=yes 10 years ago
Toshio Kuratomi 022e5274e6 Merge pull request #460 from jbinto/file_allow_touch_hardlink
Files module: Allow touch on hardlinks
10 years ago
Brian Coca 6237dab4cf fix for when state=directory, follow=yes and target is symlink to directory 10 years ago
Toshio Kuratomi c5f7fc93b2 Merge pull request #514 from jbradberry/issue9546
Fix breakage in lineinfile check mode when target file does not exist.
10 years ago
Jeff Bradberry 28375aae7f Fix breakage in lineinfile check mode when target file does not exist.
Similarly to https://github.com/ansible/ansible/issues/6182, checking of the file attributes should be avoided in check mode when the file didn't originally exist.

Also, avoid creating parent directories in check mode.

Fixes https://github.com/ansible/ansible/issues/9546
10 years ago
sysadmin75 0fee1132ad Fixes #9518 - "file state=directory" silently skips if it's currently a file 10 years ago
Brian Coca 242a1562c3 Merge pull request #36 from mscherer/fix_old_9092
Fix old ticket #9092 where a playbook can enter in recursion
10 years ago
Toshio Kuratomi 467ad65f73 Fix documentation formatting 10 years ago
Jesse Buchanan 2d5d7ff542 Files module: Allow touch on hardlinks 10 years ago
Piotr Gosławski a5b1a599e2 update docs for insertbefore/insertafter 10 years ago
follower 5c38ea8374 Note that `rsync` must be installed on both local & remote machine
In particular, if `rsync` is not installed on the remote machine the following error message will be encountered:

    "rsync error: remote command not found"
10 years ago
Brian Coca 4035d24313 Merge pull request #17 from cooniur/devel
Added support of returning owner's group name in stat module
10 years ago
Brian Coca e04ac864a5 Merge pull request #10 from techtonik/patch-1
files.stat: Expose path in returned result
10 years ago
Piotr Gosławski 3c8b4bd4b9 Fix behavior when insert* doesn't match anything
If insertbefore/insertafter didn't match anything, lineinfile module was doing nothing, instead of adding the line at end of fille as it's supposed to.
10 years ago
Eric 87dd3afc91 Fix lineinfile documentation typo 10 years ago
Toshio Kuratomi 19b328c4df Cannot readlink() on a hard link 10 years ago
Brian Coca ee39fd8df0 Merge pull request #124 from jonhadfield/remove-unused-creates
Remove redundant check for creates argument.
10 years ago
Brian Coca 4bc1e46de2 Merge pull request #24 from sysadmind/devel
Added note to files/synchronize module about synchronizing two directori...
10 years ago
Jeff Geerling b9471c9cd5 Add mention of fetch module to the copy module docs. 10 years ago
anatoly techtonik 4f2b99c1e0 acl: Fix X support in ACL permissions
If you try to set rwX permissions, ACL fails to set them at all.

Expected:

    $ sudo setfacl -m 'group::rwX' www
    ...
    drwxrwxr-x  2 root root  4096 Nov 10 17:09 www

With Ansible:

    acl: name=/var/www permissions=rwX etype=group state=present
    ...
    drwxrw-r-x  2 root root  4096 Nov 10 17:30 www

x for group is erased. =/
10 years ago
Toshio Kuratomi 6317d3a988 Move from md5 to sha1 to work on FIPS-140 enabled systems 10 years ago
Toshio Kuratomi 88b73afcbe Use original_basename to set the dest path even if src is not set 10 years ago
Ted Timmons fd68b77d37 fix spelling 10 years ago
Jon Hadfield 9e0565e58f Remove redundant check for creates argument. 10 years ago
Tadej Janež 661b452fe3 Simplified condition in a stat module example testing if path is a directory. 10 years ago
James Cammarata cb69744bce Adding file doc fragment to those modules in files/ missing it 10 years ago
Michael DeHaan 1c2995d71f Merge pull request #77 from major/suggest-selinux-enforcing
Updating SELinux example doc in lininefile module
10 years ago
Eric Hanchrow cc0a38d268 Tweak docs to mention `replace` 10 years ago
Major Hayden 6d697780f9 Updating SELinux example doc in lininefile module
Encouraging users to use this Ansible module to enable SELinux seems
like a better idea. It also warms Dan Walsh's heart.

Signed-off-by: Major Hayden <major@mhtx.net>
10 years ago
Michael Scherer 9cbd4d0fad Fix old ticket #9092 where a playbook can enter in recursion
This can be tested with this command :

    ansible -c local -m copy -a 'src=/etc/group dest=foo/' all

This is a corner case of the algorithm used to find how we should
copy recursively a folder, and this commit detect it and avoid it.

Check https://github.com/ansible/ansible/issues/9092 for the story
10 years ago
Joe Adams 2206d4b1e0 Added note to files/synchronize module about synchronizing two directories on the same host 10 years ago
Tongliang Liu e26cbb6ace Added support of returning owner's group name in stat module 10 years ago
anatoly techtonik 7f9305b24e files.stat: Expose path in returned result
This is needed to apply subsequent operation on tested path
10 years ago
Petros Moisiadis f7c498d059 synchronize: use a single -F instead of -FF
This small change corrects behavior when one uses an .rsync-filter file to exclude some paths from both being transferred and being deleted, so that these excluded paths can be handled separately with different tasks (e.g. in order to deploy the excluded paths independently from the rest paths and notify handlers appropriately). The problem with the double -FF option is that it excludes the .rsync-filter file from being transferred to the receiver. However, deletions are done on the side of the receiver, so it is absolutely necessary the .rsync-filter file to be transferred to the receiver, so that the receiver knows what files to delete and what not to delete.
10 years ago
Michael DeHaan 385a037cd6 package files 10 years ago
Michael DeHaan c8e1a2077e file extensions! 10 years ago
Michael DeHaan 417309a626 Restructuring. 10 years ago
Michael DeHaan 73123b69fa Move modules into subdirectory. 10 years ago
James Cammarata dea00c767b Merge branch 'dmage-devel' into devel 10 years ago
James Cammarata bb8bac490a Merge branch 'devel' of https://github.com/dmage/ansible into dmage-devel 10 years ago
Michael Scherer d15931f15a Make file module work on python 2.4, fix #9080
Python 2.4 do not support "except ... as ..." construct, so
revert back to the older syntax.
10 years ago
James Cammarata d98d76aeae Adding "follow" param for file/copy options
Also modifies the template action plugin to use this new param
when executing the file/copy modules for templating so that links
are preserved correctly.

Fixes #8998
10 years ago
Toshio Kuratomi 17665d962b Do not keep a new file if we fail to set its attributes. 10 years ago
James Cammarata ab5e8201f4 Fix quoting issues in lineinfile for individual single-quotes
Fixes #8806
10 years ago
Oleg Bulatov 583cfa45e5 Fix #7711
Fix relative symlinks creation in file module

Signed-off-by: Oleg Bulatov <oleg@bulatov.me>
10 years ago
James Cammarata 311c10c8e5 Docs updates to add examples for symbolic modes
Also fixes missing doc fragments missing in template and assemble
10 years ago
Brian Coca 8f3bb4ff20 now acl expands tildes 10 years ago
Michael DeHaan ef10c2dd9b Merge pull request #8441 from willthames/unarchive_dest_fix
Unarchive should work when parent directory is not writable
10 years ago
James Cammarata 005ca0e5ec Merge branch 'relative-path-fix' of https://github.com/major/ansible into major-relative-path-fix 10 years ago
Major Hayden 97d6807ec5 File module cannot create relative paths
When trying to create a directory relative to the current working
directory, a directory is created at the root of the filesystem
instead.  This patch ensures that directories specified with relative
paths will be created in the current working directory.  Fully
qualified paths aren't affected

Signed-off-by: Major Hayden <major@mhtx.net>
10 years ago
James Cammarata 0b35433654 Fix check mode issues with copy module
Fixes #8639
10 years ago
James Cammarata 989b14de80 Add option to disable ControlPath to ssh options during rsync
Fixes #8473
10 years ago
James Cammarata 6d4b429488 Update docs for copy directory_mode param per #8572 10 years ago
Michael DeHaan ed0751984c Copy recursion works when source is a parameter, there is no parameter 'recurse' here. 10 years ago
James Cammarata 3f052ead3a Make sure we only use unquote on quoted lines in lineinfile when needed 10 years ago
James Cammarata 6c9371ea90 Unquote lines that were quoted for safety during eval in lineinfile
Fixes #8535
10 years ago
Piffey Parlance c987dbcb67 Issue 8502: Fixed bug where failed when permissions weren't specified. 10 years ago
Michael DeHaan 60ce2d3853 Fix documentation builds. 10 years ago
Michael DeHaan 185d5a6221 Merge branch 'spelling' of git://github.com/cgar/ansible into devel
Conflicts:
	docsite/rst/guide_rax.rst
	plugins/callbacks/mail.py
10 years ago
Michael DeHaan 0591d3dfbf Merge pull request #7312 from bcoca/unarchive_docs
reworded copy option docs
10 years ago
Will Thames de16785b8c Unarchive should work when parent directory is not writable
Correct unarchive so that the checks for writeability are
sensible.

Added a test for when parent directory is not writable
10 years ago
Michael DeHaan f0ae6204e4 Merge pull request #8455 from nicocesar/version_check
if python >=2.7  use the option allow_no_value=True for ini_file.
10 years ago
Michael DeHaan f228e0bff4 Some stray doc tweaks with file modules. 10 years ago
Michael DeHaan d78e16ff36 Move doc fragments back into file module. 10 years ago
Nico Cesar 31b34906d0 if python >=2.7 use the option allow_no_value=True for ini_file. 10 years ago
Michael DeHaan 04568cd767 Revert ""allow_no_value=True" for ini_file module so /etc/my.cnf can be read without a problem"
This reverts commit cbdc9f1153.

Code needs to make allowances for particular python versions and try/except
around this block.
10 years ago
Michael DeHaan c05a5eba58 Add version_added attribute for regexp parameter. 10 years ago
Nico Cesar eeabda4831 "allow_no_value=True" for ini_file module so /etc/my.cnf can be read without a problem 10 years ago
RomanDolejsi 7cd6d6fb89 file: prevent replace failure when overwriting empty directory with hard/link (force=yes) 10 years ago
Michael DeHaan 03c46f016a Update unarchive example. 10 years ago
Michael DeHaan 0697bbd6dd Merge pull request #8200 from geetotes/devel
[Docs] Added another example to demonstrate unarchive module working entirely on a remote machine
10 years ago
Michael DeHaan 0221727050 Merge pull request #7968 from bcoca/acl_fix_compare
acl module: now compares permissions correctly
10 years ago
Lee Gillentine 7cdeddb740 Pushing up correct example :( 10 years ago
anatoly techtonik fdc355d376 acl: Remove obscurity in `state` description 10 years ago
Lee Gillentine 1b742ca567 Adding another example to demonstrate unarchive working entirely on a remote machine 10 years ago
James Cammarata de3133682e Merge pull request #8126 from dingus9/patch-1
Update lineinfile validate help
10 years ago
Michael DeHaan 1b48465106 Slight typo fix. 10 years ago
Nick Shobe e553e24d0a Update lineinfile 10 years ago
Henry Finucane 9fd91bec5d Make 'compress' optional 10 years ago
Andreas Fleig 3c4dbd61fc ini_file: replace lambda with named function
Fixes #6876
10 years ago
Brian Coca 030ac743a4 now compares permissions correctly 11 years ago
James Cammarata 68295b05b4 Merge branch 'fix_lineinfile_newlines' into devel 11 years ago