Commit Graph

6508 Commits (03300e99ac35fbf12beae4c85b8fec058dcd97b5)

Author SHA1 Message Date
James Cammarata 9d61a6cba8 Fixing PlayIterator bugs
* Unit tests exposed a problem where nested blocks did not correctly
  hit rescue/always portions of parent blocks
* Cleaned up logic in PlayIterator
* Unfortunately fixing the above exposed a potential problem in the
  block integration tests, where a failure in an "always" section may
  always lead to a failed state and the termination of execution
  beyond that point, so certain parts of the block integration test
  were disabled.
8 years ago
Brian Coca d7bd5fc075 Merge pull request #14824 from bcoca/ansible_shell
draft 1st release of ansible shell
8 years ago
Brian Coca 7067bb32b8 make all conditionals lists
this brings them to equivalence with when:
fixes #13905
8 years ago
Matt Clay 33f93f9241 Fix misplaced paren. 8 years ago
Brian Coca 33b550fc76 paging for amazon modules
this adds a decorator for use in amazon modules so retrieval functions
can page using the 'marker' that most boto functions return
8 years ago
James Cammarata aee2eb6287 Merge pull request #14864 from dagwieers/patch-12
Only show diff when the task actually induced a change
8 years ago
James Cammarata 1a5ee115f0 Fixing minor logic error in error detection/handling in ssh connection plugin
If max retries were reached, no AnsibleConnectionFailure was raised, which
means potentially in some cases an unreachable error might not be returned
8 years ago
Dag Wieers f5b6f52940 Only show diff when the task actually induced a change
This implements solution #1 in the proposal #14860.

It only shows the diff if the task induced a change, which means that if the changed_when control overrides the task, not diff will be produced.
See #14860 for a rationale and the use-case.
8 years ago
Dag Wieers 175351f200 Little improvement in flow
Don't get the hostname if it's not needed.
8 years ago
Brian Coca 49bb4803b5 clarify --step prompt
now shows full words and indicates default
fixes #7433
8 years ago
Brian Coca 3d6ec52e83 Merge pull request #14830 from bcoca/assemble_fix
fix assemble to not pass extra args to copy/file
8 years ago
Brian Coca eb4cb46c84 Merge pull request #14859 from sivel/issue/14858
Strip proc_1 before testing it. Fixes #14858
8 years ago
Matt Martz 2f90a4f4e2 Strip proc_1 before testing it. Fixes #14858 8 years ago
Brian Coca e24e619cf1 added stderr from vault script to error 8 years ago
Brian Coca 75ae62a978 Merge pull request #12674 from sudarkoff/fail_if_executable_password_file_returns_nonzero
(TRIVIAL) Fail if the vault password script returns non-zero.
8 years ago
Brian Coca e74ab3ecdd draft 1st release of ansible-console
porting @dominis 's ansible-shell tool from 1.9 and integrating it into ansible
added verbosity control
made more resilitent to several errors
added highlight color, to configurable colors
more resilient on exception and interruptions
prompt coloring, goes red and changes to # when using become = true and root
become setting is now explicit and not a toggle
8 years ago
Matt Martz 53bb889ef6 update submodule refs 8 years ago
Matt Martz 098333b2ec Fix redirects for get_url
* fetch_url shouldn't both accept follow_redirects and support follow_redircts via module.params
* Default follow_redirects for open_url should be 'urllib2'
* Add redirect test for get_url
8 years ago
Brian Coca 325fccfa78 added v for least verbose display function 8 years ago
James Cammarata 299d93f6e9 Updating unit tests for PlayIterator
This knowingly introduces a broken test, planning to fix that later.
8 years ago
Brian Coca 66ea464ebd Merge pull request #14793 from xiaket/devel
remove main_q for simplicity.
8 years ago
Brian Coca 25e9b5788b add per item diff handling
fixes #14843
8 years ago
John Barker 8b4ebd8e4a Make it easier to read error message 8 years ago
Brian Coca 0b2f631197 Merge pull request #14504 from bcoca/template_comments
template also when only comments present
8 years ago
Brian Coca 7d8b84dae6 fix assemble to not pass extra args to copy/file
also small refactor to dedupe code
fixes https://github.com/ansible/ansible-modules-core/issues/3154
8 years ago
Brian Coca 5aab158987 removed unused imports 8 years ago
Peter Sprygada c0f1e1801b adds multiline flag to regex test for search and match
This commit adds the multiline flag to the regexp search and match test
plugin.  It defaults to re.M = False for backwards compatibility.  To use
the multiline feature add multiline=True to the test filter

{{ config | search('^hostname', multiline=True) }}
8 years ago
Brian Coca 66a9a1feff Merge pull request #14823 from jjahns/devel
add find_vm_by_name function to vmware utils
8 years ago
Brian Coca 75b9c7db14 moved hardcoded settings from doccli to constants 8 years ago
Jay Jahns 3a1944edc1 add find_vm_by_name function to vmware utils 8 years ago
Kishin Yagami 299c18d700 Support strategy_plugins setting in a configuration file 8 years ago
Brian Coca 62ac5c047e clarified message 8 years ago
Brian Coca 8867d73420 reject extraneous data passed to mode
strictly permissions are allowed, file type info should not be passed in
alternate fixes #14771
8 years ago
Toshio Kuratomi bd618c3490 Merge pull request #14797 from mattclay/unicode-fixes
Use to_bytes on filenames in filesystem calls.
8 years ago
Brian Coca d6546a7513 make sure group_names is always sorted
this makes it consistent with previous ansilbe versions and other
paths that create the group_names variable
8 years ago
Matt Clay 5b79ed77e7 Use to_bytes on filenames in filesystem calls. 8 years ago
Brian Coca 27a33a6f18 dont erase previous nameservers in fact gathering
fixes #14806
8 years ago
夏恺(Xia Kai) b33074b703 remove main_q for simplicity.
main_q is not used anywhere in the codebase.

It is created in TaskQueueManager._initialize_processes, bundled with rslt_q
into TaskQueueManger._workers, later unwrapped in StrategyBase but not used.
This queue is closed in TaskQueueManger._cleanup_processes.

Historically, it is passed as a init parameter into WorkerProcess,
introduced in 62d7956, but this behavior is changed in 120b9a7.

Signed-off-by: 夏恺(Xia Kai) <xiaket@gmail.com>
8 years ago
Toshio Kuratomi 8f1303c81a Remember to use errors=strict since this is looking up a filename on the filesystem (ie it has to match exactly) 8 years ago
Toshio Kuratomi 253376b3b7 Make the source path into a byte string before passing to os.path 8 years ago
Brian Coca e762095497 better task parsing errors
fixes #14790
8 years ago
Brian Coca f565508d7f Merge pull request #14764 from bcoca/max_diff_config
made max diff size configurable
8 years ago
Brian Coca e432973310 Merge pull request #14757 from bcoca/register_no_template
don't template register
8 years ago
Brian Coca 13282e29a8 Merge pull request #14500 from yfried-redhat/fix_os_auth
Fix openstack auth type
8 years ago
Brian Coca b901b15d3b Merge pull request #14537 from Yannig/devel_better_error_handling
Improve message content to get more hint about the raised error.
8 years ago
Brian Coca cc3cb0f65e fix issues with older yaml lib versions
also added missing json import and removed unused ones
8 years ago
Brian Coca 6cad356b3b updated docs to show new output 8 years ago
Brian Coca b2a6784a9f changed the output to keep backwards compat
still shows path when verbose
8 years ago
Brian Coca fd8593d613 Merge pull request #14661 from jjshoe/fix-up-profile-tasks
Update the profile task callback plugin to include a fix for duplicate named tasks. Added additional features to adjust the number of tasks output and the sort order.
8 years ago
Brian Coca c022a43a47 fixed str to to_str 8 years ago
Brian Coca 347aa7b032 Merge pull request #14774 from lamby/ignore-epipe-when-flushing-stdout-stderr
Ignore EPIPE when flushing stdout stderr
8 years ago
Chris Lamb eb1141ee79 Ignore EPIPE to avoid tracebacks when piping output to other commands
For example:

  $ ansible web --list-hosts | head -n1
  hosts (7):
  ERROR! Unexpected Exception: [Errno 32] Broken pipe
  Traceback (most recent call last):
    File "/home/lamby/git/private/lamby-ansible2/.venv/bin/ansible", line 114, in <module>
      display.display("to see the full traceback, use -vvv")
    File "/home/lamby/git/private/lamby-ansible2/.venv/local/lib/python2.7/site-packages/ansible/utils/display.py", line 133, in display
      sys.stdout.flush()
  IOError: [Errno 32] Broken pipe

Such a pipe target will close up shop early when its seen enough input,
causing ansible to print an ugly traceback.

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
8 years ago
Chris Lamb 951c8a5d27 Alias fileobj. 8 years ago
Brian Coca 4cfd042839 more complete and informative errors
mostly templating issues now all return data templated and actual error
fixes #14781
8 years ago
Brian Coca 0031a72e0d tweak deprecation warnings display 8 years ago
Brian Coca ea5e089056 restore initial json parsing attempt to loader
fixes issues with extra vars json strings not being parsed correctly by the yaml parser
8 years ago
Toshio Kuratomi 4657be4eab Transform pathnames to bytes before passing on to os.path functions 8 years ago
Toshio Kuratomi 468eea82bd Merge pull request #14765 from sivel/redirect-ssl-validation
Support SSL validation with redirect control for python versions without ssl context
8 years ago
Matt Davis 0ab29f573a Merge pull request #14755 from bcoca/pause_nohup_fix
avoid issues when stdin is a closed file
8 years ago
Matt Martz 6ff0b079b4 Support SSL validation with redirect control for python versions without ssl context 8 years ago
Brian Coca c24249c57d made max diff size configurable 8 years ago
Toshio Kuratomi 1dbbd2a80c Remove debugging and fix the place where bytes are being handed to StringIO 8 years ago
Brian Coca ca0797fc4e avoid issues when stdin is a closed file
this seems to happen when nohup is involved, so the check tty
does not get a chance to fail, it just works with pipes

fixes http://github.com/ansible/ansible-modules-core/issues/3166
8 years ago
Toshio Kuratomi 093b3422ec more information 8 years ago
Brian Coca 7ba790bbaf don't tempalte register 8 years ago
Toshio Kuratomi 5aef65edcd Testing whether this fixes jenkins 8 years ago
James Cammarata 3247390123 Conditionally import StringIO in template so we only use io.StringIO on py3 8 years ago
James Cammarata 2c7a33f71d Fixing bug in setup related to StringIO fixes 8 years ago
James Cammarata 9acb5aa176 Changing location of reduce import to not use six.moves 8 years ago
James Cammarata b559d0e6ee Adding py3 stub for reduce from six.moves 8 years ago
Brian Coca 71402abf21 only do squash when 'squashable field' present 8 years ago
James Cammarata e011f52557 Expanding unit tests for module_utils/basic.py 8 years ago
Brian Coca 7af5787030 Merge pull request #14717 from xiaket/devel
Fix __repr__ for meta tasks
8 years ago
Brian Coca dd003a42b0 Merge pull request #14273 from resmo/for-ansible-2.1
[2.1] cloudstack: new generic code
8 years ago
Rene Moser 6c641fb6a8 cloudstack: add CS_HYPERVISORS constant 8 years ago
夏恺(Xia Kai) d033c40e80 Make task repr really work for meta tasks.
Signed-off-by: 夏恺(Xia Kai) <xiaket@xiaket@gmail.com>
8 years ago
Brian Coca 0d1138e0a0 Merge pull request #14712 from chouseknecht/galaxy2_paging
Fix bug 14715: Galaxy CLI paging error
8 years ago
chouseknecht 42b2077c93 Fix bug 14715: Galaxy CLI paging error 8 years ago
Peter Sprygada c2ce509aaf bugfixes for openswitch shared module
This commit fixes two bugs in the openswitch shared module.  The first
bug was a wrong argument type for the use_ssl argument.  It was set
to int and should be bool.  The second changes the default ports for http
(was 80, now 8091) and https (was 443, now 18091).  This change aligns
the default port values with the OS
8 years ago
nitzmahone 915037c628 update submodule refs 8 years ago
nitzmahone ac54f66741 don't lock file when calculating checksum 8 years ago
Brian Coca badc922c73 added warning for when host file doesn't exist
fixes #14692
8 years ago
Brian Coca 82d6a83cca Merge pull request #14633 from Etherdaemon/fix_boto3_params
Fixup boto3_conn aws_session_token and verify
8 years ago
Brian Coca 157ebcfe0b Merge pull request #14709 from bcoca/squash_fix_atp
added package to special 'squashable' fields
8 years ago
Brian Coca 67d5b77898 added package to special 'squashable' fields
apt has it as alias, this should fix https://github.com/ansible/ansible-modules-core/issues/3145
8 years ago
James Cammarata 7c049c3200 Fixing up jsonify and adding unit tests 8 years ago
Matt Martz d0a717694f Fix variable name in paramiko connection plugin 8 years ago
Matt Martz e27eb73cba sys.subversion unavailable in py24. Fixes #14704 8 years ago
Peter Sprygada f67bf3f775 updates the ops_template plugin action backup key
This commit changes the key the ops_template will search for in order
to backup the current configuration to local disk on the Ansible control
host.  This change was made to make ops_template consistent with the
other network template modules.
8 years ago
Toshio Kuratomi e01b6ad6b4 We are actually taking the repr of a string so we need separate to_bytes and repr calls 8 years ago
Toshio Kuratomi b70bf3b056 Use io.StringIO and io.BytesIO instead of StringIO.StringIO for compat with py3 8 years ago
Toshio Kuratomi c29f51804b Fix mixing of bytes and str in module replacer (caused traceback on python3) 8 years ago
Brian Coca 512d3dd621 with_ loops always should want a list 8 years ago
Brian Coca 528f073bfa update core subref 8 years ago
Toshio Kuratomi 1f2595306a normalize path components to unicode before combining or operating on them
Note that this will break if we deal with non-utf8 paths.  Fixing this
way because converting everythig to byte strings instead is a very
invasive task so it should be done as a specific feature to provide
support for non-utf8 paths at some point in the future (if needed).
8 years ago
Toshio Kuratomi ef8bec18bf Use a unicode format string so that we don't convert to byte strings
Fixes #14349
8 years ago
Brian Coca ad5a6e7993 updated submodule refs 8 years ago
James Cammarata 771f1e31a9 Rework the way ad-hoc filters inventory to match how cli/playbook does it 8 years ago
Brian Coca e2d2798a42 hosts can be list or string 8 years ago
Brian Coca 2d56293768 default play name to hosts entry
return to previous behaviour as now the name was left blank
8 years ago