ansible

Commit Graph

Author	SHA1	Message	Date
Wong Hoi Sing Edison	016b7f71b1	ansible-galaxy - support `resolvelib >= 0.5.3, < 1.1.0` (#80196 ) * ansible-galaxy - support `resolvelib >= 0.5.3, < 1.1.0` <https://pypi.org/project/resolvelib/1.0.1> released on 2023-03-09: - <https://github.com/sarugaku/resolvelib/blob/main/CHANGELOG.rst#101-2023-03-09> - <https://github.com/sarugaku/resolvelib/releases/tag/1.0.1> Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com> * Trigger CI by pinning resolvelib with latest version Since resolvelib is pre-installed in our test containers, we should temporarily pin the latest version allowed to force the tests to run with that version. Once the tests have passed that commit can be reverted. Please make those changes without force pushing, so that we keep the reference to the passing CI run. We can squash the commits when merging the PR so the temporary commits won't be in the final commit merged to the devel branch. Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com> * https://github.com/ansible/ansible/pull/80196#discussion_r1136003637 Also test resolvelib with multiple supported versions. Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com> * Revert "Trigger CI by pinning resolvelib with latest version" This reverts commit `5518e5dbca`. --------- Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>	1 year ago
Wong Hoi Sing Edison	b148fd8dd7	ansible-galaxy - support ``resolvelib >= 0.5.3, < 0.10.0`` (#79399 ) * Upgrade `resolvelib >= 0.5.3, < 0.10.0` https://pypi.org/project/resolvelib/0.9.0/ released on 2022-11-17: * https://github.com/sarugaku/resolvelib/blob/master/CHANGELOG.rst#090-2022-11-17 * https://github.com/sarugaku/resolvelib/releases/tag/0.9.0 Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>	2 years ago
Sloane Hertel	41b62f7db4	Limit Galaxy API calls during ansible-galaxy dependency resolution (#77468 ) * Limit Galaxy API calls during ansible-galaxy collection dependency resolution when possible Installing a tarfile with a dependency from a Galaxy server (e.g. dependencies: {'ns.coll': '>=1.0.0'}) does not get the available versions of the dependency from the galaxy server if a sufficient version is already installed. Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>	2 years ago
Sloane Hertel	143e7fb45e	ansible-galaxy - support resolvelib versions >= 0.5.3, < 0.9.0 (#77649 ) * ansible-galaxy - support resolvelib versions >= 0.5.3, <= 0.8.1 Test incompatibilities are removed for resolvelib >= 0.6.0 Test against the latest 0.8.x version and fix requirements * Fix tests - use a venv for testing the range of resolvelib versions * Update temporary hardcoded fallback for ansible-test * Update hardcoded upperbound for sanity tests * Make error check more flexible	2 years ago
Sloane Hertel	82f3a57bee	Fix ansible-galaxy traceback when unexpected version of resolvelib is installed (#77630 ) * Fix traceback when a supported version of resolvelib is not installed Try to read the supported version range from the package distribution info and fall back to a hardcoded lowerbound/upperbound (>=0.5.3,<0.6.0). * Add tests for unsupported resolvelib versions * Resolve remaining import sanity test issues. Co-authored-by: Matt Clay <matt@mystile.com> Co-authored-by: Matt Martz <matt@sivel.net>	2 years ago
Matt Clay	cc5ac88c4c	Update mypy test. Fix type hints for Python 3.9. This also bumps the minimum controller version (for mypy only) to Python 3.9.	2 years ago
Matt Clay	0c4c18bc04	Type hint fixes.	2 years ago
Matt Clay	8b2e628565	galaxy - Clean up type hints and imports.	2 years ago
Sloane Hertel	43e55db208	ansible-galaxy - add signature verification of the MANIFEST.json (#76681 ) * ansible-galaxy collection install\|verify: - Support verifying the origin of the MANIFEST.json when the Galaxy server has provided signatures. - Allow supplemental signatures to use during verification on the CLI/requirements file. * ansible-galaxy collection install: - Support disabling signature verification. This silences the warning provided by ansible-galaxy if the Galaxy server provided signatures it cannot use because no keyring is configured. - Store Galaxy server metadata alongside installed collections for provenance. This is used by 'ansible-galaxy collection verify --offline'. * Add unit tests for method that gets signatures from a Galaxy server * Add integration tests for user-provided signature sources - Test CLI option combinations - Test installing collections with valid/invalid signature sources - Test disabling GPG verification when installing collections - Test verifying collections with valid/invalid signature sources * Make signature verification advisory-by-default if signatures are provided by the Galaxy server - Make the default keyring None - Warn if the keyring is None but the Galaxy server provided signatures - Error if the keyring is None but the user supplied signatures - Error if the keyring is not None but is invalid * changelog * add ansible-galaxy user documentation for new options Co-authored-by: Matt Martz <matt@sivel.net> Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua> Co-authored-by: Martin Krizek <martin.krizek@gmail.com> Co-authored-by: Sandra McCann <samccann@redhat.com> Co-authored-by: Andy Mott <amott@redhat.com> Co-authored-by: John R Barker <john@johnrbarker.com>	2 years ago
Sloane Hertel	15ace5a854	ansible-galaxy - validate version for directories and collections in git repos (#76579 ) * Ensure the version is valid for directories and collections in git repos before installing Fix the error message for invalid semantic versions * Make requested changes * Add a test case for unhandled ValueError exception * Add changelog * Update lib/ansible/galaxy/collection/galaxy_api_proxy.py Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua> * Reword error message Include link to learn how to compose a semver version * Move version validation into the caller, find_matches * Add tests for more invalid version types * Remove unused import Fix raising unexpected error * Update lib/ansible/galaxy/collection/__init__.py Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua> * Update lib/ansible/galaxy/dependency_resolution/providers.py Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua> * Update lib/ansible/galaxy/dependency_resolution/providers.py Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua> Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>	2 years ago
Sloane Hertel	9759e0ca49	add option to upgrade collections (#73336 ) * Add a flag to ansible-galaxy to update collections Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>	3 years ago
Sviatoslav Sydorenko	6f4b4c345b	Match user-requested transitive pre-releases in collection dependency resolver (#73416 ) * Add direct+transitive pre-release regression test * Match user-requested transitive pre-releases This change makes sure that in scenario when a user requests collectionA-pre and collectionB that depends on collectionA, collectionA-pre would actually match that collectionA requirement while `--pre` is unset. Co-authored-by: Jordan Borean <jborean93@gmail.com>	3 years ago
Sviatoslav Sydorenko	595413d113	Replace the inhouse collection dependency resolver with `resolvelib` PR #72591 This change: * Adds an artifacts manager that abstracts away extracting the metadata from artifacts, downloading and caching them in a temporary location. * Adds `resolvelib` to direct ansible-core dependencies[0]. * Implements a `resolvelib`-based dependency resolver for `collection` subcommands that replaces the legacy in-house code. This is a dependency resolution library that pip 20.3+ uses by default. It's now integrated for use for the collection dependency resolution in ansible-galaxy CLI. * Refactors of the `ansible-galaxy collection` CLI. In particular, it: - reimplements most of the `download`, `install`, `list` and `verify` subcommands from scratch; - reuses helper bits previously moved out into external modules; - replaces the old in-house resolver with a more clear implementation based on the resolvelib library[0][1][2]. * Adds a multi Galaxy API proxy layer that abstracts accessing the version and dependencies via API or local artifacts manager. * Makes `GalaxyAPI` instances sortable. * Adds string representation methods to `GalaxyAPI`. * Adds dev representation to `GalaxyAPI`. * Removes unnecessary integration and unit tests. * Aligns the tests with the new expectations. * Adds more tests, integration ones in particular. [0]: https://pypi.org/p/resolvelib [1]: https://github.com/sarugaku/resolvelib [2]: https://pradyunsg.me/blog/2020/03/27/pip-resolver-testing Co-Authored-By: Jordan Borean <jborean93@gmail.com> Co-Authored-By: Matt Clay <matt@mystile.com> Co-Authored-By: Sam Doran <sdoran@redhat.com> Co-Authored-By: Sloane Hertel <shertel@redhat.com> Co-Authored-By: Sviatoslav Sydorenko <webknjaz@redhat.com> Signed-Off-By: Sviatoslav Sydorenko <webknjaz@redhat.com>	3 years ago

13 Commits (016b7f71b10539c90ddbb3246f19f9cbf0e65428)