Matt Clay
262c341cda
Add connection tests for winrm connection plugin.
...
These are the same tests used for the other connection plugins,
adapted to use winrm modules and Windows friendly paths.
10 years ago
Brian Coca
e1461ef792
Merge pull request #15200 from wimnat/feature/handle_lists_in_snake_dict_creation
...
Handle lists during dict recursion
10 years ago
René Moser
c0618794a2
Merge pull request #15213 from resmo/fix/cloudstack-api-secret-arg
...
cloudstack: fix bug, api_secret always None
10 years ago
Matt Clay
83e53cbb91
Add to_bytes to file paths for accelerate plugin.
10 years ago
James Cammarata
a8dbd3dee9
Pass the variable manager into load_list_of_blocks for include files
...
Fixes #15194
10 years ago
Brian Coca
4b3257c4fe
Merge pull request #15208 from bcoca/constants_pathlist
...
centralize path list handling
10 years ago
Brian Coca
5dfc013e18
Merge pull request #14971 from bcoca/clear_facts
...
meta: clear_facts
10 years ago
Brian Coca
5022fe9adc
Merge pull request #15209 from temal-/devel
...
Add '--skip-tags' to ansible-pull
10 years ago
Rene Moser
65e61e340a
cloudstack: fix bug, api_secret always None
...
In case if api args are used, api_secret is None in every cloudstack module.
10 years ago
Nathaniel Case
e4e913b331
Override params from environment variables, if set.
...
Fix a typo while I'm in the area.
Handle having None set in module.params more intelligently
10 years ago
James Cammarata
eab4ce19f3
Making the return parsing in ActionBase generic for reuse
...
Now also correctly parses the return value for the _low_level_execute_command
10 years ago
James Cammarata
4fc0aadd84
Only combine vars in include_vars if both are mappings
...
Fixes #15184
10 years ago
Brian Coca
c09e085480
Merge pull request #14735 from jsok/open_url-netrc
...
Lookup netrc for credentials in open_url
10 years ago
Malte Krupa
3c954e6572
Add '--skip-tags' to ansible-pull
10 years ago
Brian Coca
92d154f4ef
centralize path list handling
...
move it to constants and avoid duplicating code or misinforming
developers on the nature of the data
10 years ago
Brian Coca
3f6166d2bf
always return rc
10 years ago
Rob White
a46de20772
Handle lists during dict recursion
10 years ago
Peter Sprygada
fa6464e807
feature to localize prompt search logic for ios shared module
...
Prompt search logic is now localized to the ios shared module instead
of using the common regexps in the shell module. This resolves a number
of problems with ios modules functioning properly
10 years ago
James Cammarata
2be1726350
Don't remove _raw_params from static include args
10 years ago
nitzmahone
05af5c88ea
fix Mac chown/chmod -R issue, add error checks
...
The changes to chown/chmod were broken on Mac (-R was being appended to the end of the command- OSX requires it before the file list).
A number of base action remote setup commands were also blindly proceeding without checking for success. Added error raises for unrecoverable failure cases.
10 years ago
James Cammarata
f2713f764c
Take previous jinja2 blocks into account in splitter when we see quotes
...
Previously, split_args() was not taking print/block/comment depth into account
when splitting things, meaning that if there was a quote character inside an
un-quoted variable (ie. {{ foo | some_filter(' ') }}), it was incorrectly
splitting on the quotes instead of continuing to append to the previous param.
Fixes #13630
10 years ago
Brian Coca
04610106a3
Merge pull request #15173 from mattclay/issue6072
...
Support remote_user in jail connection plugin.
10 years ago
Brian Coca
e9a4526251
allow bypassing executable setting
...
if you set executable to an empty string this avoids passing one to the command constructor
fixes #14813
10 years ago
Rob White
a5b05922ed
Some helper functions to work with boto3
10 years ago
Brian Coca
c303ed24b5
Merge pull request #15159 from sigio/filter-ip4-hex
...
Add ip4_hex filter to convert ip-address to hex notation
10 years ago
Brian Coca
b77bba8f9f
Merge pull request #15175 from wimnat/feature/camel_case_fixing
...
Add function to convert CamelCased key names to snake_names
10 years ago
Brian Coca
363384f517
Merge pull request #15174 from mattclay/conn-msg-host
...
Fix inconsistent/missing host names in messages.
10 years ago
David Wittman
5036d1742c
Fix boolean choices in module docs fragments
...
A few of the docs fragments have the available choices for some params
defined as "BOOLEANS". Because choices accepts a list, it treats
"BOOLEANS" as an iterable and then generates a list composed of each
letter.
Instead, define the available choices as a list of `['yes', 'no']`,
as is common in most other modules.
10 years ago
Toshio Kuratomi
0fffb6c60c
Merge pull request #15163 from ansible/synchronize-connection-vs-play_context
...
Use _connection instead of _play_context for information about the connection
10 years ago
Brian Coca
c6c3fd79c2
Merge pull request #15168 from bcoca/script_exists_fix
...
Script exists fix
10 years ago
Rob White
ef8c1124d0
Add function to convert CamelCased key names to snake_names
10 years ago
James Cammarata
eff89d6290
Merge pull request #15140 from berlic/args-splitter-exception-context
...
Show error context in args splitter exception
10 years ago
Matt Clay
5fdc29e00f
Fix inconsistent/missing host names in messages.
10 years ago
Matt Clay
b60062bdf9
Support remote_user in jail connection plugin.
...
Resolves #6072 .
10 years ago
Brian Coca
28d20dbe53
moved 'path exists' function to shell
...
now it will work with powershell/winrm
10 years ago
Toshio Kuratomi
0cabd133ba
have to always run dwim() on the path to get the full absolute path.
...
Fixes #14944
10 years ago
Toshio Kuratomi
e2f5762232
Use _connection instead of _play_context for information about the connection
...
If we're not delegating then we change _connection into a local
connection midway through the file but we don't change
_play_context.connection (no need to alter that). When we later check
it in process_remote() we need to know the actual connection, not the
connection that we thought we were going to use at the start of run().
So we have to use _connection.transport in process_remote(). The rest
of the places could use either one (because we have not yet changed to
a local connection) but we go ahead and switch those to
_connection.transport as well to avoid confusion in the future.
Fixes https://github.com/ansible/ansible-modules-core/issues/3136
10 years ago
James Cammarata
f4eb9aac24
Fix --start-at-task which was broken by the setup task revamp
...
Fixes #15010
10 years ago
Toshio Kuratomi
2adf8f7ec9
Update submodule refs
10 years ago
Mark Janssen -- Sig-I/O Automatisering
b1015d897d
Re-add accidentaly removed comment
10 years ago
Mark Janssen -- Sig-I/O Automatisering
73766e0816
Add ip4_hex filter to convert ip-address to hex notation
10 years ago
Matt Davis
afc82f6beb
Merge pull request #14930 from mholiv/enable_dollar_as_first_char_in_folder_and_userName
...
Modified files to use single quotes rather than double for file path.…
10 years ago
Toshio Kuratomi
3221be4340
Reverse boilerplate order because from __future__ must be the first code in the file
10 years ago
Brian Coca
1c4cfee415
Merge pull request #15046 from bcoca/script_raw
...
removes python requirement to script
10 years ago
nitzmahone
4241106ad2
fix breakage from new recursive=True arg to chmod
10 years ago
Toshio Kuratomi
80e7fbff75
Add python3 compat boilerplate
10 years ago
Toshio Kuratomi
17e8500202
Don't process the same host multiple times
...
Fixes #14259
10 years ago
Brian Coca
1ebc2fda71
removes python requirement to script
...
mistakenly added when checksum was made to use stat module
fixed assertion in test
10 years ago
Brian Coca
6768f34b31
Merge pull request #15062 from gechr/gc-subset-superset-filters
...
Add `issubset` and `issuperset` tests
10 years ago
Thomas Steinbach
870160b8ed
fixed some breaks after merging ansible/devel
10 years ago
Thomas Steinbach
cd2c140f69
forwarded docker_extra_args to latest upstream/origin/devel
10 years ago
Toshio Kuratomi
228ad3ca39
Should be errors=strict since we don't want to end up matching hosts like '???'
10 years ago
Toshio Kuratomi
13b295f1ee
Fix using non-ascii for inventory hostname patterns with the CLI.
10 years ago
James Cammarata
2c20579a06
Add options to make includes 'static'
...
* Can be configured in the ansible.cfg for tasks/handlers individually
* If an included filename contains no vars or loops, it will be expanded
in-place as if it were marked as static
10 years ago
Toshio Kuratomi
f323eb858e
nv_por is needed later in the file
...
Fixes #14654
10 years ago
Toshio Kuratomi
c4a5cf174b
Merge pull request #15009 from bcoca/py3_compat_fixes
...
Py3 compat fixes
10 years ago
James Cammarata
f427955640
Make default var lookup for tasks follow the dep chain
...
Related to #14296 (@jjshoe's follow-up example on that issue)
10 years ago
Konstantin Suvorov
1c922135a0
show error context in args splitter exception
10 years ago
Brian Coca
5b11494437
python3 compatiblity
...
remove use of basestring
deal with configparser
10 years ago
Toshio Kuratomi
52e9209491
Don't create world-readable module and tempfiles without explicit user permission
10 years ago
Brian Coca
fdb56e4bad
avoid bad path entries
10 years ago
Toshio Kuratomi
728bb7d85e
Update submodule refs
10 years ago
Toshio Kuratomi
917da92e2b
Get rid of extra trailing space in log messages
10 years ago
Matthew Gamble
7b06ec79e3
Add documentation for squash_actions configuration setting
10 years ago
Matthew Gamble
197e590d7c
Small comment improvement in AnsibleModule class
10 years ago
Abhijit Menon-Sen
1b242ffb89
Merge pull request #15111 from xiaket/devel
...
complete the docstring. Fixed #14794
10 years ago
夏恺(Xia Kai)
f9a9e5e1b9
complete the docstring. Fixed #14794
...
Signed-off-by: 夏恺(Xia Kai) <xiaket@gmail.com>
10 years ago
Peter Sprygada
5bb876b0e2
fixes issue with getting value with . (dot) in key in netcfg
...
This commit addresses a problem when attempting to retrieve a value from
the result that includes a dict key using . (dot).
10 years ago
Brian Coca
b4b44b2708
Merge pull request #15086 from robinro/patch-2
...
remove double read of "path" (/etc/SuSE-release) in facts.py
10 years ago
Brian Coca
43f70d66a5
Merge pull request #15088 from robinro/patch-3
...
break after parsing SuSE-release in facts.py
10 years ago
Joel
23a74eb125
Sort plugins by basename to support ordering callbacks
10 years ago
Toshio Kuratomi
06d77996da
Update submodule refs
10 years ago
Robin Roth
2c28dcc5cb
break after parsing SuSE-release in facts.py
...
All sections that lead to succesful parsing of the version break afterwards, for SuSE-release this break was missing, potentiall causing #14837
10 years ago
Robin Roth
fea5500605
remove double read of "path"
...
path is already read in line 444, don't reread the file here, but use the existing content
10 years ago
Toshio Kuratomi
3511abb9d9
Merge pull request #15055 from ansible/ansible_sudo_pass-should-override-cli
...
Fix ansible_sudo_pass inventory variable so that it overrides setting of sudo password from the command line
10 years ago
Toshio Kuratomi
f39a1da360
Merge pull request #15074 from ansible/pluginloader-cleanups
...
Cleanup some minor issues in PuginLoader:
10 years ago
George Christou
02ad029840
Add `issubset` and `issuperset` tests
10 years ago
Toshio Kuratomi
ed9e164b80
Fix ansible_sudo_pass inventory variable so that it overrides setting of sudo password from the command line
10 years ago
Toshio Kuratomi
7ce130212f
Cleanup some minor issues in PluginLoader:
...
* class_only was a keyword arg of get() and all() that was mistakenly
passed on to Plugins. Be sure to strip it from the keyword args
before instantiating Plugins. (Reworked API probably should either
not instantiate Plugins or take the args for the Plugin as a separate
list and a dict.)
* Checking required base_classes was only done in get() and only if
class_only was False (ie: that Plugin was instantiated). This meant
that different plugins could be found depending on whether the call
was to .get() or to all() and whether it was for classes or instances.
Fixed so that required base_classes are always checked.
10 years ago
Brian Coca
3ae9a272e0
Merge pull request #14977 from towolf/hide_ok_items_in_actionable
...
For `actionable` cb plugin also hide ok for itemized results
10 years ago
James Cammarata
ae21d98955
Properly use check_raw when using parse_kv in cli/ code
...
Fixes ansible-modules-core#3070
10 years ago
Toshio Kuratomi
407f8f934e
Merge pull request #14976 from xiaket/devel
...
use __mro__ for plugin loading when we search for its base class.
10 years ago
Tobias Wolf
4938b98e4e
For `actionable` cb plugin also hide ok for itemized results
...
The purpose of the `actionable` callback plugin is to hide uninteresting
results.
Also hide the ok results when the task was itemized.
10 years ago
夏恺(Xia Kai)
38092dcc27
import the base class and check whether this obj has the required base class.
...
Signed-off-by: 夏恺(Xia Kai) <xiaket@gmail.com>
10 years ago
Toshio Kuratomi
9053d0468e
Merge pull request #15006 from ansible/local-pipelining
...
Add changes necessary for enabling pipelining for local connections
10 years ago
Will Thames
f438c074af
Remove need for unnecessary boto.ec2 import
...
Modules shouldn't need to import boto.ec2.
The check was to test if profile_name was supported by boto.
Two years after the introduction of the support, we will now
assume that if people are passing `profile`, they are using
a version of boto that supports it (this requirement is
already documented in the aws documentation fragment)
Also remove even older version check for `validate_certs`
Fixes #1901
10 years ago
James Cammarata
9d2fe2fb2c
Fixing role param precedence issues
...
* Make role param resolution follow the role dependency chain, rather
than using all roles within the play
* Also move params to be merged in after role vars in general, to match
our variable precedence rules
* Changes to the way var lookup is done in role helper methods for
get_vars(), get_inherited_vars(), and get_role_params() to make the
above possible without trampling on previously merged vars
Fixes #14472
Fixes #14475
10 years ago
Toshio Kuratomi
4a00999875
Update to latest git submodules
10 years ago
Toshio Kuratomi
b80c9b5032
Merge pull request #15049 from mattclay/paramiko-unicode
...
Add missing to_bytes for cmd.
10 years ago
Matt Clay
24c4384f0e
Add missing to_bytes for cmd.
10 years ago
James Cammarata
e4a5bcae3c
Merge pull request #14679 from dagwieers/merge_hash_v2
...
Avoid merging a dict and a AnsibleUnicode
10 years ago
Brian Coca
7a5ff16aee
Merge pull request #15042 from RNanney/RNanney-validate_certs
...
Update nxos.py
10 years ago
Toshio Kuratomi
f5654dced9
Merge pull request #15043 from mattclay/docker-user
...
Use docker exec -u only when supported.
10 years ago
Matt Clay
ea1a6c56b9
Use docker exec -u when needed and if supported.
...
If remote_user is given and cannot be set in docker, a warning will
be displayed unless the default container user matches remote_user.
10 years ago
RNanney
8bceff5136
Update nxos.py
10 years ago
James Cammarata
13f3cbaf3b
Renaming per-item and retry callbacks
10 years ago
Toshio Kuratomi
60c943997b
More doc updates regarding ansible_shell_executable
10 years ago
Toshio Kuratomi
8bdf0d4746
And another doc fix
10 years ago
Toshio Kuratomi
08394df8d0
Update submodule links for docs fixes
10 years ago
Abhijit Menon-Sen
efdac490ff
Merge pull request #14924 from mvgrimes/patch-1
...
Dynamically add ssl key to the mysql config hash iff needed
10 years ago
Brian Coca
d43fc631dd
mount facts now include network mounts (nfs)
10 years ago
Brian Coca
b809d23863
fixed typo
10 years ago
Abhijit Menon-Sen
e5460d6a6e
Merge pull request #15002 from camradal/devel
...
add find_host_portgroup_by_name function to vmware utils
10 years ago
Toshio Kuratomi
e25caebe7a
Cleanups to docs and rename of inv var
10 years ago
Toshio Kuratomi
8fc1c26c37
Merge pull request #14936 from bcoca/ansible_executable
...
add ansible_executable inventory var
10 years ago
Toshio Kuratomi
2ba4428424
Catch ValueError as well because of El Capitan provoking a bug in python2's subprocess
...
Fixes #14895
10 years ago
Abhijit Menon-Sen
a61a3e28da
Merge pull request #9776 from MiLk/fixes/git-repo-info-branch
...
ansible.utils._git_repo_info() now supports branch names with slashes
10 years ago
Brian Coca
db61e9be0c
add ansible_executable inventory var
...
also handle the overrides appropriately
also new executable to set shell type
10 years ago
Thomas Steinbach
14dfad730e
use just 'remote_user' as user for the docker connection
10 years ago
Thomas Steinbach
4ac49ed4a8
use remote_user or become_user in docker connection
10 years ago
Brian Coca
5d9b552317
Merge pull request #15024 from bcoca/delegation_vars_fix
...
ensure we use delegated vars on delegation
10 years ago
Toshio Kuratomi
ab693579a9
Clarify the document about the order of matryoshka shells
...
(nesting shells)
10 years ago
James Cammarata
1ee6d489ab
Make sure tuples returned by _get_item() are handled correctly in formatting
...
Fixes #14800
10 years ago
Brian Coca
292be944c6
ensure we use delegated vars on delegation
...
this prevents falling back to connection vars from the inventory_hostname
when matching connection var is not in delegated host.
10 years ago
René Moser
0a457230ab
Merge pull request #14982 from Linuturk/GalaxyInitWhitespaceFix
...
Remove trailing whitespace from the galaxy init Jinja2 template. Defa…
10 years ago
Toshio Kuratomi
2dd6bae9e1
Merge pull request #15003 from ansible/jail-enable-pipelining
...
Enable pipelining for jail connection plugin
10 years ago
Brian Coca
bc60f52db5
avoid exceptiosn when not being called by CLI
10 years ago
Toshio Kuratomi
e80cd8bcaf
Merge pull request #14908 from mattclay/mysql-connect-timeout
...
Document mysql connect_timeout and update tests.
10 years ago
James Cammarata
0e68c6d6fe
Cleaning up use of literal_eval in basic.py AnsibleModule.safe_eval
10 years ago
Matt Clay
6a1f97ad42
Add docs for mysql* modules connect_timeout.
10 years ago
Brian Coca
5ae9955aad
Merge pull request #15011 from dagwieers/fix-unreachable-color
...
Fix the color when unreachable in default cb plugin
10 years ago
Brian Coca
0cb804f0c2
fix lsb fact gathering
...
was erroring out when rc !=0 also fixed redundant paths
fixes #14965
10 years ago
Brian Coca
d7d47bcd75
Merge pull request #14989 from nifoc/patch-fetch_url
...
Check return value of get_distribution()
10 years ago
Dag Wieers
ed457ad53b
Fix the color when unreachable in default cb plugin
...
The dedicated color for unreachable errors was not being used in the default cb plugin.
This corrects the color.
10 years ago
qqo
a7f89cac63
fix TypeError: coercing to Unicode: need string or buffer, AnsibleParserError found
10 years ago
qqo
85e843baee
Revert "fix TypeError: coercing to Unicode: need string or buffer, AnsibleParserError found"
...
This reverts commit d1e0719e4c .
10 years ago
qqo
d1e0719e4c
fix TypeError: coercing to Unicode: need string or buffer, AnsibleParserError found
10 years ago
Brian Coca
61f05c2e8d
strip keys recursively
10 years ago
Toshio Kuratomi
7346e3098a
Update extras submodule ref
10 years ago
Toshio Kuratomi
1346c209b0
Add changes necessary for enabling pipelining for local connections
10 years ago
Toshio Kuratomi
a8acd7f93e
Enable pipelining for jail connection plugin
10 years ago
Alexey Kalinin
9763e76f6f
add find_host_portgroup_by_name function to vmware utils
10 years ago
Toshio Kuratomi
de306eb5da
Small cleanup to use class attribute directly instead of property for transport names
10 years ago
Toshio Kuratomi
fee73100c4
Move BUFSIZE to __init__ since it's common to many connection plugins
10 years ago
Toshio Kuratomi
0ca4be6fb5
Update submodule refs for docs fixes
10 years ago
Toshio Kuratomi
ec419446b7
Update submodule refs
10 years ago
Daniel Kempkens
696b68f07a
Check return value of get_distribution()
...
On none-Linux systems `get_distribution()` returns `None`, which fails in `fetch_url`, because the return value of `get_distribution()` is not checked before calling `lower()` on the result.
10 years ago
Toshio Kuratomi
fe278202f2
Fix saving of tracebacks on module failure
10 years ago
Justin Phelps
d604c8c3a6
Remove trailing whitespace from the galaxy init Jinja2 template. Default a description.
10 years ago
Toshio Kuratomi
86080fbaa9
Update submodule refs
10 years ago
Toshio Kuratomi
66328e5200
Merge pull request #14967 from ansible/facts-subset-and-cleanup
...
Facts subset and cleanup
10 years ago
夏恺(Xia Kai)
cd6d865e27
use __mro__ for plugin loading when we search for its base class.
...
This would relax the constraint a little bit, allowing subclassing existing plugins.
Signed-off-by: 夏恺(Xia Kai) <xiaket@gmail.com>
10 years ago
Brian Coca
09699d0cd0
meta: clear_facts
...
draft implementation
10 years ago
Brian Coca
f3b9449e07
don't raise exceptoins on bad hosts files
...
fixes #14969
10 years ago
Peter Sprygada
ace0c9c5c2
fixes ansible-modules-code#3250
...
Sets the default value for transport to 'cli'
10 years ago
Peter Sprygada
c039ac524d
updates to nxos shared module
...
This commit address a number of minor updates the nxos shared module
* connect() is now lazy loaded
* parse inner output messages when errored
* code syntax cleanup
10 years ago
Toshio Kuratomi
512825455e
Make ohai and facter work via module_utils Fact classes rather than in the setup module
10 years ago
Toshio Kuratomi
5a1e35224b
Make changes proposed during review of restrict fact gathering feature:
...
* Make documentation examples into code blocks
* Make code to call the subsets more general.
* Made min subset always execute (cannot disable it).
* Use a passed in modules parameter rather than global modules. This is needed for ziploader
* Remove unneeded __init__()
* Remove uneeded multiple inheritance from a base class
* gather_facts is now a list type
10 years ago
Toshio Kuratomi
d665911bab
Allow FieldAttribute lists and sets to be set from a comma separated string
10 years ago
Yannig Perré
88772b6003
Add a way to restrict gathered facts in Ansible:
...
- Using gather_subset options
- By ignoring ohai/chef or facter/puppet facts
10 years ago
Brian Coca
2984ffdfac
now item callback honors display_skipped_hosts
...
fixes #14956
10 years ago
Peter Sprygada
d211b4c962
feature to implement localized cli prompts to eos
...
This change localizes the cli prompt regexps to the eos shared module
instead of the common prompts implemented in shell
10 years ago
Peter Sprygada
5338d6af28
feature in ios to tell shell not to kickstart
...
This commit is necessary to tell shell not to kickstart the cli session as
it causes problems in IOS to recognize the prompt.
10 years ago
Peter Sprygada
249caac0d3
feature to allow prompts to be configured at instatiation
...
This commit adds a new feature to allow implementations of shell to
specify the command prompt regexp to be used. It allows adds a new
kwarg at instantiation to kick the remote device with a carriage return.
By default the kickstart flag is true but can be disabled by passing
kickstart=False.
10 years ago
Peter Sprygada
c55d1c55af
Merge pull request #14906 from devananda/fix-shell-for-junos
...
Send empty command before recv
10 years ago
Brian Coca
00b8b49112
Merge pull request #14873 from bcoca/paging_aws
...
paging for amazon modules
10 years ago
Brian Coca
fdcd80bf87
Merge pull request #13339 from bcoca/retry_rate
...
draft of common retry and rate limiting decorators for api based modules
10 years ago
Peter Sprygada
e3671a8a83
bugfix for eos shared module and new optimization
...
This commit address to issues in the eos shard module. The first one
is a bug fix for returning the running config when the transport is eapi.
The shared module will now return config text instead of an object. The
second is a optimization that delays when the eos module connects to the
remote devices. This provies a performance enhancement when using
ssh since the module doesn't default to connecting immediately
10 years ago
Toshio Kuratomi
180e70b67a
Merge pull request #14937 from mattclay/unicode-dir
...
Fix missing to_bytes on directory path.
10 years ago
Matt Clay
1e1852c34d
Add missing to_bytes on directory path.
10 years ago
root
2aba1c211d
Modified files to use single quotes rather than double for file path. Powershell does not process $ variables in strings that are single quoted. Powershell DOES process $ variables that are in double quoted strings.
...
Using single quotes enables ansible to handle file paths that contain folders that start with $. (i.e. C:/Users/$admin/...)
10 years ago
mvgrimes
e613737b80
Dynamically add ssl key to the mysql config hash iff needed
...
Just including the `ssl` key in the config for MySQLdb.connect, causes it to check for the existence of SSL support. This patch only adds the key if one of the ssl configuration options is included.
10 years ago
David Shrewsbury
336d19d3b0
Set type for OpenStack 'verify' param
...
The 'verify' param is a bool, so we don't want it to be an assumed
str.
10 years ago
Peter Sprygada
a59fe25bb1
bugfix for shared module shell.py
...
removes get_cli_connection function which was left over from a refactor
but was no longer in use
10 years ago
Matt Clay
ba1bcdfc17
Add noseclabel support to libvirt_lxc plugin.
10 years ago
James Cammarata
16f107a491
Add mysql connection_timeout param to module_utils/mysql.py
10 years ago
Devananda van der Veen
08f270ad71
Send empty command before recv
...
On some switches, starting an SSH connection and immediately calling
recv() will result in a connection timeout. The switch requires some
input on the channel before it provides any prompt.
As such, this patch sends an empty command immediately upon connection,
triggering the switch to send a prompt which the shell can then
interpret.
Signed-off-by: Devananda van der Veen <devananda.vdv@gmail.com>
10 years ago
James Cammarata
52efd7438c
Fixing template/assemble action plugins related to tmp dir use/cleanup
10 years ago
Matt Clay
f878a5d2e0
Fix unicode handling in connection plugins.
10 years ago
James Cammarata
09e5f0578a
Don't always insert failed in the results (again)
10 years ago
Brian Coca
5cbdaff9fd
avoid creating extra tmp dirs we don't delete
...
fixes #14867
10 years ago
James Cammarata
ccf646665b
Revert "Removing explicit setting of failed/failed_when"
...
This reverts commit 4e528e9535 .
10 years ago
James Cammarata
4e528e9535
Removing explicit setting of failed/failed_when
10 years ago
Brian Coca
df1268ed69
Merge pull request #14892 from dagwieers/patch-14
...
Another misspelling
10 years ago
Brian Coca
05983fdaa5
Merge pull request #14891 from dagwieers/patch-13
...
Fix misspelling and some cosmetic change
10 years ago
Brian Coca
1c1f5e9f99
Merge pull request #14889 from nitzmahone/fix_failed_when_blind_override
...
Fix blind override in failed_when
10 years ago
Peter Sprygada
ca2871de20
Merge pull request #14697 from privateip/shared_module_openswitch
...
bugfixes for openswitch shared module
10 years ago
Peter Sprygada
ae5951b97f
Merge pull request #14698 from privateip/plugin_action_ops_template
...
updates the ops_template plugin action backup key
10 years ago
Dag Wieers
a5e11b1325
Another misspelling
...
...while reading the source
10 years ago
Dag Wieers
d7d04ad2cd
Fix misspelling and some cosmetic change
10 years ago
nitzmahone
dbff3a6bbc
Fix blind override in failed_when
...
caused all task failures to be success
10 years ago
Brian Coca
18e9bc9753
common retry and rate limiting decorators for apis
...
allows modules to wrap their request functions in common retry and rate limiting
decorators or functions
10 years ago
Brian Coca
9318727021
corrected changed_when handling
10 years ago
James Cammarata
7f233c4c5e
Updating submodule refs
10 years ago
Toshio Kuratomi
331f62f769
Update submodule refs
10 years ago
Toshio Kuratomi
0628951ac6
Handle shlex incompatibility between python2.6 and python3
10 years ago
Toshio Kuratomi
c0e2dd1693
Fix ssh connection plugin to work with python3
10 years ago
James Cammarata
eb463fab00
Also changing ansible-shell -> ansible-console in cli code comments
10 years ago
James Cammarata
9d61a6cba8
Fixing PlayIterator bugs
...
* Unit tests exposed a problem where nested blocks did not correctly
hit rescue/always portions of parent blocks
* Cleaned up logic in PlayIterator
* Unfortunately fixing the above exposed a potential problem in the
block integration tests, where a failure in an "always" section may
always lead to a failed state and the termination of execution
beyond that point, so certain parts of the block integration test
were disabled.
10 years ago
Brian Coca
d7bd5fc075
Merge pull request #14824 from bcoca/ansible_shell
...
draft 1st release of ansible shell
10 years ago
Brian Coca
7067bb32b8
make all conditionals lists
...
this brings them to equivalence with when:
fixes #13905
10 years ago
Matt Clay
33f93f9241
Fix misplaced paren.
10 years ago
Brian Coca
33b550fc76
paging for amazon modules
...
this adds a decorator for use in amazon modules so retrieval functions
can page using the 'marker' that most boto functions return
10 years ago
James Cammarata
aee2eb6287
Merge pull request #14864 from dagwieers/patch-12
...
Only show diff when the task actually induced a change
10 years ago
James Cammarata
1a5ee115f0
Fixing minor logic error in error detection/handling in ssh connection plugin
...
If max retries were reached, no AnsibleConnectionFailure was raised, which
means potentially in some cases an unreachable error might not be returned
10 years ago
Dag Wieers
f5b6f52940
Only show diff when the task actually induced a change
...
This implements solution #1 in the proposal #14860 .
It only shows the diff if the task induced a change, which means that if the changed_when control overrides the task, not diff will be produced.
See #14860 for a rationale and the use-case.
10 years ago
Dag Wieers
175351f200
Little improvement in flow
...
Don't get the hostname if it's not needed.
10 years ago
Brian Coca
49bb4803b5
clarify --step prompt
...
now shows full words and indicates default
fixes #7433
10 years ago
Brian Coca
3d6ec52e83
Merge pull request #14830 from bcoca/assemble_fix
...
fix assemble to not pass extra args to copy/file
10 years ago
Brian Coca
eb4cb46c84
Merge pull request #14859 from sivel/issue/14858
...
Strip proc_1 before testing it. Fixes #14858
10 years ago
Matt Martz
2f90a4f4e2
Strip proc_1 before testing it. Fixes #14858
10 years ago
Brian Coca
e24e619cf1
added stderr from vault script to error
10 years ago
Brian Coca
75ae62a978
Merge pull request #12674 from sudarkoff/fail_if_executable_password_file_returns_nonzero
...
(TRIVIAL) Fail if the vault password script returns non-zero.
10 years ago
Brian Coca
e74ab3ecdd
draft 1st release of ansible-console
...
porting @dominis 's ansible-shell tool from 1.9 and integrating it into ansible
added verbosity control
made more resilitent to several errors
added highlight color, to configurable colors
more resilient on exception and interruptions
prompt coloring, goes red and changes to # when using become = true and root
become setting is now explicit and not a toggle
10 years ago
Matt Martz
53bb889ef6
update submodule refs
10 years ago
Matt Martz
098333b2ec
Fix redirects for get_url
...
* fetch_url shouldn't both accept follow_redirects and support follow_redircts via module.params
* Default follow_redirects for open_url should be 'urllib2'
* Add redirect test for get_url
10 years ago
Brian Coca
325fccfa78
added v for least verbose display function
10 years ago
James Cammarata
299d93f6e9
Updating unit tests for PlayIterator
...
This knowingly introduces a broken test, planning to fix that later.
10 years ago
Brian Coca
66ea464ebd
Merge pull request #14793 from xiaket/devel
...
remove main_q for simplicity.
10 years ago
Brian Coca
25e9b5788b
add per item diff handling
...
fixes #14843
10 years ago
John Barker
8b4ebd8e4a
Make it easier to read error message
10 years ago
Jonathan Sokolowski
5ec7adc64d
Lookup netrc for credentials in open_url
10 years ago
Brian Coca
0b2f631197
Merge pull request #14504 from bcoca/template_comments
...
template also when only comments present
10 years ago
Brian Coca
7d8b84dae6
fix assemble to not pass extra args to copy/file
...
also small refactor to dedupe code
fixes https://github.com/ansible/ansible-modules-core/issues/3154
10 years ago
Brian Coca
5aab158987
removed unused imports
10 years ago
Peter Sprygada
c0f1e1801b
adds multiline flag to regex test for search and match
...
This commit adds the multiline flag to the regexp search and match test
plugin. It defaults to re.M = False for backwards compatibility. To use
the multiline feature add multiline=True to the test filter
{{ config | search('^hostname', multiline=True) }}
10 years ago
Brian Coca
66a9a1feff
Merge pull request #14823 from jjahns/devel
...
add find_vm_by_name function to vmware utils
10 years ago
Brian Coca
75b9c7db14
moved hardcoded settings from doccli to constants
10 years ago
Jay Jahns
3a1944edc1
add find_vm_by_name function to vmware utils
10 years ago
Kishin Yagami
299c18d700
Support strategy_plugins setting in a configuration file
10 years ago
Brian Coca
62ac5c047e
clarified message
10 years ago
Brian Coca
8867d73420
reject extraneous data passed to mode
...
strictly permissions are allowed, file type info should not be passed in
alternate fixes #14771
10 years ago
Toshio Kuratomi
bd618c3490
Merge pull request #14797 from mattclay/unicode-fixes
...
Use to_bytes on filenames in filesystem calls.
10 years ago
Brian Coca
d6546a7513
make sure group_names is always sorted
...
this makes it consistent with previous ansilbe versions and other
paths that create the group_names variable
10 years ago
Matt Clay
5b79ed77e7
Use to_bytes on filenames in filesystem calls.
10 years ago
Brian Coca
27a33a6f18
dont erase previous nameservers in fact gathering
...
fixes #14806
10 years ago
夏恺(Xia Kai)
b33074b703
remove main_q for simplicity.
...
main_q is not used anywhere in the codebase.
It is created in TaskQueueManager._initialize_processes, bundled with rslt_q
into TaskQueueManger._workers, later unwrapped in StrategyBase but not used.
This queue is closed in TaskQueueManger._cleanup_processes.
Historically, it is passed as a init parameter into WorkerProcess,
introduced in 62d7956 , but this behavior is changed in 120b9a7 .
Signed-off-by: 夏恺(Xia Kai) <xiaket@gmail.com>
10 years ago
Toshio Kuratomi
8f1303c81a
Remember to use errors=strict since this is looking up a filename on the filesystem (ie it has to match exactly)
10 years ago
Toshio Kuratomi
253376b3b7
Make the source path into a byte string before passing to os.path
10 years ago
Brian Coca
e762095497
better task parsing errors
...
fixes #14790
10 years ago
Brian Coca
f565508d7f
Merge pull request #14764 from bcoca/max_diff_config
...
made max diff size configurable
10 years ago
Brian Coca
e432973310
Merge pull request #14757 from bcoca/register_no_template
...
don't template register
10 years ago
Brian Coca
13282e29a8
Merge pull request #14500 from yfried-redhat/fix_os_auth
...
Fix openstack auth type
10 years ago
Brian Coca
b901b15d3b
Merge pull request #14537 from Yannig/devel_better_error_handling
...
Improve message content to get more hint about the raised error.
10 years ago
Brian Coca
cc3cb0f65e
fix issues with older yaml lib versions
...
also added missing json import and removed unused ones
10 years ago
Brian Coca
6cad356b3b
updated docs to show new output
10 years ago
Brian Coca
b2a6784a9f
changed the output to keep backwards compat
...
still shows path when verbose
10 years ago
Brian Coca
fd8593d613
Merge pull request #14661 from jjshoe/fix-up-profile-tasks
...
Update the profile task callback plugin to include a fix for duplicate named tasks. Added additional features to adjust the number of tasks output and the sort order.
10 years ago
Brian Coca
c022a43a47
fixed str to to_str
10 years ago
Brian Coca
347aa7b032
Merge pull request #14774 from lamby/ignore-epipe-when-flushing-stdout-stderr
...
Ignore EPIPE when flushing stdout stderr
10 years ago
Chris Lamb
eb1141ee79
Ignore EPIPE to avoid tracebacks when piping output to other commands
...
For example:
$ ansible web --list-hosts | head -n1
hosts (7):
ERROR! Unexpected Exception: [Errno 32] Broken pipe
Traceback (most recent call last):
File "/home/lamby/git/private/lamby-ansible2/.venv/bin/ansible", line 114, in <module>
display.display("to see the full traceback, use -vvv")
File "/home/lamby/git/private/lamby-ansible2/.venv/local/lib/python2.7/site-packages/ansible/utils/display.py", line 133, in display
sys.stdout.flush()
IOError: [Errno 32] Broken pipe
Such a pipe target will close up shop early when its seen enough input,
causing ansible to print an ugly traceback.
Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
10 years ago
Chris Lamb
951c8a5d27
Alias fileobj.
10 years ago
Brian Coca
4cfd042839
more complete and informative errors
...
mostly templating issues now all return data templated and actual error
fixes #14781
10 years ago
Brian Coca
0031a72e0d
tweak deprecation warnings display
10 years ago
Brian Coca
ea5e089056
restore initial json parsing attempt to loader
...
fixes issues with extra vars json strings not being parsed correctly by the yaml parser
10 years ago
Toshio Kuratomi
4657be4eab
Transform pathnames to bytes before passing on to os.path functions
10 years ago
Toshio Kuratomi
468eea82bd
Merge pull request #14765 from sivel/redirect-ssl-validation
...
Support SSL validation with redirect control for python versions without ssl context
10 years ago
Matt Davis
0ab29f573a
Merge pull request #14755 from bcoca/pause_nohup_fix
...
avoid issues when stdin is a closed file
10 years ago
Matt Martz
6ff0b079b4
Support SSL validation with redirect control for python versions without ssl context
10 years ago
Brian Coca
c24249c57d
made max diff size configurable
10 years ago
Toshio Kuratomi
1dbbd2a80c
Remove debugging and fix the place where bytes are being handed to StringIO
10 years ago
Brian Coca
ca0797fc4e
avoid issues when stdin is a closed file
...
this seems to happen when nohup is involved, so the check tty
does not get a chance to fail, it just works with pipes
fixes http://github.com/ansible/ansible-modules-core/issues/3166
10 years ago
Toshio Kuratomi
093b3422ec
more information
10 years ago
Brian Coca
7ba790bbaf
don't tempalte register
10 years ago
Toshio Kuratomi
5aef65edcd
Testing whether this fixes jenkins
10 years ago
James Cammarata
3247390123
Conditionally import StringIO in template so we only use io.StringIO on py3
10 years ago
James Cammarata
2c7a33f71d
Fixing bug in setup related to StringIO fixes
10 years ago
James Cammarata
9acb5aa176
Changing location of reduce import to not use six.moves
10 years ago
James Cammarata
b559d0e6ee
Adding py3 stub for reduce from six.moves
10 years ago
Brian Coca
71402abf21
only do squash when 'squashable field' present
10 years ago
James Cammarata
e011f52557
Expanding unit tests for module_utils/basic.py
10 years ago
Brian Coca
7af5787030
Merge pull request #14717 from xiaket/devel
...
Fix __repr__ for meta tasks
10 years ago
Brian Coca
dd003a42b0
Merge pull request #14273 from resmo/for-ansible-2.1
...
[2.1] cloudstack: new generic code
10 years ago
Rene Moser
6c641fb6a8
cloudstack: add CS_HYPERVISORS constant
10 years ago
夏恺(Xia Kai)
d033c40e80
Make task repr really work for meta tasks.
...
Signed-off-by: 夏恺(Xia Kai) <xiaket@xiaket@gmail.com>
10 years ago
Brian Coca
0d1138e0a0
Merge pull request #14712 from chouseknecht/galaxy2_paging
...
Fix bug 14715: Galaxy CLI paging error
10 years ago
chouseknecht
42b2077c93
Fix bug 14715: Galaxy CLI paging error
10 years ago
Peter Sprygada
c2ce509aaf
bugfixes for openswitch shared module
...
This commit fixes two bugs in the openswitch shared module. The first
bug was a wrong argument type for the use_ssl argument. It was set
to int and should be bool. The second changes the default ports for http
(was 80, now 8091) and https (was 443, now 18091). This change aligns
the default port values with the OS
10 years ago
nitzmahone
915037c628
update submodule refs
10 years ago
nitzmahone
ac54f66741
don't lock file when calculating checksum
10 years ago
Brian Coca
badc922c73
added warning for when host file doesn't exist
...
fixes #14692
10 years ago
Brian Coca
82d6a83cca
Merge pull request #14633 from Etherdaemon/fix_boto3_params
...
Fixup boto3_conn aws_session_token and verify
10 years ago
Brian Coca
157ebcfe0b
Merge pull request #14709 from bcoca/squash_fix_atp
...
added package to special 'squashable' fields
10 years ago
Brian Coca
67d5b77898
added package to special 'squashable' fields
...
apt has it as alias, this should fix https://github.com/ansible/ansible-modules-core/issues/3145
10 years ago
James Cammarata
7c049c3200
Fixing up jsonify and adding unit tests
10 years ago
Matt Martz
d0a717694f
Fix variable name in paramiko connection plugin
10 years ago
Matt Martz
e27eb73cba
sys.subversion unavailable in py24. Fixes #14704
10 years ago
Peter Sprygada
f67bf3f775
updates the ops_template plugin action backup key
...
This commit changes the key the ops_template will search for in order
to backup the current configuration to local disk on the Ansible control
host. This change was made to make ops_template consistent with the
other network template modules.
10 years ago
Toshio Kuratomi
e01b6ad6b4
We are actually taking the repr of a string so we need separate to_bytes and repr calls
10 years ago
Toshio Kuratomi
b70bf3b056
Use io.StringIO and io.BytesIO instead of StringIO.StringIO for compat with py3
10 years ago
Toshio Kuratomi
c29f51804b
Fix mixing of bytes and str in module replacer (caused traceback on python3)
10 years ago
Brian Coca
512d3dd621
with_ loops always should want a list
10 years ago
Brian Coca
528f073bfa
update core subref
10 years ago
Toshio Kuratomi
1f2595306a
normalize path components to unicode before combining or operating on them
...
Note that this will break if we deal with non-utf8 paths. Fixing this
way because converting everythig to byte strings instead is a very
invasive task so it should be done as a specific feature to provide
support for non-utf8 paths at some point in the future (if needed).
10 years ago
Toshio Kuratomi
ef8bec18bf
Use a unicode format string so that we don't convert to byte strings
...
Fixes #14349
10 years ago
Dag Wieers
0eca47cf91
Avoid merging a dict and a AnsibleUnicode
...
This is the same fix we applied to v1.9 in PR #14565 , however it does not fix #14678 completely !
The dictionaries are not being merged as tey are on v1.9.
10 years ago
Brian Coca
ad5a6e7993
updated submodule refs
10 years ago
James Cammarata
771f1e31a9
Rework the way ad-hoc filters inventory to match how cli/playbook does it
10 years ago
Brian Coca
e2d2798a42
hosts can be list or string
10 years ago
Brian Coca
2d56293768
default play name to hosts entry
...
return to previous behaviour as now the name was left blank
10 years ago
Joel
b3aa373932
Update the profile task callback plugin to include a fix for duplicate named tasks. Added additional features to adjust the number of tasks output and the sort order.
10 years ago
James Cammarata
cd51ba7965
Use abspath instead of realpath for group/host vars files
...
The use of realpath means when following symlinks the actual path is
used when loading these files in the VariableManager, which may not
line up with the host or group name specified.
Fixes #14545
10 years ago
Toshio Kuratomi
9c9cce51ab
Update submodule refs
10 years ago
Brian Coca
03c33053aa
clarified become options do not imply others
...
fixes #14635
10 years ago
Etherdaemon
06977d5cb1
Fixup boto3_conn as commit 6ea772931f broke commit 27398131cf
10 years ago
James Cammarata
2db3f290ba
Fix logic error when copying files recursively to a directory
10 years ago
Brian Coca
34541b4e5e
preserve no_log for async also
10 years ago
James Cammarata
d74ea51287
Submodule update
10 years ago
James Cammarata
da02aba173
Don't inject PlayContext properties as variables if they're None
...
Fixes bug introduced in 078ebb0
10 years ago
James Cammarata
e02b98274b
issue callbacks per item and retry fails
...
- now workers passes queue to task_executor so it can send back events per item and on retry attempt
- updated result class to pass along events to strategy
- base strategy updated to forward new events to callback
- callbacks now remove 'items' on final result but process them directly when invoked per item
- new callback method to deal with retry attempt messages (also now obeys nolog)
- updated tests to match new signature of task_executor
fixes #14558
fixes #14072
10 years ago