Brian Coca
6768f34b31
Merge pull request #15062 from gechr/gc-subset-superset-filters
...
Add `issubset` and `issuperset` tests
9 years ago
Thomas Steinbach
870160b8ed
fixed some breaks after merging ansible/devel
9 years ago
Thomas Steinbach
cd2c140f69
forwarded docker_extra_args to latest upstream/origin/devel
9 years ago
Toshio Kuratomi
228ad3ca39
Should be errors=strict since we don't want to end up matching hosts like '???'
9 years ago
Toshio Kuratomi
13b295f1ee
Fix using non-ascii for inventory hostname patterns with the CLI.
9 years ago
James Cammarata
2c20579a06
Add options to make includes 'static'
...
* Can be configured in the ansible.cfg for tasks/handlers individually
* If an included filename contains no vars or loops, it will be expanded
in-place as if it were marked as static
9 years ago
Toshio Kuratomi
f323eb858e
nv_por is needed later in the file
...
Fixes #14654
9 years ago
Toshio Kuratomi
c4a5cf174b
Merge pull request #15009 from bcoca/py3_compat_fixes
...
Py3 compat fixes
9 years ago
James Cammarata
f427955640
Make default var lookup for tasks follow the dep chain
...
Related to #14296 (@jjshoe's follow-up example on that issue)
9 years ago
Konstantin Suvorov
1c922135a0
show error context in args splitter exception
9 years ago
Brian Coca
5b11494437
python3 compatiblity
...
remove use of basestring
deal with configparser
9 years ago
Toshio Kuratomi
52e9209491
Don't create world-readable module and tempfiles without explicit user permission
9 years ago
Brian Coca
fdb56e4bad
avoid bad path entries
9 years ago
Toshio Kuratomi
728bb7d85e
Update submodule refs
9 years ago
Toshio Kuratomi
917da92e2b
Get rid of extra trailing space in log messages
9 years ago
Matthew Gamble
7b06ec79e3
Add documentation for squash_actions configuration setting
9 years ago
Matthew Gamble
197e590d7c
Small comment improvement in AnsibleModule class
9 years ago
Abhijit Menon-Sen
1b242ffb89
Merge pull request #15111 from xiaket/devel
...
complete the docstring. Fixed #14794
9 years ago
夏恺(Xia Kai)
f9a9e5e1b9
complete the docstring. Fixed #14794
...
Signed-off-by: 夏恺(Xia Kai) <xiaket@gmail.com>
9 years ago
Peter Sprygada
5bb876b0e2
fixes issue with getting value with . (dot) in key in netcfg
...
This commit addresses a problem when attempting to retrieve a value from
the result that includes a dict key using . (dot).
9 years ago
Brian Coca
b4b44b2708
Merge pull request #15086 from robinro/patch-2
...
remove double read of "path" (/etc/SuSE-release) in facts.py
9 years ago
Brian Coca
43f70d66a5
Merge pull request #15088 from robinro/patch-3
...
break after parsing SuSE-release in facts.py
9 years ago
Joel
23a74eb125
Sort plugins by basename to support ordering callbacks
9 years ago
Toshio Kuratomi
06d77996da
Update submodule refs
9 years ago
Robin Roth
2c28dcc5cb
break after parsing SuSE-release in facts.py
...
All sections that lead to succesful parsing of the version break afterwards, for SuSE-release this break was missing, potentiall causing #14837
9 years ago
Robin Roth
fea5500605
remove double read of "path"
...
path is already read in line 444, don't reread the file here, but use the existing content
9 years ago
Toshio Kuratomi
3511abb9d9
Merge pull request #15055 from ansible/ansible_sudo_pass-should-override-cli
...
Fix ansible_sudo_pass inventory variable so that it overrides setting of sudo password from the command line
9 years ago
Toshio Kuratomi
f39a1da360
Merge pull request #15074 from ansible/pluginloader-cleanups
...
Cleanup some minor issues in PuginLoader:
9 years ago
George Christou
02ad029840
Add `issubset` and `issuperset` tests
9 years ago
Toshio Kuratomi
ed9e164b80
Fix ansible_sudo_pass inventory variable so that it overrides setting of sudo password from the command line
9 years ago
Toshio Kuratomi
7ce130212f
Cleanup some minor issues in PluginLoader:
...
* class_only was a keyword arg of get() and all() that was mistakenly
passed on to Plugins. Be sure to strip it from the keyword args
before instantiating Plugins. (Reworked API probably should either
not instantiate Plugins or take the args for the Plugin as a separate
list and a dict.)
* Checking required base_classes was only done in get() and only if
class_only was False (ie: that Plugin was instantiated). This meant
that different plugins could be found depending on whether the call
was to .get() or to all() and whether it was for classes or instances.
Fixed so that required base_classes are always checked.
9 years ago
Brian Coca
3ae9a272e0
Merge pull request #14977 from towolf/hide_ok_items_in_actionable
...
For `actionable` cb plugin also hide ok for itemized results
9 years ago
James Cammarata
ae21d98955
Properly use check_raw when using parse_kv in cli/ code
...
Fixes ansible-modules-core#3070
9 years ago
Toshio Kuratomi
407f8f934e
Merge pull request #14976 from xiaket/devel
...
use __mro__ for plugin loading when we search for its base class.
9 years ago
Tobias Wolf
4938b98e4e
For `actionable` cb plugin also hide ok for itemized results
...
The purpose of the `actionable` callback plugin is to hide uninteresting
results.
Also hide the ok results when the task was itemized.
9 years ago
夏恺(Xia Kai)
38092dcc27
import the base class and check whether this obj has the required base class.
...
Signed-off-by: 夏恺(Xia Kai) <xiaket@gmail.com>
9 years ago
Toshio Kuratomi
9053d0468e
Merge pull request #15006 from ansible/local-pipelining
...
Add changes necessary for enabling pipelining for local connections
9 years ago
James Cammarata
9d2fe2fb2c
Fixing role param precedence issues
...
* Make role param resolution follow the role dependency chain, rather
than using all roles within the play
* Also move params to be merged in after role vars in general, to match
our variable precedence rules
* Changes to the way var lookup is done in role helper methods for
get_vars(), get_inherited_vars(), and get_role_params() to make the
above possible without trampling on previously merged vars
Fixes #14472
Fixes #14475
9 years ago
Toshio Kuratomi
4a00999875
Update to latest git submodules
9 years ago
Toshio Kuratomi
b80c9b5032
Merge pull request #15049 from mattclay/paramiko-unicode
...
Add missing to_bytes for cmd.
9 years ago
Matt Clay
24c4384f0e
Add missing to_bytes for cmd.
9 years ago
James Cammarata
e4a5bcae3c
Merge pull request #14679 from dagwieers/merge_hash_v2
...
Avoid merging a dict and a AnsibleUnicode
9 years ago
Brian Coca
7a5ff16aee
Merge pull request #15042 from RNanney/RNanney-validate_certs
...
Update nxos.py
9 years ago
Toshio Kuratomi
f5654dced9
Merge pull request #15043 from mattclay/docker-user
...
Use docker exec -u only when supported.
9 years ago
Matt Clay
ea1a6c56b9
Use docker exec -u when needed and if supported.
...
If remote_user is given and cannot be set in docker, a warning will
be displayed unless the default container user matches remote_user.
9 years ago
RNanney
8bceff5136
Update nxos.py
9 years ago
James Cammarata
13f3cbaf3b
Renaming per-item and retry callbacks
9 years ago
Toshio Kuratomi
60c943997b
More doc updates regarding ansible_shell_executable
9 years ago
Toshio Kuratomi
8bdf0d4746
And another doc fix
9 years ago
Toshio Kuratomi
08394df8d0
Update submodule links for docs fixes
9 years ago
Abhijit Menon-Sen
efdac490ff
Merge pull request #14924 from mvgrimes/patch-1
...
Dynamically add ssl key to the mysql config hash iff needed
9 years ago
Brian Coca
d43fc631dd
mount facts now include network mounts (nfs)
9 years ago
Brian Coca
b809d23863
fixed typo
9 years ago
Abhijit Menon-Sen
e5460d6a6e
Merge pull request #15002 from camradal/devel
...
add find_host_portgroup_by_name function to vmware utils
9 years ago
Toshio Kuratomi
e25caebe7a
Cleanups to docs and rename of inv var
9 years ago
Toshio Kuratomi
8fc1c26c37
Merge pull request #14936 from bcoca/ansible_executable
...
add ansible_executable inventory var
9 years ago
Toshio Kuratomi
2ba4428424
Catch ValueError as well because of El Capitan provoking a bug in python2's subprocess
...
Fixes #14895
9 years ago
Abhijit Menon-Sen
a61a3e28da
Merge pull request #9776 from MiLk/fixes/git-repo-info-branch
...
ansible.utils._git_repo_info() now supports branch names with slashes
9 years ago
Brian Coca
db61e9be0c
add ansible_executable inventory var
...
also handle the overrides appropriately
also new executable to set shell type
9 years ago
Thomas Steinbach
14dfad730e
use just 'remote_user' as user for the docker connection
9 years ago
Thomas Steinbach
4ac49ed4a8
use remote_user or become_user in docker connection
9 years ago
Brian Coca
5d9b552317
Merge pull request #15024 from bcoca/delegation_vars_fix
...
ensure we use delegated vars on delegation
9 years ago
Toshio Kuratomi
ab693579a9
Clarify the document about the order of matryoshka shells
...
(nesting shells)
9 years ago
James Cammarata
1ee6d489ab
Make sure tuples returned by _get_item() are handled correctly in formatting
...
Fixes #14800
9 years ago
Brian Coca
292be944c6
ensure we use delegated vars on delegation
...
this prevents falling back to connection vars from the inventory_hostname
when matching connection var is not in delegated host.
9 years ago
René Moser
0a457230ab
Merge pull request #14982 from Linuturk/GalaxyInitWhitespaceFix
...
Remove trailing whitespace from the galaxy init Jinja2 template. Defa…
9 years ago
Toshio Kuratomi
2dd6bae9e1
Merge pull request #15003 from ansible/jail-enable-pipelining
...
Enable pipelining for jail connection plugin
9 years ago
Brian Coca
bc60f52db5
avoid exceptiosn when not being called by CLI
9 years ago
Toshio Kuratomi
e80cd8bcaf
Merge pull request #14908 from mattclay/mysql-connect-timeout
...
Document mysql connect_timeout and update tests.
9 years ago
James Cammarata
0e68c6d6fe
Cleaning up use of literal_eval in basic.py AnsibleModule.safe_eval
9 years ago
Matt Clay
6a1f97ad42
Add docs for mysql* modules connect_timeout.
9 years ago
Brian Coca
5ae9955aad
Merge pull request #15011 from dagwieers/fix-unreachable-color
...
Fix the color when unreachable in default cb plugin
9 years ago
Brian Coca
0cb804f0c2
fix lsb fact gathering
...
was erroring out when rc !=0 also fixed redundant paths
fixes #14965
9 years ago
Brian Coca
d7d47bcd75
Merge pull request #14989 from nifoc/patch-fetch_url
...
Check return value of get_distribution()
9 years ago
Dag Wieers
ed457ad53b
Fix the color when unreachable in default cb plugin
...
The dedicated color for unreachable errors was not being used in the default cb plugin.
This corrects the color.
9 years ago
qqo
a7f89cac63
fix TypeError: coercing to Unicode: need string or buffer, AnsibleParserError found
9 years ago
qqo
85e843baee
Revert "fix TypeError: coercing to Unicode: need string or buffer, AnsibleParserError found"
...
This reverts commit d1e0719e4c
.
9 years ago
qqo
d1e0719e4c
fix TypeError: coercing to Unicode: need string or buffer, AnsibleParserError found
9 years ago
Brian Coca
61f05c2e8d
strip keys recursively
9 years ago
Toshio Kuratomi
7346e3098a
Update extras submodule ref
9 years ago
Toshio Kuratomi
1346c209b0
Add changes necessary for enabling pipelining for local connections
9 years ago
Toshio Kuratomi
a8acd7f93e
Enable pipelining for jail connection plugin
9 years ago
Alexey Kalinin
9763e76f6f
add find_host_portgroup_by_name function to vmware utils
9 years ago
Toshio Kuratomi
de306eb5da
Small cleanup to use class attribute directly instead of property for transport names
9 years ago
Toshio Kuratomi
fee73100c4
Move BUFSIZE to __init__ since it's common to many connection plugins
9 years ago
Toshio Kuratomi
0ca4be6fb5
Update submodule refs for docs fixes
9 years ago
Toshio Kuratomi
ec419446b7
Update submodule refs
9 years ago
Daniel Kempkens
696b68f07a
Check return value of get_distribution()
...
On none-Linux systems `get_distribution()` returns `None`, which fails in `fetch_url`, because the return value of `get_distribution()` is not checked before calling `lower()` on the result.
9 years ago
Toshio Kuratomi
fe278202f2
Fix saving of tracebacks on module failure
9 years ago
Justin Phelps
d604c8c3a6
Remove trailing whitespace from the galaxy init Jinja2 template. Default a description.
9 years ago
Toshio Kuratomi
86080fbaa9
Update submodule refs
9 years ago
Toshio Kuratomi
66328e5200
Merge pull request #14967 from ansible/facts-subset-and-cleanup
...
Facts subset and cleanup
9 years ago
夏恺(Xia Kai)
cd6d865e27
use __mro__ for plugin loading when we search for its base class.
...
This would relax the constraint a little bit, allowing subclassing existing plugins.
Signed-off-by: 夏恺(Xia Kai) <xiaket@gmail.com>
9 years ago
Brian Coca
09699d0cd0
meta: clear_facts
...
draft implementation
9 years ago
Brian Coca
f3b9449e07
don't raise exceptoins on bad hosts files
...
fixes #14969
9 years ago
Peter Sprygada
ace0c9c5c2
fixes ansible-modules-code#3250
...
Sets the default value for transport to 'cli'
9 years ago
Peter Sprygada
c039ac524d
updates to nxos shared module
...
This commit address a number of minor updates the nxos shared module
* connect() is now lazy loaded
* parse inner output messages when errored
* code syntax cleanup
9 years ago
Toshio Kuratomi
512825455e
Make ohai and facter work via module_utils Fact classes rather than in the setup module
9 years ago
Toshio Kuratomi
5a1e35224b
Make changes proposed during review of restrict fact gathering feature:
...
* Make documentation examples into code blocks
* Make code to call the subsets more general.
* Made min subset always execute (cannot disable it).
* Use a passed in modules parameter rather than global modules. This is needed for ziploader
* Remove unneeded __init__()
* Remove uneeded multiple inheritance from a base class
* gather_facts is now a list type
9 years ago
Toshio Kuratomi
d665911bab
Allow FieldAttribute lists and sets to be set from a comma separated string
9 years ago
Yannig Perré
88772b6003
Add a way to restrict gathered facts in Ansible:
...
- Using gather_subset options
- By ignoring ohai/chef or facter/puppet facts
9 years ago
Brian Coca
2984ffdfac
now item callback honors display_skipped_hosts
...
fixes #14956
9 years ago
Peter Sprygada
d211b4c962
feature to implement localized cli prompts to eos
...
This change localizes the cli prompt regexps to the eos shared module
instead of the common prompts implemented in shell
9 years ago
Peter Sprygada
5338d6af28
feature in ios to tell shell not to kickstart
...
This commit is necessary to tell shell not to kickstart the cli session as
it causes problems in IOS to recognize the prompt.
9 years ago
Peter Sprygada
249caac0d3
feature to allow prompts to be configured at instatiation
...
This commit adds a new feature to allow implementations of shell to
specify the command prompt regexp to be used. It allows adds a new
kwarg at instantiation to kick the remote device with a carriage return.
By default the kickstart flag is true but can be disabled by passing
kickstart=False.
9 years ago
Peter Sprygada
c55d1c55af
Merge pull request #14906 from devananda/fix-shell-for-junos
...
Send empty command before recv
9 years ago
Brian Coca
00b8b49112
Merge pull request #14873 from bcoca/paging_aws
...
paging for amazon modules
9 years ago
Brian Coca
fdcd80bf87
Merge pull request #13339 from bcoca/retry_rate
...
draft of common retry and rate limiting decorators for api based modules
9 years ago
Peter Sprygada
e3671a8a83
bugfix for eos shared module and new optimization
...
This commit address to issues in the eos shard module. The first one
is a bug fix for returning the running config when the transport is eapi.
The shared module will now return config text instead of an object. The
second is a optimization that delays when the eos module connects to the
remote devices. This provies a performance enhancement when using
ssh since the module doesn't default to connecting immediately
9 years ago
Toshio Kuratomi
180e70b67a
Merge pull request #14937 from mattclay/unicode-dir
...
Fix missing to_bytes on directory path.
9 years ago
Matt Clay
1e1852c34d
Add missing to_bytes on directory path.
9 years ago
root
2aba1c211d
Modified files to use single quotes rather than double for file path. Powershell does not process $ variables in strings that are single quoted. Powershell DOES process $ variables that are in double quoted strings.
...
Using single quotes enables ansible to handle file paths that contain folders that start with $. (i.e. C:/Users/$admin/...)
9 years ago
mvgrimes
e613737b80
Dynamically add ssl key to the mysql config hash iff needed
...
Just including the `ssl` key in the config for MySQLdb.connect, causes it to check for the existence of SSL support. This patch only adds the key if one of the ssl configuration options is included.
9 years ago
David Shrewsbury
336d19d3b0
Set type for OpenStack 'verify' param
...
The 'verify' param is a bool, so we don't want it to be an assumed
str.
9 years ago
Peter Sprygada
a59fe25bb1
bugfix for shared module shell.py
...
removes get_cli_connection function which was left over from a refactor
but was no longer in use
9 years ago
Matt Clay
ba1bcdfc17
Add noseclabel support to libvirt_lxc plugin.
9 years ago
James Cammarata
16f107a491
Add mysql connection_timeout param to module_utils/mysql.py
9 years ago
Devananda van der Veen
08f270ad71
Send empty command before recv
...
On some switches, starting an SSH connection and immediately calling
recv() will result in a connection timeout. The switch requires some
input on the channel before it provides any prompt.
As such, this patch sends an empty command immediately upon connection,
triggering the switch to send a prompt which the shell can then
interpret.
Signed-off-by: Devananda van der Veen <devananda.vdv@gmail.com>
9 years ago
James Cammarata
52efd7438c
Fixing template/assemble action plugins related to tmp dir use/cleanup
9 years ago
Matt Clay
f878a5d2e0
Fix unicode handling in connection plugins.
9 years ago
James Cammarata
09e5f0578a
Don't always insert failed in the results (again)
9 years ago
Brian Coca
5cbdaff9fd
avoid creating extra tmp dirs we don't delete
...
fixes #14867
9 years ago
James Cammarata
ccf646665b
Revert "Removing explicit setting of failed/failed_when"
...
This reverts commit 4e528e9535
.
9 years ago
James Cammarata
4e528e9535
Removing explicit setting of failed/failed_when
9 years ago
Brian Coca
df1268ed69
Merge pull request #14892 from dagwieers/patch-14
...
Another misspelling
9 years ago
Brian Coca
05983fdaa5
Merge pull request #14891 from dagwieers/patch-13
...
Fix misspelling and some cosmetic change
9 years ago
Brian Coca
1c1f5e9f99
Merge pull request #14889 from nitzmahone/fix_failed_when_blind_override
...
Fix blind override in failed_when
9 years ago
Peter Sprygada
ca2871de20
Merge pull request #14697 from privateip/shared_module_openswitch
...
bugfixes for openswitch shared module
9 years ago
Peter Sprygada
ae5951b97f
Merge pull request #14698 from privateip/plugin_action_ops_template
...
updates the ops_template plugin action backup key
9 years ago
Dag Wieers
a5e11b1325
Another misspelling
...
...while reading the source
9 years ago
Dag Wieers
d7d04ad2cd
Fix misspelling and some cosmetic change
9 years ago
nitzmahone
dbff3a6bbc
Fix blind override in failed_when
...
caused all task failures to be success
9 years ago
Brian Coca
18e9bc9753
common retry and rate limiting decorators for apis
...
allows modules to wrap their request functions in common retry and rate limiting
decorators or functions
9 years ago
Brian Coca
9318727021
corrected changed_when handling
9 years ago
James Cammarata
7f233c4c5e
Updating submodule refs
9 years ago
Toshio Kuratomi
331f62f769
Update submodule refs
9 years ago
Toshio Kuratomi
0628951ac6
Handle shlex incompatibility between python2.6 and python3
9 years ago
Toshio Kuratomi
c0e2dd1693
Fix ssh connection plugin to work with python3
9 years ago
James Cammarata
eb463fab00
Also changing ansible-shell -> ansible-console in cli code comments
9 years ago
James Cammarata
9d61a6cba8
Fixing PlayIterator bugs
...
* Unit tests exposed a problem where nested blocks did not correctly
hit rescue/always portions of parent blocks
* Cleaned up logic in PlayIterator
* Unfortunately fixing the above exposed a potential problem in the
block integration tests, where a failure in an "always" section may
always lead to a failed state and the termination of execution
beyond that point, so certain parts of the block integration test
were disabled.
9 years ago
Brian Coca
d7bd5fc075
Merge pull request #14824 from bcoca/ansible_shell
...
draft 1st release of ansible shell
9 years ago
Brian Coca
7067bb32b8
make all conditionals lists
...
this brings them to equivalence with when:
fixes #13905
9 years ago
Matt Clay
33f93f9241
Fix misplaced paren.
9 years ago
Brian Coca
33b550fc76
paging for amazon modules
...
this adds a decorator for use in amazon modules so retrieval functions
can page using the 'marker' that most boto functions return
9 years ago
James Cammarata
aee2eb6287
Merge pull request #14864 from dagwieers/patch-12
...
Only show diff when the task actually induced a change
9 years ago
James Cammarata
1a5ee115f0
Fixing minor logic error in error detection/handling in ssh connection plugin
...
If max retries were reached, no AnsibleConnectionFailure was raised, which
means potentially in some cases an unreachable error might not be returned
9 years ago
Dag Wieers
f5b6f52940
Only show diff when the task actually induced a change
...
This implements solution #1 in the proposal #14860 .
It only shows the diff if the task induced a change, which means that if the changed_when control overrides the task, not diff will be produced.
See #14860 for a rationale and the use-case.
9 years ago
Dag Wieers
175351f200
Little improvement in flow
...
Don't get the hostname if it's not needed.
9 years ago
Brian Coca
49bb4803b5
clarify --step prompt
...
now shows full words and indicates default
fixes #7433
9 years ago
Brian Coca
3d6ec52e83
Merge pull request #14830 from bcoca/assemble_fix
...
fix assemble to not pass extra args to copy/file
9 years ago