Commit Graph

4319 Commits (006770e04c2a7ca2c8219ffab3ab12cb68d7e1b9)

Author SHA1 Message Date
James Cammarata e3ee7787ed Remove erroneous set of status_code causing a traceback in module uri
Fixes #7416
11 years ago
Michael Peters 15b3b42525 slight language change based on feedback from jimi-c 11 years ago
Michael Peters 69923cc413 fixing some typos in the docs of the yum module 11 years ago
Alan Pearce 670068aaad Update composer example
Remove unsupported 'install' argument
11 years ago
Michael DeHaan b80b92e778 Stackdriver module was in the wrong category, so moving. 11 years ago
Matt Bray 8363ab5a6f docker: fix targetting images by name 11 years ago
James Cammarata 32ce085689 Merge branch 'patch-1' of https://github.com/telsacolton/ansible into telsacolton-patch-1 11 years ago
James Cammarata df877f2e79 Check module_path permissions when creating ssh_wrapper for git
If the module directory is not writable/executable to the current user
(most likely because of a sudo to a non-root user), the ssh_wrapper
will be created in the default location for mkstemp() calls. To facilitate
the deletion of these new files, a new mechanism for cleaning up files
created by the module was also added.

Fixes #7375
11 years ago
telsacolton 06963c7826 Make file hardlink error message reasonble
When we hard-link a file, and the link path already exists, give the link path in the error message instead of the source
11 years ago
telsacolton 0d8104b8b7 Give reasonable error when symlink fails
When a symlink fails because the path already exists and force=no, we should output path in the error message instead of source.
11 years ago
James Cammarata 67d8df0e32 During vsphere config check attempt cast before marking values missing
Fixes #7385
11 years ago
James Cammarata 154ef942eb Merge pull request #7404 from jimi-c/issue_7363_docker_names
Make sure the docker data has a "Names" field before using it
11 years ago
James Cammarata e623911df6 Merge branch 'bcoca-file_new_dirs_perms' into devel 11 years ago
James Cammarata a9311a5dcb Merge branch 'file_new_dirs_perms' of https://github.com/bcoca/ansible into bcoca-file_new_dirs_perms 11 years ago
James Cammarata bf405ef7a8 Merge pull request #7400 from etehtsea/patch-1
Fix env splitting in docker module
11 years ago
Konstantin Shabanov ad9225895b Fix env splitting in docker module
ENV variable value could contain '=' (for example mysql://host/db?pool=10)
11 years ago
Scott Sturdivant 726dc1d2e8 Clarify that the encrypted param must also be set.
While the encrypted parameter's documentation clearly states that it needs to
be set, if you are focused on the password parameter's documentation, there's
nothing to draw your attention to the fact that encrypted may also need to be
set.
11 years ago
James Cammarata 19dbff916f Correctly cast the size_gb value for vpshere disks
Fixes #7385
11 years ago
Carson Gee e6fbd2d8cb Fix missing variable initialization so an unspecified internal_network runs 11 years ago
Mikhail Emelchenkov a2ca0441ae Fixed incorrect handling of paths contaiin whitespaces 11 years ago
Matt Martz 92b77048dc Handle ValueError during json.loads of json data from build 11 years ago
James Cammarata bfc1201ecd Make sure the docker data has a "Names" field before using it
Fixes #7363
11 years ago
Yuichi TANIKAWA 2b644da4ca Add dots to valid path characters 11 years ago
James Cammarata 3bf890998b Merge pull request #7348 from adamchainz/patch-2
Fix grammar and value errors in cron documentation
11 years ago
James Cammarata 62c4a15c73 Merge pull request #7346 from tongpu/devel
Add documentation for required parameter name to quantum_subnet
11 years ago
Johannes 'fish' Ziemke ea71c0c317 Fix: Remove check for Ghost state
This fixed the just committed change handling non existent Ghost state.
11 years ago
James Cammarata c97dec9d75 Merge pull request #7338 from discordianfish/remove-ghost-state
Remove check for Ghost state
11 years ago
Johannes 'fish' Ziemke b9d9ef511f Remove check for Ghost state
This doesn't exist anymore and causes ansible to throw a KeyError
11 years ago
Adam Chainz 3497582581 Fix grammar and value errors in cron documentation 11 years ago
James Cammarata b78058022d Merge pull request #7342 from herbygillot/rds-params-fix
rds module: Fix undeclared reference to "params" when setting password in modify mode
11 years ago
Lukas Grossar 0aa4cb9a79 Add documentation for required parameter name to quantum_subnet 11 years ago
Michael DeHaan 54ac0fe92c Merge pull request #7343 from lberruti/alternatives_python5_2
Make alternatives module python 2.5 compatible
11 years ago
Herby Gillot efbe4ca8d5 rds module: Fix undeclared reference to "params" when setting password in
modify mode.
11 years ago
James Cammarata 5c7109b8b9 Merge pull request #7110 from orgoj/docker-patch-version_comment
module docker - add docker version comment
11 years ago
James Cammarata a18f4b6230 Merge branch 'devel' of https://github.com/jjshoe/ansible into jjshoe-devel 11 years ago
James Cammarata 0215134907 Fixing a doc mistake in the ec2 module from 4269bb6 11 years ago
James Cammarata 48e2a5e5a2 Merge branch 'ec2-start-stop' of https://github.com/sayap/ansible into sayap-ec2-start-stop 11 years ago
Yap Sok Ann 4269bb6a45 ec2: Fix bug with running/stopped state and wait=yes.
If `get_all_instances` returns multiple reservations, the old wait loop only
dealt with the first reservation. Thus, the wait loop may end before all
instances get to be running/stopped.

Also clean up the code a little.
11 years ago
James Cammarata 9d3583cab3 Merge pull request #7055 from bpennypacker/rds_modify
cloud/rds : renaming an rds instance always fails
11 years ago
James Cammarata ebac5dfbce Updating docstring for docker_image based on new default for tag 11 years ago
James Cammarata 34e52c5884 Merge branch 'docker_image-patch-notag' of https://github.com/orgoj/ansible into orgoj-docker_image-patch-notag 11 years ago
James Cammarata 8dd91021f4 Merge branch 'git-submodule-when-recursive-true' of https://github.com/bibliotechy/ansible into bibliotechy-git-submodule-when-recursive-true 11 years ago
James Cammarata 39433949e0 Merge branch 'elb_subnets' of https://github.com/jimbydamonk/ansible into jimbydamonk-elb_subnets 11 years ago
James Cammarata 4358c846a0 Merge branch 'brian-brazil-devel' into devel 11 years ago
James Cammarata b97f087f18 Fixing a typo in the monit module (status and not status()) 11 years ago
James Cammarata a969941b85 Merge branch 'devel' of https://github.com/brian-brazil/ansible into brian-brazil-devel 11 years ago
James Cammarata d9bb1a480a Merge pull request #7013 from orgoj/replace-patch-changed
module replace - report changed only if contents is changed
11 years ago
James Cammarata 3ac4943751 Some cleanup for the rds/vpc_security_groups fix 11 years ago
James Cammarata 768de238d4 Merge branch 'vpc_fix' of https://github.com/ebrevdo/ansible into ebrevdo-vpc_fix 11 years ago
James Cammarata 1a52fcce03 Merge pull request #7335 from napkindrawing/patch-1
Route53 module handling of domains with "*" is broken
11 years ago
napkindrawing 011ec5d9e6 Fix to unescape * was discarded by unescape of @
`decoded_name` was created twice, each from `rset.name`

So, the second call to `.replace(r'\100', '@')` overwrites decoded_name, discarding the result of the call to `.replace(r'\052', '*')`

I had a problem with wildcard domains that was fixed by this patch.
11 years ago
Chris Lamb f510389298 Fail if monit reload failed; don't mask the error.
This is necessary for the scenario when you push a new, broken monit
config out, and then set a state=reloaded handler - the error was
previously swallowed so you could end up with successful play but missing
monitoring (!).

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
11 years ago
Luca Berruti a3d1f06cb2 Make alternatives module python 5 compatible 11 years ago
James Cammarata 713657d684 Make sure the default ec2_group egress rule is not removed
Upon a second run, the default egress rule will be removed when a
vpc is specified but no other egress rules were set. This patch
corrects that behavior by removing the default egress rule from the
list of unmatched outbound rules.

Fixes #7309
11 years ago
James Cammarata bd56cfdf18 Merge pull request #7313 from mmoya/doc-fixes
Minor typo fix
11 years ago
James Cammarata b71a451ed0 Close fds when running commands from the accelerate daemon
Fixes #7307
11 years ago
Maykel Moya 1d3ce41e83 Fix typo 11 years ago
Christian Berendt 2c39eff60e [get_url] check against lowered stripped sha256sum
The content of the sha256sum attribute should be lowered before comparing it with the calculated sha256sum.

In the following example the used sha256sum uses ABC.. and not abc.. and the check failed. This should not happen.

```
TASK: [get_url url=http://ftp.fau.de/apache/hadoop/common/hadoop-2.4.0/hadoop-2.4.0.tar.gz dest=/home/vagrant/hadoop-2.4.0.tar.gz mode=0644 sha256sum=024326AC68A1A68B5566B10F95609EAAFD9F70CFEB37FCA0E97CBB1674E57C3A] ***
failed: [instance000] => {"failed": true}
msg: The SHA-256 checksum for /home/vagrant/hadoop-2.4.0.tar.gz did not match 024326AC68A1A68B5566B10F95609EAAFD9F70CFEB37FCA0E97CBB1674E57C3A; it was 024326ac68a1a68b5566b10f95609eaafd9f70cfeb37fca0e97cbb1674e57c3a.

FATAL: all hosts have already failed -- aborting
```
11 years ago
James Cammarata 537494c2d6 Make sure distro variable is set if python-apt is installed
Fixes #7295
11 years ago
James Cammarata 941af22d5d Merge pull request #7294 from adamchainz/patch-1
Fix sync_binlog name in mysql_variables example
11 years ago
James Cammarata 7bf86ec1c0 Merge branch 'fixing_apache2_module' of https://github.com/berendt/ansible into berendt-fixing_apache2_module 11 years ago
Adam Chainz 967de3cdf9 Fix sync_binlog name in mysql_variables example
The previous sync_binary_log is not a real MySQL variable.
11 years ago
James Cammarata d6fc9f1dfc Fixing two bugs in the ec2_elb_lb module
* the current state of the ELB was not reflected properly when checking
  the status after a change was made.
* invalid zones caused a traceback when enabling/disabling zones
11 years ago
James Cammarata faf733bc49 Removing zone choices that overly-limit available zones for gce
Fixes #7270
11 years ago
James Cammarata b753625dbf Refuse to convert a non-empty directory into a link with the file module
Also adds an integration test for the above.

Fixes #7254
11 years ago
Kesten Broughton aee1a97102 if key name already exists on tenant, check if public_key is offered that it matches the existing key 11 years ago
James Cammarata ae7503d6fb Merge branch 'fix-copy-recursive-issue' of https://github.com/tksmd/ansible into tksmd-fix-copy-recursive-issue 11 years ago
James Cammarata c0f92317ef Fixing a documentation error in the new stackdriver module 11 years ago
James Cammarata 2b898e7e8b Minor fix to imports in new stackdriver module 11 years ago
someda 50080b3774 fix #7244 recursive copy fails when setting directory attributes
- reverse the order of new_directory_list returned from split_pre_existing_dir in copy module
11 years ago
James Cammarata 6069d5d4cf Merge branch 'stackdriver' of https://github.com/bwhaley/ansible into bwhaley-stackdriver 11 years ago
willthames 44662a3d33 Improve the ec2_snapshot argument spec and docs
ec2_snapshot got missed when moving to a common argument spec.
It could already make use of the capabilities (as it uses
ec2_connect) and the documentation suggested it supported the
common argument spec (thanks to the documentation fragment work)
so it was just a matter of fixing the argument spec.

Removed unnecessary documentation for profile and security_token
that is covered by documentation fragment

Also removed spurious documentation flags (default: null, aliases: [])
which aren't needed.
11 years ago
James Cammarata ce48e1f9ff Merge pull request #7230 from binarytemple/fix_for_issue_7228
fix issue #7228 ec2_vol crash
11 years ago
bryan hunt 88aaa70f0c fix issue #7228 ec2_vol crash 11 years ago
Atlas Health 49d0ad0644 added example 11 years ago
Atlas Health 4258eb6be7 updated docs to include snapshot_tags option
added version
11 years ago
James Cammarata 04793ff640 Merge branch 'patch-2' of https://github.com/budlight/ansible into budlight-patch-2 11 years ago
Michael DeHaan 6b26efdee0 Merge pull request #7119 from jjshoe/patch-4
Finish reverting a broken commit in #5679
11 years ago
James Cammarata ac1948c04c Minor tweak to rsync_path construction in synchronize module
Fixes #7182
11 years ago
Michael DeHaan d5e254d3c7 Merge pull request #6794 from follower/patch-4
Make `vpc_security_group` docs more accurate
11 years ago
Michael DeHaan 5c75ce1133 In apt module show 'name' vs pkg to standardize with the rest of the modules. 'pkg' is an alias for name. 11 years ago
James Cammarata d2819e22e3 Merge pull request #7212 from jimi-c/issue_7027_ec2_group_egress_rules
Make sure a default allow out rule exists if no other egress rules do
11 years ago
James Cammarata 67092039d7 Merge pull request #7190 from jimi-c/issue_7180_vsphere_guest_hardware_variable_casts
Make sure values are integers for certain hardware items for vpshere_guest
11 years ago
James Cammarata 826198196b Merge branch 'elb' of https://github.com/bpennypacker/ansible into bpennypacker-elb 11 years ago
Christian Berendt 67a8ee24e1 made enabled/disabled checks of apache2_module workable 11 years ago
James Cammarata 50cd3a4a8f Make sure values are integers for certain hardware items for vpshere_guest
Fixes #7180
11 years ago
James Cammarata a482e1583d Merge branch 'fix_user_non_root_on_rhel' of https://github.com/mscherer/ansible into mscherer-fix_user_non_root_on_rhel 11 years ago
Michael Scherer 28c373da0c Do not fail if we try to generate a ssh key for a user without being root
If we try to use the user module without being root, it fail on RHEL/Fedora
because usermod --help cannot be run. The root cause is lack of permission
due to EAL4+ certification, as seen in shadow-utils changelo.

So if we cannot run it, assume there is no append. It doesn't matter
much since we will not be able to run usermod at all with or without the
option.
11 years ago
Skyler Leigh Amador a8d9470938 Remove --timeout option to rsync from synchronize defaults
The current 10-second default timeout for rsync seems to be behind issue #6809.

As a workaround for the underlying issue in rsync when different versions are
used on the source and destination sides, don't include the timeout option
unless the user specifies a timeout > 0.
11 years ago
Michael DeHaan 2ea386fe04 Merge pull request #7168 from jjshoe/fix_apache2_module_docs
Fix example
11 years ago
Joel Schuweiler 7916545979 Fix example 11 years ago
Joel Schuweiler 5bad971873 Finish reverting #b73cddc 11 years ago
jjshoe a34478d6f3 Ensure the validation string has %s in it 11 years ago
Brian Brazil d25f1dc2d0 Use empty string rather than None to avoid TypeError
Improve error messages.
11 years ago
mkosmach fbf3b78ace add simplejson as alternative to json 11 years ago
Ben Holloway e45d33954b documentation fix 11 years ago
Ben Holloway 4596521147 attempt to set availability_zones to all if neither availability_zones or vpc_identifier are set 11 years ago
Bruce Pennypacker dc912ca201 removed unwanted 'if wait else None' 11 years ago
Ben 5a39672efa documentation fix availability_zones should be required for ec2_asg 11 years ago
Ben 30b634eae9 updated example to include instance_type 11 years ago
Ben 9770c7f47d Added instance_type to ec2_lc variable list 11 years ago
Michael DeHaan 31f7a0693e Add missing license headers to two modules and standardize formatting of another. 11 years ago
James Cammarata 89fa9b7305 Add parameters to get_url for the url username/password
Fixes #6928
11 years ago
James Cammarata 83f300ddd6 Merge branch 'apt_key_format' of https://github.com/andreasf/ansible into andreasf-apt_key_format 11 years ago
James Cammarata 3f1545f9db Fixing the version_added string in the vsphere_guest module 11 years ago
James Cammarata 833ceeca24 Merge branch 'vmware_core' of https://github.com/rhoop/ansible into rhoop-vmware_core 11 years ago
James Cammarata 2bc640c82f Merge pull request #7141 from lamby/devel
Correct/update debconf examples - need to specify vtype.
11 years ago
npeters 61bb40c0dd Remove invalid variable 11 years ago
Ben Whaley 1c996085ff Updated to use fetch_url 11 years ago
James Cammarata 16874464e9 Merge pull request #7047 from joshuaconner/docker_bugfix_exclude_entrypoint_from_command_check
docker: exclude 'entrypoint' from comparing 'command' param with containers
11 years ago
James Cammarata 46c0eb2f3e Merge pull request #7022 from jjshoe/patch-1
apt_key lists all keys in uppercase
11 years ago
Richard Hoop 578ba471b1 Author 11 years ago
Chris Lamb 446765ace0 Correct/update debconf examples - need to specify vtype.
Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
11 years ago
James Cammarata 060e2193a1 Merge pull request #6991 from joshuaconner/bugfix_dont_send_wrong_params_to_dockerclient_start
Docker: don't send wrong parameters to client.start()
11 years ago
Richard Hoop 07ad8432ec Ready for pull request 11 years ago
Richard Hoop 5692ae95ab Core complete 11 years ago
James Cammarata eb090ad4a2 Merge pull request #6599 from dmage/nova_region_name
use region_name in nova_compute
11 years ago
James Cammarata 24cfcd1f88 Merge pull request #6985 from jimi-c/issue_6763_ec2_vpc_params
Ensure params were set in ec2_vpc before accessing them
11 years ago
Brian Coca f079d022a3 now when making multiple dirs in path to make dir, same permissions are assigned (but only for NEW dirs)
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
11 years ago
James Cammarata ed1c7a0f5d Merge pull request #7128 from stansonhealth/improve_tag_docu
update ec2_tags documentation to include missing option
11 years ago
Erika Heidi 036c7a7759 Possible docs error: 'path' instead of 'src'
I came to this example today (line 50), and when I tried it, I got an error:

`msg: src and dest are required for creating links`

So, I changed **path** to **src** and it worked fine. Looks like the example is wrong, since the docs say "dest" is already an alias for "path", in which case we would have 2 "path" definitions.
11 years ago
Richard Hoop 68d45a6484 Started reconfigured 11 years ago
Ted Timmons b5895712b3 update documentation to include missing option
'list' was added more recently, it was omitted from the documentation.
11 years ago
Richard Hoop 630367ebfc Creation complete 11 years ago
Richard Hoop 3e75e504e0 More config checks and clean up for vm_config settings 11 years ago
Bruce Pennypacker 2be8feebce Changed behavior of deregister. If an instance is not found in the ELB then simply return 'changed=false'. Otherwise always remove the instance from the ELB no matter what state its currently in. 11 years ago
James Cammarata d88ac5e24d Merge pull request #7076 from mscherer/better_message_service
Add a better error message for service
11 years ago
Mike Buzzetti 4cb41de987 Updated and corrected example section 11 years ago
Michael Heca 9ad6511be7 module docker - add docker version comment
Default docker version 0.9.1 from Ubuntu 14.04 LTS don't report APIVersion.
11 years ago
Michael Scherer 43d0fbd342 Add a better error message for service
While migrating my playbook to a newer ansible version, I faced
the error message "unknown init system, cannot enable service". It turned
out to be caused by a wrong service name that was not expanded anymore.

So by giving the name of the service that cannot be enabled and a more precise
reason, i think people will be able to diagnose their issue more easily.
11 years ago
Mike Buzzetti b2c5106833 Adding support for purging subnets 11 years ago
Richard Hoop 06c64785fb Large cleanups. Reintegrating all modules together for a guest 11 years ago
James Cammarata 149339f620 Merge pull request #7089 from dagwieers/debug-docs
Add an example to show all hostvars using debug
11 years ago
James Cammarata 53754357f7 Merge pull request #7096 from CaptTofu/docker
Small bug - 'acts' should be 'facts'
11 years ago
James Cammarata afee14173e Merge pull request #7095 from radeksimko/pokemon-exc-fix
Prevent catching unrelated exceptions
11 years ago
CaptTofu 2990db728a Small bug - 'acts' should be 'facts' 11 years ago
Radek Simko 1513d2bd64 Prevention for catching unrelated exceptions added 11 years ago
Radek Simko 8bdd96b273 Explicit check of return code for autoinstallation of python-apt added
This will allow easier debugging through more meaningful error message.
11 years ago
Dag Wieers 3c15d64655 Add an example to show all hostvars using debug
This is a useful example to help debug how facts and vars are being collated.
11 years ago
Bruce Pennypacker b57887bafd Fix for https://github.com/ansible/ansible/issues/7054 - when renaming an instance and waiting for the change to occur, force result.id to the name of the new instance so the subsequent call to get_current_resource succeeds. 11 years ago
Michael Heca 4271613aa5 module docker_image - default tag latest
Fix constant rebuild of image if no tag specified.
11 years ago
Mike Buzzetti 5dada9403e Adds support for VPC subnets to ELB 11 years ago
Joshua Conner 4defd9a15a docker: exclude 'entrypoint' from comparing 'command' param with containers
The JSON the Docker API returns includes the container's ENTRYPOINT value (if it has one) with the 'Command' value. So instead of checking if `container['Command'] == module.params['command']`, we just check that `container['Command'].endswith(module.params['command'])` so the entrypoint won't affect a container being properly classified as matching the module params or not.

Also I refactored a super-long `if` statement into some temporary variables - I did it to help me figure out what was going wrong, and then it makes the code more readable so I kept it.
11 years ago
Joshua Conner 10171dc42b docker: send 1.10 params if docker-py is new enough version 11 years ago
James Cammarata 1ef0402f03 Make sure a default allow out rule exists if no other egress rules do
Fixes #7027
11 years ago
Chad Nelson ef1a8e4cdd Only update submodules when recursive is true 11 years ago
Andreas Fleig 337a0059d9 apt_key: fix key lookup for 64 bit key ids
Fixes #7018 by extending `all_keys` to work with either short or long keys.

Also removes the ununsed method `key_present`.
11 years ago
Matt Bray 3948dc2d1d docker.client.APIError has moved to docker.errors.APIError
see 18d4db09ec
11 years ago
James Cammarata a37a84243b Check resource_tags value before using it in ec2_vpc
Fixes #7024
11 years ago
Brian Brazil 8ec400669f Fix race conditions where a process gets in state "Running"
between the restart/start command and the summary command.

Refactor to avoid repeating the status, and fail if a given call to monit fails.
11 years ago