2980 Commits (0055a328b3250b40de5b4027458c51887379b7eb)

Author	SHA1	Message	Date
David Shrewsbury	c8ee186e11	Remove warning about role validation with deps (#73653) ... * Remove warning about role validation with deps * add changelog * update cl	4 years ago
Willams de Lima	fa05af8321	Fixing ad-hoc commands #73636 (#73646)	4 years ago
Toshio Kuratomi	89ed2353e0	Update the porting guide for a new ansible version (#73650) ... * Update the porting guide for a new ansible version * Add a link to the changelog to the ansible-3 porting guide	4 years ago
Sandra McCann	ccbfdec334	Split Ansible docs from core docs (#73616) ... * excludes scenario guides from core docs, splits porting guides and roadmaps, symlinks indices to create index.html pages, and adds .gitignore entries for conf.py and the toplevel index.rst files generated by the docs build This solution builds three types of docs: * ansible-2.10 and earlier: all the docs. Handle this via `make webdocs ANSIBLE_VERSION=2.10` * ansible-3 and later: a subset of the docs for the ansible package. Handle this via `make webdocs ANSIBLE_VERSION=3` (change the ANSIBLE_VERSION to match the version being built for. * ansible-core: a subset of the docs for the ansible-core package. Handle this via `make coredocs`. * `make webdocs` now always builds all the collection docs * Use `make coredocs` to limit it to core plugins only * The user specifies the desired version. If no ANSIBLE_VERSION is specified, build plugins for the latest release of ansible Co-authored-by: Toshio Kuratomi <a.badger@gmail.com> Co-authored-by: Matt Clay <matt@mystile.com>	4 years ago
Sebastian Haderecker	27baa8cd86	OpenStack guidelines: Replace with link (#73617) ... Replace the guidelines page with a link to the current guidelines on opendev.org.	4 years ago
David Moreau Simard	d40da3ee0b	Update 2.10 porting guide to include module index (#73615) ... This will help users find out where modules and plugins might have been moved.	4 years ago
Felix Fontein	1f3a90270b	Import sanity test for plugins (#72497)	4 years ago
Lydie	4059b37ab1	Conscious language added to user guide, development guide, and Ansible community guide, (#73574) ... * Added conscious language note to index pages of guides	4 years ago
David Shrewsbury	f0ec10dbc3	Role arg spec validation implementation (#73152) ... * Initial import of modified version of alikins' code * Add unit testing for new Role methods * Fix validate_arg_spec module for sanity test. Add test_include_role_fails.yml integration test from orig PR. * Add testing of suboptions * Use new ArgumentSpecValidator class instead of AnsibleModule * fix for roles with no tasks, use FQ name of new plugin * Add role dep warning	4 years ago
Toshio Kuratomi	2b227203a2	Ansible 4 roadmap (#73465) ... Co-authored-by: Deric Crago <deric.crago@gmail.com> Co-authored-by: Sandra McCann <samccann@redhat.com> Co-authored-by: John R Barker <john@johnrbarker.com> Co-authored-by: Deric Crago <deric.crago@gmail.com> Co-authored-by: Alicia Cozine <acozine@users.noreply.github.com>	4 years ago
Brian Coca	1cb753225c	added perf note to inc/imp diffs (#73371)	4 years ago
Brian Coca	4334957e2c	add that we now validate choices to porting guide (#73509) ... for those that had choices that didn't match actual values used	4 years ago
Rick Elrod	7cd577cc16	Fill in some 2.11 roadmap dates (#73560) ... Signed-off-by: Rick Elrod <rick@elrod.me>	4 years ago
Florian Sey	ae241b407a	Update guide_azure.rst (#73030) ... Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com> Co-authored-by: Alicia Cozine <879121+acozine@users.noreply.github.com>	4 years ago
Toshio Kuratomi	bf10bb370b	Update the porting guide for a new ansible release (#73547)	4 years ago
Matt Martz	d3441bc313	Add new split filter (#73532) ... * Add version added	4 years ago
Jill R	7fb7d138fb	Update working group links for cloud collections (#73471)	4 years ago
Sloane Hertel	bd18be6c0c	Fix ansible-galaxy collection subdir searching and update documentation (#73406) ... * Ensure there is a single source of collection metadata * Allow collection subdirs to be detected by a galaxy.yml or MANIFEST.json * Add documentation about installing and downloading collection directories * Add an example for downloading a git repository * Update documented valid metadata sources for installing git repositories Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua> Co-authored-by: Alicia Cozine <879121+acozine@users.noreply.github.com>	4 years ago
Sloane Hertel	9759e0ca49	add option to upgrade collections (#73336) ... * Add a flag to ansible-galaxy to update collections Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>	4 years ago
Akira Yokochi	fce22529c4	fix typo (#73434)	4 years ago
Toshio Kuratomi	564a0fce4a	Add the porting guide for Ansible-3.x (#73455)	4 years ago
Matt Clay	607af05d36	Fix syntax errors detected by rstcheck. ... The errors occur when using sphinx >= 2.0.0.	4 years ago
David Moreau Simard	1265c6def3	Update porting guide for 2.10.6	4 years ago
Felix Fontein	76604397cb	Mention that C(...) should be used for inline code. (#73312)	4 years ago
Sviatoslav Sydorenko	ab667200cc	Mention renaming ansible-base to -core @ roadmap (#73354) ... * Mention renaming ansible-base to -core @ roadmap * Replace ansible-base with ansible-core @ roadmap	4 years ago
Sviatoslav Sydorenko	6abeabaff1	Fix `versionadded` syntax @ galaxy user guide	4 years ago
Abhijeet Kasurde	7f6fcc3407	json_query: Update documentation (#73302)	4 years ago
Brian Coca	dec443e3a5	why no mfa? (#73324) ... Co-authored-by: Sandra McCann <samccann@redhat.com> Co-authored-by: Rick Elrod <rick@elrod.me>	4 years ago
Nilashish Chakraborty	45240c1871	Update NX-OS platform guide with MDS information (#73315) ... Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>	4 years ago
luto	51e00c5e86	Fix documentation for slaac filter (#73294) ... ##### SUMMARY One of the parameters to the slaac filter was unquoted causing a crash: ``` template error while templating string: expected token 'end of print statement', got ':'. String: {{ fdcf:1894:23b5:d38c:0000:0000:0000:0000 | slaac('c2:31:b3:83:bf:2b') }} ``` This adds the missing quotes. ##### ISSUE TYPE - Docs Pull Request +label: docsite_pr	4 years ago
Brian Coca	13ea312cc8	added pb fqcn docs (#72602) ... * added pb fqcn docs	4 years ago
Koki Kato	d500e6ec45	doc: fix ansible_play_hosts description about failure (#73190) ... The variable ansible_play_hosts actually does _not_ includes failed or unreachable hosts. +label: docsite_pr	4 years ago
Felix Fontein	73aa571305	Make sure to mention collection version for version_added as well. (#73270)	4 years ago
Martijn Suijlen	aa21804165	Added TLS security protocol for Powershell downloads (#73226) ... ##### SUMMARY Added `[Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12` to the Powershell scripts that use a file download. If not specified the script won't be allowed to download data from the mentioned URL's. ##### ISSUE TYPE - Docs Pull Request +label: docsite_pr	4 years ago
Brian Coca	1202dd000f	Allow restricting config values to enumerated list (#73162) ... * Allow restricting config values to enumerated list * dont document internal entries * also ignore private defs for ansible-config * remove invalid value from tests * added porting entry	4 years ago
Adam Miller	e9a1ff296e	Fix block example line emphasis (#73238) ... Signed-off-by: Adam Miller <admiller@redhat.com>	4 years ago
Gregor Riepl	403a3b90b5	Fix list to dict example (#73213) ... ##### SUMMARY <!--- Your description here --> single_list must be transformed to a list of pairs before feeding it into dict() ##### ISSUE TYPE - Docs Pull Request +label: docsite_pr	4 years ago
Felix Fontein	270385f949	Remove 'type: complex' from the example, and mention that it should be avoided. (#73171)	4 years ago
Jens Heinrich	8a202cae3e	Update developing_collections.rst (#73142) ... Fix typo - FQCN not FCQN.	4 years ago
Sascha Marcel Schmidt	61f0d6b919	add note regarding datetime docs (#72976) ... Adds a note pointing to the datetime documentation as to_datetime does not use the time library but instead uses datetime. Co-authored-by: Alicia Cozine <879121+acozine@users.noreply.github.com>	4 years ago
Tim Herty	995e76c6e3	Update windows_winrm.rst (#73101) ... The standard Port for ansible winrm is set to 5986/HTTPS. To be able to use Kerberos, you need to set ansible_port: 5985/HTTP otherwiese you get error message or timeout. HTTPS is not needed for environments with Kerberos, since kerberos has server identification built in to the protocoll. FYI: HTTP traffic will by default also be encrypted when using kerberos	4 years ago
Sandra McCann	0936623901	update the docs requirements versions (#73108)	4 years ago
Felix Fontein	c9f28c1735	Rewrite Docker scenario guide (#73069)	4 years ago
Alicia Cozine	1d8760779c	left a stray </div> by mistake (#73132) ... Co-authored-by: Alicia Cozine <acozine@users.noreply.github.com>	4 years ago
Deric Crago	24e8ba7c9e	Update the porting guide for a new ansible version (#73124)	4 years ago
Abhijeet Kasurde	25792d2388	galaxy: handle plus sign in user token appearing in role url (#73057) ... Fixes: #45475 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>	4 years ago
Sandra McCann	0a3c5d9dcc	remove doc survey banner (#73119)	4 years ago
Jean-Pierre Matsumoto	3074ede8a3	ExecutionPolicy default value is RemoteSigned (#72993) ... * ExecutionPolicy default value is RemoteSigned ##### SUMMARY In Windows setup steps, settings `ExecutionPolicy` is restored to value `Restricted`. But actually default value for Windows server is not `Restricted` but `RemoteSigned` ([source](https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_execution_policies?view=powershell-7.1#default)). I have got issue with `win_dsc` because `ExecutionPolicy` was `Restricted`. ##### ISSUE TYPE - Docs Pull Request +label: docsite_pr * Add changelog fragment * Apply suggestions from code review Co-authored-by: Sandra McCann <samccann@redhat.com>	4 years ago
Abhijeet Kasurde	776274143f	galaxy: Update example for git+file (#73053) ... Use correct syntax for installation of role from local git repository. Fixes: #72217 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>	4 years ago
Simeon Bobylev	202689b1c0	Update lookup.rst (#72831) ... ##### SUMMARY Set correct indentation. ##### ISSUE TYPE - Docs Pull Request +label: docsite_pr	4 years ago
Dmitry	79ab1247b8	Fixed vault id in variable encryption example (#72626)	4 years ago
Sam Doooran	103decccac	Add complex example of fileglob with loop (#72396) ... * Add complex example of fileglob with loop * Explain Python unpacking notation * Add missing paren	4 years ago
Matt Martz	97765f4ebd	Role duplicates docs updates (#72666) ... * Change example to use role params to represent the documented outcome. Fixes #68922 * Add notes about how vars vs role params affect variable scoping, and how lazy evaluation and role-deduplicating is affected. Fixes #72650 * link to term	4 years ago
Felix Fontein	b514200126	Add link to all module and plugin indexes (#72743) ... * Add link to all module and plugin indexes. * Use glob setting for toctree. * Explicitly include new file. * Move all_plugins one level up. * Revert "Move all_plugins one level up." This reverts commit bd47e82ead. * Revert "Explicitly include new file." This reverts commit 74ae50a734. * Adjust .gitignore * Revert "Revert "Explicitly include new file."" This reverts commit f30d99c861. * Fix docs make clean Now that there's a static file in rst/collections, we have to be more explicit about how we clean the generated files out of that directory. Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>	4 years ago
Sam Doooran	8fdb5ace01	Update WSL docs to mention sleep workaround (#72839) ... Co-authored-by: Joseph Chambers <joe.chambers@lexisnexis.com>	4 years ago
tkhkokd	389c7b7806	Documentation fix, /etc/apt/source.list from non-code block to code block (#72933) ... /etc/apt/source.list was sentence, not code-block. Therefore made it code-block	4 years ago
azrdev	6487a239c0	developing_inventory sample code: fix undefined var "results" if get_option(cache)=False (#72977) ... if user_cache_setting == False, then the previous code didn't parse the inventory source	4 years ago
Jamie Wark	7eee2454f6	Remove note on combining roles and collections (#72957)	4 years ago
flowerysong	8450858651	Remove inaccurate Vault documentation (#72938) ... This is not functionality that exists.	4 years ago
Alicia Cozine	e5ccd18be4	Wording changes to docs (#70082)	4 years ago
Sandra McCann	6098793315	add docs survey banner (#72907) ... * add docs survey banner, with date	4 years ago
Evgeni Golov	57c2cc7c77	correct the reST rendering of the R() note (#72896)	4 years ago
lukebtaylor	bc35fbf5de	Change apt-add-repository to add-apt-repository (#72893)	4 years ago
devon-mar	e97f333532	Add missing endfor to vlan_parser example (#72872)	4 years ago
Toshio Kuratomi	6608f3aab3	Update ansible roadmap (#72838) ... * Update to the ansible package roadmap for 3.0.0 * Rename files for the ansible roadmap from 2.11 to 3.0 Co-authored-by: Sandra McCann <samccann@redhat.com> Co-authored-by: Alicia Cozine <879121+acozine@users.noreply.github.com>	4 years ago
Abhijeet Kasurde	38f21557ba	json_query: Add examples for starts_with and contains (#72821) ... * Add a note about - data structure returned from register variables needs to be parsed using ``to_json | from_json`` in order to get correct result. * Add examples for starts_with and contains Fixes: https://github.com/ansible-collections/community.general/issues/320 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>	4 years ago
Andrew Klychkov	0a7fcd135c	Docsite: update "Migrating Ansible content to a different collection" info (#72710) ... * add a reminder about ignore-*.txt entries, fix formatting, add symlink removal note * Update docs/docsite/rst/dev_guide/developing_collections.rst Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: David Moreau Simard <moi@dmsimard.com> Co-authored-by: Alicia Cozine <879121+acozine@users.noreply.github.com>	4 years ago
Andrew Klychkov	2aa3531b1b	Docsite: update complex_data_manipulation and playbooks_advanced_syntax rst files to use FQCNs (#72539)	4 years ago
David Moreau Simard	478b2687ec	Update the porting guide to include 2.10.4 (#72782)	4 years ago
Simon Heimberg	79fb065d16	document that handler can not run include_role and import_role (#72744) ... Warn the users until issue #20493 is fixed.	4 years ago
gfyoung	fa481e3316	Fix missing dashes in playbooks intro doc (#72746)	4 years ago
Pablo Martinez	454ac6420e	Update playbooks_filters_ipaddr.rst (#72705) ... Fix the order of the arguments for ansible.netcommon.reduce_on_network. Pass the network as the argument and the list of IP addresses as the filter input.	4 years ago
gdiamond	74196577a3	added sample output for echo example (#72718)	4 years ago
Abhijeet Kasurde	a57539f764	Update VMware module development (#72603) ... Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>	4 years ago
gdiamond	35022e13a8	Update intro_getting_started.rst (#72689) ... Move the command output to immediately follow the example.	4 years ago
Marco Lembo	1937dd5e9c	Update developing_plugins.rst (#72305) ... ##### SUMMARY ansible_date_time returns utc time. datetime.utcnow() rather than datetime.now() ##### ISSUE TYPE - Docs Pull Request +label: docsite_pr	4 years ago
Simon Heimberg	ad4ddd8211	document what the name of a play is (#72633) ... ##### SUMMARY Make clear that `ansible_play_name` is the name attribute from the play and not the file name of the playbook. improves #57361 ##### ISSUE TYPE - Docs Pull Request +label: docsite_pr	4 years ago
Brian Coca	452bc3af04	example of exponential backup (#72617)	4 years ago
Ashwini Mhatre	8c67432fc8	Update intro_installation.rst (#72586)	4 years ago
Sean Blundy	a5eb788578	Minor Edit: Fix typo in platform_index.rst (#72564) ... Fix Dell OS 10 dellemc.os10.0s10 to dellemc.os10.os10 in platform_index.rst	4 years ago
Matthew Davis	ddad9930aa	Clarify collection paths in docs (#72510) ... * Clarify collection paths in docs, fix rst syntax, rephrase docs about using collection from folder/local git Co-authored-by: Felix Fontein <felix@fontein.de>	4 years ago
Brian Coca	8eab113cb1	show keyword documentation in ansible-doc (#72476) ... * show keyword documentation in ansible-doc Co-authored-by: Felix Fontein <felix@fontein.de>	4 years ago
Matt Martz	96ad5b799e	Emit warning when running on the controller with a Python older than 3.8 (#72467) ... * Emit warning when running on the controller with a Python older than 3.8 * Add spaces Co-authored-by: Matt Clay <matt@mystile.com> * and more spaces Co-authored-by: Matt Clay <matt@mystile.com> * s/Py/Python/ Co-authored-by: Matt Clay <matt@mystile.com> * Add note to Control node requirements about Py3.8 requirement * Add collection_name to deprecated call * more spaces Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua> * Clarify that we are only packaging for py3.8+ Co-authored-by: Matt Clay <matt@mystile.com> Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>	4 years ago
Mohammad Sadegh Dehghan	599805e316	Introduce Ansible plugin in Jetbrains section of doc (#72465)	4 years ago
Felix Fontein	da1c1e8bb8	Add info on how to contribute to **community**-maintained collections as well. (#72494)	4 years ago
Lydie	a5a0b8f0e7	Style guide edit to the tools page (#72506)	4 years ago
Felix Fontein	01d207a3e3	Improve argument spec documentation (#72335) ... * Link to argument spec documentation from 'Creating a module'. * Use items instead of sub-headings. * Update deprecation information. * Document conditional requirements. * Document supports_check_mode and add_file_common_args. * Add deprecation examples. * Re-add word. * Improve title. * Fix RST formatting, add conditional dependency section starter.	4 years ago
Felix Fontein	569d937df8	Improve config.rst formatting (#72354) ... * Indent Jinja2 directives. * Show version_added and deprecations for ini settings and environment variables. * Make default conditional, add choices. Copied from #55474. * Add Ansible variables. Copied from #55474. * Turn ini keys and environment variables into lists. Copied from #55474. * Improve formatting. Copied from #55474.	4 years ago
Andrew Klychkov	dbe43e071e	Docsite: update user_guide/playbooks_module_defaults (#72051) ... * Docsite: update user_guide/playbooks_module_defaults, add name: lines and use FQCN consistently	4 years ago
Samy Mahmoudi	8ada1bb447	docs: Transpose two words to correct a sentence. (#72329)	4 years ago
Josh	1a5d2938c6	Update playbooks_filters_ipaddr.rst (#72464) ... Fix small code formatting issue - remove extra `:` before code-block.	4 years ago
Toshio Kuratomi	d53c47940a	Update the ansible-2.10 porting guide	4 years ago
Sandra McCann	d76f85208d	clarify upstream release status of 2.10 (#72269) ... * clarify upstream release status of 2.10 * wordsmith	4 years ago
Kohei Takahashi	2e4038f4d2	Fixed a typo in user_guide/playbooks_conditinals (#72427) ... +label: docsite_pr	4 years ago
Daniel Tavernier	dd19c9f737	Update playbooks_tags.rst (#72351) ... ##### SUMMARY Corrected the "Adding tags to blocks" example syntax. ##### ISSUE TYPE - Docs Pull Request +label: docsite_pr	4 years ago
Matt Davis	83909bfa22	Remove ansible-galaxy login (#72288) ... * GitHub is removing the underlying API used to implement the `login` command. Since the general consensus seems to be that relatively nobody currently uses this command (in favor of explicit token passing), support was simply removed for interactive login. If a future need arises, this command should be reimplemented via OAuth Device Auth Grants. * login or role login commands now produce a fatal error with a descriptive message * updated 2.10 and 2.11 porting guide entries * remove dead code/config, update messages and porting guides	4 years ago
Abhijeet Kasurde	b6360dc5e0	VMware: scenario guide for vmware_tools connection plugin (#72080) ... * VMware: scenario guide for vmware_tools connection plugin Scenario doc to guide user about the usage of vmware_tools using connection plugin. Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com> * review comments Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>	4 years ago
Abhijeet Kasurde	fe65144a4a	vmware: Using env variable for custom SSL path (#72273) ... When validate_certs is True and user has custom SSL certificate path, user can use ``REQUESTS_CA_PATH`` in ``environment`` parameter of task to specify this path. Fixes: https://github.com/ansible-collections/community.vmware/issues/49 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>	4 years ago
Nathan Scott	c20329a0f6	Update migrating_roles.rst (#72260) ... Fix a typo in the sample spec file Source0 line	4 years ago
Sandra McCann	3ece57c01a	remove ansibleFest banner (#72253)	4 years ago
Jaime Hablutzel	afba5c2852	Miscellaneous fixes in user_guide/intro_inventory.rst docs (#72202) ... * Fixing missing hosts entry under the group dict. * Added missing 'vars:' key * Reordering arguments for consistency with the format displayed by "ansible-playbook --help" * Fixing contradictory text	4 years ago
Abhijeet Kasurde	02658d7bf8	k8s: Scenario guides (#72095) ... * Start Kubernetes Scenario guides for users * K8S inventory scenario guide Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>	4 years ago
Ronald Eddy Jr	d18901dd4a	Update HTTP -> HTTPS (#72244) ... Co-authored-by: Ronald Eddy Jr <ron@Ronalds-MacBook-Pro.local>	4 years ago
Matt Martz	a33cc191bd	Update 2.11 Roadmap to include dates and planned work (#72222) ... * Update 2.11 Roadmap to include dates and planned work * remove comma	4 years ago
Justin Otherguy	8465f285cc	Update playbooks_strategies.rst (#72176) ... beside the fact that naming the variable to specify the number of machines executed in *parallel* is named *serial* - the number of hosts chosen in this example is not optimal, either: 2x2 = 4; so - 3 hosts in 2 batches should clear things up a little	4 years ago
Ken Celenza	b18e462bbb	Consistent Taxonomy (#72215) ... Historically "these" have been called directives, attributes, and keywords. We've now settled on `keyword` (https://docs.ansible.com/ansible/latest/reference_appendices/playbooks_keywords.html). Update all documentation to reflect this term.	4 years ago
Toshio Kuratomi	6e7a40dd94	Update the porting guide for a new ansible version (#72211)	4 years ago
Jordan Borean	caba47dd3f	Add support for GSSAPI/Kerberos to urls.py (#72113) ... * Add support for GSSAPI/Kerberos to urls.py * Test out changes with the latest test container * Get remote hosts working * Fix up httptester_krb5_password reader * Fix tests for opensuse and macOS * Hopefully last lot of testing changes * Dont do CBT on macOS * Fixes from review	4 years ago
Sandra McCann	7c1dd1c7fb	add link to jinja docs from templating section (#72205)	4 years ago
Sandra McCann	c084bc160c	add details on how to get API token for Galaxy (#72203)	4 years ago
Andrius Benokraitis	9382738f52	Update contributing_maintained_collections.rst (#72178) ... ##### SUMMARY Adding Kubernetes.Core collection, editing vmware.vmware_rest a bit ##### ISSUE TYPE - Docs Pull Request +label: docsite_pr	4 years ago
Andrew Klychkov	30a651bca3	Docsite: update user_guide/playbooks_async (#72115)	4 years ago
Raphael Prosillo	e119c2d2bf	Add The Bullhorn to the community communication page (#72125) ... Update documentation on communication channels for Ansible.	4 years ago
Jens Heinrich	835752cc53	Update playbooks_vars_facts.rst (#72150) ... Remove misleading typo, add a note on the mode of local facts Co-authored-by: JensHeinrich <github.com/JensHeinrich>	4 years ago
Gonéri Le Bouder	af7fd0f79d	doc: use FQCN for vmware_rest examples ... Use the collection name + the module name for clarity.	4 years ago
Gonéri Le Bouder	c72e2ee675	import of the vmware_rest documentation (#72090) ... Co-authored-by: Jill R <4121322+jillr@users.noreply.github.com>	4 years ago
Evan Van Dam	3db08adbb1	Add optional attribute arg for min and max filters (#50909) ... * Pass **kwargs to min and max filters * Use the jinja2 filters if available * Add unit tests * Add examples to docs passing attribute	4 years ago
Lars Kellogg-Stedman	bc98ebf29f	installation docs - add tip pointing to pip docs (#71741)	4 years ago
Erik Zettel	2b79cd2c0f	Fix typos (#72072)	4 years ago
Andrew Klychkov	3efc8b6de8	Docsite: update user_guide/playbooks_prompts (#72049)	4 years ago
Andrew Klychkov	c12fce3aa9	Docsite: update user_guide/playbooks_checkmode (#72052)	4 years ago
Andrew Klychkov	77840f886e	Docsite: update user_guide/playbooks_debugger (#72053)	4 years ago
Zois Pagoulatos	eee13962e5	Minor typo in test_strategies.rst (#72060)	4 years ago
DarrenHSKG	88a676246e	Update porting_guide_2.8.rst (#72041) ... ##### SUMMARY Removed translatable words from codeblocks as per https://github.com/ansible/ansible/issues/59449 ##### ISSUE TYPE - Docs Pull Request +label: docsite_pr	4 years ago
Abhijit Menon-Sen	64d9ccb965	Reword strangely patronising introduction to loops (#72019)	4 years ago
Felix Fontein	a077bca5d5	ansible-test: improve version number validation, validate some semantic versioning properties (#71679) ... * Validate removal versions. * Validate that removal collection versions and version_added collection versions conform to semver spec. * Validate removal version numbers in meta/runtime.yml. * Stricter validation for isodates (f.ex. YYYY-M-D is not allowed). * Improve error reporting. * Validate removal collection versions. Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>	4 years ago
Jorge Vallecillo	94522b7c10	Fix typos (#71970)	4 years ago
Andrew Klychkov	74be7de361	Docsite: improve user_guide/playbooks_vars_facts (#71973) ... * Docsite: improve user_guide/playbooks_vars_facts	4 years ago
Andrew Klychkov	8ae3998ecf	Docsite: update user_guide/vault (#71975)	4 years ago
Andrew Klychkov	0645436acd	Docsite: update user_guide/playbooks_filters (#71980)	4 years ago
Andrius Benokraitis	c5a161b2b0	Update faq.rst (#71982) ... Added link to https://access.redhat.com/solutions/5295121 in third sentence	4 years ago
Alicia Cozine	eed606e0e9	adds name lines to handler re-use examples (#71946) ... Co-authored-by: Alicia Cozine <acozine@users.noreply.github.com>	4 years ago
Gonéri Le Bouder	c1005147e0	doc: add vmware_rest_guidelines ... Add the development guidelines for the vmware_rest collection.	4 years ago
Alicia Cozine	27826827e9	updates intersphinx references for docs links (#71921) ... * DOCS: updates intersphinx references for docs links * TESTS: Raise the number of bytes scanned to determine if a file is binary. The newest ansible-2.10.inv file has its first null byte at position 2261. 4096 is still a cheap chunksize to read so it still makes sense to raise this. Co-authored-by: Alicia Cozine <acozine@users.noreply.github.com> Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>	4 years ago
Obioma Osuagwu	4cb20dba97	Update index.rst (#71887) ... * Update docs/docsite/rst/community/index.rst to include another link to the mailing lists list	4 years ago
Andrew Klychkov	c19af92be6	Docsite: improve user_guide/playbooks_variables (#71938) ... * Docsite: improve user_guide/playbooks_variables	4 years ago
Andrew Klychkov	2fed63a930	Docsite: improve inventory-related pages (#71907) ... * Update docs/docsite/rst/plugins/inventory.rst	4 years ago
Abhijeet Kasurde	4f990e7615	dev_guide: Add Pygments Lexer examples (#71458) ... * dev_guide: Add Pygments Lexer examples Fixes: #51307 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com> * adds ansible-output lexer, remmoves unsupported lexers Co-authored-by: Alicia Cozine <acozine@users.noreply.github.com>	4 years ago
Brian Coca	9a39452a31	update the definition of changed (#71865) ... * add nuance to the definition of changed, add notes to modules that return "changed" without changing state	4 years ago
Badhreesh	a47eafa581	Update playbooks_reuse_roles.rst (#71880) ... Change "vars_files" to "vars, files" under the Roles heading	4 years ago
Andrew Klychkov	25bfda8417	Docsite: improve user_guide/intro_inventory (#71859)	4 years ago
Andrew Klychkov	c3841b8440	Docsite: improve user_guide/playbooks_tags (#71858)	4 years ago
Andrew Klychkov	7a0a2f188b	Docsite: improve user_guide/playbooks_reuse_roles (#71857) ... * Docsite: improve user_guide/playbooks_reuse_roles * fix	4 years ago
Andrew Klychkov	2655fc0c23	Docsite: update Migrating Ansible content to a different collection (#71854) ... Co-authored-by: Felix Fontein <felix@fontein.de>	4 years ago
Baptiste Mille-Mathias	401be27053	Add example values and results for theory filters (#71908) ... Add example values and results for theory filters	4 years ago
Andrew Klychkov	ed6fb2e3f6	Docsite: improve user_guide/intro_adhoc (#71909)	4 years ago
Sandra McCann	70e25dc158	clarify releases download for older releases only (#71892)	4 years ago
Sandra McCann	e358946b98	update install instructions for pip (#71891)	4 years ago
Sandra McCann	4aedd1b987	add new glossary terms for 2.10 (#71813) ... * add new terms for 2.10 Co-authored-by: Alicia Cozine <879121+acozine@users.noreply.github.com>	4 years ago
Sandra McCann	d6063b7457	clarify FQCN use for playbooks (#71816) ... * clarify FQCN use * Apply suggestions from code review Co-authored-by: Alicia Cozine <879121+acozine@users.noreply.github.com> Co-authored-by: Alicia Cozine <879121+acozine@users.noreply.github.com>	4 years ago
brnl	5b27b307b9	Update intro_getting_started.rst (#71851) ... Fixed the formatting on the remote user name override list.	4 years ago
Toshio Kuratomi	606924a4b4	Update the porting guide for a new ansible version (#71863)	4 years ago
Sandra McCann	bf4e102d97	update version switcher for 2.10 release	4 years ago
Sandra McCann	0e5911d650	add cli parser documentation (#71497) ... * with native network example, linux example	4 years ago
Sandra McCann	bcfead8e0f	change duplicated label	4 years ago
Andrew Klychkov	3db4be2c3b	Docsite: improve user_guide/playbooks_reuse (#71834)	4 years ago
Andrew Klychkov	05a45f63ff	Docsite: misc fixes of playbooks_delegation (#71753)	4 years ago
Andrew Klychkov	aa1f0bd062	Docsite: fix playbooks_conditionals (#71754)	4 years ago
Andrew Klychkov	79dc6fa948	Docsite: fix user_guide/playbooks_blocks (#71769)	4 years ago
Andrew Klychkov	1cf42897d2	Docsite: fix user_guide/playbooks_handlers (#71770)	4 years ago
Andrew Klychkov	2c6661d4c1	Docsite: fix user_guide/playbooks_error_handling (#71771)	4 years ago
Andrew Klychkov	a204f5f955	Docsite: fix user_guide/playbooks_environment (#71772)	4 years ago
Rick Elrod	7a38c470ba	[docs] add porting guide for DNF GPG validation (#71640) ... * [docs] add porting guide for DNF GPG validation Change: - This was a breaking change (security fix), but I neglected to add a porting guide entry for it previously. Tickets: - Refs #71537 - Refs #71539 - Refs #71540 - Refs #71541 Signed-off-by: Rick Elrod <rick@elrod.me> * changes from sivel Signed-off-by: Rick Elrod <rick@elrod.me>	4 years ago
Abhijeet Kasurde	760334303b	vmware: Add docs for filters (#71670) ... Add a scenario guide for filters in VMware documentation Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>	4 years ago
Shounak	c36e939414	Fixed invalid urls inside guide_packet.rst and collections_using.rst (#71705) ... * Fixed invalid urls inside guide_packet.rst and collections_using.rst * Reverted fix for collections_using.rst	4 years ago
Evaristo Rojas	00ed5b1f2e	Fix broken bullet list (#71728)	4 years ago
Shufeng	4bf61f0714	Fix typo in delveloping_plugins_network (#71737)	4 years ago
Andrew Klychkov	a80131a283	Docsite: misc fixes (#71697)	4 years ago
Andrew Klychkov	13ab9f5932	Docsite: improve playbooks_loops.rst (#71718)	4 years ago
Sloane Hertel	7048542199	Fix passing the connection timeout to connection plugins (#71722) ... * Fix passing the connection timeout to connection plugins	4 years ago
Andrew Klychkov	5511c898cc	Docsite: fix a typo in user_guide/index.rst (#71717)	4 years ago
Amin Vakil	7a0e545700	Add how to run unit test link in testing_units_modules doc (#71523) ... * Add how to run unit test link in testing_units_modules * Fix sanity test	4 years ago
Guillaume Vincent	1a06587f3b	Fix typo in the documentation (#71701) ... Fix typo in the documentation: casting instead of casing	4 years ago
Andrew Klychkov	73bed95ead	Docsite: add reference to Style guide (#71694)	4 years ago
Jérôme Loyet	daca3ade99	Allow list of filters for the setup module (#68551) ... The setup module can now filter out multiple pattern by providing a list to the filter parameter instead of just a string. Single string sill works. Previous behaviour remains. (cherry picked from commit b5c36dac483fdd74d6c570d77cc8f3e396720366)	4 years ago
Alicia Cozine	b430f9b9aa	Adds FAQ and other pointers for collections (#71606)	4 years ago
esmersmith	a34043c6be	Changed all_modules references to list_of_collections in the documentation (#71656)	4 years ago
Zois Pagoulatos	1ad0f666d5	Fix typo in documentation (#71652) ... Fix typo on the page about unit testing modules,	4 years ago
Toshio Kuratomi	9fcf1db871	Update the porting guide for 2.10.0b2 (#71677)	4 years ago
Matt Martz	61f6aa55b6	Add semver support to the jinja2 version test (#71600)	4 years ago
Toshio Kuratomi	4d4e75ee05	Update to the ansible-2.10.0 pre-release schedule (#71647)	4 years ago
Sandra McCann	bbd4ec13f1	clarify that collection names use same requirements as namespaces (#71639)	4 years ago
Sandra McCann	2f240f5dd7	Add note on where inventory scripts moved to' (#71638)	4 years ago
Andrew Klychkov	7bfeed3e24	Docsite: replace Latin phrases to English (#71588) ... Replace Latin phrases like "e.g." and "i.e." and "etc." with English phrases. * Update docs/docsite/rst/community/committer_guidelines.rst * Update docs/docsite/rst/dev_guide/developing_modules_documenting.rst * Update docs/docsite/rst/dev_guide/developing_program_flow_modules.rst * Update docs/docsite/rst/dev_guide/module_lifecycle.rst * Update docs/docsite/rst/user_guide/intro_inventory.rst * Update docs/docsite/rst/user_guide/playbooks_loops.rst * Update docs/docsite/rst/user_guide/playbooks_reuse.rst * Update docs/docsite/rst/dev_guide/platforms/aws_guidelines.rst * Update docs/docsite/rst/dev_guide/testing.rst * Update docs/docsite/rst/dev_guide/testing_integration.rst * Update docs/docsite/rst/porting_guides/porting_guide_2.5.rst * Update docs/docsite/rst/reference_appendices/faq.rst	4 years ago
Martin Krizek	a3b954e5c9	Force template module to use non-native Jinja2 (#68560) ... Fixes #46169	4 years ago
Sandra McCann	b518a5db14	add skeleton ansible 2.11 roadmap (#71566) ... * add skeleton ansible roadmap to docs/docsite/rst/roadmap/COLLECTIONS_2_11.rst	4 years ago
Alicia Cozine	96aee766f4	More docs updates to reflect collections ecosystem (#71597)	4 years ago
Sandra McCann	7f9258b024	update backport instructions for 2.11 (#71567) ... * update backport instructions in docs/docsite/rst/community/development_process.rst Co-authored-by: Matt Martz <matt@sivel.net>	4 years ago
Andrew Klychkov	bfba0ffc45	Docsite: improve developing_modules_documenting.rst (#71590) ... * Docsite: improve developing_modules_documenting.rst * add necessary dots to returns descriptions	4 years ago
Andrew Klychkov	cda5854099	Docsite: improve spelling_word_choice.rst (#71592)	4 years ago
Toshio Kuratomi	1882c60b04	Update the porting guide for ansible-2.10.0b1 (#71583)	4 years ago
Rick Elrod	0c50ee1abe	[docs] Fix up porting guides for CVE revert (#71580) ... Change: - Fix up wording and do proper backports for porting guide entries. Signed-off-by: Rick Elrod <rick@elrod.me>	4 years ago
Alicia Cozine	b694dbadfe	User guide overhaul, Table of Contents (#71553)	4 years ago
Alicia Cozine	29b20bd1b1	DOCS: Mentions ansible-base, adds collections pointers to Community and Dev Guides (#71480)	4 years ago
Andrew Klychkov	56423b1648	testing_sanity.rst: add argument for running in docker (#71223)	4 years ago
Sandra McCann	f75223d2c6	update install for 2.10 (#71543) ... * update install for 2.10	4 years ago
Matt Deacalion	ec3920cef1	Update intro_patterns.rst (#71542) ... Call out the trailing comma when specifying a single host. Small snag that took me a while to notice.	4 years ago
Amin Vakil	bc6461432e	Add --allow-disabled to sanity docs (#71524)	4 years ago
Sandra McCann	d6fe849b2e	add skeleton 2.11 base roadmap (#71478)	4 years ago
Toshio Kuratomi	c586d436fa	Feature freeze date has been merged with Ansible-2.10.0beta1 (#71494)	4 years ago
Sandra McCann	addee0699e	quick update to changelog instructins (#71492)	4 years ago
Sandra McCann	b6f10b9b52	update Network Advanced Topics for FQCN (#71325) ... * update Network Advanced Topics for FQCN	4 years ago
Alicia Cozine	f82a1e06d7	updates network plugin docs pages for 2.10 (#71467) ... Co-authored-by: Alicia Cozine <acozine@users.noreply.github.com>	4 years ago
Abhijeet Kasurde	3c8744f0c1	Add link to Matt's blog (#71436) ... nitzmahone's blog nicely explained why Windows is not supported as Ansible controller. Link that in documentation so users can read about it. Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>	4 years ago
Abhijeet Kasurde	0b16c0a8c7	user_guide: Fix reuse role examples (#71440) ... Fixes: #53919 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>	4 years ago
Abhijeet Kasurde	5c1594916a	user_guide: Add an example for loop (#71441) ... Explain how to use complex data in loop while converting from with_together Fixes: #47906 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>	4 years ago
John Westcott IV	a6537b59ab	Modify wording to specify two ctl-d to end stdin input in ansible-vault (#69436) ... * 51860 - Modify wording to specify two ctl-d to end stdin input in ansible-vault * removes space to make line 160 chars	4 years ago
Patrick Reader	2b7461eb52	fix broken links due to master -> main branch rename (#71426)	4 years ago
flowerysong	66e38bf499	docs: Remove examples using the `ec2.py` script (#69107) ... This script is mostly unmaintained and relies on the deprecated and unmaintained `boto` library. Featuring it prominently in the docs leads to many new users using it instead of the supported `aws_ec2` inventory plugin.	4 years ago
Sandra McCann	6c48c62f93	document securing editor for vault (#71404)	4 years ago
Sloane Hertel	fb035da3b2	clarify inventory plugin user documentation (#71387)	4 years ago
Eric G	13ab73cd89	Docs: ansible_host can contain FQDN (#71186)	4 years ago
David M. Lee	3e4377300b	Explain duplicate checks includes tags and when (#68183) ... ##### SUMMARY Per #67913, when comparing dependencies, Ansible takes into account parameters, tags and the when clause in determining whether a role is a duplicate or not. ##### ISSUE TYPE - Docs Pull Request +label: docsite_pr	4 years ago
Sloane Hertel	1425e3597b	Allow meta tasks to use tags (#67508) ... * Support tags for explicit meta tasks Add --list-tasks tests for meta tags Add breaking_changes changelog fragment and porting guide	4 years ago
Abhijeet Kasurde	59b80b9146	docs: Update Kubernetes Guide (#71372) ... Fixes: #61681 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>	4 years ago
Andrew Klychkov	5498b0bb71	Documentation: improve dev_guide/testing_integration.rst (#71370)	4 years ago
Felix Fontein	a479b003e8	Fix module links. (#71030)	4 years ago
Sandra McCann	80b8fde946	update fest link (#71376)	4 years ago
Andrew Klychkov	b82889eef5	Add note about integration tests for new modules to the dev guide (#71345)	4 years ago
Sandra McCann	74f88c56a5	quick fix to change main back to devel (#71342) ... * quick fix to change main back to devel * Update docs/docsite/rst/dev_guide/developing_collections.rst Co-authored-by: Felix Fontein <felix@fontein.de>	4 years ago
Sandra McCann	9be8d723da	Add Fest banner (#71360) ... Adds Fest banner, with fixes; updates existing banners, adds links.	4 years ago
Rick Elrod	ea58d7c233	Make it so callback plugins can act on implicit/explicit meta tasks (#71009) ... Change: - Now sends meta tasks to the task start callback - Lets callback plugins opt-in to receiving implicit tasks Test Plan: - New integration tests Tickets: - Indirectly fixes #71007 by allowing custom callbacks with this data Signed-off-by: Rick Elrod <rick@elrod.me>	4 years ago
Abhijeet Kasurde	a1257d75aa	network: Correct documentation (#71246) ... ini-style inventory does not support Ansible Vault password. This fixes network_best_practices_2.5 doc. Fixes: #69039 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>	4 years ago
Abhijeet Kasurde	4f993922c8	Add documentation about info/facts module development (#71250) ... Fixes: #40151 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>	4 years ago
Sandra McCann	f79a7c5585	Update Network Getting Started for FQCN/collection world (#71188) ... * pull out network roles, cleanup, update first playbook examples, update gather facts section, some inventory conversion to .yml, update inventory and roles, simplify the navigation titles, fix tocs, feedback comments	4 years ago
Alicia Cozine	5073cfc8bc	incorporate minimalism feedback on debugging page (#71272) ... Co-authored-by: bobjohnsrh <50667510+bobjohnsrh@users.noreply.github.com>	4 years ago
Alicia Cozine	02ea80f6d7	tidies up vars page (#71339)	4 years ago
Sayee	4d68efbe24	Writing style updates to Using Variables topic (#71194) ... * updated topic title, underline length for headings, and incorporated peer feedback	4 years ago
Andrew Klychkov	180507c62b	dev_guide: improve developing_collections.rst (#71332)	4 years ago
Remi Verchere	824cd4cbeb	Update ansible european IRC channel (#71326) ... Signed-off-by: Rémi VERCHERE <remi@verchere.fr>	4 years ago
Abhijeet Kasurde	606604bb97	Add warning about copyright year change (#71251) ... To simplify project administration and avoid any legal issues, add a warning in the docs. This reflects - https://github.com/ansible/ansible/issues/45989#issuecomment-423635622 and fixes: #45989 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>	4 years ago
Sayee	ecd3b52ad7	Writing style updates to Developing dynamic inventory topic (#71245) ... * modified the writing style * incorporated peer feedback	4 years ago
Abhijeet Kasurde	ecea018506	Fix 404 links (#71256) ... Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>	4 years ago
Felix Fontein	ee48e0b0ad	Fix roadmap formatting. (#71275)	4 years ago
Felix Fontein	61b7f234bd	Update auto-generated 2.10 porting guide in devel. (#71276)	4 years ago
Andrew Klychkov	a496b89d6f	overview_architecture.rst: fix playbook example (#71303)	4 years ago
Andrew Klychkov	9296ee9329	developing_modules_in_groups.rst: add note about releasing (#71305)	4 years ago
Baptiste Mille-Mathias	92d59a58c0	Fix code markups and add link to CVE (#71082)	4 years ago
Toshio Kuratomi	99cac0b135	Fix expr regex for MacOSX compat ... MacOSX seems to want bare `+` whereas GNU expr wants escaped `+` (`\+`) to mean match one or more. Use `\{1,\}` instead which will match one or more on both MaxOSX and GNU-using systems. Fixes #71053	4 years ago
Toshio Kuratomi	e507c127e5	Move 2.10.0rc1 release date a few days forward. (#71270) ... At yesterday's meeting it was decided to have ansible-2.10.0 depend on ansible-base-2.10.1 so that we can get several fixes for ansible-base's routing (including adding the gluster.gluster collection). ansible-base-2.10.1 will release on September 8th. So we will plan on releasing ansible-2.10.0rc1 on the 10th. https://meetbot.fedoraproject.org/ansible-community/2020-08-12/ansible_community_meeting.2020-08-12-18.00.html	4 years ago
Sayee	4f0bd5de38	a few writing style updates (#71212)	4 years ago
Sandra McCann	553ccedcd3	Update release page for ansible and ansible-base (#71229) ... * [docs] 2.7 is EOL, add 2.10 which is almost out - Remove 2.7 support from the maintenance schedule - Add 2.10 which is in RC and will be out soon enough. Signed-off-by: Rick Elrod <rick@elrod.me> * Update docs/docsite/rst/reference_appendices/release_and_maintenance.rst, fix table and separate ansible-base from ansible, fix rstcheck errors, clean up sections, explain the two packages Co-authored-by: Sandra McCann <samccann@redhat.com> Co-authored-by: Rick Elrod <rick@elrod.me>	4 years ago
Alicia Cozine	ae3b8eec12	Adds fest link (#71241) ... * adds two possible links to AnsibleFest - pick one * selected preferred text Co-authored-by: Alicia Cozine <acozine@users.noreply.github.com>	4 years ago
Sam Doran	888be697cb	Revert "Change default file permissions so they are not world readable (#70221)" (#71231) ... * Revert "Change default file permissions so they are not world readable (#70221)" This reverts commit 5260527c4a. * Revert "Fix warning for new default permissions when mode is not specified (#70976)" This reverts commit dc79528cc6.	4 years ago
Andrew Klychkov	19589db10c	Fix references to Ansible Collections Overview (#71227)	4 years ago
Sayee	7195788ffe	updates per writing style (#70978) ... * updated to follow IBM and Ansible style guides * modified heading underlines * incorporated peer review feedback	4 years ago
Abhijeet Kasurde	0a7ab396c7	filters: minor doc fix (#71178) ... Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>	4 years ago
Sandra McCann	172230d7b8	update Ansible-maintained platform guides with FQCN (#70369) ... * update platform guides with FQCN * implemented feedback * fix remainin fqcn * Update docs/docsite/rst/network/user_guide/platform_netconf_enabled.rst Co-authored-by: Alicia Cozine <879121+acozine@users.noreply.github.com>	4 years ago
Sandra McCann	f4388de14d	add another resource module example (#71162) ... * Update docs/docsite/rst/network/user_guide/network_resource_modules.rst Co-authored-by: Nilashish Chakraborty <nilashishchakraborty8@gmail.com>	4 years ago
Håkon Solbjørg	e72e12aa27	docs: 'ansible_play_hosts' lists active hosts, not limited by serial (#71116) ... ansible_play_batch lists the currently targeted host(s) in the serial/batch, while ansible_play_hosts lists all the hosts which will be targeted by the play.	4 years ago