Correcting the security group id lookup from the list of security group names

12 years ago · fe95745a20
parent 74e7eba528
commit fe95745a20
1 changed files with 1 additions and 3 deletions
--- a/library/cloud/ec2
+++ b/library/cloud/ec2
@ -392,9 +392,7 @@ def create_instances(module, ec2):
        if group_name:
            grp_details = ec2.get_all_security_groups()
            if type(group_name) == list:
-                # FIXME: this should be a nice list comprehension
-                # also not py 2.4 compliant
-                group_id = list(filter(lambda grp: str(grp.id) if str(tmp) in str(grp) else None, grp_details) for tmp in group_name)
+                group_id = [ str(grp.id) for grp in grp_details if str(grp.name) in group_name ]
            elif type(group_name) == str:
                for grp in grp_details:
                    if str(group_name) in str(grp):