sns: move from notification directory to cloud/amazon directory - fixes #11874 (#23805)

* move sns to cloud directory

* make sns pep8 and remove from legacy files

lib/ansible/modules/cloud/amazon/sns.py

@@ -200,9 +200,9 @@ def main():
         e = get_exception()
         module.fail_json(msg=str(e))
 
-    if not message_structure=='string' and message_attributes:
+    if not message_structure == 'string' and message_attributes:
         module.fail_json(msg="when specifying message_attributes, the message_structure must be set to 'string'; otherwise the attributes will not be sent.")
-    elif message_structure=='string' and (email or sqs or sms or http or https):
+    elif message_structure == 'string' and (email or sqs or sms or http or https):
         module.fail_json(msg="do not specify non-default message formats when using the 'string' message_structure. they can only be used with "
                              "the 'json' message_structure.")
 

test/sanity/pep8/legacy-files.txt

@@ -634,7 +634,6 @@ lib/ansible/modules/notification/pushover.py
 lib/ansible/modules/notification/rocketchat.py
 lib/ansible/modules/notification/sendgrid.py
 lib/ansible/modules/notification/slack.py
-lib/ansible/modules/notification/sns.py
 lib/ansible/modules/notification/twilio.py
 lib/ansible/modules/packaging/language/bundler.py
 lib/ansible/modules/packaging/language/cpanm.py