Merge pull request #724 from ferrants/devel-metric_alarm_fix

check keys is in dim2 before evaluating
10 years ago · fb1c92ffa4
parent a97bc22103 e1f2c570eb
commit fb1c92ffa4
1 changed files with 1 additions and 1 deletions
--- a/cloud/amazon/ec2_metric_alarm.py
+++ b/cloud/amazon/ec2_metric_alarm.py
@ -190,7 +190,7 @@ def create_metric_alarm(connection, module):
        for keys in dim1:
            if not isinstance(dim1[keys], list):
                dim1[keys] = [dim1[keys]]
-            if dim1[keys] != dim2[keys]:
+            if keys not in dim2 or dim1[keys] != dim2[keys]:
                changed=True
                setattr(alarm, 'dimensions', dim1)