From f96c569f9d1568f634645e7d3d04b566812039ee Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gon=C3=A9ri=20Le=20Bouder?= Date: Thu, 11 Apr 2019 00:05:42 -0400 Subject: [PATCH] VMware: vmware_host_vmnic_facts: py3 fix (#55117) With Python3, `filter()` returns an iterator. So we cannot do a `len()` on the result. --- lib/ansible/modules/cloud/vmware/vmware_host_vmnic_facts.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/ansible/modules/cloud/vmware/vmware_host_vmnic_facts.py b/lib/ansible/modules/cloud/vmware/vmware_host_vmnic_facts.py index f6f331ecd57..a867d5b4237 100644 --- a/lib/ansible/modules/cloud/vmware/vmware_host_vmnic_facts.py +++ b/lib/ansible/modules/cloud/vmware/vmware_host_vmnic_facts.py @@ -192,11 +192,10 @@ class HostVmnicMgr(PyVmomi): host_vmnic_facts = dict(all=[], available=[], used=[], vswitch=dict(), dvswitch=dict()) host_nw_system = host.configManager.networkSystem if host_nw_system: + vmnics = [pnic.device for pnic in nw_config.pnic if pnic.startswith('vmnic')] nw_config = host_nw_system.networkConfig host_vmnic_facts['all'] = [pnic.device for pnic in nw_config.pnic] - host_vmnic_facts['num_vmnics'] = ( - len(filter(lambda s: s.startswith('vmnic'), [pnic.device for pnic in nw_config.pnic])) - ) + host_vmnic_facts['num_vmnics'] = len(vmnics) host_vmnic_facts['vmnic_details'] = [] for pnic in host.config.network.pnic: pnic_facts = dict()