From f9589bd4b1b39c93343f96475215f7241d54eadf Mon Sep 17 00:00:00 2001 From: Paul Belanger Date: Thu, 9 May 2019 08:02:50 -0400 Subject: [PATCH] Don't validate ip address for mgmt interface (#56136) It is possible the EOS appliance doesn't have an IP address on the management1 interface, instead just check we have found that interface. Signed-off-by: Paul Belanger --- test/integration/targets/eos_facts/tests/cli/default_facts.yaml | 2 +- test/integration/targets/eos_facts/tests/cli/not_hardware.yaml | 2 +- .../integration/targets/eos_facts/tests/eapi/default_facts.yaml | 2 +- test/integration/targets/eos_facts/tests/eapi/not_hardware.yaml | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/test/integration/targets/eos_facts/tests/cli/default_facts.yaml b/test/integration/targets/eos_facts/tests/cli/default_facts.yaml index 3f5879a0c5e..b99437fb731 100644 --- a/test/integration/targets/eos_facts/tests/cli/default_facts.yaml +++ b/test/integration/targets/eos_facts/tests/cli/default_facts.yaml @@ -23,7 +23,7 @@ # Items from those subsets are present - "result.ansible_facts.ansible_net_filesystems is defined" #hw - "result.ansible_facts.ansible_net_memtotal_mb > 10" #hw - - "result.ansible_facts.ansible_net_interfaces.Management1.ipv4.masklen > 1" # interfaces + - "result.ansible_facts.ansible_net_interfaces.Management1" # interfaces # ... and not present - "result.ansible_facts.ansible_net_config is not defined" # config diff --git a/test/integration/targets/eos_facts/tests/cli/not_hardware.yaml b/test/integration/targets/eos_facts/tests/cli/not_hardware.yaml index b65caa5d975..f528ce77c11 100644 --- a/test/integration/targets/eos_facts/tests/cli/not_hardware.yaml +++ b/test/integration/targets/eos_facts/tests/cli/not_hardware.yaml @@ -23,7 +23,7 @@ - "'hardware' not in result.ansible_facts.ansible_net_gather_subset" # Items from those subsets are present - - "result.ansible_facts.ansible_net_interfaces.Management1.ipv4.masklen > 1" # interfaces + - "result.ansible_facts.ansible_net_interfaces.Management1" # interfaces # ... and not present - "result.ansible_facts.ansible_net_filesystems is not defined" diff --git a/test/integration/targets/eos_facts/tests/eapi/default_facts.yaml b/test/integration/targets/eos_facts/tests/eapi/default_facts.yaml index 0f7467aae68..baa1216227c 100644 --- a/test/integration/targets/eos_facts/tests/eapi/default_facts.yaml +++ b/test/integration/targets/eos_facts/tests/eapi/default_facts.yaml @@ -27,7 +27,7 @@ # Items from those subsets are present - "result.ansible_facts.ansible_net_filesystems is defined" #hw - "result.ansible_facts.ansible_net_memtotal_mb > 10" #hw - - "result.ansible_facts.ansible_net_interfaces.Management1.ipv4.masklen > 1" # interfaces + - "result.ansible_facts.ansible_net_interfaces.Management1" # interfaces # ... and not present - "result.ansible_facts.ansible_net_config is not defined" # config diff --git a/test/integration/targets/eos_facts/tests/eapi/not_hardware.yaml b/test/integration/targets/eos_facts/tests/eapi/not_hardware.yaml index 30db5d93033..37a901319e8 100644 --- a/test/integration/targets/eos_facts/tests/eapi/not_hardware.yaml +++ b/test/integration/targets/eos_facts/tests/eapi/not_hardware.yaml @@ -27,7 +27,7 @@ - "'hardware' not in result.ansible_facts.ansible_net_gather_subset" # Items from those subsets are present - - "result.ansible_facts.ansible_net_interfaces.Management1.ipv4.masklen > 1" # interfaces + - "result.ansible_facts.ansible_net_interfaces.Management1" # interfaces # ... and not present - "result.ansible_facts.ansible_net_filesystems is not defined"