ovirt_auth: Fix checking of auth paramters (#35512)

lib/ansible/modules/cloud/ovirt/ovirt_auth.py

@@ -173,7 +173,7 @@ ovirt_auth:
         ca_file:
             description: CA file, which is used to verify SSL/TLS connection.
             returned: success
-            type: string
+            type: path
             sample: "ca.pem"
         insecure:
             description: Flag indicating if insecure connection is used.
@@ -220,7 +220,7 @@ def main():
             username=dict(default=None),
             password=dict(default=None, no_log=True),
             ca_file=dict(default=None, type='path'),
-            insecure=dict(required=False, type='bool', default=False),
+            insecure=dict(required=False, type='bool', default=None),
             timeout=dict(required=False, type='int', default=0),
             compress=dict(required=False, type='bool', default=True),
             kerberos=dict(required=False, type='bool', default=False),
@@ -242,12 +242,20 @@ def main():
     elif state == 'absent':
         params = module.params['ovirt_auth']
 
-    url = params.get('url') or os.environ.get('OVIRT_URL')
-    username = params.get('username') or os.environ.get('OVIRT_USERNAME')
-    password = params.get('password') or os.environ.get('OVIRT_PASSWORD')
-    ca_file = params.get('ca_file') or os.environ.get('OVIRT_CAFILE')
-    insecure = params.get('insecure') or ca_file is None
-    token = params.get('token') or os.environ.get('OVIRT_TOKEN')
+    def get_required_parameter(param, env_var, required=False):
+        var = params.get(param) or os.environ.get(env_var)
+        if not var and required and state == 'present':
+            module.fail_json(msg="'%s' is a required parameter." % param)
+
+        return var
+
+    url = get_required_parameter('url', 'OVIRT_URL', required=True)
+    username = get_required_parameter('username', 'OVIRT_USERNAME', required=True)
+    password = get_required_parameter('password', 'OVIRT_PASSWORD', required=True)
+    token = get_required_parameter('token', 'OVIRT_TOKEN')
+    ca_file = get_required_parameter('ca_file', 'OVIRT_CAFILE')
+    insecure = params.get('insecure') if params.get('insecure') is not None else not bool(ca_file)
+
     connection = sdk.Connection(
         url=url,
         username=username,