Test aliases fix (#84377)

* integrity tests: Tag (destructive) root tests as such - apt_key needs root to touch the apt key database - debconf needs root to change debconf values of system packages - gathering writes to /etc/ansible/*, writeable only to root - group creates system groups - noexec mounts/umounts a ramdisk - systemd requires root to start/stop services Mark all except noexec as "destructive" as they change the state of the system. * integration test cron requires root, as it calls setup_cron * integration test dpkg_selection runs dpkg as root * integration test facts_linux_network requires root It adds/removes IP addresses from network interfaces, requiring root for that. * integration test package requires root installs/removes system packages * Integration test service requires root Creates/starts/stops/removes systemd services * integration test user requires root to create users * integration tests using setup_test_user require root --------- Co-authored-by: Lee Garrett <lgarrett@rocketjump.eu>
1 year ago · f2a77b071e
parent 2a53b851fe
commit f2a77b071e
15 changed files with 20 additions and 0 deletions
--- a/test/integration/targets/apt_key/aliases
+++ b/test/integration/targets/apt_key/aliases
@ -1,3 +1,5 @@
+destructive
+needs/root
 shippable/posix/group1
 skip/freebsd
 skip/macos
--- a/test/integration/targets/cron/aliases
+++ b/test/integration/targets/cron/aliases
@ -1,3 +1,4 @@
 destructive
+needs/root
 shippable/posix/group1
 skip/macos
--- a/test/integration/targets/debconf/aliases
+++ b/test/integration/targets/debconf/aliases
@ -1 +1,3 @@
+destructive
+needs/root
 shippable/posix/group1
--- a/test/integration/targets/dpkg_selections/aliases
+++ b/test/integration/targets/dpkg_selections/aliases
@ -1,5 +1,6 @@
 shippable/posix/group1
 destructive
+needs/root
 skip/freebsd
 skip/macos
 skip/rhel
--- a/test/integration/targets/facts_linux_network/aliases
+++ b/test/integration/targets/facts_linux_network/aliases
@ -1,4 +1,5 @@
 needs/privileged
+needs/root
 shippable/posix/group1
 skip/freebsd
 skip/macos
--- a/test/integration/targets/gathering/aliases
+++ b/test/integration/targets/gathering/aliases
@ -1,2 +1,4 @@
+destructive
+needs/root
 shippable/posix/group5
 context/controller
--- a/test/integration/targets/group/aliases
+++ b/test/integration/targets/group/aliases
@ -1 +1,3 @@
+destructive
+needs/root
 shippable/posix/group1
--- a/test/integration/targets/keyword_inheritance/aliases
+++ b/test/integration/targets/keyword_inheritance/aliases
@ -1,4 +1,5 @@
 shippable/posix/group4
 context/controller
+needs/root
 needs/target/setup_test_user
 setup/always/setup_passlib_controller  # required for setup_test_user
--- a/test/integration/targets/noexec/aliases
+++ b/test/integration/targets/noexec/aliases
@ -1,3 +1,4 @@
+needs/root
 shippable/posix/group4
 context/controller
 skip/docker
--- a/test/integration/targets/omit/aliases
+++ b/test/integration/targets/omit/aliases
@ -1,4 +1,5 @@
 shippable/posix/group5
+needs/root
 needs/target/setup_test_user
 context/controller
 setup/always/setup_passlib_controller  # required for setup_test_user
--- a/test/integration/targets/package/aliases
+++ b/test/integration/targets/package/aliases
@ -1,2 +1,3 @@
+needs/root
 shippable/posix/group1
 destructive
--- a/test/integration/targets/service/aliases
+++ b/test/integration/targets/service/aliases
@ -1,3 +1,4 @@
 destructive
+needs/root
 shippable/posix/group1
 skip/macos
--- a/test/integration/targets/service_facts/aliases
+++ b/test/integration/targets/service_facts/aliases
@ -1,2 +1,3 @@
+needs/root
 shippable/posix/group2
 skip/macos
--- a/test/integration/targets/systemd/aliases
+++ b/test/integration/targets/systemd/aliases
@ -1 +1,3 @@
+destructive
+needs/root
 shippable/posix/group1
--- a/test/integration/targets/user/aliases
+++ b/test/integration/targets/user/aliases
@ -1,2 +1,3 @@
 destructive
+needs/root
 shippable/posix/group1