From f28e32c0638a743bf6f6a8998e6b297049b33654 Mon Sep 17 00:00:00 2001 From: Matt Clay Date: Mon, 21 Aug 2023 12:58:09 -0700 Subject: [PATCH] ansible-test - Limit deprecated check to core (#81552) Using `# deprecated:` comment checks in collections would effectively limit those collections to a single version of ansible-core. --- changelogs/fragments/pylint-deprecated-comment-checker.yml | 2 +- .../_util/controller/sanity/pylint/config/collection.cfg | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/changelogs/fragments/pylint-deprecated-comment-checker.yml b/changelogs/fragments/pylint-deprecated-comment-checker.yml index bd315b7191b..c86eff224d7 100644 --- a/changelogs/fragments/pylint-deprecated-comment-checker.yml +++ b/changelogs/fragments/pylint-deprecated-comment-checker.yml @@ -1,3 +1,3 @@ minor_changes: - ansible-test - Add new pylint checker for new ``# deprecated:`` comments within code to trigger errors when time to remove code - that has no user facing deprecation message + that has no user facing deprecation message. Only supported in ansible-core, not collections. diff --git a/test/lib/ansible_test/_util/controller/sanity/pylint/config/collection.cfg b/test/lib/ansible_test/_util/controller/sanity/pylint/config/collection.cfg index bf8f02821fd..762d488d77f 100644 --- a/test/lib/ansible_test/_util/controller/sanity/pylint/config/collection.cfg +++ b/test/lib/ansible_test/_util/controller/sanity/pylint/config/collection.cfg @@ -30,6 +30,7 @@ disable= consider-using-max-builtin, consider-using-min-builtin, cyclic-import, # consistent results require running with --jobs 1 and testing all files + deprecated-comment, # custom plugin only used by ansible-core, not collections deprecated-method, # results vary by Python version deprecated-module, # results vary by Python version duplicate-code, # consistent results require running with --jobs 1 and testing all files