From f10d11bcdc54c9b7edc0111eb38c59a88e396d0a Mon Sep 17 00:00:00 2001
From: Abhijeet Kasurde <akasurde@redhat.com>
Date: Thu, 3 Aug 2023 14:01:20 -0700
Subject: [PATCH] dpkg_selections: Check if package exists before selection
 operation (#81406)

* dpkg_selections: Check if the package exists before the selection operation

Fixes: #81404

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
---
 changelogs/fragments/dpkg_selections.yml             |  3 +++
 lib/ansible/modules/dpkg_selections.py               |  9 ++++++++-
 .../dpkg_selections/tasks/dpkg_selections.yaml       | 12 ++++++++++++
 3 files changed, 23 insertions(+), 1 deletion(-)
 create mode 100644 changelogs/fragments/dpkg_selections.yml

diff --git a/changelogs/fragments/dpkg_selections.yml b/changelogs/fragments/dpkg_selections.yml
new file mode 100644
index 00000000000..5a4008cabcb
--- /dev/null
+++ b/changelogs/fragments/dpkg_selections.yml
@@ -0,0 +1,3 @@
+---
+bugfixes:
+- dpkg_selections - check if the package exists before performing the selection operation (https://github.com/ansible/ansible/issues/81404).
diff --git a/lib/ansible/modules/dpkg_selections.py b/lib/ansible/modules/dpkg_selections.py
index 71226f01b06..7c8a7250805 100644
--- a/lib/ansible/modules/dpkg_selections.py
+++ b/lib/ansible/modules/dpkg_selections.py
@@ -54,6 +54,7 @@ EXAMPLES = '''
 '''
 
 from ansible.module_utils.basic import AnsibleModule
+from ansible.module_utils.common.locale import get_best_parsable_locale
 
 
 def main():
@@ -67,12 +68,18 @@ def main():
 
     dpkg = module.get_bin_path('dpkg', True)
 
+    locale = get_best_parsable_locale(module)
+    DPKG_ENV = dict(LANG=locale, LC_ALL=locale, LC_MESSAGES=locale, LC_CTYPE=locale)
+    module.run_command_environ_update = DPKG_ENV
+
     name = module.params['name']
     selection = module.params['selection']
 
     # Get current settings.
     rc, out, err = module.run_command([dpkg, '--get-selections', name], check_rc=True)
-    if not out:
+    if 'no packages found matching' in err:
+        module.fail_json(msg="Failed to find package '%s' to perform selection '%s'." % (name, selection))
+    elif not out:
         current = 'not present'
     else:
         current = out.split()[1]
diff --git a/test/integration/targets/dpkg_selections/tasks/dpkg_selections.yaml b/test/integration/targets/dpkg_selections/tasks/dpkg_selections.yaml
index 080db262bcf..016d7716d03 100644
--- a/test/integration/targets/dpkg_selections/tasks/dpkg_selections.yaml
+++ b/test/integration/targets/dpkg_selections/tasks/dpkg_selections.yaml
@@ -87,3 +87,15 @@
   apt:
     name: hello
     state: absent
+
+- name: Try to select non-existent package
+  dpkg_selections:
+    name: kernel
+    selection: hold
+  ignore_errors: yes
+  register: result
+
+- name: Check that module fails for non-existent package
+  assert:
+    that:
+      - "'Failed to find package' in result.msg"