From ee49adfaf489061cd7ef712943e63f8159950432 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=F0=9F=87=BA=F0=9F=87=A6=20Sviatoslav=20Sydorenko=20=28?= =?UTF-8?q?=D0=A1=D0=B2=D1=8F=D1=82=D0=BE=D1=81=D0=BB=D0=B0=D0=B2=20=D0=A1?= =?UTF-8?q?=D0=B8=D0=B4=D0=BE=D1=80=D0=B5=D0=BD=D0=BA=D0=BE=29?= Date: Fri, 7 Feb 2025 19:43:29 +0100 Subject: [PATCH] =?UTF-8?q?=F0=9F=A7=AA=F0=9F=94=A5=20Delete=20the=20`egg-?= =?UTF-8?q?info`=20integration=20test=20(#84686)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Previously, the integration test depended on luck. `setuptools` used to be bundled in Python stdlib's `ensurepip`. Python 3.12 and newer no longer include it. This test imports `pkg_resources` that is a part of `setuptools`, meaning that it'll run out of luck at some point, under newer Python runtimes. This test does not seem to be useful to us so instead of fixing it, we remove it from the repo [[1]]. Supersedes #84681. [1]: https://github.com/ansible/ansible/pull/84681#discussion_r1945525317 --- test/integration/targets/egg-info/aliases | 2 -- .../egg-info/lookup_plugins/import_pkg_resources.py | 10 ---------- test/integration/targets/egg-info/tasks/main.yml | 3 --- 3 files changed, 15 deletions(-) delete mode 100644 test/integration/targets/egg-info/aliases delete mode 100644 test/integration/targets/egg-info/lookup_plugins/import_pkg_resources.py delete mode 100644 test/integration/targets/egg-info/tasks/main.yml diff --git a/test/integration/targets/egg-info/aliases b/test/integration/targets/egg-info/aliases deleted file mode 100644 index 8278ec8bcc7..00000000000 --- a/test/integration/targets/egg-info/aliases +++ /dev/null @@ -1,2 +0,0 @@ -shippable/posix/group3 -context/controller diff --git a/test/integration/targets/egg-info/lookup_plugins/import_pkg_resources.py b/test/integration/targets/egg-info/lookup_plugins/import_pkg_resources.py deleted file mode 100644 index cba386b83c6..00000000000 --- a/test/integration/targets/egg-info/lookup_plugins/import_pkg_resources.py +++ /dev/null @@ -1,10 +0,0 @@ -from __future__ import annotations - -import pkg_resources # pylint: disable=unused-import - -from ansible.plugins.lookup import LookupBase - - -class LookupModule(LookupBase): - def run(self, terms, variables, **kwargs): - return ['ok'] diff --git a/test/integration/targets/egg-info/tasks/main.yml b/test/integration/targets/egg-info/tasks/main.yml deleted file mode 100644 index d7b886c00cc..00000000000 --- a/test/integration/targets/egg-info/tasks/main.yml +++ /dev/null @@ -1,3 +0,0 @@ -- name: Make sure pkg_resources can be imported by plugins - debug: - msg: "{{ lookup('import_pkg_resources') }}"