Review requests

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

lib/ansible/modules/debconf.py

@@ -140,16 +140,15 @@ def get_password_value(module, pkg, question, vtype):
     for line in out.split("\n"):
         if line.startswith(pkg):
             desired_line = line
-            break
+            (dpkg, dquestion, dvtype, *dvalue) = line.split()
+            if dquestion == question and dvtype == vtype:
+                if len(dvalue) >= 1:
+                    return dvalue[0]
+                return ''
 
     if not desired_line:
         module.fail_json(msg="Failed to find the value '%s' from '%s'" % (question, pkg))
 
-    (dpkg, dquestion, dvtype, *dvalue) = desired_line.split()
-    if dquestion == question and dvtype == vtype:
-        if len(dvalue) >= 1:
-            return dvalue[0]
-        return ''
     return ''
 
 

test/integration/targets/debconf/tasks/main.yml

@@ -82,6 +82,34 @@
         that:
           - debconf_test2.changed
 
+    - name: Set different question for same package name
+      debconf:
+        name: ddclient2
+        question: ddclient/password1
+        value: "Sample"
+        vtype: password
+      no_log: false
+      register: debconf_test1
+
+    - name: validate if different question for same package name is set
+      assert:
+        that:
+          - debconf_test1.changed
+
+    - name: Set different question for same package name again (idempotency)
+      debconf:
+        name: ddclient2
+        question: ddclient/password1
+        value: "Sample"
+        vtype: password
+      no_log: false
+      register: debconf_test2
+
+    - name: validate if different question for same package name is set (idempotency)
+      assert:
+        that:
+          - not debconf_test2.changed
+
     - name: Multiselect value
       debconf:
         name: libnss-ldapd