assign a sane default to yum/dnf lock_timeout, in line with cli (#57383)

* assign a sane default to yum/dnf lock_timeout, in line with cli

Fixes #57189

Signed-off-by: Adam Miller <admiller@redhat.com>

* fix typo in changelog snippet

Signed-off-by: Adam Miller <admiller@redhat.com>
(cherry picked from commit d2dc4c9bc4)

changelogs/fragments/yum-sane-default-lockfile-timeout.yml

@@ -0,0 +1,3 @@
+minor_changes:
+  - yum - set lock_timeout to a sane default (30 seconds, as is the cli)
+  - dnf - set lock_timeout to a sane default (30 seconds, as is the cli)

lib/ansible/module_utils/yumdnf.py

@@ -46,7 +46,7 @@ yumdnf_argument_spec = dict(
         update_cache=dict(type='bool', default=False, aliases=['expire-cache']),
         update_only=dict(required=False, default="no", type='bool'),
         validate_certs=dict(type='bool', default=True),
-        lock_timeout=dict(type='int', default=0),
+        lock_timeout=dict(type='int', default=30),
     ),
     required_one_of=[['name', 'list', 'update_cache']],
     mutually_exclusive=[['name', 'list']],

lib/ansible/modules/packaging/os/dnf.py

@@ -181,7 +181,7 @@ options:
     description:
       - Amount of time to wait for the dnf lockfile to be freed.
     required: false
-    default: 0
+    default: 30
     type: int
     version_added: "2.8"
   install_weak_deps:

lib/ansible/modules/packaging/os/yum.py

@@ -187,7 +187,7 @@ options:
     description:
       - Amount of time to wait for the yum lockfile to be freed.
     required: false
-    default: 0
+    default: 30
     type: int
     version_added: "2.8"
   install_weak_deps: