From eb77afe4dec8692c5c1394113655977aa68112de Mon Sep 17 00:00:00 2001 From: Yanis Guenane Date: Tue, 1 May 2018 13:55:19 +0200 Subject: [PATCH] Add space between arguments for acme-tiny (#36739) (#39018) Currently, the module fail with a error saying that --acme-dir is mandatory. Looking at the commandline: /usr/sbin/acme-tiny --chain --account-key /srv/letsencrypt/acme_key/acme.key --csr /srv/letsencrypt/nginx_certs/www.example.org.csr--acme-dir /srv/letsencrypt/webroot", We can see that the space before --acme-dir is missing. --- .../openssl_certificate-generate-acme-missing-space.yaml | 2 ++ lib/ansible/modules/crypto/openssl_certificate.py | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) create mode 100644 changelogs/fragments/openssl_certificate-generate-acme-missing-space.yaml diff --git a/changelogs/fragments/openssl_certificate-generate-acme-missing-space.yaml b/changelogs/fragments/openssl_certificate-generate-acme-missing-space.yaml new file mode 100644 index 00000000000..58d5a174b5b --- /dev/null +++ b/changelogs/fragments/openssl_certificate-generate-acme-missing-space.yaml @@ -0,0 +1,2 @@ +bugfixes: + - openssl-certificate - Add space between arguments for acme-tiny (https://github.com/ansible/ansible/pull/36739) diff --git a/lib/ansible/modules/crypto/openssl_certificate.py b/lib/ansible/modules/crypto/openssl_certificate.py index f2c75151843..453658a1e25 100644 --- a/lib/ansible/modules/crypto/openssl_certificate.py +++ b/lib/ansible/modules/crypto/openssl_certificate.py @@ -771,7 +771,7 @@ class AcmeCertificate(Certificate): chain = '--chain' try: - crt = module.run_command("%s %s --account-key %s --csr %s" + crt = module.run_command("%s %s --account-key %s --csr %s " "--acme-dir %s" % (acme_tiny_path, chain, self.accountkey_path, self.csr_path,