From e658995760ac1209cb12df97027a2e282b4536ae Mon Sep 17 00:00:00 2001 From: Matt Clay Date: Fri, 3 Feb 2023 15:42:09 -0800 Subject: [PATCH] ansible-test - Enable pylint unused-import for core (#79910) --- .../_util/controller/sanity/pylint/config/default.cfg | 1 - test/sanity/ignore.txt | 6 ++++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/test/lib/ansible_test/_util/controller/sanity/pylint/config/default.cfg b/test/lib/ansible_test/_util/controller/sanity/pylint/config/default.cfg index 1832f734acf..2a65ba30c23 100644 --- a/test/lib/ansible_test/_util/controller/sanity/pylint/config/default.cfg +++ b/test/lib/ansible_test/_util/controller/sanity/pylint/config/default.cfg @@ -104,7 +104,6 @@ disable= unsupported-delete-operation, unsupported-membership-test, unused-argument, - unused-import, unused-variable, unspecified-encoding, # always run with UTF-8 encoding enforced use-dict-literal, # ignoring as a common style issue diff --git a/test/sanity/ignore.txt b/test/sanity/ignore.txt index 0c378d6566a..4ad6e0bed4f 100644 --- a/test/sanity/ignore.txt +++ b/test/sanity/ignore.txt @@ -66,6 +66,7 @@ lib/ansible/modules/yum.py validate-modules:parameter-invalid lib/ansible/modules/yum_repository.py validate-modules:doc-default-does-not-match-spec lib/ansible/modules/yum_repository.py validate-modules:parameter-type-not-in-doc lib/ansible/modules/yum_repository.py validate-modules:undocumented-parameter +lib/ansible/module_utils/basic.py pylint:unused-import # deferring resolution to allow enabling the rule now lib/ansible/module_utils/compat/_selectors2.py future-import-boilerplate # ignore bundled lib/ansible/module_utils/compat/_selectors2.py metaclass-boilerplate # ignore bundled lib/ansible/module_utils/compat/_selectors2.py pylint:disallowed-name @@ -178,6 +179,11 @@ test/integration/targets/win_script/files/test_script_with_splatting.ps1 pslint: test/lib/ansible_test/_data/requirements/sanity.pslint.ps1 pslint:PSCustomUseLiteralPath # Uses wildcards on purpose test/lib/ansible_test/_util/target/setup/ConfigureRemotingForAnsible.ps1 pslint:PSCustomUseLiteralPath test/lib/ansible_test/_util/target/setup/requirements.py replace-urlopen +test/support/integration/plugins/module_utils/network/common/utils.py pylint:unused-import +test/support/integration/plugins/modules/sefcontext.py pylint:unused-import +test/support/integration/plugins/modules/zypper.py pylint:unused-import +test/support/network-integration/collections/ansible_collections/ansible/netcommon/plugins/module_utils/network/common/utils.py pylint:unused-import +test/support/windows-integration/plugins/action/win_reboot.py pylint:unused-import test/support/integration/plugins/modules/timezone.py pylint:disallowed-name test/support/integration/plugins/module_utils/compat/ipaddress.py future-import-boilerplate test/support/integration/plugins/module_utils/compat/ipaddress.py metaclass-boilerplate