From e2b454f4e331b9d77d15f7e7aff655e2c7745a61 Mon Sep 17 00:00:00 2001 From: Alex Willmer Date: Thu, 5 Dec 2024 19:56:14 +0000 Subject: [PATCH] wait_for_connection: fix errant warning for local connection(s) (#84421) This prevents "[WARNING]: Reset is not implemented for this connection" when using wait_for_connection with localhost or other local hosts. It's arguable (from a consistency/correctness perspective) that `ansible.plugins.connection.local.Connection.reset()` should call `Connection.close()`. I went for a no-op on the basis of "if it aint broke don't fix it", and erred on the side of keeping existing semantics. However either option would be fine with me. --- changelogs/fragments/84419-fix-wait_for_connection-warning.yml | 2 ++ lib/ansible/plugins/connection/local.py | 3 +++ 2 files changed, 5 insertions(+) create mode 100644 changelogs/fragments/84419-fix-wait_for_connection-warning.yml diff --git a/changelogs/fragments/84419-fix-wait_for_connection-warning.yml b/changelogs/fragments/84419-fix-wait_for_connection-warning.yml new file mode 100644 index 00000000000..3b34fefc459 --- /dev/null +++ b/changelogs/fragments/84419-fix-wait_for_connection-warning.yml @@ -0,0 +1,2 @@ +bugfixes: + - wait_for_connection - a warning was displayed if any hosts used a local connection (https://github.com/ansible/ansible/issues/84419) diff --git a/lib/ansible/plugins/connection/local.py b/lib/ansible/plugins/connection/local.py index 2fa8f491a08..d77b37a43bf 100644 --- a/lib/ansible/plugins/connection/local.py +++ b/lib/ansible/plugins/connection/local.py @@ -189,6 +189,9 @@ class Connection(ConnectionBase): display.vvv(u"FETCH {0} TO {1}".format(in_path, out_path), host=self._play_context.remote_addr) self.put_file(in_path, out_path) + def reset(self) -> None: + pass + def close(self) -> None: """ terminate the connection; nothing to do here """ self._connected = False