From e1dd83f2b6730c751220648d62aae07c35ffd765 Mon Sep 17 00:00:00 2001 From: Jesse Keating Date: Tue, 25 Jun 2013 10:58:55 -0700 Subject: [PATCH] add_host should not be a changed action The action doesn't actually change anything on a system, so setting the status to changed is wrong. add_host is much like set_fact in that regard. Since changed is False by default, there is no need to explicity set it, so just create an empty dict for result and add to it from there. --- lib/ansible/runner/action_plugins/add_host.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/ansible/runner/action_plugins/add_host.py b/lib/ansible/runner/action_plugins/add_host.py index f698a29b39a..723bc00102d 100644 --- a/lib/ansible/runner/action_plugins/add_host.py +++ b/lib/ansible/runner/action_plugins/add_host.py @@ -46,7 +46,7 @@ class ActionModule(object): if not 'hostname' in args and not 'name' in args: raise ae("'name' is a required argument.") - result = {'changed': True} + result = {} # Parse out any hostname:port patterns new_name = args.get('name', args.get('hostname', None)) @@ -69,7 +69,6 @@ class ActionModule(object): # add the new host to the 'all' group allgroup = inventory.get_group('all') allgroup.add_host(new_host) - result['changed'] = True groupnames = args.get('groupname', args.get('groups', '')) # add it to the group if that was specified