mirror of https://github.com/ansible/ansible.git
Do not erroneously mask exceptions
There was a catch-all `except` statement in `create_containers`: try: containers = do_create(count, params) except: self.pull_image() containers = do_create(count, params) This would mask a variety of errors that should be exposed, including API compatability errors (as in #1707) and common Python exceptions (KeyError, ValueError, etc) that could result from errors in the code. This change makes the `except` statement more specific, and only attempts to pull the image and start a container if the original create attempt failed due to a 404 error from the docker API.pull/18777/head
parent
6116e4cdab
commit
e031efd82c
Loading…
Reference in New Issue