From de76c797ab7d820b3f9525aa3ce044de4a8920cd Mon Sep 17 00:00:00 2001 From: Sam Doiron Date: Tue, 5 May 2015 10:53:17 -0300 Subject: [PATCH] Fix Issue #1216 (ValueError with Amazon RDS) Fix typo where wrong variable was used, causing ValueError. --- cloud/amazon/rds_param_group.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/cloud/amazon/rds_param_group.py b/cloud/amazon/rds_param_group.py index 5f4cb3bf552..cba482c72d6 100644 --- a/cloud/amazon/rds_param_group.py +++ b/cloud/amazon/rds_param_group.py @@ -78,7 +78,7 @@ EXAMPLES = ''' name: norwegian_blue description: 'My Fancy Ex Parrot Group' engine: 'mysql5.6' - params: + params: auto_increment_increment: "42K" # Remove a parameter group @@ -196,8 +196,8 @@ def modify_group(group, params, immediate=False): if not param.is_modifiable: raise NotModifiableError('Parameter %s is not modifiable.' % key) - changed[key] = {'old': param.value, 'new': new_value} - + changed[key] = {'old': old_value, 'new': new_value} + set_parameter(param, new_value, immediate) del new_params[key] @@ -260,7 +260,7 @@ def main(): if e.error_code != 'DBParameterGroupNotFound': module.fail_json(msg = e.error_message) exists = False - + if state == 'absent': if exists: conn.delete_parameter_group(group_name) @@ -284,7 +284,7 @@ def main(): marker = next_group.Marker else: break - + except BotoServerError, e: module.fail_json(msg = e.error_message)