From dda41fd95a0c74c2c6f9c57ac44ff6deb467c6f8 Mon Sep 17 00:00:00 2001 From: acaveroc Date: Thu, 18 Jun 2015 09:43:32 +0200 Subject: [PATCH] Add version_added and type of parameter --- lib/ansible/modules/database/mysql/mysql_variables.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/ansible/modules/database/mysql/mysql_variables.py b/lib/ansible/modules/database/mysql/mysql_variables.py index 36415df5460..f50ed740539 100644 --- a/lib/ansible/modules/database/mysql/mysql_variables.py +++ b/lib/ansible/modules/database/mysql/mysql_variables.py @@ -53,6 +53,7 @@ options: - mysql host to connect required: False login_port: + version_added: "1.9" description: - mysql port to connect required: False @@ -198,7 +199,7 @@ def main(): login_user=dict(default=None), login_password=dict(default=None), login_host=dict(default="127.0.0.1"), - login_port=dict(default="3306"), + login_port=dict(default="3306", type='int'), login_unix_socket=dict(default=None), variable=dict(default=None), value=dict(default=None) @@ -233,9 +234,9 @@ def main(): module.fail_json(msg="when supplying login arguments, both login_user and login_password must be provided") try: if module.params["login_unix_socket"]: - db_connection = MySQLdb.connect(host=module.params["login_host"], port=int(module.params["login_port"]), unix_socket=module.params["login_unix_socket"], user=login_user, passwd=login_password, db="mysql") + db_connection = MySQLdb.connect(host=module.params["login_host"], port=module.params["login_port"], unix_socket=module.params["login_unix_socket"], user=login_user, passwd=login_password, db="mysql") else: - db_connection = MySQLdb.connect(host=module.params["login_host"], port=int(module.params["login_port"]), user=login_user, passwd=login_password, db="mysql") + db_connection = MySQLdb.connect(host=module.params["login_host"], port=module.params["login_port"], user=login_user, passwd=login_password, db="mysql") cursor = db_connection.cursor() except Exception, e: module.fail_json(msg="unable to connect to database, check login_user and login_password are correct or ~/.my.cnf has the credentials")