From db26fe2f1e468073ff784a7534ae9575eed940b9 Mon Sep 17 00:00:00 2001 From: Andrey Klychkov Date: Thu, 25 Jul 2019 18:04:18 +0300 Subject: [PATCH] module_utils.common.*: removed unused objects (#59570) --- .../fragments/59570-module_utils_remove_unused_objects.yml | 2 ++ lib/ansible/module_utils/common/dict_transformations.py | 1 - lib/ansible/module_utils/common/removed.py | 2 +- lib/ansible/module_utils/common/sys_info.py | 1 - 4 files changed, 3 insertions(+), 3 deletions(-) create mode 100644 changelogs/fragments/59570-module_utils_remove_unused_objects.yml diff --git a/changelogs/fragments/59570-module_utils_remove_unused_objects.yml b/changelogs/fragments/59570-module_utils_remove_unused_objects.yml new file mode 100644 index 00000000000..aa5219eb5a1 --- /dev/null +++ b/changelogs/fragments/59570-module_utils_remove_unused_objects.yml @@ -0,0 +1,2 @@ +bugfixes: +- module_utils - remove unused objects from dict_transformations, removed, and sys_info modules (https://github.com/ansible/ansible/pull/59570) diff --git a/lib/ansible/module_utils/common/dict_transformations.py b/lib/ansible/module_utils/common/dict_transformations.py index 6d5d8e61f09..831fbc5385e 100644 --- a/lib/ansible/module_utils/common/dict_transformations.py +++ b/lib/ansible/module_utils/common/dict_transformations.py @@ -86,7 +86,6 @@ def _camel_to_snake(name, reversible=False): def prepend_underscore_and_lower(m): return '_' + m.group(0).lower() - import re if reversible: upper_pattern = r'[A-Z]' else: diff --git a/lib/ansible/module_utils/common/removed.py b/lib/ansible/module_utils/common/removed.py index 826d0dfa1c9..bffe92679e9 100644 --- a/lib/ansible/module_utils/common/removed.py +++ b/lib/ansible/module_utils/common/removed.py @@ -31,7 +31,7 @@ def removed_module(removed_in, msg='This module has been removed. The module doc version = removed_in.split('.') try: numeric_minor = int(version[-1]) - except Exception as e: + except Exception: last_version = None else: version = version[:-1] diff --git a/lib/ansible/module_utils/common/sys_info.py b/lib/ansible/module_utils/common/sys_info.py index 20476386192..860a0792ba1 100644 --- a/lib/ansible/module_utils/common/sys_info.py +++ b/lib/ansible/module_utils/common/sys_info.py @@ -5,7 +5,6 @@ from __future__ import absolute_import, division, print_function __metaclass__ = type -import os import platform from ansible.module_utils import distro