From daaea1780176f610fdcf982f0e99e725c20ed6b1 Mon Sep 17 00:00:00 2001 From: Evert Mulder Date: Fri, 12 Apr 2019 19:25:18 +0200 Subject: [PATCH] Fixed incorrect response removing a group (#55116) --- .../modules/remote_management/manageiq/manageiq_group.py | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/lib/ansible/modules/remote_management/manageiq/manageiq_group.py b/lib/ansible/modules/remote_management/manageiq/manageiq_group.py index 32d8b0bade8..51f587166bb 100644 --- a/lib/ansible/modules/remote_management/manageiq/manageiq_group.py +++ b/lib/ansible/modules/remote_management/manageiq/manageiq_group.py @@ -35,6 +35,8 @@ version_added: '2.8' author: Evert Mulder (@evertmulder) description: - The manageiq_group module supports adding, updating and deleting groups in ManageIQ. +requirements: +- manageiq-client options: state: @@ -319,10 +321,13 @@ class ManageIQgroup(object): """ try: url = '%s/groups/%s' % (self.api_url, group['id']) - self.client.post(url, action='delete') + result = self.client.post(url, action='delete') except Exception as e: self.module.fail_json(msg="failed to delete group %s: %s" % (group['description'], str(e))) + if result['success'] is False: + self.module.fail_json(msg=result['message']) + return dict( changed=True, msg="deleted group %s with id %i" % (group['description'], group['id'])) @@ -610,7 +615,7 @@ def main(): else: res_args = dict( changed=False, - msg="group %s: does not exist in manageiq" % description) + msg="group '%s' does not exist in manageiq" % description) # group should exist if state == "present":