From d8d00c36fa41ddc384966249005f7a922ead43c1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Ne=C4=8Das?= Date: Wed, 14 Aug 2019 12:24:29 +0200 Subject: [PATCH] ovirt_vm add linux boot param warning (#60474) * ovirt_vm add kernel param check * update check * update docs phrase * use douple quotes --- lib/ansible/modules/cloud/ovirt/ovirt_vm.py | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/lib/ansible/modules/cloud/ovirt/ovirt_vm.py b/lib/ansible/modules/cloud/ovirt/ovirt_vm.py index c2c29d50278..bedb4ebf132 100644 --- a/lib/ansible/modules/cloud/ovirt/ovirt_vm.py +++ b/lib/ansible/modules/cloud/ovirt/ovirt_vm.py @@ -1250,6 +1250,7 @@ from ansible.module_utils.ovirt import ( search_by_attributes, search_by_name, wait, + engine_supported, ) @@ -2255,6 +2256,15 @@ def import_vm(module, connection): return True +def check_deprecated_params(module, connection): + if engine_supported(connection, '4.4') and \ + (module.params.get('kernel_params_persist') is not None or + module.params.get('kernel_path') is not None or + module.params.get('initrd_path') is not None or + module.params.get('kernel_params') is not None): + module.warn("Parameters 'kernel_params_persist', 'kernel_path', 'initrd_path', 'kernel_params' are not supported since oVirt 4.4.") + + def control_state(vm, vms_service, module): if vm is None: return @@ -2403,6 +2413,7 @@ def main(): state = module.params['state'] auth = module.params.pop('auth') connection = create_connection(auth) + check_deprecated_params(module, connection) vms_service = connection.system_service().vms_service() vms_module = VmsModule( connection=connection,