Merge pull request #17394 from privateip/bugfix-17391

fixes bug when template is missing src argument
pull/16822/merge
Peter Sprygada 8 years ago committed by GitHub
commit d5aecfdd14

@ -41,7 +41,7 @@ class ActionModule(ActionBase):
try: try:
self._handle_template() self._handle_template()
except ValueError as exc: except (ValueError, AttributeError) as exc:
return dict(failed=True, msg=exc.message) return dict(failed=True, msg=exc.message)
result.update(self._execute_module(module_name=self._task.action, result.update(self._execute_module(module_name=self._task.action,
@ -75,9 +75,12 @@ class ActionModule(ActionBase):
def _handle_template(self): def _handle_template(self):
src = self._task.args.get('src') src = self._task.args.get('src')
if not src:
raise ValueError('missing required arguments: src')
working_path = self._get_working_path() working_path = self._get_working_path()
if os.path.isabs(src) or urlparse.urlsplit('src').scheme: if os.path.isabs(src) or urlparse.urlsplit(src).scheme:
source = src source = src
else: else:
source = self._loader.path_dwim_relative(working_path, 'templates', src) source = self._loader.path_dwim_relative(working_path, 'templates', src)

Loading…
Cancel
Save