[Backport 2.9] vyos: Fix to give no traceback on empty config (#62568)

* vyosnoconfig tracebackfix (#62518)

* vyosnoconfig tracebackfix

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* vyos noconfig tracebackfix test cases added

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* test/integration/targets/vyos_lldp_global/tests/cli/empty_config.yaml

(cherry picked from commit b24f7d2800)

* empty config traceback fix

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

changelogs/fragments/62518-nobacktracefix_vyos.yaml

@@ -0,0 +1,3 @@
+---
+bugfixes:
+  - this fix result in no more traceback on empty config when state is 'merged', 'replaced' or 'overridden'. (https://github.com/ansible/ansible/pull/62518). 

lib/ansible/module_utils/network/vyos/config/lag_interfaces/lag_interfaces.py

@@ -107,6 +107,8 @@ class Lag_interfaces(ConfigBase):
         """
         commands = []
         state = self._module.params['state']
+        if state in ('merged', 'replaced', 'overridden') and not want:
+            self._module.fail_json(msg='config is required for state {0}'.format(state))
         if state == 'overridden':
             commands.extend(self._state_overridden(want, have))
         elif state == 'deleted':

lib/ansible/module_utils/network/vyos/config/lldp_global/lldp_global.py

@@ -100,6 +100,8 @@ class Lldp_global(ConfigBase):
         """
         commands = []
         state = self._module.params['state']
+        if state in ('merged', 'replaced') and not want:
+            self._module.fail_json(msg='config is required for state {0}'.format(state))
         if state == 'deleted':
             commands.extend(self._state_deleted(want=None, have=have))
         elif state == 'merged':

lib/ansible/module_utils/network/vyos/config/lldp_interfaces/lldp_interfaces.py

@@ -110,6 +110,8 @@ class Lldp_interfaces(ConfigBase):
         """
         commands = []
         state = self._module.params['state']
+        if state in ('merged', 'replaced', 'overridden') and not want:
+            self._module.fail_json(msg='config is required for state {0}'.format(state))
         if state == 'overridden':
             commands.extend(self._state_overridden(want=want, have=have))
         elif state == 'deleted':

test/integration/targets/vyos_lag_interfaces/tests/cli/empty_config.yaml

@@ -0,0 +1,36 @@
+---
+- debug:
+      msg: "START vyos_lag_interfaces empty_config integration tests on connection={{ ansible_connection }}"
+
+- name: Merged with empty config should give appropriate error message
+  vyos_lag_interfaces:
+    config:
+    state: merged
+  register: result
+  ignore_errors: True
+
+- assert:
+    that:
+      - result.msg == 'config is required for state merged'
+
+- name: Replaced with empty config should give appropriate error message
+  vyos_lag_interfaces:
+    config:
+    state: replaced
+  register: result
+  ignore_errors: True
+
+- assert:
+    that:
+      - result.msg == 'config is required for state replaced'
+
+- name: Overridden with empty config should give appropriate error message
+  vyos_lag_interfaces:
+    config:
+    state: overridden
+  register: result
+  ignore_errors: True
+
+- assert:
+    that:
+      - result.msg == 'config is required for state overridden'

test/integration/targets/vyos_lldp_global/tests/cli/empty_config.yaml

@@ -0,0 +1,25 @@
+---
+- debug:
+      msg: "START vyos_lldp_global empty_config integration tests on connection={{ ansible_connection }}"
+
+- name: Merged with empty config should give appropriate error message
+  vyos_lldp_global:
+    config:
+    state: merged
+  register: result
+  ignore_errors: True
+
+- assert:
+    that:
+      - result.msg == 'config is required for state merged'
+
+- name: Replaced with empty config should give appropriate error message
+  vyos_lldp_global:
+    config:
+    state: replaced
+  register: result
+  ignore_errors: True
+
+- assert:
+    that:
+      - result.msg == 'config is required for state replaced'

test/integration/targets/vyos_lldp_interfaces/tests/cli/empty_config.yaml

@@ -0,0 +1,36 @@
+---
+- debug:
+      msg: "START vyos_lldp_interfaces empty_config integration tests on connection={{ ansible_connection }}"
+
+- name: Merged with empty config should give appropriate error message
+  vyos_lldp_interfaces:
+    config:
+    state: merged
+  register: result
+  ignore_errors: True
+
+- assert:
+    that:
+      - result.msg == 'config is required for state merged'
+
+- name: Replaced with empty config should give appropriate error message
+  vyos_lldp_interfaces:
+    config:
+    state: replaced
+  register: result
+  ignore_errors: True
+
+- assert:
+    that:
+      - result.msg == 'config is required for state replaced'
+
+- name: Overridden with empty config should give appropriate error message
+  vyos_lldp_interfaces:
+    config:
+    state: overridden
+  register: result
+  ignore_errors: True
+
+- assert:
+    that:
+      - result.msg == 'config is required for state overridden'