diff --git a/changelogs/fragments/yum-sane-default-lockfile-timeout.yml b/changelogs/fragments/yum-sane-default-lockfile-timeout.yml new file mode 100644 index 00000000000..5cf8c2e8338 --- /dev/null +++ b/changelogs/fragments/yum-sane-default-lockfile-timeout.yml @@ -0,0 +1,3 @@ +minor_changes: + - yum - set lock_timeout to a sane default (30 seconds, as is the cli) + - dnf - set lock_timeout to a sane default (30 seconds, as is the cli) diff --git a/lib/ansible/module_utils/yumdnf.py b/lib/ansible/module_utils/yumdnf.py index 02605bf3764..b8ed14844aa 100644 --- a/lib/ansible/module_utils/yumdnf.py +++ b/lib/ansible/module_utils/yumdnf.py @@ -46,7 +46,7 @@ yumdnf_argument_spec = dict( update_cache=dict(type='bool', default=False, aliases=['expire-cache']), update_only=dict(required=False, default="no", type='bool'), validate_certs=dict(type='bool', default=True), - lock_timeout=dict(type='int', default=0), + lock_timeout=dict(type='int', default=30), ), required_one_of=[['name', 'list', 'update_cache']], mutually_exclusive=[['name', 'list']], diff --git a/lib/ansible/modules/packaging/os/dnf.py b/lib/ansible/modules/packaging/os/dnf.py index fd973009304..1010cd9cc11 100644 --- a/lib/ansible/modules/packaging/os/dnf.py +++ b/lib/ansible/modules/packaging/os/dnf.py @@ -181,7 +181,7 @@ options: description: - Amount of time to wait for the dnf lockfile to be freed. required: false - default: 0 + default: 30 type: int version_added: "2.8" install_weak_deps: diff --git a/lib/ansible/modules/packaging/os/yum.py b/lib/ansible/modules/packaging/os/yum.py index 6d02a6dba64..18174a0ab1b 100644 --- a/lib/ansible/modules/packaging/os/yum.py +++ b/lib/ansible/modules/packaging/os/yum.py @@ -187,7 +187,7 @@ options: description: - Amount of time to wait for the yum lockfile to be freed. required: false - default: 0 + default: 30 type: int version_added: "2.8" install_weak_deps: