From d2826f468965e2e70f874e295b954ffc4e89b30c Mon Sep 17 00:00:00 2001
From: jkhall81 <jason.kei.hall@gmail.com>
Date: Tue, 7 Oct 2025 06:51:06 -0700
Subject: [PATCH] Added virtual package handling to install_deb function

---
 lib/ansible/modules/apt.py     | 23 ++++++++++--
 test/units/modules/test_apt.py | 65 +++++++++++++++++++++++++++++++++-
 2 files changed, 84 insertions(+), 4 deletions(-)

diff --git a/lib/ansible/modules/apt.py b/lib/ansible/modules/apt.py
index 97452f03106..ef542fd0808 100644
--- a/lib/ansible/modules/apt.py
+++ b/lib/ansible/modules/apt.py
@@ -888,9 +888,26 @@ def install_deb(
                 else:
                     m.fail_json(msg=pkg._failure_string)
 
-            # add any missing deps to the list of deps we need
-            # to install so they're all done in one shot
-            deps_to_install.extend(pkg.missing_deps)
+           # Handle virtual package dependencies properly
+            missing_deps = []
+            for dep in pkg.missing_deps:
+                if cache.is_virtual_package(dep):
+                    providers = cache.get_providing_packages(dep)
+                    if providers:
+                        # Check if any provider is already installed
+                        provider_installed = False
+                        for provider in providers:
+                            if provider in cache and cache[provider].installed:
+                                provider_installed = True
+                                break
+                        if not provider_installed:
+                            missing_deps.append(dep)
+                    else:
+                        missing_deps.append(dep)
+                else:
+                    missing_deps.append(dep)
+
+            deps_to_install.extend(missing_deps)
 
         except Exception as e:
             m.fail_json(msg="Unable to install package: %s" % to_native(e))
diff --git a/test/units/modules/test_apt.py b/test/units/modules/test_apt.py
index d207320c82a..8bc98373364 100644
--- a/test/units/modules/test_apt.py
+++ b/test/units/modules/test_apt.py
@@ -4,7 +4,10 @@ from __future__ import annotations
 
 import collections
 
-from ansible.modules.apt import expand_pkgspec_from_fnmatches
+from ansible.modules.apt import (
+    expand_pkgspec_from_fnmatches, 
+)
+
 import pytest
 
 FakePackage = collections.namedtuple("Package", ("name",))
@@ -43,3 +46,63 @@ fake_cache = [
 def test_expand_pkgspec_from_fnmatches(test_input, expected):
     """Test positive cases of ``expand_pkgspec_from_fnmatches``."""
     assert expand_pkgspec_from_fnmatches(None, test_input, fake_cache) == expected
+
+
+def test_virtual_package_resolution_fixed():
+    """Test that virtual package dependencies are properly resolved with the fix."""
+    # Scenario: A package depends on virtual package 'libglib2.0-0'
+    # which is provided by 'libglib2.0-0t64'
+    
+    virtual_dependency = 'libglib2.0-0'
+    providing_package = 'libglib2.0-0t64'
+    
+    class MockCache:
+        def is_virtual_package(self, pkg_name):
+            return pkg_name == virtual_dependency
+            
+        def get_providing_packages(self, pkg_name):
+            if pkg_name == virtual_dependency:
+                return [providing_package]
+            return []
+            
+        def __contains__(self, pkg_name):
+            # Virtual packages are not directly in cache, but have providers
+            return pkg_name == providing_package  # Only the provider is in cache
+            
+        def __getitem__(self, pkg_name):
+            if pkg_name == providing_package:
+                return MockPackage(installed=True)
+            raise KeyError(pkg_name)
+    
+    class MockPackage:
+        def __init__(self, installed=False):
+            self.installed = installed
+    
+    cache = MockCache()
+    unsatisfied_deps = []
+    
+    # SIMULATE THE FIXED LOGIC (what we implemented):
+    dep_name = virtual_dependency
+    
+    # FIXED IMPLEMENTATION (with virtual package handling):
+    if cache.is_virtual_package(dep_name):
+        providers = cache.get_providing_packages(dep_name)
+        if providers:
+            # Check if any provider is installed
+            provider_installed = False
+            for provider in providers:
+                if provider in cache and cache[provider].installed:
+                    provider_installed = True
+                    break
+            if not provider_installed:
+                unsatisfied_deps.append(dep_name)
+        else:
+            unsatisfied_deps.append(dep_name)
+    elif dep_name not in cache or not cache[dep_name].installed:
+        unsatisfied_deps.append(dep_name)
+    
+    # With the fixed logic, virtual dependencies with installed providers should be satisfied
+    assert virtual_dependency not in unsatisfied_deps, (
+        f"Virtual package {virtual_dependency} should be satisfied by {providing_package}"
+    )
+    assert len(unsatisfied_deps) == 0
\ No newline at end of file