From d1a4f703ce493db6e0dfa8b37bb225ca7f53651c Mon Sep 17 00:00:00 2001 From: Adrian Likins Date: Tue, 24 May 2016 11:55:14 -0400 Subject: [PATCH] Fix pkgutil "upgrade_catalog must be one of" err (#2149) The arg spec for update_catalog include 'type=bool' and 'choices=["yes", "no"] which can never both be true. Remove the 'choices' directive, and update doc string. Fixes #2144 --- packaging/os/pkgutil.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/packaging/os/pkgutil.py b/packaging/os/pkgutil.py index 0cdc3dee5e8..35ccb4e1906 100644 --- a/packaging/os/pkgutil.py +++ b/packaging/os/pkgutil.py @@ -54,8 +54,7 @@ options: description: - If you want to refresh your catalog from the mirror, set this to (C(yes)). required: false - choices: ["yes", "no"] - default: no + default: False version_added: "2.1" ''' @@ -130,7 +129,7 @@ def main(): name = dict(required = True), state = dict(required = True, choices=['present', 'absent','latest']), site = dict(default = None), - update_catalog = dict(required = False, default = "no", type='bool', choices=["yes","no"]), + update_catalog = dict(required = False, default = False, type='bool'), ), supports_check_mode=True )