From cb765ce5908b9fee412705af0f11bf1bcbfd2a1d Mon Sep 17 00:00:00 2001 From: Matthew Krupcale Date: Thu, 17 Nov 2016 13:15:11 -0500 Subject: [PATCH] gluster_volume: Fixes gluster peer probe / volume creation issue. (#3486) * gluster_volume: Fixes issue when creating a new volume failing due to peers not being present. The peers which are not 'localhost' should invoke wait_for_peer, but the find method returns -1 (not 0) on non-localhost peers. --- lib/ansible/modules/extras/system/gluster_volume.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ansible/modules/extras/system/gluster_volume.py b/lib/ansible/modules/extras/system/gluster_volume.py index ceb63300673..4043f10ae18 100644 --- a/lib/ansible/modules/extras/system/gluster_volume.py +++ b/lib/ansible/modules/extras/system/gluster_volume.py @@ -274,7 +274,7 @@ def wait_for_peer(host): def probe(host, myhostname): global module out = run_gluster([ 'peer', 'probe', host ]) - if not out.find('localhost') and not wait_for_peer(host): + if out.find('localhost') == -1 and not wait_for_peer(host): module.fail_json(msg='failed to probe peer %s on %s' % (host, myhostname)) changed = True