From c908d782fb75a6949fb1b7b1e7070948544a8258 Mon Sep 17 00:00:00 2001
From: Sloane Hertel <19572925+s-hertel@users.noreply.github.com>
Date: Thu, 2 Jun 2022 15:19:02 -0400
Subject: [PATCH] get_url - permit to have a checksum only file (#77948)

checksum can also accept a checksum only file (no filename beside the checksum).
fixes #54390

Co-authored-by: Baptiste Mille-Mathias <baptiste.millemathias@gmail.com>
---
 .../get_url-accept-file-for-checksum.yml      |  2 ++
 lib/ansible/modules/get_url.py                | 28 +++++++++++--------
 .../targets/get_url/tasks/main.yml            | 22 ++++++++++++++-
 3 files changed, 40 insertions(+), 12 deletions(-)
 create mode 100644 changelogs/fragments/get_url-accept-file-for-checksum.yml

diff --git a/changelogs/fragments/get_url-accept-file-for-checksum.yml b/changelogs/fragments/get_url-accept-file-for-checksum.yml
new file mode 100644
index 00000000000..2c54d4295e4
--- /dev/null
+++ b/changelogs/fragments/get_url-accept-file-for-checksum.yml
@@ -0,0 +1,2 @@
+minor_changes:
+- get_url - permit to pass to parameter ``checksum`` an URL pointing to a file containing only a checksum (https://github.com/ansible/ansible/issues/54390).
diff --git a/lib/ansible/modules/get_url.py b/lib/ansible/modules/get_url.py
index fb750f9ccb3..b344f00474b 100644
--- a/lib/ansible/modules/get_url.py
+++ b/lib/ansible/modules/get_url.py
@@ -505,18 +505,24 @@ def main():
                 lines = [line.rstrip('\n') for line in f]
             os.remove(checksum_tmpsrc)
             checksum_map = []
-            for line in lines:
-                # Split by one whitespace to keep the leading type char ' ' (whitespace) for text and '*' for binary
-                parts = line.split(" ", 1)
-                if len(parts) == 2:
-                    # Remove the leading type char, we expect
-                    if parts[1].startswith((" ", "*",)):
-                        parts[1] = parts[1][1:]
-
-                    # Append checksum and path without potential leading './'
-                    checksum_map.append((parts[0], parts[1].lstrip("./")))
-
             filename = url_filename(url)
+            if len(lines) == 1 and len(lines[0].split()) == 1:
+                # Only a single line with a single string
+                # treat it as a checksum only file
+                checksum_map.append((lines[0], filename))
+            else:
+                # The assumption here is the file is in the format of
+                # checksum filename
+                for line in lines:
+                    # Split by one whitespace to keep the leading type char ' ' (whitespace) for text and '*' for binary
+                    parts = line.split(" ", 1)
+                    if len(parts) == 2:
+                        # Remove the leading type char, we expect
+                        if parts[1].startswith((" ", "*",)):
+                            parts[1] = parts[1][1:]
+
+                        # Append checksum and path without potential leading './'
+                        checksum_map.append((parts[0], parts[1].lstrip("./")))
 
             # Look through each line in the checksum file for a hash corresponding to
             # the filename in the url, returning the first hash that is found.
diff --git a/test/integration/targets/get_url/tasks/main.yml b/test/integration/targets/get_url/tasks/main.yml
index b5a9c7e5ba2..cf2ffacdd67 100644
--- a/test/integration/targets/get_url/tasks/main.yml
+++ b/test/integration/targets/get_url/tasks/main.yml
@@ -376,6 +376,13 @@
       30949cc401e30ac494d695ab8764a9f76aae17c5d73c67f65e9b558f47eff892 *not_target1.txt
       d0dbfc1945bc83bf6606b770e442035f2c4e15c886ee0c22fb3901ba19900b5b *not_target2.txt
 
+# completing 27617 with bug 54390
+- name: create sha256 checksum only with no filename inside
+  copy:
+    dest: '{{ files_dir }}/sha256sum_checksum_only.txt'
+    content: |
+      b1b6ce5073c8fac263a8fc5edfffdbd5dec1980c784e09c5bc69f8fb6056f006
+
 - copy:
     src: "testserver.py"
     dest: "{{ remote_tmp_dir }}/testserver.py"
@@ -509,11 +516,22 @@
     path: "{{ remote_tmp_dir }}/71420sha256_with_dot.txt"
   register: stat_result_sha256_with_file_scheme_71420
 
+- name: download src with sha256 checksum url with no filename
+  get_url:
+    url: 'http://localhost:{{ http_port }}/27617.txt'
+    dest: '{{ remote_tmp_dir }}/27617sha256_with_no_filename.txt'
+    checksum: 'sha256:http://localhost:{{ http_port }}/sha256sum_checksum_only.txt'
+  register: result_sha256_checksum_only
+
+- stat:
+    path: "{{ remote_tmp_dir }}/27617.txt"
+  register: stat_result_sha256_checksum_only
+
 - name: Assert that the file was downloaded
   assert:
     that:
-      - result_sha1_check_mode is changed
       - result_sha1 is changed
+      - result_sha1_check_mode is changed
       - result_sha256 is changed
       - result_sha256_with_dot is changed
       - result_sha256_with_asterisk is changed
@@ -527,12 +545,14 @@
       - result_sha256_71420 is changed
       - result_sha256_with_dot_71420 is changed
       - result_sha256_with_asterisk_71420 is changed
+      - result_sha256_checksum_only is changed
       - result_sha256_with_file_scheme_71420 is changed
       - "stat_result_sha1_71420.stat.exists == true"
       - "stat_result_sha256_71420.stat.exists == true"
       - "stat_result_sha256_with_dot_71420.stat.exists == true"
       - "stat_result_sha256_with_asterisk_71420.stat.exists == true"
       - "stat_result_sha256_with_file_scheme_71420.stat.exists == true"
+      - "stat_result_sha256_checksum_only.stat.exists == true"
 
 #https://github.com/ansible/ansible/issues/16191
 - name: Test url split with no filename